Commit graph

6966 commits

Author SHA1 Message Date
Michael Vogel
5af9596dde New item field "Post-type" and new table "permissionset" (#5408)
* "post-type" replaces "bookmark" and "type"

* Removed some more type

* Added index to permission set

* The permission set is now stored

* The permission set is now removed upon expiry

* Post update now stores the permission set

* New file

* Permissions are now sorted

* Changed documentation
2018-07-19 09:52:05 -04:00
Roland Häder
0b38f1c58b Fixes applied: (#5399)
- $_SESSION['remember_user'] did only exist here and no where else
- it seems to be accient old-lost code, so I fixed it to $a->user['nickname']
  instead
- used multi-line comment for multiple lines of on-line comments

Signed-off-by: Roland Häder <roland@mxchange.org>
2018-07-19 07:11:03 -04:00
Hypolite Petovan
67dc08d120 Enforce systen.register_policy value type 2018-07-16 19:38:19 -04:00
Hypolite Petovan
c207f6d597 Remove remaining references to Config::get in include/dba 2018-07-16 19:38:18 -04:00
Hypolite Petovan
820afa2284 Replace global $a with BaseObject::getApp() 2018-07-16 19:38:17 -04:00
Hypolite Petovan
adacf421a6 Remove deprecated functions in include/text 2018-07-16 19:38:17 -04:00
Hypolite Petovan
5906c7e013 Remove api test pconfig debug 2018-07-16 19:38:17 -04:00
Hypolite Petovan
224765cdf5 Wrong table name 2018-07-16 19:38:16 -04:00
Hypolite Petovan
f8a90f3425 Add more api test debug 2018-07-16 19:38:16 -04:00
Hypolite Petovan
de0afd3b32 Add api test debug 2018-07-16 19:38:16 -04:00
Hypolite Petovan
9396b05659 Revert using Config class in dba 2018-07-16 19:38:16 -04:00
Hypolite Petovan
9be9741562 Fix uses in include/dba 2018-07-16 19:38:16 -04:00
Hypolite Petovan
762a786611 Replace direct accesses to App->config by Config::get/set calls 2018-07-16 19:38:16 -04:00
Hypolite Petovan
cd9b864045 Rework App modes
- Replace App mode constants with capability-based flags
- Add App->isInstallMode()
- Add file config fallback in (P)Config abstraction
- Removed logger disabling code
2018-07-16 19:38:15 -04:00
Hypolite Petovan
7d8c45dde8 Remove dependency to App in dba::connect
- Remove timing (can be done centrally)
- Add charset parameter to dba::connect and dba::reconnect
2018-07-16 19:38:13 -04:00
0e8fa34156 Fix for displaying public items 2018-07-16 04:00:57 +00:00
Hypolite Petovan
a6eae9adec Add new put_item_in_cache hook in include/text 2018-07-15 08:03:12 -04:00
Roland Häder
6b5d90333f Fixes for some E_NOTICE and type-hints added (#5358)
* Fixed http://github to https://github

Signed-off-by: Roland Häder <roland@mxchange.org>

* Fixes for #4965:
- updated messages.po file

Signed-off-by: Roland Häder <roland@mxchange.org>

* Fixed E_NOTICE where isset()/empty() was absent.

Signed-off-by: Roland Häder <roland@mxchange.org>

* Fixed missing variable $sql_order causing E_NOTICE.

Signed-off-by: Roland Häder <roland@mxchange.org>

* Continued:
- added array type-hint where known (some)

Signed-off-by: Roland Häder <roland@mxchange.org>

* Fixes:
- in Profile::load() $user is now only one-dimensional
- $a->get_hostname is no property, it is a method

Signed-off-by: Roland Häder <roland@mxchange.org>

* reverted changes that are unintended

Signed-off-by: Roland Häder <roland@mxchange.org>

* Continued:
- removed leading \ (uncommon, okay)
- removed entire if() block (CR by Hypolite)

Signed-off-by: Roland Häder <roland@mxchange.org>

* Removed if() block

Signed-off-by: Roland Häder <roland@mxchange.org>
2018-07-13 15:47:14 -04:00
Michael Vogel
0360f7197a Several more warnings ... (#5340)
* Some more warnings removed

* Even more warnings ...

* Will it ever end? ;-)

* Avoid warning in dbstructure

* Origin and OStatus ...

* There are more warnings solved ... yeah!

* And again ...

* We are not done yet

* And more ...

* And some new places ...

* And more in the feeds

* Avoid some more

* And some backend stuff

* Notifications cleared

* Some more stuff

* and again ...

* It's getting fewer ...

* Some warnings had been hidden in the notifications

* Fix the fix

* And another missing one ...

* We need the owner here, not the user

* Forgotten user

* And more ...

* And some more warnings disappeared ...

* Some more frontend warnings

* Some backend warnings removed

* Fixed sidebar for "vier"

* And more ...

* Some more ...

* And something for "remote self"

* Am I stuck in an endless loop?

* Fix: Clear tag and file field on update

* Preset page content
2018-07-10 08:27:56 -04:00
c829e43725
moved get_guid to System::createGUID 2018-07-09 21:38:16 +02:00
675a6adf35 Added comment 2018-07-08 13:52:11 +00:00
8a2230bc4c Avoid warnings in addons 2018-07-08 12:01:36 +00:00
3e797547a3 Warnings fixed 2018-07-08 09:37:05 +00:00
69db696ab1 Improve test behaviour 2018-07-08 05:29:06 +00:00
Michael Vogel
ff5ee74ecf
Merge branch 'develop' into item-activities 2018-07-08 06:35:50 +02:00
4d35e228c4 More item abstraction / making remote deletion work again 2018-07-07 18:14:16 +00:00
1ffe0cfd81
Added Lock Unittests & Bugfixings
Added Redis Lock Unittests
Added Memcached Lock Unittests

Fixed a bug in dba
Fixed a bug in RedisLock
2018-07-07 16:15:03 +02:00
Hypolite Petovan
e44111e935 Revert renaming lang to language in api
- Normalize some quotes
- Put "Empty user-agent" log message in a else statement
2018-07-04 17:33:09 -04:00
Hypolite Petovan
43688c04b1 Add NotFoundException for recipients in api_direct_messages_new() 2018-07-02 07:48:59 -04:00
Hypolite Petovan
cb7176ee70 Fix Config use in api_statusnet_config() 2018-07-02 07:48:53 -04:00
Hypolite Petovan
757fd357f6 Fix yet more undefined variable/index notice in api 2018-07-02 07:48:48 -04:00
Hypolite Petovan
dde61a77a4 Fix root element containing only text in api_create_xml() 2018-07-02 07:48:42 -04:00
Hypolite Petovan
62eba48679 Fix yet more undefined variable/index messages in api_statuses_show 2018-07-02 07:48:38 -04:00
Hypolite Petovan
0ee153e1bd Fix Array to String conversion message for IN conditions 2018-07-02 07:47:47 -04:00
Hypolite Petovan
a380bcd1c1 Fix more undefined variable/index notice in tests 2018-07-02 07:45:25 -04:00
Hypolite Petovan
a329ce5b50 Fix $called_api expecting at least 2 elements in tests 2018-07-02 07:45:11 -04:00
Hypolite Petovan
6776c4e3f9 Fix some undefined variable/index notices in tests 2018-07-02 07:44:55 -04:00
717ca0b7eb Use already fetched data for magiclink 2018-07-02 05:41:55 +00:00
0ab9f2e265 Preparations to not store the tags in the item table anymore 2018-06-30 13:54:01 +00:00
028c9f4da5 We now store the verb in the item-content as well 2018-06-27 19:37:13 +00:00
76dab3b2d7 Use gravity instead of verb 2018-06-27 18:09:33 +00:00
b03db4643f The fetch function now centrally controls the content 2018-06-24 10:48:29 +00:00
Hypolite Petovan
98a5749b45
Merge pull request #5277 from annando/native-pdo
We now are using the native pdo mode
2018-06-22 16:04:50 -04:00
6e64091fc7 We now are using the native pdo mode 2018-06-22 19:35:42 +00:00
miqrogroove
c37a8cc661
Update dba.php 2018-06-22 07:34:27 -04:00
miqrogroove
150989ba99
Ensure IN() Conditions Never Mix Data Types 2018-06-21 23:56:19 -04:00
Hypolite Petovan
47ab72352e
Merge pull request #5269 from annando/non-unique-values
This fixes the problem with mixed variables in queries
2018-06-21 22:12:07 -04:00
e1e28ba7c3 Better float detection 2018-06-21 21:55:43 +00:00
miqrogroove
c600ccad5c
Correct dba::close() To Match dba::p() 2018-06-21 17:27:12 -04:00
1b85b75563 Currently removed, needs more testing 2018-06-21 20:42:58 +00:00
261d7435c0 Check for floats and enable native prepares 2018-06-21 20:33:27 +00:00
5656c0564a We don't need to look $is_int there 2018-06-21 19:52:28 +00:00
c1059875bc This fixes the problem with mixed variables in queries 2018-06-21 19:48:25 +00:00
Michael Vogel
4b0cf8d60f
Merge pull request #5267 from miqrogroove/patch-2
Allow for Integer Literals in PDO Database Driver
2018-06-21 18:51:01 +02:00
miqrogroove
759dfe6bb1
Allow for Integer Literals in PDO Database Driver
This should fix things like "LIMIT ?"
2018-06-21 11:42:43 -04:00
d643e00d33 Standards and a new function to fetch content 2018-06-21 15:14:01 +00:00
70af2cecf2 Some of the last direct SQL calls to the item table had been changed 2018-06-21 06:21:51 +00:00
1567eb0791
fixed another left-over ...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-06-20 22:02:16 +02:00
852ef4021b
more spaces + some curly spaces added
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-06-20 22:02:16 +02:00
f2f12d6f50
Minor improvements:
- added spaces and curly braces
- added more TODOs as there really more to be done
- removed redundant braces from "return" keyword (no function)
- merged 2 nested if() into one single

Signed-off-by: Roland Häder <roland@mxchange.org>
2018-06-20 22:02:15 +02:00
962fbc9166 Many "fetch_first" had been replaced 2018-06-19 21:33:07 +00:00
ab5669e091 Some more direct SQL calls had been replaced 2018-06-19 19:06:17 +00:00
Hypolite Petovan
82d55f120f
Merge pull request #5238 from annando/more-abstraction
Even more replaced item calls ...
2018-06-19 14:02:43 -04:00
e4adaa9900 Standards and variable renaming 2018-06-19 17:11:59 +00:00
rabuzarus
0a97a3f822 Bugfix: hide savedsearch butten and subthread button for non local_users 2018-06-19 18:27:54 +02:00
a5ca724fd3 Merge remote-tracking branch 'upstream/develop' into more-abstraction 2018-06-19 13:48:19 +00:00
4714cb746b Use the item functions at many more places 2018-06-18 20:36:34 +00:00
Michael Vogel
f828350ba2
Merge pull request #5234 from fabrixxm/fix/api
API: fix sender/recipient of PMs
2018-06-18 12:03:53 +02:00
fabrixxm
e3ee9ee501 API: fix sender/recipient of PMs: check api_user before get user info.
To throw ForbiddenException and pass tests
2018-06-18 11:55:02 +02:00
507956818d Use the item classes where possible 2018-06-18 05:19:28 +00:00
fabrixxm
c015bb1b77 API: fix sender/recipient of PMs 2018-06-17 19:57:32 +02:00
6e10de9284 New function to fetch item data especially for users 2018-06-17 17:05:17 +00:00
0280a46ab4 Use predefined field lists 2018-06-17 06:27:52 +00:00
abef0cd46c Don't use the author-link anymore - just author-id 2018-06-16 15:35:30 +00:00
14cb128264 New function for generating item URI 2018-06-16 06:44:19 +00:00
bb79b8f4ac More item calls have been replaced with the new functions 2018-06-15 22:30:49 +00:00
Hypolite Petovan
7469de29f1 Fix corrupt registration emails
- Use double quotes for line break-containing translation string
- Simplify HTML/plaintext email body conversion
2018-06-14 23:42:08 -04:00
Hypolite Petovan
d46cac7905 Wrap content filter around entire post including attachments 2018-06-12 21:54:36 -04:00
738644a006 Quit if database connection was lost during "e" 2018-06-11 03:56:19 +00:00
8584e09e12 Store the database credentials for reconnect 2018-06-11 03:45:45 +00:00
b02cdc8a7f Merge remote-tracking branch 'upstream/develop' into quit-on-error 2018-06-11 03:15:59 +00:00
aa3f8ec09d Force a database reconnection in the daemon to prevent lost connections 2018-06-10 22:04:09 +00:00
5d9083c369 Bugfix in notifications / network and display are using the new functions now 2018-06-10 07:26:37 +00:00
defd3d15b6 Possibly fixed test 2018-06-09 20:39:40 +00:00
b6c344a80a $r was still in use 2018-06-09 20:08:15 +00:00
50dfc7d36e Small query corrections 2018-06-09 19:27:44 +00:00
446a45003d Added documentation, some indention fixes 2018-06-09 19:12:13 +00:00
baf316e898 The central item fetch does work now and the API now uses these functions 2018-06-09 16:56:37 +00:00
4874e589f1 New class function to fetch items 2018-06-07 06:03:12 +00:00
e632be763c Corrected variable 2018-06-05 05:44:04 +00:00
18a77a1b45 Removed some quick and dirty hack to upload pictures 2018-06-05 05:42:26 +00:00
Hypolite Petovan
0a13ab6b9f
Merge pull request #5166 from annando/unsed-item-fields
Remove unused, unneeded or redundant item fields
2018-06-03 12:19:50 -04:00
Hypolite Petovan
973ece09c5
Merge pull request #5157 from annando/daemon
Workers can now be started exclusively from the daemon and other workers
2018-06-03 12:18:47 -04:00
443d828ba7 We don't need to look for the uid 2018-06-03 10:29:42 +00:00
6985ad4fb5 Improved error message 2018-06-03 09:55:41 +00:00
b654af28fa We need "global" 2018-06-03 09:40:32 +00:00
ea498ff283 And a second SQL error fixed 2018-06-03 09:21:48 +00:00
d76fb6d0b9 Fixed SQL error 2018-06-03 09:19:27 +00:00
3f07d01dd1 Get rid of unneeded or redundant fields 2018-06-03 07:42:56 +00:00
a720c4f501 Removed unneeded fields from the API 2018-06-03 07:22:01 +00:00
723b5ae803 Use MagicLinkbyId when possible 2018-06-02 08:28:01 +00:00
8a34895a23 Use magicLink whenever possible 2018-06-02 08:05:06 +00:00
28f8beebfc Workers can now be started exclusively from the daemon and other workers 2018-06-01 22:09:27 +00:00
b5b172500d Merge remote-tracking branch 'upstream/develop' into public-redir 2018-06-01 12:32:51 +00:00
Hypolite Petovan
93daf7883e Merge branch 'master' into develop
- Updated new develop version label
- Incremented database build number
2018-06-01 07:30:04 -04:00
ae8d7267a0 "redir" is now centralized and works with the public contact 2018-06-01 06:46:34 +00:00
8329705eba New function to delete items for users 2018-05-29 05:22:57 +00:00
c5a22f86c7 Merge remote-tracking branch 'upstream/2018.05-rc' into deleted-item 2018-05-27 10:38:49 +00:00
Pascal Deklerck
334aa40292 Fix autoname output length 2018-05-27 10:20:27 +02:00
54136f3a74 Added the new parameter to the delete function. 2018-05-26 21:38:45 +00:00
4c36109f02 Some more places to add the user id 2018-05-26 20:03:30 +00:00
bdbc51229a Fix for not being able to delete items 2018-05-26 18:07:27 +00:00
de609e49f0 Improved logging 2018-05-24 22:00:54 +00:00
f8230badba Avoid problems with better variable naming 2018-05-24 21:46:57 +00:00
1bce39120d Reconnect after the connection had been lost. 2018-05-24 21:19:59 +00:00
Hypolite Petovan
b0155fe37b Remove obsolete DNS test from include/dba 2018-05-24 01:31:03 -04:00
87b5e26063 Do a hard exit when the SQL connection went down 2018-05-24 04:07:39 +00:00
3fe07cca57 Issue 2880: Editing post doesn't destroy mentions or hashtags anymore 2018-05-19 14:55:27 +00:00
Alexandre Alapetite
e7d2d27938 sizeof bug
sizeof cannot be used to test existance.

Fixes: Got error 'PHP message: PHP Warning:  sizeof(): Parameter must be
an array or an object that implements Countable in
/.../include/items.php on line 66\n':  1 Time(s)

PHP 7.2.5 / Ubuntu 17.04 LTS
2018-05-17 07:37:50 +02:00
Hypolite Petovan
ce75177d4e
Merge pull request #5022 from Rudloff/feature/test_api
Add API tests
2018-05-16 08:25:11 -04:00
c9f55f6b3d Show "Remove from your screen" or "delete" depending of the impact of the deletion 2018-05-15 21:06:34 +00:00
f34d72c143
Fixes:
- used empty() instead of x()
- removed superflous count()

Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:22 +02:00
d0c7ba5257
Fixed parser error
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:21 +02:00
debcdea82a
Continued:
- merged 2 if() into one with &&
- added TODO for possible rewrite (avoid "complex" code)

Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:05 +02:00
bacb7b70f6
Cleanups:
- added empty lines
- removed old-lost commented out line

Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:05 +02:00
94a02f8572
Continued:
- return is a keyword, not a function, so don't add braces here

Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:05 +02:00
57e668d9e0
Continued:
- avoided else() block which reduces code complexibility
- used more x()
- added curly braces
- added known type-hints

Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:05 +02:00
e0a07d5f27
Continued:
- used x() to make sure the array key is there, else an E_NOTICE is triggered
- added type-hints where it is safe

Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:04 +02:00
47f95855c0
added spaces + some curly braces + some usage of dbm::is_result()
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:01 +02:00
de50d62b81
more spaces + some curly spaces added
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:01 +02:00
35ada99954
Opps, added missing curly brace.
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:58 +02:00
78ffd5b80f
fixed parser error
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:58 +02:00
1c9dc6526f
Continued:
- added more curly braces
- replaced if (blaFoo()) { return true; } return false; with return blaFoo();
- added spaces

Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:58 +02:00
337824f649
Continued:
- added curly braces/spaces
- added TODOs (type-hints, old-lost code)
- more usage of dbm::is_result()
- combined some if() return stuff into a simple return statement

Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:49:58 +02:00
c3c9a53364
added spaces + curly braces and TODOs for upcoming type-hint rewrite. Please
note that PHP5 allows 'array' as type-hint already (+ interface/class name).

Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:49:58 +02:00
61fdc32d2f
Continued a bit:
- more spaces added
- more curly braces added
- let's use x($_FOO, 'bar') and not isset($_FOOT['bar'])

Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:49:57 +02:00
09384119b1
added spaces + some curly braces + some usage of dbm::is_result()
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:55 +02:00
c7e256f9de
more spaces + some curly spaces added
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:55 +02:00
1a61cee5a7
added spaces + some curly braces
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:55 +02:00
f7ceea7a85
added spaces + some curly braces
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:55 +02:00
5b56f189ae
more spaces + some curly spaces added
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:54 +02:00
bc259cdc44
added spaces + some curly braces
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:54 +02:00
914a4e2e0a Fix: Public items werent visible under certain circumstances 2018-05-10 22:06:34 +00:00
Pierre Rudloff
3195d6e125 Add API tests 2018-05-10 19:12:00 +02:00
df019eb5bd Issue 4772: Display posts with uid=0 as well 2018-05-10 10:13:48 +00:00
6c792588fd Ensure to mostly fetch the item with an non zero user id 2018-05-08 22:26:49 +00:00
8d513d74be Reverted SQL sorting 2018-05-08 22:08:25 +00:00
14833edb2d Issue 4990: Fixes missing posts on network page 2018-05-08 22:00:32 +00:00
Pierre Rudloff
9bb11ccfa5 $attachments should aways be an array
In order to avoid a PHP 7.2 error when using count()
2018-05-08 12:16:48 +02:00
Pierre Rudloff
23371880e8 $called_api should always be an array
In order to avoid a PHP 7.2 error when using count()
2018-05-08 12:16:48 +02:00
Hypolite Petovan
3a3a4807a8
Merge pull request #4978 from annando/dba-2
Diaspora: Fix person/contact retraction
2018-05-04 18:04:38 -04:00
7cd7b1a9bf Some more replaced queries 2018-05-04 21:43:29 +00:00
125afb4ae5 Suppress blocked contacts from being displayed 2018-05-04 21:27:20 +00:00
a83970bc0e Some more dba stuff 2018-05-04 06:33:36 +00:00
4ad655ab80 Replace old database queries with the new ones 2018-05-02 19:26:15 +00:00
b4f5311e7f Add Install Mode
- merge `friendica/develop` to `nupplaphil/install_mode`
2018-04-29 20:15:12 +02:00
Michael Vogel
bd0ba24518
Merge pull request #4951 from MrPetovan/bug/4946-move-current-theme-to-app
Move current_theme() to App
2018-04-29 19:11:49 +02:00
78f563407a Fix PR 4942: Fixed item query 2018-04-29 16:32:46 +00:00
Hypolite Petovan
20289393da Fix own post check for content filter 2018-04-28 19:11:11 -04:00
Hypolite Petovan
fde3d6f870 Replace current_theme() and current_theme_url() calls 2018-04-28 18:37:25 -04:00
Hypolite Petovan
9edff6cc5c Add exception for self-contact in item_joins() 2018-04-28 11:38:01 -04:00
1ab965c944 Add Install Mode
- merged `friendica/develop` to `nupplaPhil/install_mode`
- content merged `mod/install.php` to `src/Class/`
2018-04-28 15:11:01 +02:00
Hypolite Petovan
c417f779c4 Add missing readonly check for displaying items in item_joins 2018-04-28 07:47:02 -04:00
a97ad9dc42 Add Install Mode (Part 2)
- Added constants to class `App`
- Added global App-Mode to `dba:connect()` instead parameter `$install`
2018-04-28 12:36:40 +02:00
d5b68cd146 Add a App-Mode with defined constants
- Normal Mode = 0
- Install Mode = 1
- Maintenance Mode = 2

Moved Install-Mode check to class `App`

Replaced all maintenance and install checks with $a->mode checks
2018-04-27 21:07:04 +02:00
6973aaefc2 Add Install Mode
- Added $install_mode in Class App instead
- Extracted the install business logic to a new Class Install
- Replaced all $a->module == 'install' with $a->install_mode
2018-04-23 22:56:59 +02:00
Hypolite Petovan
a84477ed2d Fix count() warning in include/dba.php 2018-04-23 00:00:06 -04:00
Hypolite Petovan
48122733b8 Move content filter HTML in a template 2018-04-22 18:02:00 -04:00
Hypolite Petovan
4cfb12e9d9 Add one-line content filter when there's only one reason 2018-04-22 14:28:34 -04:00
Hypolite Petovan
273dde508b Add default value doc for options.cascade in dba::delete 2018-04-22 11:34:41 -04:00
Hypolite Petovan
0a026515bd Add documentation for $options parameter in dba::delete 2018-04-22 11:33:20 -04:00
Hypolite Petovan
ba3f721524 Prevent side effect with cascade => false in dba::delete 2018-04-22 04:46:46 -04:00
Hypolite Petovan
18078ce7a4 Prevent infinite loop when a dbstructure_definition hook is orphan
- Add cascade option to dba::delete
- use cascade = false for orphan hook deletion
2018-04-21 20:34:07 -04:00
Hypolite Petovan
98f64ed824 Replace duplicate behaviors by Model\Term::populateTagsFromItem
- Replaced in include/conversation
- Replaced in include/text
2018-04-16 22:22:58 -04:00
Hypolite Petovan
54b75026fc Add header support for security token check 2018-04-16 22:22:58 -04:00
d149541dba notify admin when user deletes account 2018-04-15 11:39:05 +02:00
Marcus Müller
3761797e5f
Merge branch 'develop' into patch-1 2018-04-13 09:41:24 +02:00
Marcus Müller
89ba3b78ff
[BUGFIX] DB: Remove host DNS_PTR check
DNS_PTR checks fail on some domains and result in the return value `false`, even if the domain is valid and reachable.
2018-04-12 19:32:04 +02:00
Marcus Müller
e382dfcfbd
[BUGFIX] DB: Don't check DNS on IPs
Fixes https://github.com/friendica/friendica/issues/4786
2018-04-12 19:14:53 +02:00
Pierre Rudloff
f3d98b2864 api_get_user() should not return false right away if the number in the URL is not a valid user 2018-04-10 10:46:10 +02:00
Pierre Rudloff
7d953d952e Various small fixes (#4795)
* Use strict comparison to avoid 0 == false
* Avoid unecessary loop
* Avoid undefined variable
* Fix wrong variable name
* Don't try to use the $status_info variable if it does not exist
* Avoid undefined variable
* Check that variable is defined before trying to use it
* Don't cast $data array to boolean
* Fix undefined array
* $reactivate_group variable is not always defined
* Variable $found is not always defined
* Remove unused return statement
* Fix undefined array
* api_unique_id_to_nurl() requires an integer as argument
* Don't try to use $uinfo if it is false
* Don't use the same variable names in inner loop
* Throw an exception if $fileext is not defined
2018-04-09 15:34:53 -04:00
Pierre Rudloff
773591a6ba Add some missing return types 2018-04-09 19:53:02 +02:00
Pierre Rudloff
4b36f3ad05 api_format_data() seems to never return an object 2018-04-09 19:34:09 +02:00
Pierre Rudloff
9cde7881ee Throw a ForbiddenException if api_get_user() returns false 2018-04-09 18:52:38 +02:00
Pierre Rudloff
d0591dd882 The first argument for api_format_items() must be an array 2018-04-08 01:06:40 +02:00
Pierre Rudloff
9c351bad68 Fix wrong use of empty() 2018-04-08 00:55:05 +02:00
Pierre Rudloff
bef3799942 Use empty() instead of !x() 2018-04-07 23:21:51 +02:00
Pierre Rudloff
333eb5f9dd Add missing variable 2018-04-07 23:20:30 +02:00
Pierre Rudloff
b775cba8c2 Remove confusing comment 2018-04-07 22:39:38 +02:00
Pierre Rudloff
036803d8c7 Typo 2018-04-07 22:37:57 +02:00
Pierre Rudloff
5d8d62015c Make list_id parameter mandatory in api/lists/statuses 2018-04-07 22:36:54 +02:00
Pierre Rudloff
6401eb988b Use dba to access database in api_lists_statuses() 2018-04-07 22:35:19 +02:00
Pierre Rudloff
fea7ec2482 We don't need type casting for dba::select() arguments 2018-04-07 22:18:39 +02:00
Pierre Rudloff
c5aaa61d11 Rename api_list_create() to api_lists_create() for consistency 2018-04-07 22:15:35 +02:00
Pierre Rudloff
c4edad212b Use dba to access the database in list API functions 2018-04-07 19:55:41 +02:00
Pierre Rudloff
929440417c We don't really need the unsen bit in api_lists_statuses() 2018-04-07 19:52:47 +02:00
Pierre Rudloff
b3235c2d02 Implement parts of the list API:
lists/statuses
lists/destroy
lists/update
lists/create
lists/ownerships
2018-04-07 19:16:47 +02:00
Pierre Rudloff
78a979ee58 Add profile_image_url_profile_size and profile_image_url_large properties to user object returned by API (fixes #4695)
This allows some clients to display a bigger avatar on profiles.
2018-04-07 13:31:17 +02:00
Hypolite Petovan
32ca95a1b0 Use App->getSenderEmailAddress in include/enotify 2018-04-06 21:47:42 -04:00
0ccb29c4df Only compare the HTML when we forcefully ignore the cache 2018-04-06 16:52:01 +00:00
297784880e Update the cached rendered html when it changed 2018-04-06 14:01:52 +00:00
Michael Vogel
05cff59f70
Merge pull request #4722 from MrPetovan/task/add-content_filter-hook
Add content_filter hook
2018-04-06 06:42:52 +02:00
3792012723 Improved accessibility for "Frio" 2018-04-05 21:50:34 +00:00
Hypolite Petovan
34fd442821 Rename social.disable_cw pconfig to system.disable_cw 2018-04-04 23:08:48 -04:00
Hypolite Petovan
41db5f0912 Display content warning as title if collapsing is deactivated 2018-04-04 23:08:48 -04:00
Hypolite Petovan
296f561878 Rename hook to "prepare_body_content_filter" 2018-04-04 23:08:48 -04:00
Hypolite Petovan
d38b86dabf Fix disabled content filter for own posts 2018-04-04 23:08:48 -04:00
Hypolite Petovan
f26c99d17b Disable content filter for preview and own posts 2018-04-04 23:08:48 -04:00
Hypolite Petovan
d603bf062d Add CSS classes to content-filter wrapper 2018-04-04 23:08:48 -04:00
Hypolite Petovan
b755e808df Add new content_filter hook in prepare_body
- Add content warning processing to prepare_body with use of disable_cw
setting
- Add filter_reasons params to prepare_body hook
2018-04-04 23:08:48 -04:00
Hypolite Petovan
bec46d7b01 Remove content warning processing in put_item_in_cache 2018-04-04 23:08:48 -04:00
Hypolite Petovan
586b0b6e57 Add bash to text_highlight language list 2018-03-29 19:29:09 -04:00
Hypolite Petovan
daffc27061 Move suppress_tags config to template
- Add new item.suppress_tags template variable
- Fix template formatting
2018-03-25 00:38:23 -04:00
Hypolite Petovan
4eaf0d76b0 Remove include/event 2018-03-23 06:32:34 -04:00
Hypolite Petovan
6e7c6ab0fa Remove references to include/event 2018-03-23 06:32:34 -04:00
Hypolite Petovan
f7e2071117 Replace include/event function with method calls
- Updated scope of Model\Event methods
- Updated use list
2018-03-23 06:32:34 -04:00
Hypolite Petovan
5aecc758f9 Replace include/event function content by method calls 2018-03-23 06:32:34 -04:00
Hypolite Petovan
27d94023ee Merge branch 'master' into develop 2018-03-23 06:15:55 -04:00
e74f186b34 Event: Prevent SQL errors with events without end 2018-03-21 20:16:43 +00:00
73efdb99e3 Fix for incorrect datetime values 2018-03-21 05:20:55 +00:00
f082f0da4f
Merge pull request #4636 from annando/event-diaspora
Fix: Events on Diaspora now should look fine
2018-03-20 08:48:37 +01:00
f4ba5d9799 Fix: Events on Diaspora now should look fine 2018-03-20 06:32:17 +00:00
fabrixxm
e6c59b0593
fix docstring of get_poke_verbs() 2018-03-19 10:20:01 +01:00
fabrixxm
8a2a4510ec
Small fixes to translatable string
and some small cosmetic fixup to docstring for `notification()`
2018-03-19 10:15:09 +01:00
Hypolite Petovan
881c7ccfc1 Add meaningful return value to dba::connect
- Move System::unavailable call to index
2018-03-18 05:15:14 -04:00
537ef83a24 If we aren't connected to the database, we shouldn't return "true" on connect 2018-03-17 09:21:06 +00:00
Hypolite Petovan
c53c00ba4e Add rendred-hash to put_item_in_cache todo 2018-03-15 03:23:11 -04:00
Hypolite Petovan
644767519e Ensure the item body stays the same in put_item_in_cache()
- Add documentation
2018-03-15 02:13:00 -04:00
Hypolite Petovan
e28020c68a Fix for CW: Items weren't cached 2018-03-15 01:32:04 -04:00
Hypolite Petovan
65b0159282
Merge pull request #4593 from annando/fix-ostatus
OStatus: Fixed communication issues with deleted contacts
2018-03-14 18:46:21 -04:00
5bd519efff There is now a "content-warning" field 2018-03-14 22:28:35 +00:00
d98c6819e7 $contact isn't called by reference anymore 2018-03-14 20:53:03 +00:00
32ee4ca4b1 OStatus: Fixed communication issues with deleted contacts 2018-03-13 06:21:44 +00:00
4bb9263e43 Fix: The acl lookup now works in multi threaded posts as well 2018-03-12 04:51:27 +00:00
052ad155a2 Issue 4115: Events are now formatted better for Diaspora 2018-03-11 21:10:36 +00:00
Hypolite Petovan
9f693cc443 Display attach with missing title
- Rework preg_match_all call to remove 3 indentation levels
2018-03-08 23:52:01 -05:00
Hypolite Petovan
f633acd8d1 Remove include/html2*.php files 2018-03-07 16:34:48 -05:00
Hypolite Petovan
789561c7a2 Remove/Update references to include/html2*.php 2018-03-07 16:34:17 -05:00
Hypolite Petovan
5e806ff598 Replace html2plain calls by HTML::toPlaintext 2018-03-07 16:29:44 -05:00
Hypolite Petovan
b5666bd27f Replace html2bbcode calls by HTML::toBBCode 2018-03-07 16:24:13 -05:00
Hypolite Petovan
3bb2f72d05 Replace html2* function content by references to HTML class 2018-03-07 16:21:02 -05:00
Michael Vogel
cc688e2b4f
Merge pull request #4549 from MrPetovan/task/4518-add-memcached-support
[develop] Performance: Add memcached support/Improve database cache (redux)
2018-03-06 16:34:28 +01:00
Hypolite Petovan
95752b79e8 Add cache performance to API and worker 2018-03-04 23:13:19 -05:00
Hypolite Petovan
6447a45a06 Remove include/bb2diaspora.php 2018-03-04 17:43:51 -05:00
Hypolite Petovan
fe5ce67ef8 Move bb2diaspora() content to Content\Text\BBCode::toMarkdown
- Use self where appropriate
- Add BaseObject extension
2018-03-04 17:34:59 -05:00
506f851b23 Bugfix: Avoid that Twidere is crashing 2018-03-04 19:25:02 +00:00
Hypolite Petovan
49f99d94f6 Replace disapora2bb function content with Markdown::toBBCode call 2018-03-04 08:31:40 -05:00
Hypolite Petovan
7bd4a52156
Merge pull request #4532 from annando/dba-array
[develop] We now accept array as condition parameters
2018-03-03 18:14:19 -05:00
74f6dc5373 Renamed functions / each is replaced 2018-03-03 23:02:45 +00:00
Hypolite Petovan
b8fca5efe7 [PHP 7.2] Fix missing Countable warning 2018-03-03 08:48:30 -05:00
194da423e0 An array with fieldnames as keys is important for the "insert" in the "update" function 2018-03-03 13:26:23 +00:00
1510b3d948 tyoi, found by 朱陈锬 thanks for that! 2018-03-03 11:02:40 +01:00
5bda6c7f6d We now accept array as condition parameters 2018-03-03 08:47:13 +00:00
Hypolite Petovan
2f463dfb17 Remove include/acl_selectors 2018-03-02 18:40:09 -05:00
Hypolite Petovan
09c717d751 Remove references to include/acl_selectors 2018-03-02 18:40:09 -05:00
Hypolite Petovan
207eac4a16 Move navbar_complete to Acl 2018-03-02 18:40:08 -05:00
Hypolite Petovan
824262b824 Move populate_acl to Acl 2018-03-02 18:40:08 -05:00
Hypolite Petovan
2b35938e34 Move get_acl_permissions to Acl 2018-03-02 18:40:08 -05:00
Hypolite Petovan
ce9e0f3649 Move prune_deadguys to Contact 2018-03-02 18:40:08 -05:00
Hypolite Petovan
113ea38d50 Move contact_select to Acl
- Simplify Acl::getMessageContactSelectHTML parameters
2018-03-02 18:40:08 -05:00
Hypolite Petovan
eef25a3259 Move contact_selector() 2018-03-02 18:40:08 -05:00
Hypolite Petovan
e2de86de46 Update references in acl_selectors to new functions 2018-03-02 18:40:08 -05:00
1be5275eef Some more performance measuring for database stuff 2018-03-02 13:37:49 +00:00
Hypolite Petovan
4fe1d804ab
Merge pull request #4511 from annando/no-activity
Only show visible activities
2018-02-27 04:41:12 -05:00
74ff36eee9 Only show visible activities 2018-02-27 09:29:11 +00:00
20368cbbf4 Fix for network update (number of maximum comments set to 0) 2018-02-26 22:15:57 +00:00
d2728cad2e Children for the network page are now fetched correctly in the conversation 2018-02-26 06:38:27 +00:00
a1eb5a584f Improve the queries on the network page 2018-02-25 21:33:15 +00:00
a59796d1d4 No gcontact-id anymore (It wasn't really used) 2018-02-21 05:15:55 +00:00
a3af6807ac Improved resource id creation 2018-02-20 10:02:07 +00:00
Hypolite Petovan
e2d8c80f33
Revert "Fix PHP Warning: preg_replace(): Compilation failed in include/items" 2018-02-16 11:12:41 -05:00
Hypolite Petovan
31831b9fdb Remove partial preg_quote in include/items 2018-02-16 00:31:32 -05:00
Hypolite Petovan
f4d76d10b2 Fix PHP Warning: preg_replace(): Compilation failed in include/items 2018-02-15 22:13:45 -05:00
Hypolite Petovan
71cb1523d5 Remove include/bbcode.php 2018-02-14 22:05:16 -05:00
Hypolite Petovan
9e3bae5caa Remove references to include/bbcode.php 2018-02-14 22:01:14 -05:00
Hypolite Petovan
05a2ea4220 Refactor comments including "bbcode()" 2018-02-14 22:00:43 -05:00
Hypolite Petovan
4e4f5862b2 Remove unused $preserve_nl parameter from bb2diaspora() 2018-02-14 21:45:41 -05:00
Hypolite Petovan
0c52866693 Refactor bbcode() into BBCode::convert() 2018-02-14 21:33:55 -05:00
Hypolite Petovan
29f5270313 Remove unused parameter preserve_nl in BBCode::convert 2018-02-14 21:31:28 -05:00
rabuzarus
5fe7a21482 add $no_photos parameter to add_page_info_data() 2018-02-12 03:56:20 +01:00
rabuzarus
26fd6b1c33 fix undeclared variables or wrong variable names (/include) 2018-02-11 22:13:29 +01:00
30cfca40d8 Use a more simple HTML for API output 2018-02-10 13:33:15 +00:00
ee7c587693 Suppress content from hidden or blocked contacts 2018-02-10 12:34:10 +00:00
Hypolite Petovan
164f4f7cdf
Merge pull request #4424 from annando/manage-admin
We can now delegate again like before
2018-02-08 21:41:51 -05:00
Hypolite Petovan
6f9c66b0bc Add missing require in include/text 2018-02-08 19:59:34 -05:00
d42f86e218 We can now delegate again like before 2018-02-08 22:18:34 +00:00
c953784945 Forgotten "use" 2018-02-07 20:22:40 +00:00
85c8bf0228
Merge pull request #4399 from MrPetovan/task/3878-move-include-bbcode-to-src
Move include/bbcode to src/ part 1 : Everything but bbcode()
2018-02-07 07:18:39 +01:00
1ec6359faa Duplicate check 2018-02-06 16:44:48 +00:00
e609de2957 Many item calls are now isolated in a single function 2018-02-06 12:40:22 +00:00
Hypolite Petovan
a0cdd9c674 Rename Core\Network to Core\Protocol 2018-02-05 12:57:41 -05:00
Adam Magness
8906b98426 Remove old file
remove old file
2018-02-05 12:47:37 -05:00
Adam Magness
4be49e706b Remove requires
remove require_once for old file
2018-02-05 12:47:37 -05:00
Michael Vogel
fa95911fdb
Merge pull request #4393 from MrPetovan/task/3878-move-include-tags-to-src
Move include/tags to src/
2018-02-05 18:11:29 +01:00
Hypolite Petovan
8b60cffcb5 Remove most moved functions from include/bbcode 2018-02-04 19:26:22 -05:00
Hypolite Petovan
010cf3b1e8 Update references to BBCode methods
- Resolve name conflicts with Util\Network
2018-02-04 19:26:22 -05:00
Hypolite Petovan
b4651870db Add references to new methods and constants in include/bbcode
- Remove all private callback functions from include/bbcode
2018-02-04 19:25:22 -05:00
Hypolite Petovan
2a5431a59e Rename Model\Term methods 2018-02-04 16:48:50 -05:00
Michael Vogel
dad58e0f6f
Merge pull request #4387 from MrPetovan/task/3878-move-datetime-to-src
Move include/datetime to src/ - Part 2
2018-02-04 21:05:27 +01:00
Hypolite Petovan
fd76b15638 Add is_null check 2018-02-04 08:58:29 -05:00
Hypolite Petovan
ef77a772e5 Remove include/tags.php 2018-02-04 00:00:11 -05:00
Hypolite Petovan
2a486903d1 Remove references to include/tags.php 2018-02-03 23:59:31 -05:00
Hypolite Petovan
d00c6111fd Replace include/tags function content with references to src methods 2018-02-03 23:52:36 -05:00
Hypolite Petovan
0abe4158d2 Rename Term methods ahead of the move
- Rename createFromItemURI() to insertFromItemFileByUri()
- Rename createFromItem() to insertFromItemFileById()
2018-02-03 22:42:31 -05:00
Hypolite Petovan
3dda70baf1 Add system.dlogip setting usage in dlogger() 2018-02-03 21:46:28 -05:00
Hypolite Petovan
6b50c42de6 Actually delete include/datetime.php 2018-02-03 20:47:37 -05:00
Hypolite Petovan
d037300d3b Remove include/datetime.php 2018-02-03 20:47:37 -05:00
Hypolite Petovan
f020292408 Remove references to include/datetime 2018-02-03 20:47:37 -05:00
Hypolite Petovan
cea80c78e4 Replace remaining functions in include/datetime by Temporal methods
- Fix uses statements
2018-02-03 20:47:37 -05:00
Hypolite Petovan
876acd68a0
Merge branch 'develop' into task/3878-move-session-to-src 2018-02-03 11:59:43 -05:00
e5a5a7dc7b
Merge pull request #4386 from MrPetovan/task/3878-move-friendica_smarty-to-src
Move SMARTY3_TEMPLATE_FOLDER to FriendicaSmarty
2018-02-03 17:01:30 +01:00
Hypolite Petovan
5e7285b9ba Move Temporal::convert() to DateTimeFormat::convert() 2018-02-03 08:56:55 -05:00
Hypolite Petovan
b7a7355292 Simplify include/bb2diaspora event format 2018-02-03 08:56:53 -05:00
Hypolite Petovan
0bee706e51 Add Temporal::local() shorthand for Temporal::convert() 2018-02-03 08:56:53 -05:00
Hypolite Petovan
25954314ec Add missing Temporal::utc() 2018-02-03 08:56:53 -05:00
Hypolite Petovan
a2ee2b56d2 Add Temporal::localNow() shorthand for Temporal::convert() 2018-02-03 08:56:53 -05:00
Hypolite Petovan
89602e44da Add Temporal::timezoneNow() shorthand for Temporal::convert() 2018-02-03 08:56:53 -05:00
Hypolite Petovan
35d06bd9eb Add Temporal::utc() shorthand to Temporal::convert() 2018-02-03 08:56:53 -05:00
Hypolite Petovan
8aff8a76eb Add Temporal::utcNow() 2018-02-03 08:56:52 -05:00
Hypolite Petovan
38ff1b455b Add Temporal::MYSQL constant
- Rename Temporal::convert() parameter names
2018-02-03 08:56:52 -05:00
Hypolite Petovan
b854905150 Move ATOM_TIME to Temporal::ATOM 2018-02-03 08:56:52 -05:00
Hypolite Petovan
dc366bf1f7 Refactor datetime_convert into Temporal::convert
- Changed parameter order to save space
- Refactor select_timezone into Temporal::getTimezoneSelect
- Refactor field_timezone into Temporal::getTimezoneField
2018-02-03 08:56:51 -05:00
Hypolite Petovan
d478ef6c6d Add Util\Temporal to src
- Map include/datetime functions to Temporal methods
- Move update_contact_birthdays() to Model\Contact::updateBirthdays()
2018-02-03 08:56:51 -05:00
Hypolite Petovan
7be49913d4 Remove get_template_file function 2018-02-03 08:52:55 -05:00
Hypolite Petovan
87b19dd9ac Remove include/session file 2018-02-03 08:40:18 -05:00
Hypolite Petovan
99eb696386 Remove include/friendica_smarty 2018-02-02 07:46:13 -05:00
Hypolite Petovan
65713f26f4 Remove references to include/friendica_smarty 2018-02-02 07:46:13 -05:00
Hypolite Petovan
1ef02bd36b Remove include/like 2018-02-01 14:17:31 -05:00
Hypolite Petovan
974539913c Remove include/like references 2018-02-01 14:17:22 -05:00
Hypolite Petovan
a286e8bf3b Replace do_like() calls 2018-02-01 14:17:08 -05:00
Hypolite Petovan
d1001bf158 Replace do_like() content 2018-02-01 14:14:27 -05:00
03aafa8228 Public commenting is now always enabled 2018-01-31 23:22:41 +00:00
9cbc4a7355 Basic forum support for Diaspora 2018-01-30 06:22:09 +00:00
7b27dda784 Most functions now moved from include/items.php 2018-01-28 11:18:08 +00:00
Adam Magness
f04d40a37e Review update
Rename function, move others
2018-01-27 11:13:41 -05:00
Adam Magness
0f1be37279 Remove old file
remove network.php and all require_once statements
2018-01-27 08:28:20 -05:00
Adam Magness
ca76e49c23 Move remaining functions
update remaining function calls
2018-01-27 08:25:54 -05:00
Adam Magness
1eb7c19c1e Move multiple functions
move multiple smaller functions
2018-01-26 23:51:41 -05:00
Adam Magness
cd3643d174 Move xml_status and http_status_exit
move functions
2018-01-26 23:37:55 -05:00
Adam Magness
a32ba32ff4 Move post_url
move post_url function
2018-01-26 23:24:23 -05:00
Adam Magness
2f9642392d Move z_fetch_url
move z_fetch_url method
2018-01-26 23:18:38 -05:00
Adam Magness
c67452f72e Move fetch_url
move fetch_url function
2018-01-26 23:09:48 -05:00
Adam Magness
1b51777825 Create Network class
Create Network class and copy methods
2018-01-26 22:51:07 -05:00
Adam Magness
177edd2b6e Rename class to BBCode
Rename Plaintext class to BBCode
2018-01-26 20:01:32 -05:00
Adam Magness
c437b0c871 Remove old file
remove include/plaintext.php
2018-01-26 19:16:26 -05:00
Adam Magness
11c7441e94 Remove requires
remove require_once statements
2018-01-26 19:15:57 -05:00
Adam Magness
21881f2885 Update function calls
update to new function calls
2018-01-26 19:14:47 -05:00
cd7b81afd5 Use "sup" instead of "h5" for the link to the website 2018-01-26 13:27:16 +00:00
Adam Magness
5951ceeb6f Remove old file
remove include/post_update.php
2018-01-25 11:29:43 -05:00
Hypolite Petovan
9ab55181ed
Merge pull request #4331 from annando/other-hashtags
Support for hashtags with "#" inside the link (mastodon style?)
2018-01-25 10:02:04 -05:00
8abc4d25b4 Support for hashtags with "#" inside the link (mastodon style?) 2018-01-25 14:58:10 +00:00
66fe4cc5d6
Merge pull request #4326 from MrPetovan/task/fix-translation-strings
Fix translation strings
2018-01-25 07:02:09 +01:00
Hypolite Petovan
49b7a830dc
Merge pull request #4324 from annando/items-rework
Some functions had been moved away from include/items.php
2018-01-24 17:25:36 -05:00
Hypolite Petovan
9cd3b17743 Fix translation strings for use with util/extract.php
- Change parentheses to “\x28” and “\x29”
- Remove leading commas
- Remove quotes before commas
2018-01-24 16:51:32 -05:00
1294ac19c8 Issue 4227: Make hash tags always local links 2018-01-24 21:37:12 +00:00
3ace5d0d1d Some functions had been moved away from include/items.php 2018-01-24 20:27:32 +00:00
Hypolite Petovan
30c1cc0e8c
Merge pull request #4312 from zeroadam/feature/L10n
Move pgettext to src
2018-01-24 11:48:55 -05:00
Adam Magness
df7bdbfc66 More missed calls
missed t() calls
2018-01-24 10:19:58 -05:00
Adam Magness
428a22cc76 More sprintf
eliminate more sprintf( with L10n
2018-01-24 07:18:21 -05:00
Adam Magness
8eecad4c7f String correction
monthly is monthly
2018-01-23 22:43:22 -05:00
Adam Magness
5142e65726 Review updates
improve a t() call and move some to tt()
2018-01-23 22:38:47 -05:00
Adam Magness
c28f886179 Avoid branch conflict 2018-01-23 22:03:57 -05:00
Adam Magness
208a149a7b Review sprintf
remove more sprintf calls
2018-01-23 21:59:16 -05:00
3fbc873ffe Birthdays are now transmitted reliably to Diaspora 2018-01-23 22:51:30 +00:00
Adam Magness
f7e9b74dca Update function and sprintf
Update variable to static function and remove sprintf wrappers
2018-01-23 12:47:30 -05:00
Adam Magness
f0725ae384 Hopefully all t()
hopefully the last of the t()
2018-01-22 18:03:26 -05:00
Adam Magness
83f1149d04 More missing t()
update t() calls
2018-01-22 18:03:26 -05:00
Adam Magness
bae725c279 Security t()
missed t() calls in security
2018-01-22 18:03:26 -05:00
Adam Magness
6e758d0074 More missed use
a few more missed use statements for L10n
2018-01-22 18:03:26 -05:00
Adam Magness
06fc1d6588 Missing use
missed use statement for L10n
2018-01-22 18:03:26 -05:00
Adam Magness
b4d0df18c5 Remove old file and requires
Remove pgettext.php and remove require_once calls
2018-01-22 18:03:26 -05:00
Adam Magness
3b0f69599e Updat tt() calls
update function calls for tt()
2018-01-22 18:03:26 -05:00
Adam Magness
d49f986d1e Many t() calls
modify many t() calls.
2018-01-22 18:03:26 -05:00
Adam Magness
c8ecc31405 Update functions and calls
Update function names and calls.
2018-01-22 18:03:26 -05:00
2e333dea8f Code cleaned 2018-01-22 22:26:47 +00:00
b4d14164bb The url detection in BBCode is too greedy 2018-01-22 21:52:32 +00:00
004f46e600 Standards 2018-01-21 00:18:31 +00:00
efa8dbcfb3 Relocate functions in items.php into several classes 2018-01-20 23:52:54 +00:00
Adam Magness
b86b04a81a Change plugin to addon
change the use of plugin to addon where appropriate.
2018-01-20 07:48:22 -05:00
Adam Magness
3bad83f24e Remove old file
remove include/plugin.php
2018-01-20 07:48:22 -05:00
Adam Magness
6c4c567319 Remove require
remove require_once for plugins.php
2018-01-20 07:48:22 -05:00
Adam Magness
11cf36105c Update Addon functions and calls
Update function names and calls for Addon class.
2018-01-20 07:48:22 -05:00
Michael Vogel
104a03e82a
Merge pull request #4283 from MrPetovan/bug/2487-fix-autolink-regex
Fix autolink regular expression to include accents
2018-01-20 09:24:16 +01:00
Hypolite Petovan
4cca8280b4 Fix undefined variables PHP Notice
- $order_string in include/dba
- $limit_string in include/dba
- $search in mod/search
- $lang_list in include/pgettext.php
2018-01-19 22:52:49 -05:00
Hypolite Petovan
491a1373e0 Fix autolink regular expression to include accents 2018-01-19 21:39:57 -05:00
Hypolite Petovan
de70007a46 Update RINO settings 2018-01-19 11:27:53 -05:00
034d46196f "last-child" is not used anymore 2018-01-18 06:54:44 +00:00
2d66242b4f The delete function is now changed to the new function 2018-01-17 23:22:01 +00:00
Hypolite Petovan
f193f01a7d Fix issues in changed files
- Initializes $return in Process::insert
- Update the type hint of dba::fetch
- Remove unused $a parameter in worker_init()
- Fix uses
2018-01-17 00:17:58 -05:00
c4d3ab6878 Transfer all item shadow functions to the item class 2018-01-16 22:23:19 +00:00
Adam Magness
c98e558372 Remove old file
remove include/queue_fn.php
2018-01-15 20:16:51 -05:00
Adam Magness
bb08f87bba Remove old file
remove include/nav.php
2018-01-15 17:12:39 -05:00
Hypolite Petovan
e36f2bb1fb Use short form array syntax everywhere
- Add short form array syntax to po2php.php generation
2018-01-15 14:07:17 -05:00
Adam Magness
ebd071d181 Remove old file
remove include/message.php
2018-01-15 12:14:37 -05:00
Adam Magness
b3e6a1d283 Update functions and calls
Update functions and calls.
2018-01-15 12:14:09 -05:00
Hypolite Petovan
46bf82eeb7
Merge pull request #4247 from zeroadam/ProfileSel-#3878
Move profile_selector to src
2018-01-15 11:34:35 -05:00
Adam Magness
494f61a78f Remove old file
remove include/profile_selectors.php
2018-01-15 10:16:21 -05:00
Adam Magness
d4178d482b Remove old file
remove include/contact_widgets.php
2018-01-15 09:50:45 -05:00
Adam Magness
6cf6029ff5 Rename functions and calls
Rename functions and update calls
2018-01-15 09:50:06 -05:00
Adam Magness
edb8110555 Remove old file
remove include/attach.php
2018-01-15 08:33:12 -05:00
Adam Magness
41159cd14f use 2018-01-14 21:41:56 -05:00
Adam Magness
641ab5e247 Remove include/identity
remove no longer used file
2018-01-14 21:23:18 -05:00
Adam Magness
4fb2547df8 Update function calls
update function calls to use profile class
2018-01-14 21:22:39 -05:00
Hypolite Petovan
fabbf810b0 Move library/markdown.php to src 2018-01-14 19:01:09 -05:00
Hypolite Petovan
503e5847f9 Improve html2bbcode
- trim code blocks
- Add <code> conversion to <code> (from Diaspora)
2018-01-14 19:01:09 -05:00
Hypolite Petovan
f828afde83 Extend multi-line code blocks regular expression
- Covers the case where there's no new line after the [code] tag
2018-01-14 19:01:09 -05:00
Hypolite Petovan
64e3dbfaa4
Merge pull request #4225 from zeroadam/UserImport-#3878
Move include/uimport to src
2018-01-14 17:21:26 -05:00
Michael Vogel
1ecfa49f4c
Merge pull request #4233 from MrPetovan/task/4116-move-smarty-to-composer
Move Smarty to composer
2018-01-14 20:05:52 +01:00
Hypolite Petovan
e412cd7c51 Fix formatting in include/friendica_smarty 2018-01-14 13:36:48 -05:00
Hypolite Petovan
03b16c449f Remove library/Smarty 2018-01-14 13:36:27 -05:00
Hypolite Petovan
4dafdda99e Fix Deprecated error message 2018-01-14 09:04:46 -05:00
Hypolite Petovan
adfabeadb1 Rename param to condition in dba::delete
- Fix formatting
- Use new array syntax
2018-01-13 23:46:59 -05:00
Adam Magness
4e7657da99 Remove redir.php
remove old file
2018-01-13 09:41:26 -05:00
Adam Magness
88aeddab82 Remove old file
Remove include/uimport.php
2018-01-13 09:15:45 -05:00
fabrixxm
2d0fe7a30f
Fix api login 2018-01-13 09:22:40 +01:00
Hypolite Petovan
93355b574d Fix attachment display
- Move autolink before any potential OEmbed injection
- Add original URL attribute to invalid href and src
- Add loop to video to enable animated gifs
- Add URL domain to link attachments
- Hide link attachment description if equals the title
- Change attachment span to div to respect block order
2018-01-11 22:37:38 -05:00
Hypolite Petovan
b01daf18c5 Fix formatting of get_attachment_data() 2018-01-11 22:29:56 -05:00
6f1b1aee4b Bugfix: The name of the item owner was empty in notifications 2018-01-11 22:07:41 +00:00
a7b2db5db9 When no OEmbedding is wanted, the links are now created fine again 2018-01-11 21:31:44 +00:00
Hypolite Petovan
5ccbc95cef Guard dba::lastInsertId() with result conditions 2018-01-11 03:49:02 -05:00
Hypolite Petovan
5fc4927764 Improve dba::selectFirst calls
- Fix remaining $r[0] references
- Rename $r to meaningful names
2018-01-11 03:43:57 -05:00
Hypolite Petovan
5691564220 Trust OEmbed HTML when it's available
- Reworked bb_attachment() to trust OEmbed content when it's
successfully pulled
- Fix coding standard by renaming parameter and variables
2018-01-10 19:25:08 -05:00
Michael Vogel
d23c1c0da7
Merge pull request #4194 from MrPetovan/task/fix-scrutinizer-issues
Replace dba::select(limit => 1) by dba::selectFirst()
2018-01-10 22:16:02 +01:00
Michael Vogel
7be65769c5
Merge pull request #4197 from rabuzarus/20180110_-_rename_saved_search_button
the "save" button is now 'follow' when searching for tags
2018-01-10 20:31:44 +01:00
Hypolite Petovan
1fda0ae4ae Replace select(limit => 1) by selectFirst() in Model\Term and include/enotify
- Add new array declaration syntax
- Add braces
2018-01-10 13:04:00 -05:00
Hypolite Petovan
483d1a1bcb Rename selectOne to selectFirst in comment 2018-01-10 12:57:21 -05:00
Hypolite Petovan
ae66bcaff3 Rename selectOne to selectFirst 2018-01-10 12:57:21 -05:00
Hypolite Petovan
c7a7658316 Fix documentation in include/dba 2018-01-10 12:57:21 -05:00
Hypolite Petovan
da60893590 Replace dba::select(limit => 1) by dba::selectOne
- Convert array declarations to new style
2018-01-10 12:57:21 -05:00
Adam Magness
7723309310 Remove requires
Remove left over require_once statements.
2018-01-10 12:11:11 -05:00
Adam Magness
dc175b8e12 Update functions and calls
Change function names, calls and use dba functions.
2018-01-10 12:05:20 -05:00
Adam Magness
55ee9a1c72 Move files to src
Move files.php and create Term class
2018-01-10 11:46:05 -05:00
rabuzarus
a75ececab4 remove @brief from the doc header 2018-01-10 16:39:59 +01:00
rabuzarus
eb031e7ee2 rename the "save" button to 'follow' when searching for tags 2018-01-10 16:08:39 +01:00
Adam Magness
510e0dbb2e Remove requires
remove old require_once
2018-01-09 22:48:15 -05:00
Adam Magness
98c162552b Remove old file
remove contact_selectors
2018-01-09 22:43:14 -05:00
Adam Magness
a3ef9e35ec Update functions and calls
Update function names and calls.
2018-01-09 22:42:04 -05:00
Adam Magness
484eb960d7 Remove follow
remove follow.php
2018-01-09 10:03:31 -05:00
Hypolite Petovan
4a20bcd6f0 Fix allowed_email()
- Reworked allowed_domain
- Added more variable checks to allowed_email() and
OEmbed::isAllowedURL()
2018-01-07 19:10:09 -05:00
Hypolite Petovan
6496a721ea
Merge pull request #4182 from annando/notify-public-post
Sends notifications for public posts with "uid=0"
2018-01-07 15:54:57 -05:00
24d7b2af82 One more query 2018-01-07 18:11:48 +00:00
28d3980fab Changed queries 2018-01-07 18:06:06 +00:00
Michael Vogel
511572533e
Merge pull request #4183 from MrPetovan/bug/4173-fix-oembed-iframe-url
Restore tryoembed callback function
2018-01-07 18:10:00 +01:00
Hypolite Petovan
5605bdd289 Remove debug code 2018-01-07 10:02:21 -05:00
Hypolite Petovan
ca77bff933 Restore tryoembed callback
- Remove irritating extra <br> before shared content
2018-01-07 10:01:41 -05:00
708d034c6d We have to check for the contacts uid not the items uid 2018-01-07 12:10:31 +00:00
f2efd58366 Sends notifications for public posts with "uid=0" 2018-01-07 11:08:36 +00:00
Michael Vogel
1fdde9b140
Merge pull request #4179 from MrPetovan/bug/4173-fix-oembed-iframe-url
Fix OEmbed iframe
2018-01-07 09:28:44 +01:00
Hypolite Petovan
d8a312d286 Move tryoembed to Content\OEmbed
- Add bbcode functions documentation
- Add Exception handling to OEmbed::getHTML
- Fix formatting
2018-01-07 00:44:23 -05:00
Hypolite Petovan
1cd8001833 Fall back to normal twitter share if rich OEmbed is disabled
- Fix typo
2018-01-06 21:57:58 -05:00
Hypolite Petovan
9e54d8d4b4 Fix Twitter quote tweet display
- Transforms twitter share tags into rich OEmbed attachments
2018-01-06 00:39:59 -05:00
Hypolite Petovan
6444f97c98 Fix issues in mod/contacts
- Fix formatting
- Use DBM::is_result()
- Use dba::select
- Simplify sprintf(t[t]()) structures
- Remove commented out code
- Remove unused variables
- Update documentation type hints
2018-01-05 21:05:23 -05:00
2d9163ce30 Posts from contacts weren't displayed correctly 2018-01-05 19:47:55 +00:00
Hypolite Petovan
c544258627 Revert assignment change in datetime 2018-01-04 22:51:38 -05:00
Hypolite Petovan
819592c3bd Fix Scrutinizer issues in mod [_well_know -> contactgroup]
- Remove unused variables and parameter
- Updated function documentation
- Fix formatting
- Add back uninitialized variables
- Simplify nested conditions
2018-01-04 19:42:48 -05:00
Hypolite Petovan
3b4f5f98f8
Merge pull request #4169 from annando/comment-dfrn
Precaution for incomplete threads
2018-01-04 16:31:16 -05:00
05c8cbc1e1 Precaution for incomplete threads 2018-01-04 20:59:19 +00:00
Hypolite Petovan
58d5d91831
Merge pull request #4168 from annando/comment-dfrn
Commenting to (nearly) every Friendica contact is now possible
2018-01-04 15:12:07 -05:00
Michael Vogel
066b776dcc
Merge pull request #4166 from MrPetovan/task/fix-scrutinizer-issues
[Scrutinizer] Fix unused code issues in boot and include
2018-01-04 20:59:07 +01:00
Michael Vogel
c938623a3d
Merge pull request #4167 from MrPetovan/bug/4155-remove-proxy-oembed
Add settings for OEmbed
2018-01-04 20:57:27 +01:00
0c9a9b6f0c Commenting to (nearly) every Friendica contact is now possible 2018-01-04 19:48:56 +00:00
Hypolite Petovan
d1b3b7fbe4 Review changes
- Remove doc for unused config value
- Restore api_get_user($a) calls
2018-01-04 13:26:09 -05:00
Hypolite Petovan
35a18f6825 Fix unused code in include (second pass) 2018-01-04 12:21:13 -05:00
Hypolite Petovan
3b23f89ca2 Fix unused code in include
- Fix local formatting
- Remove unused variable
- Fix unreached breaks
- Remove commented out code
- Add some documentation
2018-01-04 12:21:13 -05:00
Hypolite Petovan
722782d553 Remove unused parameter in can_write_wall() 2018-01-04 12:21:13 -05:00
Hypolite Petovan
659d637b5a Remove unused param in datetimesel() 2018-01-04 12:19:06 -05:00
Hypolite Petovan
3b4625ebdd Fix unused code in include/api 2018-01-04 12:19:06 -05:00
Hypolite Petovan
d9c6417f5d Remove construct_acl_data() 2018-01-04 12:19:06 -05:00
04589ecd38
Merge pull request #4092 from MrPetovan/task/3954-move-auth-to-src
Move auth to src
2018-01-04 18:06:42 +01:00
Hypolite Petovan
1f805da94f Move ParseUrl to Util namespace 2018-01-04 12:03:15 -05:00
Hypolite Petovan
3494663c15 Add allowed_domain generic function 2018-01-04 11:57:41 -05:00
Hypolite Petovan
6e71a84075
Merge pull request #4160 from annando/community
We now are having a global items page
2018-01-04 11:50:45 -05:00
ade987db47 Updates for community pages do work now 2018-01-04 15:46:56 +00:00
b677bdd4ff Ensuring that only local users can comment on community items 2018-01-04 14:39:47 +00:00
505474e118 Community is always available 2018-01-04 14:09:44 +00:00
f66f631079 We now have a single menu item again 2018-01-04 14:02:04 +00:00
e96dbbe7f7 It's now in a single file 2018-01-04 13:04:12 +00:00
174a1bb54b Commenting on community timelines is now possible 2018-01-04 10:02:56 +00:00
Adam Magness
e37640c44c Move Photos to xrc
Move photos from include to Model\Photo class
2018-01-03 21:01:41 -05:00
243848eec1 Remove some currently unused stuff 2018-01-03 13:34:51 +00:00
3ffea2cd2c We now have a global page for all global entries from the network. 2018-01-03 13:27:43 +00:00
6925299e5a Merge remote-tracking branch 'upstream/develop' into community 2018-01-03 01:15:27 +00:00
Hypolite Petovan
9a3e773a9a Merge branch 'develop' into task/3954-move-auth-to-src 2018-01-02 19:30:41 -05:00
Hypolite Petovan
9ea4fad46c Review: Ensure $arr['network'] is populated in item_store 2018-01-02 08:32:53 -05:00
Hypolite Petovan
3dab04e6cc Review: Removed unused code in include/bbcode 2018-01-02 08:30:15 -05:00
Hypolite Petovan
69df67740c Last minute fix to include/items
- Use defaults() to fix undefined indexes
2018-01-02 08:18:19 -05:00
Hypolite Petovan
d0d4e3813b Fix formatting and PHP notices in include/tags
- Change remaining double quotes into single
2018-01-02 08:11:14 -05:00
Hypolite Petovan
9f04017e27 Quick fix PHP notices in various files
- Remove unused variables
- Fix variable name typos
- Use x() and defaults() to fix undefined index
- Add back uninitialized variables
2018-01-02 08:11:14 -05:00
Hypolite Petovan
861c4c7474 Fix formatting and PHP notices in identity
- Change flow of profile_load() function to return early if $profiledata
and !$user
- Replace remaining double quotes by single
- Add back uninitialized variables in profile_sidebar
2018-01-02 08:09:50 -05:00
Hypolite Petovan
a964129085 Fix formatting and PHP notices in events
- Initialized variables in include/event
- Check for argc before retrieving argv in mod/events
2018-01-02 08:09:50 -05:00
Hypolite Petovan
3069f3b59d Fix formatting and PHP notices in include/conversation
- Remove unused $nickname variable
- Remove unused $comment variable
- Use defaults() in get_responses() to check for array key existence
2018-01-02 08:09:50 -05:00
Hypolite Petovan
66dbef93e3 Fix formatting and PHP notices in bb_ShareAttributes
- Use x() to check for existence of key in $matches
- Remove unused $reldate from template shared_content
2018-01-02 08:09:49 -05:00
Hypolite Petovan
eb1b6605b7 Remove include/oembed and mod/oembed 2017-12-31 20:58:32 -05:00
Hypolite Petovan
e7c53af6fa Add Module\Oembed and Content\OEmbed 2017-12-31 20:58:09 -05:00
Adam Magness
9e6bf79380 Crypto to src
move Crypto to src and Friendica\Util namespace
2017-12-30 11:51:49 -05:00
Hypolite Petovan
c238154a6e Move include/auth to Login::sessionAuth
- Remove include/auth
2017-12-29 21:55:13 -05:00
Hypolite Petovan
2dc598ed5b Move login() to Login module
- Move nuke_session to include/security
- Remove mod/login
2017-12-29 21:55:13 -05:00
Hypolite Petovan
1724dd3841 Make validate_url more intuitive
- Remove the parameter passed by reference
- Add modified url in return value
2017-12-29 21:55:13 -05:00
Hypolite Petovan
e16852c2f5 Replace init_groups_visitor with Group::getIdsByContactId 2017-12-29 21:55:12 -05:00
Hypolite Petovan
09467be02a Fix formatting include/security 2017-12-29 21:55:12 -05:00