Changes: - added more type-hints - DBStructure::existsTable() does no longer need array support for table name because this is no longer used (good work!)Roland Häder2022-06-19 02:10:04 +0200
Continued: - added more type-hints - added some missing documentation - Return the result from DBA::delete() to let other methods know about itRoland Häder2022-06-18 17:22:10 +0200
Continued: - prevents a "Return value of Friendica\Core\Worker::workerProcess() must be of the type array, bool returned"Roland Häder2022-06-18 15:56:58 +0200
Sizes increased for: - video files that have sizes var being int allowes - URLs that might be longer (e.g. magnet: URLs) than varbinary(511) allowsRoland Häder2022-06-18 15:30:36 +0200
Fixed TypeError: "Argument 1 passed to Friendica\Core\System::httpExit() must be of the type string, null given, called in /var/www/.../src/Module/DFRN/Poll.php on line 37"Roland Häder2022-06-18 05:41:19 +0200
Set type-hint for parameter $data to SimpleXMLElement as $fields in dispatch() is the same and being handled over.Roland Häder2022-06-18 05:18:38 +0200
Changes: - added some type-hints - replaced most double-quotes (only Diaspora.php, later more) with single - added some documentation - normalized indenting in Diaspora.php (I hope I got all?)Roland Häder2022-06-18 05:01:51 +0200
36d56a4041Continued: - changed back to 'return false;' as other methods heavily rely on false instead of an empty array as pointed out by @heluecht@pirati.ca - $fetched_contact should be initialized as an empty array, let's not make this code more crazier than it already is (see APContact::getByURL())Roland Häder2022-06-17 11:48:52 +0200
fdd237a090Fix for "Uncaught Exception TypeError: "Argument 1 passed to Friendica\Model\APContact::unarchiveInbox() must be of the type string, null given" error messageRoland Häder2022-06-17 10:53:45 +0200
605e7d55b3Continued: - added more type-hints - some methods in Diaspora returned void but integer was documented so I changed it to -1 to have a proper type-hintRoland Häder2022-06-17 10:44:13 +0200
0c9aff8a09Also need to declare $profile or otherwise an invocation of Receiver::getReceiverForActor() will fail.Roland Häder2022-06-17 09:51:11 +0200
af8cd5ca86Worker::getWaitingJobForPID() can also return FALSE on failure ... :-(Roland Häder2022-06-16 22:17:37 +0200
227bab43a8Ops, wrong type-hint here, must be string ($nickname can never be an integer).Roland Häder2022-06-16 22:15:06 +0200
e484b6d6dcContinued: - added more type-hints - added some documentation - Contact::getAccountType() should only process string, not nullRoland Häder2022-06-16 21:57:02 +0200
45b5f67bcaFix for non-existing record system.mobile_theme in config tableRoland Häder2022-06-16 20:58:24 +0200
5c9ce790bfFixed: - $object_data['actor'] can be null, but Receiver::getReceivers()'s 2nd parameter expect it to be stringRoland Häder2022-06-16 20:47:59 +0200
33768ea1c6Some fixes: - $gsid's default value cannot sadly be 0, it now must be null to allow some code work - added some more type-hints - documented a bit moreRoland Häder2022-06-16 20:42:40 +0200
2766c7d9cfContinued: - added more type-hints - added some missing documentationRoland Häder2022-06-16 20:01:09 +0200
a587217f47Fixed "Argument 4 passed to Friendica\Protocol\DFRN::processVerbs() must be of the type bool"Roland Häder2022-06-16 19:39:49 +0200
dd54e52575MrPetovan brought the right one up: > Since this is depending on remote systems, the log can quickly fill with unactionable messages.Roland Häder2022-06-16 19:21:07 +0200
This will 2 things: 1) The first change prevents "expensive" code in HTML::toBBcode() to be executed just for an empty string which makes no sense. 2) The above change was maybe flawed as $apcontact['about'] would have never been created, not even empty which could have side effectsRoland Häder2022-06-16 15:08:04 +0200
Fixes and type-hints: - added more checked type-hints as they prevent bad method invocations - fixed TypeError for HTML::toBBCode() invocations with NULL as first (wrong) argument, thanks to @tobias@social.diekershoff.de pointing this out.Roland Häder2022-06-16 13:14:00 +0200
Changes: - added more type-hints - changed return; to return ''; when string was requested as returned type-hint (thanks to @MrPetovan)Roland Häder2022-06-15 22:03:13 +0200
Hypolite Petovan
Roland Häder
Tobias Diekershoff
Michael