strk/friendica
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

$contact isn't called by reference anymore

Browse source
This commit is contained in:
Michael 2018-03-14 20:53:03 +00:00
parent 7db0b850cb
commit d98c6819e7
2 changed files with 6 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
include/items.php
View file

@ -228,7 +228,7 @@ function add_page_info_to_body($body, $texturl = false, $no_photos = false) {
*
* @TODO find proper type-hints
*/
function consume_feed($xml, $importer, &$contact, &$hub, $datedir = 0, $pass = 0) {
function consume_feed($xml, $importer, $contact, &$hub, $datedir = 0, $pass = 0) {
if ($contact['network'] === NETWORK_OSTATUS) {
if ($pass < 2) {
// Test - remove before flight

13
src/Worker/OnePoll.php
View file

@ -582,15 +582,12 @@ class OnePoll
logger("Consume feed of contact ".$contact['id']);
// Use a copy of the contact to avoid problems.
// The contact parameter is called by reference.
$contact2 = $contact;
consume_feed($xml, $importer, $contact2, $hub, 1, 1);
consume_feed($xml, $importer, $contact, $hub);
// do it twice. Ensures that children of parents which may be later in the stream aren't tossed
$contact2 = $contact;
consume_feed($xml, $importer, $contact2, $hub, 1, 2);
// do it a second time for DFRN so that any children find their parents.
if ($contact['network'] === NETWORK_DFRN) {
consume_feed($xml, $importer, $contact, $hub);
}
$hubmode = 'subscribe';
if ($contact['network'] === NETWORK_DFRN || $contact['blocked'] || $contact['readonly']) {