ce177f22c8
Fix doc blocks and return value type
2019-01-21 11:36:01 -05:00
7f2dc40601
Fix potential bugs without expected behavior change
...
- Fix uninitialized variables
- Fix potentially not set variables
- Fix wrong parameter default value
- Fix method scope
- Fix missing return value
2019-01-21 11:04:19 -05:00
ad9c67663d
Move Contact::Page_* constants to User::PAGE_FLAGS_*
2019-01-21 10:55:37 -05:00
da7706ce61
Remove unused code in include/
...
- Remove unused variables
2019-01-21 10:53:33 -05:00
c5cb976b62
Update PHPDoc in include/
2019-01-21 10:44:46 -05:00
d1c6ec9718
Update namespaces declaration in include/
...
- Remove unused use statements
- Add required use statements
2019-01-21 10:44:45 -05:00
070aa016e0
Update more PHPDoc, including in include/
2019-01-21 10:39:28 -05:00
cbda92f253
Add "on their post" label to notifications
...
- Align tag notifications on comment notifications
2019-01-21 10:12:52 -05:00
2e602afd3e
Add Monolog
2019-01-21 10:10:40 -05:00
2f49c4a058
Revert "Add monolog"
2019-01-21 10:08:09 -05:00
5ee72b681b
removed unused get_app()
2019-01-21 10:00:46 -05:00
6e48df2163
Refactor Loglevels
2019-01-21 10:00:46 -05:00
81cb6bec30
define api log prefix
2019-01-21 09:59:10 -05:00
ff162dfef2
Replacing log usage
2019-01-21 09:59:09 -05:00
fe8f0e0045
Add Monolog
2019-01-21 09:58:05 -05:00
55e54bb950
Replace deprecated Addon::callHooks with Hook::callAll
...
- Update documentation
2019-01-21 09:50:56 -05:00
895b3abf32
Remove/replace killme() with *exit()
2019-01-21 09:49:17 -05:00
root
dbd2e4cdf3
follow code standard
2019-01-21 09:13:10 -05:00
root
06ccba1c28
code style & use DBA::p
2019-01-21 09:13:09 -05:00
root
61afd5b3fb
refs #6292
...
APIs show number of comments
- /api/statuses/*_timeline
- /api/search
- /api/favorites
/api/search enhacement
- support exclude_replies parameter
2019-01-21 09:13:09 -05:00
root
6c2ace3cab
update hashtag regular expression
2019-01-21 09:12:35 -05:00
root
8de263df8b
#6275 - q support hashtag search
2019-01-21 09:12:35 -05:00
root
939364f9a0
API - /search #6274
...
- fixed: search result always return empty
- add hashtag search: friendica_tag params
- ApiTest & api.md updated
2019-01-21 09:12:35 -05:00
root
b43dd28b7a
closes #6272
2019-01-21 09:12:33 -05:00
root
d331e4e6e3
API - /media/upload - add return value #6272
...
image.preview: string (url for small image)
2019-01-21 09:12:33 -05:00
fabrixxm
55292c954b
Remove resourceid parameter from Photo::exists()
2019-01-21 09:12:29 -05:00
fabrixxm
e7fbe04b11
Fix parse error
2019-01-21 09:12:29 -05:00
fabrixxm
8c75c26361
Use Model\Photo as much as possible
...
Most important is to use `Photo::delete()` to have backend
to remove data.
2019-01-21 09:12:28 -05:00
ea1946ec03
Use preg_quote instead of str_replace in include/items
2019-01-03 21:27:47 -05:00
5e1ceb57de
Escape global namespaced get_app() calls
...
- Add deprecated status
2019-01-03 21:27:36 -05:00
Michael Vogel
94eca77041
Merge pull request #6315 from MrPetovan/bug/6309-add-fulltext-index-profile
...
Rework mod/match and mod/msearch
2018-12-27 18:04:06 +01:00
c5867df24c
Remove useless intermediate network_name variable in include/api
2018-12-26 11:02:28 -05:00
bb0d7a5c51
Don't show "follow" activity
2018-12-25 19:50:40 +00:00
acaee626f5
Remove include/ requires that are now done directly from Composer
2018-12-24 09:56:25 -05:00
1f432d006b
API: Fix author of repeated items from Diaspora
2018-12-21 22:55:36 +00:00
38109665c7
Various improvements/fixes
...
- Fix potential missing variable
- Improve replaceMacros doc
- Fix CSS value in smoothly
2018-12-16 22:38:30 -05:00
f6c3974c8f
Issue 6257: Make notes visible again
2018-12-13 20:09:19 +00:00
f2e2066d33
Non public content is now displayed again to visitors.
2018-12-09 13:09:49 +00:00
9c534546e4
Fix condition in api_fr_photo_create_update
2018-11-30 10:48:47 -05:00
458981f75c
Replace x() by isset(), !empty() or defaults()
...
- Remove extraneous parentheses around empty() calls
- Remove duplicate calls to intval(), count() or strlen() after empty()
- Replace ternary operators outputting binary value with empty() return value
- Rewrite defaults() without x()
2018-11-30 09:06:22 -05:00
c77926be03
Merge pull request #6206 from annando/parent
...
Missing '
2018-11-26 11:43:16 +01:00
563a24e30b
Missing '
2018-11-26 08:52:40 +00:00
b9efe5a532
Show contact posts from hidden users
2018-11-25 18:50:41 +00:00
Michael Vogel
42a3610a79
Merge pull request #6184 from MrPetovan/task/normalize-bbcode-hashtags
...
Normalize BBCode hashtags links
2018-11-24 13:14:50 +01:00
c23d1b2776
Urlencode /network file parameter
2018-11-23 10:02:30 -05:00
4874f7f8ab
Remove useless rawurlencode calls for building hashtag bbcode
...
- Fix some formatting
2018-11-22 09:32:41 -05:00
43079bfaf8
Several default features are now in the core
2018-11-18 20:13:46 +00:00
Jonny Tischbein
a36a780b99
Add fallback if comment as no parent
2018-11-18 12:46:21 +01:00
Jonny Tischbein
5d464c353f
Delete comment from its guid and return to parent guid
2018-11-18 12:43:26 +01:00
Jonny Tischbein
cf9c3444bc
Fix return url when delete comment from display
2018-11-17 13:56:58 +01:00
a5ddaa9dbc
Issue 6128: Websub could work now
2018-11-13 22:23:16 +00:00
34a0e71485
API: The wrong user had been shown for repeated posts
2018-11-11 19:05:57 +00:00
Adam Magness
218f0734be
Rename removeTags to escapeTags
...
rename function and update calls.
2018-11-09 13:29:42 -05:00
Adam Magness
ffc406d819
normalise_link calls
...
implement normaliseLink function
2018-11-08 11:28:29 -05:00
Adam Magness
46d7767fd0
formatBytes calls
...
implement function in new class
2018-11-08 10:28:49 -05:00
Adam Magness
a0f65ca7a1
notags calls
...
implement removeTags function
2018-11-08 10:14:37 -05:00
Adam Magness
991f259ecb
random_string calls
...
implement getRandomHex function
2018-11-08 08:45:46 -05:00
Adam Magness
fd597472f1
Split text.php to Strings class
...
move functions to new strings class
Split text.php to Strings class
move functions to new Strings class
2018-11-08 08:33:28 -05:00
Adam Magness
7cb9138201
Move another function
...
move get_plink to Item class, and also fix up getApp since we extend BaseObject
2018-11-07 07:19:39 -05:00
Adam Magness
e537f7d017
Function calls
...
update function calls to new class
2018-11-06 21:16:27 -05:00
Adam Magness
d50a1edef4
Split text to Item
...
move functions from text.php to Item class
2018-11-06 21:12:41 -05:00
Jonny Tischbein
509dc29b2d
Fix return url when dropping post loaded by update_* in non-frio
2018-11-06 21:37:10 +01:00
Adam Magness
352da9bcf3
Update function calls
...
update function calls for moved functions
2018-11-06 09:52:58 -05:00
Adam Magness
1d571a527b
Split text.php to L10n
...
move functions from text.php to L10n class
2018-11-06 09:52:58 -05:00
Adam Magness
4f07ebb52f
Rename properly
...
rename function properly this time!
2018-11-06 06:34:32 -05:00
Adam Magness
3eecd108c5
rename function
...
rename function and update calls.
2018-11-06 06:31:48 -05:00
Adam Magness
9264059945
Missing Include
...
missed use statement
2018-11-05 21:15:47 -05:00
Adam Magness
a71eb1d127
functions moved to HTML class
...
update function calls to moved class.
2018-11-05 21:06:26 -05:00
Adam Magness
e31dde6084
Split text.php to HTML class
...
move functions from text.php to src/Content/Text/HTML
2018-11-05 20:27:22 -05:00
6e10bdf361
Move random Digits to Crypto class
2018-11-05 21:02:54 +01:00
Adam Magness
9e51be7554
Revert "Update function calls"
...
This reverts commit 748fb8b946
2018-11-05 13:07:07 -05:00
Adam Magness
748fb8b946
Update function calls
...
update function calls to new class
2018-11-05 07:40:18 -05:00
Adam Magness
b07d47b0f7
Update function calls
...
update function calls to new names
2018-11-05 07:24:14 -05:00
Adam Magness
61bc9facc8
Implement functions
...
implement functions relocated to xml class
2018-11-05 07:24:14 -05:00
Adam Magness
84e900d96f
Move to XML
...
move functions from text to xml
2018-11-05 07:24:14 -05:00
Jonny Tischbein
645f9387fa
make return url optional
2018-10-31 20:09:44 +01:00
Jonny Tischbein
b66bcb20da
Redirect to previous page after NON-AJAX Post delete via second parameter in /item/drop
2018-10-31 20:09:44 +01:00
Adam Magness
93ccd7bcdb
Remove old functions
...
remove old functions from file.
2018-10-31 11:02:30 -04:00
Adam Magness
35abc4bb64
get markup template
...
implement getMarkupTemplate function
2018-10-31 10:44:06 -04:00
Adam Magness
91facd2d0a
replace macros
...
implement new replaceMacros function
2018-10-31 10:35:50 -04:00
Adam Magness
f6c86649c2
Create Core\Renderer Class
...
create new class and redirect old functions
2018-10-31 10:03:42 -04:00
Adam Magness
3a604029eb
Create FileTag class
...
create class and move functions
2018-10-30 14:51:21 -04:00
Adam Magness
50da89d861
Logger Levels
...
update logger levels in calls
2018-10-30 09:58:45 -04:00
Adam Magness
80367d05d8
Remove functions
...
remove functions that were moved to Logger class
2018-10-30 09:57:14 -04:00
Adam Magness
14fde5dc9b
Log function
...
implement log() function.
2018-10-30 09:57:14 -04:00
Adam Magness
d6d593d724
Create Logger class
...
Create Core\Logger class and point old functions to the new ones.
2018-10-30 09:57:14 -04:00
14237a9599
Move $pager and $page_offset out of App
...
- Move infinite scroll data output in a module hook
- Use Pager instead of paginate() and alt_pager()
2018-10-25 00:07:15 -04:00
9c9ebfc7c9
Merge pull request #6013 from JonnyTischbein/issue_comment_media_link_prompt
...
[frio] Add media / link prompt in comments
2018-10-24 12:17:58 -04:00
Jonny Tischbein
d2b5f77be9
Add multimedia link for jot + enables hover text in jot + autosize in when paste link + renaming / Code Standards
2018-10-24 16:20:10 +02:00
cb75c40f4e
adapted profile pic resize to 300px for whole system
2018-10-23 16:36:57 +02:00
32af52842b
adding defaults in mod/redir.php
2018-10-22 22:13:41 +02:00
3edad1591e
replaced $return_url to $return_path to make it more clear that it is a relative path to the Friendica baseurl
2018-10-22 22:13:37 +02:00
d00ddc01af
Split goaway to System::externalRedirectTo() and App->internalRedirect()
2018-10-22 22:13:35 +02:00
2ef81108b3
Renamed System::redirect() to $a->redirect()
2018-10-22 22:13:22 +02:00
1cd72e7694
API: The source field does now reliably return the correct network name of the author
2018-10-22 14:15:14 +00:00
8e11f055b1
Improve PR 5984: better check for remote users as well
2018-10-21 21:56:46 +00:00
9b387a226c
Fix webmentions and microformats ("redir" only for logged in users)
2018-10-21 20:23:08 +00:00
a8d3a4d218
Add missing L10n::popLang calls
2018-10-20 09:02:10 -04:00
ec0d3a6eac
Merge pull request #5946 from JonnyTischbein/move_include_security
...
Move and Split include/security
2018-10-19 08:55:08 -04:00
Jonny Tischbein
f3fc1f36ca
Renaming functions + moving functions from security to Model/Item and BaseModule + fix multiline comments
2018-10-17 21:30:41 +02:00
Michael Vogel
389685e099
Merge pull request #5920 from MrPetovan/bug/remove-password-from-register
...
Avoid storing plaintext password in register table
2018-10-17 21:04:11 +02:00
Jonny Tischbein
ce2b1f5715
Rename function Authentication::authenticate_success to Authentication::success
2018-10-17 18:45:32 +02:00
Jonny Tischbein
05be2db725
Move include/security tp /src/Core/Authentication and /src/Util/Security
2018-10-17 14:19:58 +02:00
Adam Magness
370ee08fcc
Remaining contacts to contact
...
Update occurrences of contacts/ to contact/
2018-10-17 07:49:27 -04:00
481b0ac138
Fix notices in include/enotify
2018-10-15 23:13:00 -04:00
f2bde919e5
Fix ignored show_in_notification_page parameter in notification()
2018-10-14 11:30:39 -04:00
Jonny Tischbein
bfa05156ca
change links from /contacts to /contact
2018-10-13 13:29:56 +02:00
7c73e8634c
Curl Response Refactoring
...
- refactored Network::post()
- replaced every Network::post() execution with the new Curl container
2018-10-10 21:15:26 +02:00
5a02e39a65
Rename App Methods
...
- renamed a lot of App methods to CamelCase
- replaced direct public variables with get-/set-Methods
2018-10-10 00:16:06 +02:00
Jonny Tischbein
29033bdf05
goaway to network if deleted item + remove goaway for filerm
2018-10-09 20:44:30 +02:00
Jonny Tischbein
d18421f760
Return to item if not owned by user or canceld
2018-10-09 20:40:25 +02:00
Jonny Tischbein
d8780b1640
Replace goaway location SESSION var return_url with page as string value
2018-10-09 20:10:34 +02:00
9fbaaa1481
We now can show "Friendica (AP)" as network name
2018-10-05 19:26:20 +00:00
3ab837f3c7
Functionality is now split
2018-10-03 09:15:38 +00:00
505350c9fb
Merge pull request #5794 from annando/ap1
...
ActivityPub support
2018-10-02 11:24:04 -04:00
54c7ca58d8
Repeated posts from OStatus, ActitivyPub and Twitter are now shown as is
2018-10-02 03:41:38 +00:00
b746ddec64
Issue 5797: Retweets are now displayed again via API
2018-10-01 18:16:19 +00:00
e3a4a9c407
Issue 5798: We had displayed the author as owner
2018-10-01 17:36:23 +00:00
Michael Vogel
103535d620
Merge pull request #5773 from MrPetovan/task/rewrite-js-hooks
...
Rewrite JS hooks
2018-10-01 17:10:30 +00:00
3dfb0c2e7c
Merge pull request #5762 from JonnyTischbein/2018.08-rc
...
Add api_friendships_destroy() like mod/unfollow.php
2018-10-01 12:51:46 -04:00
cb9be8a7ab
UUID is now createUUID
2018-09-27 11:52:15 +00:00
60b0759b50
UUID instead of GUID
2018-09-26 20:03:46 +00:00
c083ae047c
Merge remote-tracking branch 'upstream/2018.08-rc' into ap1
2018-09-22 15:18:53 +00:00
c6268ca0b7
Issue 5760: Avoid a non numeric value for "tt"
2018-09-22 14:17:14 +00:00
Hypolite Petovan
1eaa523e61
Remove unused App->page['end']
...
- Remove unused empty templates
2018-09-20 21:02:28 -04:00
Jonny Tischbein
9821f173a4
fix response
2018-09-16 19:36:25 +02:00
Hypolite Petovan
ba4f368b45
Remove references to pear/Text_Highlighter
2018-09-16 09:05:00 -04:00
Jonny Tischbein
a0942963c9
api_friendships_detroy uid - api_user instead of local_uer, empty check for
2018-09-15 11:06:55 +02:00
Jonny Tischbein
b7e15e8b38
api_friendships_destroy finally function header + NotFoundException typo
2018-09-14 19:35:24 +02:00
61e2c7d20d
Added AP to many network conditions / enabling inbox processing
2018-09-14 16:51:32 +00:00
Jonny Tischbein
2c3a58d44e
api_friendhips_destroy function header
2018-09-14 10:06:26 +02:00
Jonny Tischbein
3eb539aefd
api_friendships_destroy idents, DBA::selectFirst, Excepions and LogMessages
2018-09-14 09:28:14 +02:00
root
a89f9cf7d5
api_friendships_destroy cleanup
2018-09-13 23:32:26 +02:00
root
3f85fee7e3
Add api_friendships_destroy() like mod/unfollow.php
2018-09-13 23:23:53 +02:00
d5a3b0bd5e
Merge pull request #5710 from annando/fix-api
...
Fix for timeout issues when posting to the API
2018-09-02 14:52:09 +02:00
703c668a37
More notices ...
2018-09-02 08:01:13 +00:00
394526db74
Typo corrected / use the thread table instead
2018-09-02 07:35:12 +00:00
4bb45f611f
Fix for timeout issues when posting to the API
2018-09-02 07:20:04 +00:00
38fd21019b
Invalid pictures could lead to notices, this is removed now
2018-08-31 07:48:44 +00:00
Michael Vogel
601851f3d0
Removed notice - pokes do now work mostly ( #5693 )
2018-08-29 09:00:01 -04:00
Michael Vogel
99b8f85624
Poke is fixed ( #5689 )
...
* Fix: Poke hasn't worked. It does work now partially
* Poke are now displayed good again
* removed code
2018-08-28 15:38:28 -04:00
Michael Vogel
edcd0a3744
Issue 4960: Ignoring and blocking of contacts should work again ( #5657 )
...
* Issue 4960: Ignoring and blocking of contacts should work again
* Renamed functions
* This function should be renamed as well.
* We now have a frontend to block and ignore public contacts
* Hide some parts for public contacts
* Removed notices, public contact is now accessible from dirfind as well
* We now show contact conversations and contact posts
* We now use a new conversation mode
* The update functionality is disabled until it will work completely
* Fixing tabs chaos
* Update after posts on the contacts page will now work
* Show connect link
2018-08-25 09:48:00 -04:00
82d097879b
Oh no ... there are still some notices that want to be removed ...
2018-08-24 11:09:58 +00:00
fabrixxm
93ba393559
API: add private value (bool) to item results ( #5647 )
...
* API: add private value (bool) to item results
friendica:private for xml
friendica_privarte for json
* API Docs: add a section about custom value returned in status data
2018-08-23 10:09:50 -04:00
Michael Vogel
dc3d2d5988
"dba" is now "DBA". This hadn't been respected at some places ( #5655 )
...
* "dba" is now "DBA". This hadn't been respected at some places
* Cleaning up unneeded stuff
2018-08-23 09:51:58 -04:00
Michael Vogel
d29cb1acaf
Fix: Mail notifications arrive again ( #5654 )
...
* Fix: Mail notifications arrive again
* Ensure that user data is always there
2018-08-23 10:00:25 +02:00
578549df13
Merge pull request #5646 from annando/notes
...
The notes are now fetching their content from a central function
2018-08-21 17:36:15 +02:00
Michael Vogel
54aee2aaa7
Removed notices that revealed themselfes over night ... ( #5645 )
...
* Removed notices that revealed themselfes over night ...
* And more notices removed that occured over night
* One more ..
* Some more notices of the day ...
2018-08-21 17:35:09 +02:00
1fb5925073
The notes are now fetching their content from a central function
2018-08-21 07:35:22 +00:00
Michael Vogel
d9b44153da
The content generation for the display page is now using a centralized function ( #5642 )
...
* The content generation for the display page is now using a centralized function
* Small correction to avoid notices
2018-08-20 16:32:55 -04:00
Michael Vogel
16a081871c
Improved profile page, improved "limit" handling ( #5639 )
...
* Improved profile page, improved "limit" handling
* Update will now work again
* Update will work now
2018-08-20 06:26:05 +02:00
Michael Vogel
c1da44b7dc
We now use a central function to fetch the importer ( #5636 )
2018-08-19 13:37:56 +00:00
Michael Vogel
7f3fb34c24
Some easy to replace "q" calls have been replaced by "DBA" calls ( #5632 )
...
* Some easy to replace "q" calls have been replaced by "DBA" calls
* Simplified the GUID creation
* And one in the API ...
* And OStatus has got some DBA calls more
* Just some more replaced database calls
* The event query is now simplified
* Events are now shown again
* subthread is now using the DBA calls as well
* Some more replaced database calls
* And some more replaced database calls and prevented notices
* Better use gravity
* Some more replaced database stuff
* Some more replaced database calls in DFRN.php
* The gcontact class now has got the new DBA functions as well
* The Contact class is now changed to new database functions as well
* Small correction
* We can now delete without cascade
* One more functionality is safe for future changes
2018-08-19 12:46:10 +00:00
Michael Vogel
dfe4413463
Avoid blocks with invalid entries in superblock ( #5635 )
2018-08-19 12:14:12 +02:00
d5c2c41b02
Merge pull request #5626 from annando/notices-oh-yeah
...
Removed notices, will it ever end?
2018-08-17 09:33:02 +02:00
0342f9e084
Removed notices, will it ever end?
2018-08-17 03:19:42 +00:00
fabrixxm
66b4730a70
api: fix friendica/notification/seen api call
...
Fix return item related to notification when notification is set as seen
2018-08-16 11:46:53 +02:00
56443b53cb
Fix: We now are notified again when a new post had been created
2018-08-12 04:34:56 +00:00
Roland Häder
e06fc2aa69
Stopped using deprecated constants NETWORK_* ( #5537 )
...
* Rewrite:
- stopped using deprecated NETWORK_* constants, now Protocol::* should be used
- still left them intact for slow/lazy developers ...
* Removed deprecated NETWORK_* constants as per code reviewer's request.
2018-08-11 22:40:44 +02:00
a8016e4187
Issue 4507: Superblock does now work on comments as well
2018-08-10 04:27:52 +00:00
Michael Vogel
276abfaba6
Issue 5158: Ignore all threads, even public ones ( #5588 )
...
* Issue 5158: Ignore all threads, even public ones
* Remove some notice
* Now it really should work
* Using "defaults"
2018-08-08 22:32:11 +02:00
Michael Vogel
c72c64a6d8
Notices again ( #5543 )
...
* And again notices
* Notices in the directory
* Much more places
* Fix some double $
* Notice in ping
* Missing field
* Fix: We now remove deleted users from the directory
* Some more stuff
* Notices when removing users
* Added logging
* More logging
* Two more
2018-08-02 07:21:01 +02:00
Michael Vogel
9d0f18c0b3
Yeah, and again notices ... ( #5536 )
...
* Yeah, and again notices ...
* And some more
* Block access without given user name
* Reformatting
2018-08-01 07:29:58 +02:00
Michael Vogel
71b1638d9a
Once again, notices ... ( #5535 )
2018-07-31 18:39:23 +02:00
Roland Häder
2c0ad47dfc
Fixed fatal error: ( #5532 )
...
* Fixed fatal error:
````
PHP Fatal error: Uncaught TypeError: Argument 1 passed to add_page_info_data()
must be of the type array, boolean given, called in
/var/www/../include/items.php on line 153 and defined in
/var/www/../include/items.php:27
````
Fix for type-hint array when query_page_info() returned a non-array, this may
happen when the instance/node/pod owner decided to shutdown server and replace
all URLs with a replacement message.
* Fixed parser error, ops.
2018-07-30 22:24:32 -04:00
Roland Häder
4d39164c1e
[WIP] Rewrite to Proxy class: ( #5507 )
...
* Rewrite to Proxy class:
- introduced new Friendica\Network\Proxy class for in exchange of proxy_*()
functions
- moved also all PROXY_* constants there as Proxy::*
- removed now no longer needed mod/proxy.php loading as composer's auto-load
will do this for us
- renamed those proxy_*() functions to better names:
+ proxy_init() -> Proxy::init() (public)
+ proxy_url() -> Proxy::proxifyUrl() (public)
+ proxy_parse_html() -> Proxy::proxifyHtml() (public)
+ proxy_is_local_image() -> Proxy::isLocalImage() (private)
+ proxy_parse_query() -> Proxy::parseQuery() (private)
+ proxy_img_cb() -> Proxy::replaceUrl() (private)
* Ops, need to set $a here ...
* CR request:
- moved Proxy class to Friendica\Module
- extended BaseModule
* Ops, no need for own instance of $a when self::getApp() is around.
* Proxy-rewrite:
- proxy_url() and proxy_parse_html() are both non-module functions (now
methods)
- so they must be splitted into a seperate class
- also the SIZE_* and DEFAULT_TIME constants are both not relevant to module
* No instances from utility classes
* Fixed error:
- proxify*() is now located in `Friendica\Util\ProxyUtils`
* Moved back to original place, ops? How did they move here? Well, it was not
intended by me.
* Removed duplicate (left-over from split) constants and static array. Thank to
MrPetovan finding it.
* Renamed ProxyUtils -> Proxy and aliased it back to ProxyUtils.
2018-07-30 22:06:22 -04:00
Roland Häder
3da1b9f319
Cleaned up include/items.php ( #5523 )
...
* Cleaned up include/items.php
- added type-hint for array where suitable
- moved opening curly brace to new line after function
- used BaseObject::getApp() instead of get_app()
- used empty() instead of is_array(), maybe avoids E_NOTICE
* Changed 'AS' to 'as', keywords in PHP are all lower-case.
2018-07-30 21:02:34 -04:00
Roland Häder
4a22710b3b
Moved global PAGE_* to Profile class ( #5500 )
...
* Rewrites:
- moved PAGE_* to Friendica\Model\Profile class
* Fixed more rewrites from plain (global namespace) PAGE_* to Friendica\Models\Profile class
* CR request:
- moved all PAGE_* constants to Friendica\Model\Contact class
- fixed all references of both classes
* CR request:
- moved ACCOUNT_TYPE_* constants from boot.php to Contact::ACCOUNT_TYPE_*
* Just copy-pasted this code from boot.php, needs to be changed to `const ACCOUNT_TYPE_FOO = x;`
* Ops, melting brain cells here ... :-/
2018-07-27 19:25:57 -04:00
Michael Vogel
986106a8f7
Item storage: Permissions aren't stored in the items anymore ( #5495 )
...
* The permission set is now used for item permissions
* Check for allow_cid, ... is superfluous. Checking for "private" is enough
* We query the permissionset
* Permissions are displayed correctly
* Changed index
* We don't store the permissions in the item table anymore
* Permission fields are now deprecated
* Reversed ...
2018-07-25 19:14:55 -04:00
Roland Häder
37253656e3
Moved CONTACT_* constants to Friendica\Model\Contact class, lesser in global namespace ( #5490 )
...
* Rewrite:
- moved all CONTACT_* constants from boot.php to Contact class
* CR request:
- renamed Contact::CONTACT_IS_* -> Contact::* ;-)
2018-07-24 22:53:46 -04:00
Hypolite Petovan
6141023640
Remove dbesc() and dba_timer() function declarations
2018-07-23 15:30:54 -04:00
Hypolite Petovan
a6fb3568f9
Rename dbesc to DBA::escape
2018-07-23 15:30:54 -04:00
Hypolite Petovan
ecea7425f8
Rename DBA::is_result to DBA::isResult
2018-07-23 11:04:14 -04:00
Hypolite Petovan
0ec44f3e8a
Rename DBM method calls to DBA method calls
2018-07-23 11:02:24 -04:00
Hypolite Petovan
4db98eb43d
Rename DBA::inArray to DBA::toArray
2018-07-22 19:27:35 -04:00
Hypolite Petovan
abbaaf5aa5
Rename DBA::clean_query to DBA::cleanQuery
2018-07-22 19:27:34 -04:00
Hypolite Petovan
910e832dc2
Rename DBA::any_value_fallback to DBA::anyValueFallback
2018-07-22 19:27:34 -04:00
Roland Häder
c17adaf333
Uncommon logger levels in Friendica ( #5453 )
...
* "normal" is an uncommon logger level:
- changed LOGGER_NORMAL -> LOGGER_INFO
- added LOGGER_WARNING (a common logger level)
* Used constants instead of values (MrPetovan)
2018-07-22 14:07:44 -04:00
Hypolite Petovan
af6dbc654f
Rename Friendica\Database\dba to Friendica\Database\DBA
2018-07-20 08:19:26 -04:00
Hypolite Petovan
72f32f90d1
Remove class \dba from include/dba
2018-07-19 22:15:57 -04:00
Hypolite Petovan
daa1177e3a
Update use statement lists with new Friendica\Database\dba class
...
- Remove unused use statement
- Remove superfluous use statements (classes in the same namespace)
- Add missing use statements
2018-07-19 22:15:21 -04:00
Michael Vogel
ece4d3f4fb
Issue 5407: Workers didn't start anymore ( #5409 )
2018-07-19 11:05:17 -04:00
Michael Vogel
5af9596dde
New item field "Post-type" and new table "permissionset" ( #5408 )
...
* "post-type" replaces "bookmark" and "type"
* Removed some more type
* Added index to permission set
* The permission set is now stored
* The permission set is now removed upon expiry
* Post update now stores the permission set
* New file
* Permissions are now sorted
* Changed documentation
2018-07-19 09:52:05 -04:00
Roland Häder
0b38f1c58b
Fixes applied: ( #5399 )
...
- $_SESSION['remember_user'] did only exist here and no where else
- it seems to be accient old-lost code, so I fixed it to $a->user['nickname']
instead
- used multi-line comment for multiple lines of on-line comments
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-07-19 07:11:03 -04:00
Hypolite Petovan
67dc08d120
Enforce systen.register_policy value type
2018-07-16 19:38:19 -04:00
Hypolite Petovan
c207f6d597
Remove remaining references to Config::get in include/dba
2018-07-16 19:38:18 -04:00
Hypolite Petovan
820afa2284
Replace global $a with BaseObject::getApp()
2018-07-16 19:38:17 -04:00
Hypolite Petovan
adacf421a6
Remove deprecated functions in include/text
2018-07-16 19:38:17 -04:00
Hypolite Petovan
5906c7e013
Remove api test pconfig debug
2018-07-16 19:38:17 -04:00
Hypolite Petovan
224765cdf5
Wrong table name
2018-07-16 19:38:16 -04:00
Hypolite Petovan
f8a90f3425
Add more api test debug
2018-07-16 19:38:16 -04:00
Hypolite Petovan
de0afd3b32
Add api test debug
2018-07-16 19:38:16 -04:00
Hypolite Petovan
9396b05659
Revert using Config class in dba
2018-07-16 19:38:16 -04:00
Hypolite Petovan
9be9741562
Fix uses in include/dba
2018-07-16 19:38:16 -04:00
Hypolite Petovan
762a786611
Replace direct accesses to App->config by Config::get/set calls
2018-07-16 19:38:16 -04:00
Hypolite Petovan
cd9b864045
Rework App modes
...
- Replace App mode constants with capability-based flags
- Add App->isInstallMode()
- Add file config fallback in (P)Config abstraction
- Removed logger disabling code
2018-07-16 19:38:15 -04:00
Hypolite Petovan
7d8c45dde8
Remove dependency to App in dba::connect
...
- Remove timing (can be done centrally)
- Add charset parameter to dba::connect and dba::reconnect
2018-07-16 19:38:13 -04:00
0e8fa34156
Fix for displaying public items
2018-07-16 04:00:57 +00:00
Hypolite Petovan
a6eae9adec
Add new put_item_in_cache hook in include/text
2018-07-15 08:03:12 -04:00
Roland Häder
6b5d90333f
Fixes for some E_NOTICE and type-hints added ( #5358 )
...
* Fixed http://github to https://github
Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixes for #4965 :
- updated messages.po file
Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixed E_NOTICE where isset()/empty() was absent.
Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixed missing variable $sql_order causing E_NOTICE.
Signed-off-by: Roland Häder <roland@mxchange.org>
* Continued:
- added array type-hint where known (some)
Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixes:
- in Profile::load() $user is now only one-dimensional
- $a->get_hostname is no property, it is a method
Signed-off-by: Roland Häder <roland@mxchange.org>
* reverted changes that are unintended
Signed-off-by: Roland Häder <roland@mxchange.org>
* Continued:
- removed leading \ (uncommon, okay)
- removed entire if() block (CR by Hypolite)
Signed-off-by: Roland Häder <roland@mxchange.org>
* Removed if() block
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-07-13 15:47:14 -04:00
Michael Vogel
0360f7197a
Several more warnings ... ( #5340 )
...
* Some more warnings removed
* Even more warnings ...
* Will it ever end? ;-)
* Avoid warning in dbstructure
* Origin and OStatus ...
* There are more warnings solved ... yeah!
* And again ...
* We are not done yet
* And more ...
* And some new places ...
* And more in the feeds
* Avoid some more
* And some backend stuff
* Notifications cleared
* Some more stuff
* and again ...
* It's getting fewer ...
* Some warnings had been hidden in the notifications
* Fix the fix
* And another missing one ...
* We need the owner here, not the user
* Forgotten user
* And more ...
* And some more warnings disappeared ...
* Some more frontend warnings
* Some backend warnings removed
* Fixed sidebar for "vier"
* And more ...
* Some more ...
* And something for "remote self"
* Am I stuck in an endless loop?
* Fix: Clear tag and file field on update
* Preset page content
2018-07-10 08:27:56 -04:00
c829e43725
moved get_guid to System::createGUID
2018-07-09 21:38:16 +02:00
675a6adf35
Added comment
2018-07-08 13:52:11 +00:00
8a2230bc4c
Avoid warnings in addons
2018-07-08 12:01:36 +00:00
3e797547a3
Warnings fixed
2018-07-08 09:37:05 +00:00
69db696ab1
Improve test behaviour
2018-07-08 05:29:06 +00:00
Michael Vogel
ff5ee74ecf
Merge branch 'develop' into item-activities
2018-07-08 06:35:50 +02:00
4d35e228c4
More item abstraction / making remote deletion work again
2018-07-07 18:14:16 +00:00
1ffe0cfd81
Added Lock Unittests & Bugfixings
...
Added Redis Lock Unittests
Added Memcached Lock Unittests
Fixed a bug in dba
Fixed a bug in RedisLock
2018-07-07 16:15:03 +02:00
Hypolite Petovan
e44111e935
Revert renaming lang to language in api
...
- Normalize some quotes
- Put "Empty user-agent" log message in a else statement
2018-07-04 17:33:09 -04:00
Hypolite Petovan
43688c04b1
Add NotFoundException for recipients in api_direct_messages_new()
2018-07-02 07:48:59 -04:00
Hypolite Petovan
cb7176ee70
Fix Config use in api_statusnet_config()
2018-07-02 07:48:53 -04:00
Hypolite Petovan
757fd357f6
Fix yet more undefined variable/index notice in api
2018-07-02 07:48:48 -04:00
Hypolite Petovan
dde61a77a4
Fix root element containing only text in api_create_xml()
2018-07-02 07:48:42 -04:00
Hypolite Petovan
62eba48679
Fix yet more undefined variable/index messages in api_statuses_show
2018-07-02 07:48:38 -04:00
Hypolite Petovan
0ee153e1bd
Fix Array to String conversion message for IN conditions
2018-07-02 07:47:47 -04:00
Hypolite Petovan
a380bcd1c1
Fix more undefined variable/index notice in tests
2018-07-02 07:45:25 -04:00
Hypolite Petovan
a329ce5b50
Fix $called_api expecting at least 2 elements in tests
2018-07-02 07:45:11 -04:00
Hypolite Petovan
6776c4e3f9
Fix some undefined variable/index notices in tests
2018-07-02 07:44:55 -04:00
717ca0b7eb
Use already fetched data for magiclink
2018-07-02 05:41:55 +00:00
0ab9f2e265
Preparations to not store the tags in the item table anymore
2018-06-30 13:54:01 +00:00
028c9f4da5
We now store the verb in the item-content as well
2018-06-27 19:37:13 +00:00
76dab3b2d7
Use gravity instead of verb
2018-06-27 18:09:33 +00:00
b03db4643f
The fetch function now centrally controls the content
2018-06-24 10:48:29 +00:00
Hypolite Petovan
98a5749b45
Merge pull request #5277 from annando/native-pdo
...
We now are using the native pdo mode
2018-06-22 16:04:50 -04:00
6e64091fc7
We now are using the native pdo mode
2018-06-22 19:35:42 +00:00
miqrogroove
c37a8cc661
Update dba.php
2018-06-22 07:34:27 -04:00
miqrogroove
150989ba99
Ensure IN() Conditions Never Mix Data Types
2018-06-21 23:56:19 -04:00
Hypolite Petovan
47ab72352e
Merge pull request #5269 from annando/non-unique-values
...
This fixes the problem with mixed variables in queries
2018-06-21 22:12:07 -04:00
e1e28ba7c3
Better float detection
2018-06-21 21:55:43 +00:00
miqrogroove
c600ccad5c
Correct dba::close() To Match dba::p()
2018-06-21 17:27:12 -04:00
1b85b75563
Currently removed, needs more testing
2018-06-21 20:42:58 +00:00
261d7435c0
Check for floats and enable native prepares
2018-06-21 20:33:27 +00:00
5656c0564a
We don't need to look $is_int there
2018-06-21 19:52:28 +00:00
c1059875bc
This fixes the problem with mixed variables in queries
2018-06-21 19:48:25 +00:00
Michael Vogel
4b0cf8d60f
Merge pull request #5267 from miqrogroove/patch-2
...
Allow for Integer Literals in PDO Database Driver
2018-06-21 18:51:01 +02:00
miqrogroove
759dfe6bb1
Allow for Integer Literals in PDO Database Driver
...
This should fix things like "LIMIT ?"
2018-06-21 11:42:43 -04:00
d643e00d33
Standards and a new function to fetch content
2018-06-21 15:14:01 +00:00
70af2cecf2
Some of the last direct SQL calls to the item table had been changed
2018-06-21 06:21:51 +00:00
1567eb0791
fixed another left-over ...
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-06-20 22:02:16 +02:00
852ef4021b
more spaces + some curly spaces added
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-06-20 22:02:16 +02:00
f2f12d6f50
Minor improvements:
...
- added spaces and curly braces
- added more TODOs as there really more to be done
- removed redundant braces from "return" keyword (no function)
- merged 2 nested if() into one single
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-06-20 22:02:15 +02:00
962fbc9166
Many "fetch_first" had been replaced
2018-06-19 21:33:07 +00:00
ab5669e091
Some more direct SQL calls had been replaced
2018-06-19 19:06:17 +00:00
Hypolite Petovan
82d55f120f
Merge pull request #5238 from annando/more-abstraction
...
Even more replaced item calls ...
2018-06-19 14:02:43 -04:00
e4adaa9900
Standards and variable renaming
2018-06-19 17:11:59 +00:00
rabuzarus
0a97a3f822
Bugfix: hide savedsearch butten and subthread button for non local_users
2018-06-19 18:27:54 +02:00
a5ca724fd3
Merge remote-tracking branch 'upstream/develop' into more-abstraction
2018-06-19 13:48:19 +00:00
4714cb746b
Use the item functions at many more places
2018-06-18 20:36:34 +00:00
Michael Vogel
f828350ba2
Merge pull request #5234 from fabrixxm/fix/api
...
API: fix sender/recipient of PMs
2018-06-18 12:03:53 +02:00
fabrixxm
e3ee9ee501
API: fix sender/recipient of PMs: check api_user before get user info.
...
To throw ForbiddenException and pass tests
2018-06-18 11:55:02 +02:00
507956818d
Use the item classes where possible
2018-06-18 05:19:28 +00:00
fabrixxm
c015bb1b77
API: fix sender/recipient of PMs
2018-06-17 19:57:32 +02:00
6e10de9284
New function to fetch item data especially for users
2018-06-17 17:05:17 +00:00
0280a46ab4
Use predefined field lists
2018-06-17 06:27:52 +00:00
abef0cd46c
Don't use the author-link anymore - just author-id
2018-06-16 15:35:30 +00:00
14cb128264
New function for generating item URI
2018-06-16 06:44:19 +00:00
bb79b8f4ac
More item calls have been replaced with the new functions
2018-06-15 22:30:49 +00:00
Hypolite Petovan
7469de29f1
Fix corrupt registration emails
...
- Use double quotes for line break-containing translation string
- Simplify HTML/plaintext email body conversion
2018-06-14 23:42:08 -04:00
Hypolite Petovan
d46cac7905
Wrap content filter around entire post including attachments
2018-06-12 21:54:36 -04:00
738644a006
Quit if database connection was lost during "e"
2018-06-11 03:56:19 +00:00
8584e09e12
Store the database credentials for reconnect
2018-06-11 03:45:45 +00:00
b02cdc8a7f
Merge remote-tracking branch 'upstream/develop' into quit-on-error
2018-06-11 03:15:59 +00:00
aa3f8ec09d
Force a database reconnection in the daemon to prevent lost connections
2018-06-10 22:04:09 +00:00
5d9083c369
Bugfix in notifications / network and display are using the new functions now
2018-06-10 07:26:37 +00:00
defd3d15b6
Possibly fixed test
2018-06-09 20:39:40 +00:00
b6c344a80a
$r was still in use
2018-06-09 20:08:15 +00:00
50dfc7d36e
Small query corrections
2018-06-09 19:27:44 +00:00
446a45003d
Added documentation, some indention fixes
2018-06-09 19:12:13 +00:00
baf316e898
The central item fetch does work now and the API now uses these functions
2018-06-09 16:56:37 +00:00
4874e589f1
New class function to fetch items
2018-06-07 06:03:12 +00:00
e632be763c
Corrected variable
2018-06-05 05:44:04 +00:00
18a77a1b45
Removed some quick and dirty hack to upload pictures
2018-06-05 05:42:26 +00:00
Hypolite Petovan
0a13ab6b9f
Merge pull request #5166 from annando/unsed-item-fields
...
Remove unused, unneeded or redundant item fields
2018-06-03 12:19:50 -04:00
Hypolite Petovan
973ece09c5
Merge pull request #5157 from annando/daemon
...
Workers can now be started exclusively from the daemon and other workers
2018-06-03 12:18:47 -04:00
443d828ba7
We don't need to look for the uid
2018-06-03 10:29:42 +00:00
6985ad4fb5
Improved error message
2018-06-03 09:55:41 +00:00
b654af28fa
We need "global"
2018-06-03 09:40:32 +00:00
ea498ff283
And a second SQL error fixed
2018-06-03 09:21:48 +00:00
d76fb6d0b9
Fixed SQL error
2018-06-03 09:19:27 +00:00
3f07d01dd1
Get rid of unneeded or redundant fields
2018-06-03 07:42:56 +00:00
a720c4f501
Removed unneeded fields from the API
2018-06-03 07:22:01 +00:00
723b5ae803
Use MagicLinkbyId when possible
2018-06-02 08:28:01 +00:00
8a34895a23
Use magicLink whenever possible
2018-06-02 08:05:06 +00:00
28f8beebfc
Workers can now be started exclusively from the daemon and other workers
2018-06-01 22:09:27 +00:00
b5b172500d
Merge remote-tracking branch 'upstream/develop' into public-redir
2018-06-01 12:32:51 +00:00
Hypolite Petovan
93daf7883e
Merge branch 'master' into develop
...
- Updated new develop version label
- Incremented database build number
2018-06-01 07:30:04 -04:00
ae8d7267a0
"redir" is now centralized and works with the public contact
2018-06-01 06:46:34 +00:00
8329705eba
New function to delete items for users
2018-05-29 05:22:57 +00:00
c5a22f86c7
Merge remote-tracking branch 'upstream/2018.05-rc' into deleted-item
2018-05-27 10:38:49 +00:00
Pascal Deklerck
334aa40292
Fix autoname output length
2018-05-27 10:20:27 +02:00
54136f3a74
Added the new parameter to the delete function.
2018-05-26 21:38:45 +00:00
4c36109f02
Some more places to add the user id
2018-05-26 20:03:30 +00:00
bdbc51229a
Fix for not being able to delete items
2018-05-26 18:07:27 +00:00
de609e49f0
Improved logging
2018-05-24 22:00:54 +00:00
f8230badba
Avoid problems with better variable naming
2018-05-24 21:46:57 +00:00
1bce39120d
Reconnect after the connection had been lost.
2018-05-24 21:19:59 +00:00
Hypolite Petovan
b0155fe37b
Remove obsolete DNS test from include/dba
2018-05-24 01:31:03 -04:00
87b5e26063
Do a hard exit when the SQL connection went down
2018-05-24 04:07:39 +00:00
3fe07cca57
Issue 2880: Editing post doesn't destroy mentions or hashtags anymore
2018-05-19 14:55:27 +00:00
