friendica/friendica-addons
8
4
Fork 16
Code Issues 3 Pull requests 2 Releases 16 Wiki Activity

Check PHPStan in addons #1592

Merged
MrPetovan merged 2 commits from Art4/friendica-addons:fix-phpstan-error into develop 2025-01-23 14:30:00 +01:00
Conversation 8 Commits 2 Files changed 2 +10 -6
Art4 commented 2025-01-22 09:46:21 +01:00
Contributor
Copy link

I noticed that #1589 adds a PHPStan warning that was not noticed in the review. This leads now to failing tests in the friendica repository.

This PR fixes the error and tries to introduce PHPStan tests in the addon repository to avoid this situation in the future.

Update 1: In the meanwhile #1590 was merged. I resolved the merge conflict.

Update 2: And now I noticed #1591 😆

I noticed that #1589 adds a PHPStan warning that was not noticed in the review. This leads now to failing tests in the friendica repository. This PR fixes the error and tries to introduce PHPStan tests in the addon repository to avoid this situation in the future. **Update 1**: In the meanwhile #1590 was merged. I resolved the merge conflict. **Update 2**: And now I noticed #1591 😆
Art4 added 1 commit 2025-01-22 09:46:21 +01:00
Art4 added 1 commit 2025-01-22 09:47:03 +01:00
Art4 added 1 commit 2025-01-22 09:50:34 +01:00
heluecht commented 2025-01-22 14:26:26 +01:00
Owner
Copy link

Concerning the warning: Couldn't the addons be excluded from that? Because currently this leads to a situation where you have to fix something in the addons to make the core work - and this doesn't sound right.

Concerning the warning: Couldn't the addons be excluded from that? Because currently this leads to a situation where you have to fix something in the addons to make the core work - and this doesn't sound right.
heluecht commented 2025-01-22 14:30:20 +01:00
Owner
Copy link

I'm currently getting a merge conflict when I try to accept rhe PR.

I'm currently getting a merge conflict when I try to accept rhe PR.
👀 1
Art4 commented 2025-01-22 18:16:20 +01:00
Author
Contributor
Copy link

Concerning the warning: Couldn't the addons be excluded from that? Because currently this leads to a situation where you have to fix something in the addons to make the core work - and this doesn't sound right.

This warning occurs because we don't have checks on the addon repository. If we had this check established, we wouldn't run into this situation.

The addon repository depends on the friendica repository. That's why we a.) run checks in friendica repository so a breaking change there should notified early and b.) should run checks on the addon repository to avoid situations like #1589.

As long as we don't have a documented contract or other mechanisms between these repos I recommend that we keep this checks.

> Concerning the warning: Couldn't the addons be excluded from that? Because currently this leads to a situation where you have to fix something in the addons to make the core work - and this doesn't sound right. This warning occurs because we don't have checks on the addon repository. If we had this check established, we wouldn't run into this situation. The addon repository depends on the friendica repository. That's why we a.) run checks in friendica repository so a breaking change there should notified early and b.) should run checks on the addon repository to avoid situations like #1589. As long as we don't have a documented contract or other mechanisms between these repos I recommend that we keep this checks.
Art4 commented 2025-01-22 18:25:47 +01:00
Author
Contributor
Copy link

I cannot see if woodpecker jobs are running on this repository. Are the actions configured correctly and activated?

I cannot see if woodpecker jobs are running on this repository. Are the actions configured correctly and activated?
MrPetovan force-pushed fix-phpstan-error from 27c3572a96 to 7a7940a8ed 2025-01-23 14:29:23 +01:00 Compare
MrPetovan added the
2025.02
 label 2025-01-23 14:29:29 +01:00
MrPetovan approved these changes 2025-01-23 14:29:46 +01:00
MrPetovan merged commit 69e75ef88b into develop 2025-01-23 14:30:00 +01:00
Art4 commented 2025-01-24 00:34:05 +01:00
Author
Contributor
Copy link

@MrPetovan I'm a bit confused. Are actions and runners are activated in this repo?

@MrPetovan I'm a bit confused. Are actions and runners are activated in this repo?
Art4 deleted branch fix-phpstan-error 2025-01-24 00:34:18 +01:00
MrPetovan commented 2025-01-24 19:30:18 +01:00
Owner
Copy link

It doesn't look like it but I don't pay attention to it. Maybe @nupplaPhil would be able to answer this question better.

It doesn't look like it but I don't pay attention to it. Maybe @nupplaPhil would be able to answer this question better.
tobias commented 2025-01-26 09:15:36 +01:00
Owner
Copy link

IIRC the CI only allowes one target - github or self-hosted service - and as long as the bug that prevents us from importing the core repos history and issues is not solved upstream, we are bound to check either core or addons.

IIRC the CI only allowes one target - github or self-hosted service - and as long as the bug that prevents us from importing the core repos history and issues is not solved upstream, we are bound to check either core or addons.
Art4 commented 2025-01-27 09:44:43 +01:00
Author
Contributor
Copy link

IIRC the CI only allowes one target - github or self-hosted service - and as long as the bug that prevents us from importing the core repos history and issues is not solved upstream, we are bound to check either core or addons.

Ok, thank you for this information. This seems to be a problem. And as long as we couldn't run the CI on the addons only we should definitely keep the tests running for the addons in the friendica repository.

> IIRC the CI only allowes one target - github or self-hosted service - and as long as the bug that prevents us from importing the core repos history and issues is not solved upstream, we are bound to check either core or addons. Ok, thank you for this information. This seems to be a problem. And as long as we couldn't run the CI on the addons only we should definitely keep the tests running for the addons in the friendica repository.
Sign in to join this conversation.
Reviewers
No reviewers
MrPetovan
Labels
Clear labels   
2018.09

   
2019.01

   
2019.03

   
2019.06

   
2019.09

   
2019.12

   
2020.03

   
2020.06

   
2020.09

   
2020.12

   
2021.03

   
2021.07

   
2021.09

   
2022.02

   
2022.06

   
2022.09

   
2022.12

   
2023.04

   
2023.05

   
2023.09

   
2024.03

   
2024.06

   
2024.09

   
2024.12

   
2025.02

   
2025.05

   
dependencies

Pull requests that update a dependency file

  
Hackathon 2021
No labels
2018.09
2019.01
2019.03
2019.06
2019.09
2019.12
2020.03
2020.06
2020.09
2020.12
2021.03
2021.07
2021.09
2022.02
2022.06
2022.09
2022.12
2023.04
2023.05
2023.09
2024.03
2024.06
2024.09
2024.12
2025.02
2025.05
dependencies
Hackathon 2021
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: friendica/friendica-addons#1592
No description provided.
Delete branch "Art4/friendica-addons:fix-phpstan-error"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?