friendica/friendica-addons
8
3
Fork 14
Code Issues 3 Pull requests 1 Releases 16 Wiki Activity

Small bug fix #1566

Merged
MrPetovan merged 1 commit from loma-one/friendica-addons:2024.09-rc into 2024.09-rc 2024-12-21 21:57:57 +01:00
Conversation 3 Commits 1 Files changed 1 +1548 -1551
loma-one commented 2024-11-17 08:22:59 +01:00
Contributor
Copy link

Close the Uni-Code Smilies link with a ’;’

Close the Uni-Code Smilies link with a ’;’
loma-one added 1 commit 2024-11-17 08:23:00 +01:00 
Close the Uni-Code Smilies link with a ’;’
MrPetovan commented 2024-11-17 14:13:12 +01:00
Owner
Copy link

This PR isn't just a small bug fix. Can you explain the rationale behind:

  • Adding a semi-colon at the end of the unicode point for most but not all of the smilies?
  • Adding a semi-colon at the end of unicode point groups but not in-between them?
  • Renaming the category comments?
  • Removing the e from finger?
  • Indenting comment characters?
This PR isn't just a small bug fix. Can you explain the rationale behind: - Adding a semi-colon at the end of the unicode point for most but not all of the smilies? - Adding a semi-colon at the end of unicode point groups but not in-between them? - Renaming the category comments? - Removing the `e` from `finger`? - Indenting comment characters?
loma-one added 1 commit 2024-12-07 21:28:42 +01:00 
Änderungen gemäß Kommentare
loma-one added 1 commit 2024-12-07 21:39:15 +01:00 
This addon allows users to create a signature.

Users can decide whether the signature should appear under a post or additionally under a comment.
loma-one added 1 commit 2024-12-07 21:40:08 +01:00 
This addon allows users to create a signature.

Users can decide whether the signature should appear under a post or additionally under a comment.
loma-one added 1 commit 2024-12-07 21:41:25 +01:00 
This addon allows users to create a signature.

Users can decide whether the signature should appear under a post or additionally under a comment.
loma-one added 1 commit 2024-12-10 19:39:34 +01:00 
PHP message handled: Got error 'PHP message: PHP Warning:  Undefined array key "uri-id" in /var/www/html/friend/addon/signatur/signatur.php on line 41'
tobias commented 2024-12-11 06:40:08 +01:00
Owner
Copy link

Could you please make the pull request for the new signature addon in a separate PR to the changes in the unicode smiley pack @loma-one

Could you please make the pull request for the new signature addon in a separate PR to the changes in the unicode smiley pack @loma-one
loma-one added 1 commit 2024-12-16 11:24:50 +01:00 
Constant for the signature marker: SIGNATURE_MARKER is defined as a constant to keep the value consistent.
Simplification of the conditions: Some conditions have been simplified to improve readability.
Clearer variable names: Some variable names have been renamed to make their meaning clearer.
Removal of redundant conditions: The condition isset($b[‘original_body’]) && $b[‘original_body’] != $b[‘body’] has been removed as it is redundant.
Removal of the admin settings: The functions signature_admin_settings and signature_admin_settings_post have been removed.
Removal of admin hooks: The addon_admin and addon_admin_post hooks have been removed from the signature_install function.
Removal of the admin configuration: The configuration for the admin signature has been removed.


Problems
- I still have problems recognising an ‘@’ sign. This causes the signature to be added at the top instead of the bottom.
- If several images are integrated inline, the signature is inserted at the top instead of the bottom.
- Perhaps someone can give me a tip on how to avoid this.
loma-one added 1 commit 2024-12-21 08:48:21 +01:00 
Further work. The add-on will be submitted again later.
loma-one added 1 commit 2024-12-21 08:48:34 +01:00 
Further work. The add-on will be submitted again later.
loma-one added 1 commit 2024-12-21 08:48:43 +01:00 
Further work. The add-on will be submitted again later.
loma-one added 1 commit 2024-12-21 08:48:53 +01:00 
Further work. The add-on will be submitted again later.
loma-one commented 2024-12-21 08:50:53 +01:00
Author
Contributor
Copy link

Thank you Tobias. I've only just seen your message. The addon has been deleted

Thank you Tobias. I've only just seen your message. The addon has been deleted
MrPetovan force-pushed 2024.09-rc from 506f5b89ba to 16e06f9b2b 2024-12-21 21:57:39 +01:00 Compare
MrPetovan approved these changes 2024-12-21 21:57:48 +01:00
MrPetovan merged commit f2a9eb151d into 2024.09-rc 2024-12-21 21:57:57 +01:00
MrPetovan added the
2024.09
 label 2024-12-21 21:58:03 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
MrPetovan
Labels
Clear labels   
2018.09

   
2019.01

   
2019.03

   
2019.06

   
2019.09

   
2019.12

   
2020.03

   
2020.06

   
2020.09

   
2020.12

   
2021.03

   
2021.07

   
2021.09

   
2022.02

   
2022.06

   
2022.09

   
2022.12

   
2023.04

   
2023.05

   
2023.09

   
2024.03

   
2024.06

   
2024.09

   
2024.12

   
dependencies

Pull requests that update a dependency file

  
Hackathon 2021
No labels
2018.09
2019.01
2019.03
2019.06
2019.09
2019.12
2020.03
2020.06
2020.09
2020.12
2021.03
2021.07
2021.09
2022.02
2022.06
2022.09
2022.12
2023.04
2023.05
2023.09
2024.03
2024.06
2024.09
2024.12
dependencies
Hackathon 2021
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: friendica/friendica-addons#1566
No description provided.
Delete branch "loma-one/friendica-addons:2024.09-rc"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?