friendica/friendica-addons
9
4
Fork 16
Code Issues 3 Pull requests 4 Releases 16 Wiki Activity

Small bug fix #1566

Merged
MrPetovan merged 1 commit from :2024.09-rc into 2024.09-rc 2024-12-21 21:57:57 +01:00
Conversation 4 Commits 1 Files changed 1 +1548 -1551
loma-one commented 2024-11-17 08:22:59 +01:00
Contributor
Copy link

Close the Uni-Code Smilies link with a ’;’

Close the Uni-Code Smilies link with a ’;’
MrPetovan commented 2024-11-17 14:13:12 +01:00
Owner
Copy link

This PR isn't just a small bug fix. Can you explain the rationale behind:

  • Adding a semi-colon at the end of the unicode point for most but not all of the smilies?
  • Adding a semi-colon at the end of unicode point groups but not in-between them?
  • Renaming the category comments?
  • Removing the e from finger?
  • Indenting comment characters?
This PR isn't just a small bug fix. Can you explain the rationale behind: - Adding a semi-colon at the end of the unicode point for most but not all of the smilies? - Adding a semi-colon at the end of unicode point groups but not in-between them? - Renaming the category comments? - Removing the `e` from `finger`? - Indenting comment characters?
tobias commented 2024-12-11 06:40:08 +01:00
Owner
Copy link

Could you please make the pull request for the new signature addon in a separate PR to the changes in the unicode smiley pack @loma-one

Could you please make the pull request for the new signature addon in a separate PR to the changes in the unicode smiley pack @loma-one
loma-one commented 2024-12-21 08:50:53 +01:00
Author
Contributor
Copy link

Thank you Tobias. I've only just seen your message. The addon has been deleted

Thank you Tobias. I've only just seen your message. The addon has been deleted
MrPetovan approved these changes 2024-12-21 21:57:48 +01:00
MrPetovan merged commit f2a9eb151d into 2024.09-rc 2024-12-21 21:57:57 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
MrPetovan
Labels
Clear labels   
2018.09

   
2019.01

   
2019.03

   
2019.06

   
2019.09

   
2019.12

   
2020.03

   
2020.06

   
2020.09

   
2020.12

   
2021.03

   
2021.07

   
2021.09

   
2022.02

   
2022.06

   
2022.09

   
2022.12

   
2023.04

   
2023.05

   
2023.09

   
2024.03

   
2024.06

   
2024.09

   
2024.12

   
2025.02

   
2025.05

   
dependencies

Pull requests that update a dependency file

  
Hackathon 2021
No labels
2018.09
2019.01
2019.03
2019.06
2019.09
2019.12
2020.03
2020.06
2020.09
2020.12
2021.03
2021.07
2021.09
2022.02
2022.06
2022.09
2022.12
2023.04
2023.05
2023.09
2024.03
2024.06
2024.09
2024.12
2025.02
2025.05
dependencies
Hackathon 2021
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: friendica/friendica-addons#1566
No description provided.
Delete branch ":2024.09-rc"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?