Commit graph

20297 commits

Author SHA1 Message Date
Roland Häder
7d47152564 Fixed E_NOTICE in boot.php and DBA class (#5430)
* Fixes:
- fixed missing variable $port (MySQL: 3306)
- "imported" mysqli class

Signed-off-by: Roland Häder <roland@mxchange.org>

* Fixed:
- better use `false` and `$port > 0`

* And better only provide `$port` when larger zero.

* Initialize `$port` with zero value (int) and not `false` (bool).

* Removed duplicate mysqli "import".

* `$post_update` is no longer used. Instead `$prefix` needs to be checked.
2018-07-22 12:53:46 -04:00
Hypolite Petovan
3500e50be9
Fix Fatal error in Protocol\OStatus (#5450) 2018-07-22 12:52:38 -04:00
Roland Häder
0a519f5001 Fixes/tye-hints (#5449)
- added type-hints for DOMDocument, DOMXPath and array
- added missing documentation about optional parameter
- `if ($foo['bar'])` is not a good choice, better use
  `if (!empty($foo['bar']))` instead
2018-07-22 12:35:20 -04:00
Roland Häder
2e332134d4 There is no LOGGER_WARNING (triggering E_NOTICE about absent constant). Either (#5448)
declare it and push all other numbers higher or use LOGGER_NORMAL.
2018-07-22 12:33:28 -04:00
Roland Häder
2970a976d5 Fixes: (#5447)
- rewrote to first check if PID file is readable, then if found load it
- next addition is to cast it's content to int. Any non-integer content will
  result in 0 (as I know).
- Give warnings a voice! (xdebug's scream option showed a warning)
- added some spaces for better readability
2018-07-22 12:28:39 -04:00
Jeroen De Meerleer
d1d2ee6b2f Added a for-loop (#5442)
* Using json_decode instead of reinventing hot water

Guys, you could have told me ;)

* changed spaces to tabs

* Guess I'll need a beer ;)
2018-07-21 17:29:39 -04:00
Jeroen De Meerleer
ddaeb305bc Worker-details: Using json_decode instead of reinventing hot water (#5441)
* Using json_decode instead of reinventing hot water

Guys, you could have told me ;)

* changed spaces to tabs
2018-07-21 13:24:03 -04:00
Philipp
c5cbf565d9 DBStructure enhancements (#5437)
* Adding DBStructure enhancements

- Added DBStructure::rename()
- Added DBStructure::existTable()
- Added DBStructure::existColumn()

(cherry picked from commit 4ae06ec)

* Adding `pre_update_1279` method

- Added DBStructure::rename()
- Added DBStructure::existTable()
- Added DBStructure::existColumn()

(cherry picked from commit 8496d84)

* code standards

(cherry picked from commit 551d09b)

* simplify to `empty` instead `is_null`

(cherry picked from commit ce68835)
2018-07-21 08:43:43 -04:00
Andreas Neustifter
303aef34f0 Make frio more consistent by replacing textual links with icons everywhere. (#5415)
* Make frio more consistent by replacing textual links with icons everywhere I could find them.

* [frio] Move profile add link to icon.
2018-07-21 07:31:05 -04:00
eded252a40
Merge pull request #5435 from annando/htaccess
Automatically create a .htaccess when not existing
2018-07-21 07:48:15 +02:00
f02bcdba51 Automatically create a .htaccess when not existing 2018-07-21 05:41:19 +00:00
e4a652cae8
Merge pull request #5433 from annando/mysqli
Forgotten "use"
2018-07-21 07:18:10 +02:00
4ba91d4ea1 Forgotten "use" 2018-07-21 05:09:09 +00:00
Michael Vogel
6a6a805225 One more notice (#5429)
* Some more notices

* And some more notice in the worker
2018-07-20 20:43:21 -04:00
Roland Häder
6da47936c6 renamed .htaccess to .htaccess-dist and ignored .htaccess afterwards (#5428)
* renamed .htaccess to .htaccess-dist and ignored .htaccess afterwards. This
allows local changes to it without having a dirty checkout directory.

Signed-off-by: Roland Häder <roland@mxchange.org>

* Some fixes:
- removed non-neutral words
- added examples for Linux/Windows

* Better documentation and added note about **not** renaming the file.

Signed-off-by: Roland Häder <roland@mxchange.org>
2018-07-20 20:27:37 -04:00
Michael Vogel
4bbcb61a9e We now have a pre update script (#5425)
* We now have a pre update script

* Some optimized stuff
2018-07-20 15:47:16 -04:00
Andreas Neustifter
b26da6096b [frio] Restyle album edit header. (#5426) 2018-07-20 15:23:51 -04:00
Andreas Neustifter
24fc070c5c [frio] Restyle photo upload (#5427)
* Better wording in photo upload.

* [frio] Restyle photo uploader to conform to frio style.
2018-07-20 15:23:12 -04:00
Michael Vogel
7382be2766 Some more notices (#5424) 2018-07-20 14:07:54 -04:00
Michael Vogel
4f2ae88684
Merge pull request #5422 from MrPetovan/task/5410-rename-dba-to-DBA
Rename Friendica\Database\dba to Friendica\Database\DBA
2018-07-20 19:44:54 +02:00
Hypolite Petovan
af6dbc654f Rename Friendica\Database\dba to Friendica\Database\DBA 2018-07-20 08:19:26 -04:00
b6a1df0598
Merge pull request #5420 from annando/notices
Just some more fixed notice
2018-07-20 12:46:42 +02:00
e821e738a8
Merge pull request #5421 from annando/fatal
Wrong "use" for config
2018-07-20 12:45:00 +02:00
045358cb88 Wrong "use" for config 2018-07-20 06:04:23 +00:00
5c63de1692 Just some more fixed notice 2018-07-20 05:31:26 +00:00
Michael Vogel
519b82420a
Merge pull request #5419 from annando/fixes
Makes Diaspora working again
2018-07-20 07:13:24 +02:00
9a6a3bf1c1 Makes Diaspora working again 2018-07-20 05:10:16 +00:00
Michael Vogel
4e44b07dfe
Merge pull request #5418 from MrPetovan/task/5410-move-dba-to-src
Move \dba to \Friendica\Database\dba
2018-07-20 06:50:36 +02:00
Hypolite Petovan
9c70a94589 Add missing PDO* use statements in Database\dba 2018-07-19 22:24:03 -04:00
Hypolite Petovan
72f32f90d1 Remove class \dba from include/dba 2018-07-19 22:15:57 -04:00
Hypolite Petovan
daa1177e3a Update use statement lists with new Friendica\Database\dba class
- Remove unused use statement
- Remove superfluous use statements (classes in the same namespace)
- Add missing use statements
2018-07-19 22:15:21 -04:00
Hypolite Petovan
c316c5ae30 Add new Friendica\Database\dba class 2018-07-19 22:06:13 -04:00
Roland Häder
36c6e35c7e Misc cleanups (#5417)
* Fixed http://github to https://github

Signed-off-by: Roland Häder <roland@mxchange.org>

* reverted back

Signed-off-by: Roland Häder <roland@mxchange.org>

* Added type-hint 'array' as the method uses foreach() on it.

Signed-off-by: Roland Häder <roland@mxchange.org>

* Tpzo fixed ...

Signed-off-by: Roland Häder <roland@mxchange.org>

* Added missing new-line at end of file, will make some POSIX parsers being lesser
confused ...

Signed-off-by: Roland Häder <roland@mxchange.org>
2018-07-19 20:52:18 -04:00
Michael Vogel
01b67c4eb3 Little fixes (#5414)
* We now store the item delivery data in a separate table

* Reorganized table structure

* Fix  a notice when using the profiler / ensure that permissions are strings
2018-07-19 18:40:39 -04:00
Roland Häder
b2899d76cf Small cleanup (#5416)
- added internal TODO to decide about is_result() usage
- removed semicolon (not needed here) from SQL query
- added empty line

Signed-off-by: Roland Häder <roland@mxchange.org>
2018-07-19 18:39:05 -04:00
Andreas Neustifter
bc5cf8f3c1 Fix photo-upload and croping. (#5412) 2018-07-19 17:59:18 -04:00
Michael Vogel
ec49d004e3 We now store the item delivery data in a separate table (#5413)
* We now store the item delivery data in a separate table

* Reorganized table structure
2018-07-19 17:56:52 -04:00
Michael Vogel
ece4d3f4fb Issue 5407: Workers didn't start anymore (#5409) 2018-07-19 11:05:17 -04:00
Jeroen De Meerleer
b375370c37 Workerqueue param reformat (#5403)
* Prettified the parameter layout of workerqueue

* Updated to code standards :)

* Where did I go wrong?

* Seems like someone needs to sleep ;)
2018-07-19 09:52:48 -04:00
Michael Vogel
5af9596dde New item field "Post-type" and new table "permissionset" (#5408)
* "post-type" replaces "bookmark" and "type"

* Removed some more type

* Added index to permission set

* The permission set is now stored

* The permission set is now removed upon expiry

* Post update now stores the permission set

* New file

* Permissions are now sorted

* Changed documentation
2018-07-19 09:52:05 -04:00
Roland Häder
0b38f1c58b Fixes applied: (#5399)
- $_SESSION['remember_user'] did only exist here and no where else
- it seems to be accient old-lost code, so I fixed it to $a->user['nickname']
  instead
- used multi-line comment for multiple lines of on-line comments

Signed-off-by: Roland Häder <roland@mxchange.org>
2018-07-19 07:11:03 -04:00
Roland Häder
b05b96d04a Fixes: (#5404)
- fixed E_NOTICE in mod/follow.php
- fixed 2 E_NOTICE in src/Protocol/Diaspora.php
- added more type-hints for `array` type where known

Signed-off-by: Roland Häder <roland@mxchange.org>
2018-07-19 07:07:14 -04:00
Michael Vogel
732da04ced
Merge pull request #5406 from tobiasd/20180717-msg
regen master messages.po
2018-07-19 08:45:54 +02:00
921493fc92 regen master messages.po 2018-07-19 06:40:31 +02:00
Jeroen De Meerleer
5790a0c58a Added warning for special characters in docs and template (#5402) 2018-07-18 17:30:34 -04:00
Roland Häder
346790cbbc According to @annando and @MrPetovan, $emailcc is no item field (column) and (#5401)
should be initialized empty (I did it above the `if()` block).

Signed-off-by: Roland Häder <roland@mxchange.org>
2018-07-18 17:26:14 -04:00
Pierre Rudloff
6e1ed0b0d3 Fix tests (#5400)
* Avoid argc side-effects

* Fix undefined array keys in JITConfigAdapter::set()

* Avoid argv side effects in ApiTest
2018-07-18 16:30:55 -04:00
Jeroen De Meerleer
b265bf2ec3 Prettified the parameter layout of workerqueue (#5397)
* Prettified the parameter layout of workerqueue

* Updated to code standards :)

* Where did I go wrong?
2018-07-18 16:24:35 -04:00
Roland Häder
2c44437d40 Fixed E_NOTICE when no 'term' was provided (#5391)
* Fixed E_NOTICE when no 'term' was provided, maybe better encapsulate this whole
$_GET, $_POST and $_SESSION thing into a `Request` class?

Signed-off-by: Roland Häder <roland@mxchange.org>

* Rewrote to recommendation by @MrPetovan which results in really nicer code.

Signed-off-by: Roland Häder <roland@mxchange.org>
2018-07-18 15:41:24 -04:00
Pierre Rudloff
b057906bed Fix silent exit in ApiTest::testApiMediaUploadWithMedia() (#5398) 2018-07-18 15:36:51 -04:00