6070221364
Improved checks in "storeForUserByUriId" to reduce recursion depth
2022-08-17 05:28:24 +00:00
3e2c684319
Some more index / fatal erros fixed
2022-08-16 11:23:47 +00:00
bb52e5a804
Cascade on author deletion
2022-08-16 04:18:29 +00:00
4d617c9c48
This cache key doesn't exist anymore
2022-08-15 18:46:10 +00:00
5b3145d7ce
Several performance improvements
2022-08-15 13:23:01 +00:00
946db2ab45
Normalize start_time and end_time parameter names in Friendica API event endpoints
2022-08-13 23:28:20 -04:00
pankraz
bd02340162
new event APIs
2022-08-13 23:28:19 -04:00
c1c37da545
Changed double-quotes to single
2022-08-13 23:24:38 +02:00
52d1b9905e
Fixes:
...
- fixed "get() on NULL invocation, PHP is case-sensitive here
- renamed $this->baseurl to $this->baseUrl (instance) in MoveToAvatarCache to
make it same as everywhere else
2022-08-13 22:47:57 +02:00
f579d687a9
Fixes:
...
- fixed $this usage (kept) and got rid of static context
- "imported" exception class
- added some nice text to it
2022-08-13 22:32:56 +02:00
21f3a56c42
Merge pull request #11841 from Quix0r/cleanups/type-hints-documentation
...
Cleanups/type hints + documentation
2022-08-13 10:43:11 -04:00
c6de91a8ec
Don't delete the post when there is some undeleted post-user
2022-08-13 12:24:25 +00:00
88cdb695b1
Changed:
...
- double-quotes to single
- more space around concated strings
- removed TODO as there is sadly no IOException in PHP
2022-08-13 13:35:50 +02:00
5c5ae00370
Improved performance when updating contacts
2022-08-13 09:01:48 +00:00
ff5673e2d8
Changed:
...
- used $this->baseurl instead of DI::baseurl() (@MrPetovan )
2022-08-13 06:52:09 +02:00
cfa575b8e5
Changes:
...
- added missing type-hints
- added documentation
- removed parameter $baseURL while it can be locally get the same way but
lesser parameter
- used ActivityNamespace::SALMON_ME
- changed double-quotes to single
2022-08-12 14:01:40 +02:00
074bae33c9
Changes:
...
- added some missing type-hints
- added some documentation
- added some empty lines to `@return` statements (code-style convention)
2022-08-12 13:36:34 +02:00
33c7abd376
Changes:
...
- methods should ALWAYS start lower-case, not upper
- documented a bit more
2022-08-12 13:13:54 +02:00
9794ce0c87
Changes:
...
- added type-hint for $type parameter
- documented method
- unsupported verbs logged
2022-08-12 13:09:59 +02:00
Philipp
a145712f04
Merge pull request #11837 from MrPetovan/task/remove-poke
...
Remove poke feature
2022-08-11 18:17:11 +02:00
ae9bd4f3f2
Changes:
...
- reformatted and documented private method
- used [] instead of deprecated/discouraged array()
2022-08-10 17:10:59 +02:00
809beeee9d
Merge pull request #11838 from annando/asynchronous-conversation
...
Conversation entries will now be stored asynchronous if possible
2022-08-10 10:42:19 -04:00
e2896b449b
Changes after code review
2022-08-10 13:43:00 +00:00
d9aee0b3ea
Conversation entries will now be stored asynchronous if possible
2022-08-10 09:28:18 +00:00
4a885a13a6
Remove poke feature
2022-08-09 14:55:55 -04:00
62be1c5614
Merge pull request #11835 from annando/sql-fetchqueue
...
Improve SQL-Queries / fixed "fetch_parents" setting
2022-08-08 23:00:48 +02:00
548b7f43a5
Improve SQL-Queries / fixed "fetch_parents" setting
2022-08-08 20:00:21 +00:00
547b4684fd
Add smarty3 dirs config
...
`FriendicaSmarty` get work dirs from config, with fallback if not set
2022-08-08 12:28:07 -04:00
Philipp
e0ec304d2a
Merge pull request #11830 from MrPetovan/task/11826-pluralization
...
Use L10n->tt instead of t() for plural strings
2022-08-08 15:35:54 +02:00
7634fc2425
added Gàidhlig language translation
...
This adds the initial translation of Friendica core into Gàidhlig by @gunchleoc
redo of #11818
2022-08-08 11:37:39 +02:00
71084cf9f0
Use L10n->tt instead of t() for plural string in Module\BaseApi
2022-08-08 02:08:43 -04:00
c19e57e176
Use L10n->tt instead of t() for plural strings in Module\Admin\Federation
2022-08-08 02:08:40 -04:00
f917286d6e
Use L10n->tt instead of t() for plural strings for polls in Model\Item
2022-08-08 01:52:16 -04:00
bff6a5a9ee
Add support for additional interpolated variables in L10n->tt()
2022-08-08 01:51:42 -04:00
d60d2caef6
Improved queue processing
2022-08-07 19:24:50 +00:00
22c1873064
Merge remote-tracking branch 'upstream/develop' into loop-prevention
2022-08-06 17:11:04 +00:00
87a945b295
More prevention of double processing of the same content
2022-08-06 17:06:55 +00:00
963ebe9193
Merge pull request #11821 from tobiasd/20220805-typo
...
typo in console tool
2022-08-05 10:05:06 -04:00
91911c4676
typo in console tool
...
@gunchleoc spottet a typo while working on the translations of Friendica. This fixes it.
2022-08-05 15:37:38 +02:00
704bd95608
Fix WSOD when Renderer throws exception
...
`HTTPException` builds a simple static version of error page if
`Renderer` throws any exception while rendering the error page.
2022-08-05 15:28:21 +02:00
bd246b8cc2
Merge pull request #11817 from annando/double-processing
...
Avoid processing the same activity
2022-08-05 09:04:33 -04:00
8b698b183d
Abort when public item cannot be inserted
2022-08-05 05:48:20 +00:00
8227367522
Remove test code, add documentation
2022-08-05 04:45:31 +00:00
f222e9d278
Avoid to provess the same activity
2022-08-04 21:52:10 +00:00
2e00797ebc
Merge pull request #11816 from annando/fetch-parents
...
New option to disable the fetching of parents
2022-08-04 16:00:00 -04:00
06f7244280
New option to disable the fetching of parents
2022-08-04 19:32:36 +00:00
8105668caf
Added missing 'private' field, see Processor::processContent() where it is needed
2022-08-04 10:50:44 +02:00
196a1de7f2
Merge pull request #11812 from annando/ap-performance
...
Hopefully fixes loops during message processing
2022-08-03 03:00:50 -04:00
e82ef8890b
Only process entries for existing posts
2022-08-03 05:14:07 +00:00
3463e34693
Don't always fetch parent posts
2022-08-03 04:51:57 +00:00
23ef4a99bb
Changes after code review
2022-08-03 04:31:56 +00:00
f2eec66240
Hopefully fixes loops during message processing
2022-08-03 03:38:03 +00:00
49394aedeb
Add password length limit if using the Blowfish hashing algorithm
...
- Add new page to reset a password that would be too long
- Add support for pattern parameter in field_password
2022-08-01 12:12:18 -04:00
067f06b166
Rework return_path session key handling
...
- Add new IHandleSessions::pop() method
- Remove redirection from Authentication::setForUser()
- Add explicit return_path form parameter to Login::form()
2022-08-01 12:10:43 -04:00
c8d1bf4cdf
Code standards and updated database documentation
2022-08-01 07:06:30 +00:00
81b244f91e
Option to activate or deactivate the background fetching
2022-08-01 06:59:20 +00:00
f7ec8d5b8e
Improved log message
2022-08-01 05:59:59 +00:00
7d5b4808cd
Merge branch 'fetch' into fetch-cache
2022-08-01 05:57:59 +00:00
4be6e9a27d
Cache if an activity has recently been fetched
2022-08-01 05:56:55 +00:00
6c7dfd6958
New table to control the fetching process
2022-08-01 04:48:49 +00:00
3945de5e3b
No blubb allowed
2022-08-01 00:58:56 +00:00
0347f4fc66
Remove test code
2022-07-31 16:01:56 +00:00
b6da15557b
The post-reason / protocol is now filled in most cases
2022-07-31 15:54:35 +00:00
06a124338a
Only store the inbox-queue on activated background processing
2022-07-31 08:10:47 +00:00
371f20a1aa
Decoupling is deactivated by default now
2022-07-31 07:48:35 +00:00
8b4bf890f8
Issue 11798: Handling of empty author
2022-07-30 05:30:08 +00:00
f6d11e8401
Issue 11800: Remove entry from queue in any case.
2022-07-30 04:43:18 +00:00
da48453931
Merge pull request #11801 from annando/no-zero
...
Don't add zero as receiver
2022-07-29 21:15:20 -04:00
6383b07022
Don't add zero as receiver
2022-07-29 22:56:53 +00:00
2e75d442a5
Merge pull request #11793 from Quix0r/reformatted-arrays
...
Reformatted some arrays for better readability
2022-07-29 17:54:53 -04:00
653aaf1e26
Merge branch 'post-reason' of github.com:annando/friendica into post-reason
2022-07-29 21:31:34 +00:00
f9bf2424b1
Merge remote-tracking branch 'upstream/develop' into post-reason
2022-07-29 21:29:15 +00:00
699152e15e
Add more post reasons
2022-07-29 21:28:22 +00:00
Michael Vogel
fa3c5d6c5e
Update src/Content/Conversation.php
...
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2022-07-29 21:59:53 +02:00
0971bcf165
Make the tests happy
2022-07-29 16:05:04 +00:00
1210e235fb
Extracted as variable to have 2 more array fields moved to array initialization.
2022-07-29 17:20:09 +02:00
676ca36c52
Changes:
...
- reformatted arrays
2022-07-29 17:20:07 +02:00
2c32429d8d
Fix test
2022-07-29 14:56:40 +00:00
81aaacc67d
Improvements for the "post-reason"
2022-07-29 14:17:53 +00:00
95ac2aa54b
Fixed a possible NULL value (not valid, at least empty string)
2022-07-29 12:45:21 +02:00
f8ed028013
Changed back to $cdata.
2022-07-29 12:41:08 +02:00
a20d05ba39
Merge pull request #11792 from Quix0r/fixes/get-request-value
...
Wrong variable name fixed (maybe copy-paste mistake) + used method instead of direct array access
2022-07-28 21:17:34 -04:00
eaed3945d1
Changed:
...
- used `$this->getRequestValue($request, 'foo', <bar>)` instead of `$request['foo'] ?? <bar>`
- fixed wrong variable naming
- changed double-quotes to single
- see https://github.com/friendica/friendica/issues/11631#issuecomment-1196410497
2022-07-29 00:38:46 +02:00
37bda3e5fb
Changes:
...
- fixed wrong type-hint uid => int
- added returned type-hint
- added some documentation
- formatted arrays a bit
2022-07-29 00:08:38 +02:00
5ec407699b
Merge pull request #11790 from annando/fetchactivity
...
Negative caching / config for receiver / fix fatals
2022-07-28 17:29:34 -04:00
b63ad63c29
Config for receiver / fix fatals
2022-07-28 21:16:42 +00:00
6e7823eaaa
Merge pull request #11784 from MrPetovan/task/11779-blocklist-notification
...
Add email notification to all users on server domain pattern block list update
2022-07-28 16:26:51 -04:00
f0499e7269
Use negative caching
2022-07-28 20:25:38 +00:00
1aacff4ce1
Fix fatal error
2022-07-28 19:35:25 +00:00
d12c9a8f58
Caching for fetched activities
2022-07-28 19:05:04 +00:00
f29d9be574
Merge pull request #11785 from annando/processing
...
Decoupling of relay posts / endless loop removed
2022-07-28 05:42:46 -04:00
97ccb4d2c4
Make server domain pattern block reason mandatory
2022-07-28 05:39:51 -04:00
5045f9e188
Add email notification to all users on server domain pattern block list update
2022-07-28 05:39:29 -04:00
1810b32c26
Move server domain pattern blocklist features to its own class
...
- Update tests
2022-07-28 05:38:50 -04:00
e445975c20
Use DBA::quoteIdentifier in Database::escapeFields
2022-07-28 05:37:22 -04:00
Roland Häder
09cb4c1540
Revert "Added logging of unsupported meta-tag records"
2022-07-28 06:00:58 +00:00
a27274b3b4
Avoid loops at deletion / decoupling for relay posts
2022-07-28 05:29:47 +00:00
8fb0fa2921
Added logging of unsupported meta-tag records
2022-07-28 04:10:57 +02:00
3c71392f9e
Avoid endless loop while deleting
2022-07-27 21:57:05 +00:00
505191dec5
Decouple the processor from the receiver
2022-07-27 20:59:42 +00:00
3af55de978
Issue 11776 - process replies via a worker task
2022-07-27 20:03:28 +00:00
ff9dc1e291
Merge remote-tracking branch 'upstream/develop' into untrusted
2022-07-27 17:56:56 +00:00
86105635ca
Improved message handling / new activity relay handling
2022-07-27 17:39:00 +00:00
e11d3cfeb0
Add upload feature for domain pattern block list
...
- Add new /admin/blocklist/server/import route
- Add form on domain pattern blocklist index page
2022-07-27 11:54:50 -04:00
7d7a5a65e9
Add download feature for domain block list
...
- Add new /blocklist/domain/download route
- Add link on /friendica page
2022-07-27 11:54:50 -04:00
1b2182c43c
Move system messages from boot to own class
2022-07-27 11:54:50 -04:00
Michael Vogel
f9777ce0dc
Merge pull request #11770 from MrPetovan/bug/notices
...
Handle rare case where contact doesn't exist in Model\Group::getIdsByContactId
2022-07-25 21:01:12 +02:00
488f4dcaa4
Handle rare case where contact doesn't exist in Model\Group::getIdsByContactId
...
- Address https://github.com/friendica/friendica/issues/11632#issuecomment-1193953621
2022-07-25 12:07:42 -04:00
d1b21eaf42
Changes:
...
- use local variables
2022-07-25 17:53:54 +02:00
1ac1db6173
Changed:
...
- rewrote to almost one block of array initialization
2022-07-25 16:49:01 +02:00
65cd0def22
Fix wrong type-hint in Module/DFRN/Notify
...
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1193958648
2022-07-25 09:09:22 -04:00
7834359957
Merge remote-tracking branch 'upstream/develop' into untrusted
2022-07-24 21:58:49 +00:00
b546173747
IMproved handling of untrusted posts
2022-07-24 21:58:09 +00:00
a5d679ea95
Merge pull request #11759 from annando/enqueue-posts
...
Fetch missing posts via a queue
2022-07-24 15:38:44 -04:00
5ab94ea921
Option to store untrusted entries
2022-07-24 19:31:31 +00:00
51cc1f679f
Added trust / isActivityGone
2022-07-24 14:26:06 +00:00
55b6a89c7c
Optimizing
2022-07-24 13:49:57 +00:00
72bc92db62
Standards
2022-07-24 13:11:52 +00:00
6abb4d40d6
Handle changed parents
2022-07-24 13:09:35 +00:00
06280aa5a3
Recursively delete failed worker tasks
2022-07-24 09:26:52 +00:00
c2b2e8ae9f
Standards
2022-07-23 23:15:08 +00:00
073695b33c
Funkwhale context file moved
2022-07-23 23:10:47 +00:00
86ef7c66d3
Changes:
...
- added some missing type-hints, thanks to @MrPetovan
2022-07-23 23:09:35 +02:00
ba1c1049d6
Changes:
...
- added some type-hints
- added some documentation
- used self::exists() instead of DBA::exists('user', ['uid' => $uid])
2022-07-23 21:58:00 +02:00
a2a7d04fa1
Changed double-quotes to single
2022-07-23 21:58:00 +02:00
edc49ec9b4
Add expected "users" property to NodeInfo usage property for all versions
2022-07-23 13:21:44 -04:00
6a19639ac2
Standards
2022-07-23 14:10:07 +00:00
5d6eb4670a
We now store the conversation as well
2022-07-23 13:58:14 +00:00
abf39ff9cf
Merge remote-tracking branch 'upstream/develop' into enqueue-posts
2022-07-23 12:55:34 +00:00
8c602071c2
Bookwyrm posts now work
2022-07-23 12:50:15 +00:00
7eb410bed7
Conversation/context is now stored
2022-07-23 06:52:43 +00:00
54cebf5a88
Remove test code
2022-07-21 12:42:26 +00:00
4c5e9f206e
Remove ignored undo
2022-07-21 11:47:23 +00:00
99f7270e18
Improved workerqueue handling
2022-07-21 08:55:45 +00:00
3966bff8a1
Fix standards
2022-07-21 08:14:47 +00:00
2e39cebcb9
Process the replies
2022-07-21 07:08:17 +00:00
4930e77eb3
We are now setting the corresponding worker id
2022-07-21 07:05:38 +00:00
28fb022425
Reset the recursion depth at a different place
2022-07-21 06:26:31 +00:00
c775833117
Use deferred tasks
2022-07-21 06:23:55 +00:00
d4a536137d
database.sql updated, standards fixed
2022-07-21 05:42:53 +00:00
4a1fb1da12
Hourly process pending queue entries
2022-07-21 05:33:01 +00:00
1d13574225
Fetching of missing posts is reworked
2022-07-21 05:16:14 +00:00
650e05bcb5
Merge pull request #11758 from Quix0r/fixes/wrong-variable-name
...
Fixed variable name + used empty()
2022-07-20 07:55:38 -04:00
4b5ae32ec6
Changes:
...
- ops, fixed variable name (thanks to @annando)
- also used empty() for an empty array (and false/null)
2022-07-20 11:54:28 +02:00
Michael Vogel
fc52296a77
Merge branch 'develop' into diaspora
2022-07-20 08:12:30 +02:00
c20c0a1812
Restore the original functionality
2022-07-20 05:47:30 +00:00
138a15404f
Fix processing of incoming Diaspora messages
2022-07-20 05:38:53 +00:00
7dcd02938d
Remove entries from queue / relay detection
2022-07-20 05:37:40 +00:00
1fbda27aad
Changes:
...
- rewrote a lot local variables to an array and returned it instead of an
anonymous array
- added more debug/warning logging in case something went wrong -> lesser guessing! ;-)
- changed double-quote to single
2022-07-20 01:08:15 +02:00
d69ac56338
Merge pull request #11753 from Quix0r/fixes/missing-contact-array
...
Fixed missing $contact array, at least initialize it empty
2022-07-19 17:58:02 -04:00
2ef0566ba5
Fixed:
...
- "Undefined variable: contact in .../src/Protocol/Diaspora.php on line 4097
Trying to access array offset on value of type null in .../src/Protocol/Diaspora.php on line 4097"
- see https://github.com/friendica/friendica/issues/11632#issuecomment-1189465336
2022-07-19 23:46:09 +02:00
3c540517e7
Ops
2022-07-19 23:40:29 +02:00
cf8698afe6
This is the correct way:
...
<?php
if (!isset($foo['account_removed) || $foo['account_removed'])
?>
2022-07-19 18:08:18 +02:00
4e5179a7b3
Changes:
...
- added some missing type-hints
- fixed some documentation (e.g. empty * line between @param and @return/throws)
2022-07-19 18:02:38 +02:00
cb2a052a70
Fixed E_NOTICE, for some strange reason 'account_removed' isn't around?
2022-07-18 23:49:58 +02:00
a676cf8bed
Merge remote-tracking branch 'upstream/develop' into enqueue-posts
2022-07-18 14:05:04 +00:00
ce38e63399
Add and delete entries
2022-07-18 14:03:49 +00:00
42d411712b
Merge pull request #11742 from annando/server-detection
...
Improved server detection
2022-07-18 08:50:59 -04:00
2e9d1a9046
Merge pull request #11746 from annando/warn
...
Check for GMP module
2022-07-18 08:49:50 -04:00
ac47aed1b4
Merge remote-tracking branch 'upstream/develop' into enqueue-posts
2022-07-18 05:32:44 +00:00
af8e059990
Renamed platform definition file
2022-07-18 03:48:19 +00:00
3bd706fcfc
Superfluous todo removed
2022-07-18 03:32:49 +00:00
2f462ffa16
Store incoming posts in a queue
2022-07-18 03:31:00 +00:00
121607b8d9
Merge pull request #11740 from annando/json-ld
...
Improved JsonLD parsing
2022-07-17 17:44:53 -04:00
46fdd9893c
Merge remote-tracking branch 'upstream/develop' into server-detection
2022-07-17 15:42:09 +00:00
Philipp
6175f9086e
Merge pull request #11747 from annando/fixes
...
Emergency fixes to fix a bunch of fatal errors
2022-07-17 16:34:53 +02:00
9a4be84853
Only check for string value
2022-07-17 13:13:14 +00:00
6882e70024
Match the documentation
2022-07-17 13:00:34 +00:00
2ddf37f32d
Emergency fixes to fix a bunch of fatal errors
2022-07-17 11:47:12 +00:00
23953be7cb
Merge remote-tracking branch 'upstream/develop' into warn
2022-07-17 08:51:46 +00:00
f2a4aecc05
Check for GMP module
2022-07-17 06:34:37 +00:00
d52f52f45f
Somed added documentation
2022-07-17 05:42:44 +00:00
Philipp
1894302011
Merge pull request #11739 from Quix0r/fixes/missing-return-statements
...
Fixes/missing return statements
2022-07-16 16:23:32 +02:00
0a19759e4f
Fix wrong variable type
2022-07-16 13:44:35 +00:00
8b7cb5d9ef
Merge remote-tracking branch 'upstream/develop' into server-detection
2022-07-16 12:44:21 +00:00
cb7f52cc6a
Fixed:
...
- $item is the proper array here,
- see https://github.com/friendica/friendica/issues/11632#issuecomment-1186119430
2022-07-16 12:19:09 +02:00
8db0e090d7
Merge remote-tracking branch 'upstream/develop' into json-ld
2022-07-16 09:33:24 +00:00
8cc362fb8b
Improved JSonLD parsing
2022-07-16 09:25:12 +00:00
abe3fd7605
Improved check for invalid certificates
2022-07-16 08:27:38 +00:00
ce7af4edb8
All these methods need to return an integer (0=Success) or otherwise doExecute()
...
will return NULL.
2022-07-16 08:17:47 +02:00
896fd3fc91
Use the redirect value
2022-07-14 05:39:25 +00:00
a38209db1e
Changed:
...
- added a final check on $link_item, as it might not be initialized or no
record was found, thanks to @AlfredSK for reporting this
- see #11632
2022-07-13 22:05:53 +02:00
4cb5cadba8
Added returned type-int "int"
2022-07-13 21:10:50 +02:00
1d94e2866a
Enable the view module in maintenance mode
...
- This allows to load the default theme CSS
- Theme scripts have been updated to reflect the possibility they will be included in maintenance mode
2022-07-12 19:48:36 -04:00
74c5c66cb5
Add docs
2022-07-13 00:27:39 +02:00
d74e57ef2c
include suggested changes
2022-07-13 00:23:12 +02:00
a910fd8864
Split DBStructure & View to avoid DB-calls and dependencies for basic operations
...
- new "Definition" classes vor DB and Views
- new "Writer" classes to create SQL definitions for DB and Views
- DBStructure & View are responsible to execute DB-querys
2022-07-12 23:40:31 +02:00
8e547510a0
Fix HTTP Client redirect Bug
2022-07-12 20:11:53 +02:00
74991d1f95
Fix type hint typo in Protocol\Email::messageGetPart
...
- Address https://github.com/friendica/friendica/issues/11724
2022-07-11 23:05:13 -04:00
dad05f1c76
Only fetch the first word for the platform
2022-07-10 13:52:38 +00:00
85c7bacb00
Improved server detection
2022-07-10 13:01:47 +00:00
05ed13a279
Merge pull request #11719 from nupplaphil/feat/type_use
...
adhere `use` and type-hints :-)
2022-07-09 17:42:42 -04:00
eb8237dd89
Remove unused uid parameter in Item::newURI
2022-07-09 07:39:51 -04:00
e8fd495847
adhere use and type-hints :-)
2022-07-09 11:41:36 +02:00
96d3b5bcf1
Merge branch 'develop' into feature-optional-network-group-count
2022-07-08 15:35:26 -04:00
e57e1ba1e5
Make network counts at the group level system level configurable
2022-07-08 15:29:34 -04:00
34f2b2f558
Add the right exceptions for BaseUrl::redirect and respect them when catching exceptions at the Trust page
2022-07-07 21:47:39 +02:00
e4a83eafb8
Add a lot of log-points
2022-07-07 21:33:41 +02:00
bf809c9d57
Fixed:
...
> TypeError: "Argument 2 passed to Friendica\Protocol\ActivityPub\Transmitter::sendContactReject()
> must be of the type int, string given
I followed here here the documentation, may fix #11708
2022-07-06 05:43:00 +02:00
4875524101
Fixed:
...
- added exception to prevent `TypeError` because of missing `uri-id` entry
- maybe fixes #11708
2022-07-05 18:53:51 +02:00
cc75eb5d18
Improved server detection
2022-07-05 05:04:05 +00:00
ba33c95e97
Fixes:
...
"Argument 1 passed to Friendica\Content\Text\BBCode::toPlaintext() must be of the type string, null given, called in /var/www/.../htdocs/mod/display.php on line 305"
2022-07-03 14:45:12 +02:00
181c142bb4
Remove overly strict type-hint in ActivityPub\Transmission::createCachedActivityFromItem
...
- Fix "Return value of Friendica\Protocol\ActivityPub\Transmitter::createCachedActivityFromItem() must be of the type array, bool returned" error
2022-07-02 22:16:59 -04:00
e6feed65bf
Rename Smilies::pregHeart to better match its purpose
...
- Fix "Argument 1 passed to Friendica\Content\Smilies::pregHeart() must be of the type string, array given" error
2022-07-02 22:14:20 -04:00
3326c4cb31
Added missing type-hints, #11700
2022-07-01 02:50:34 +02:00
1ee0e6f711
Changes:
...
- no NULL anymore for 2nd parameter OEmbed::toHTML()
- some double-quotes to single
2022-06-30 15:03:12 +02:00
6186aac792
Fixed type-hints
2022-06-30 14:58:45 +02:00
99902bb478
Changes
...
- ops, also this needs change since null is no longer wanted
2022-06-30 14:52:37 +02:00
5c0e8c62de
Changes
...
- renamed Widget::accounttypes() to Widget::accountTypes()
- fixed type-hint the documentation was wrong
2022-06-30 14:50:28 +02:00
83cbe586ac
Changes
...
- renamed Item::visibleActivity() to Item::isVisibleActivity() as this returns
a boolean value
- added some type-hints
- added some documentation
2022-06-30 14:18:13 +02:00
e33f5612ab
Changes:
...
- added some type-hints
- added some documentation
- changed some double-quotes to single
2022-06-27 15:16:18 +02:00
a392a22eee
Changes:
...
- added some type-hints
- fixed some documentation (void is lately returned, not null)
- added some documentation
2022-06-27 15:16:17 +02:00
703ba1439b
Some empty lines
2022-06-27 15:16:17 +02:00
98bc5216ef
A bit more documentation
2022-06-27 15:16:17 +02:00
9871e9718e
Changes:
...
- added some type-hints
2022-06-27 15:16:16 +02:00
6c5acf9ee0
Fixed:
...
- "Argument 3 passed to Friendica\Model\Photo::createPhotoForExternalResource()
must be of the type string, null given
2022-06-27 15:16:16 +02:00
ff9707713b
Fixed:
...
- Friendica\Content\BoundariesPager::renderFull(int $itemCount) must be
compatible with Friendica\Content\Pager::renderFull(int $itemCount): string
2022-06-27 15:16:15 +02:00
8e19998191
Fixes:
...
- more "bool expected but null returned" errors
2022-06-27 13:49:53 +02:00
7c049abfda
Fixed:
...
- Contact/User::isBlocked() needs to return boolean, but sometimes (strangely)
a NULL can come from database, so let's cast it
This tries to fix:
TypeError: "Return value of Friendica\Model\Contact\User::isBlocked() must be of the type bool, null returned"
2022-06-27 11:39:18 +02:00
4bdce6948f
Changed:
...
- $publicContact['about'] can be NULL, causing following error:
--------------------------
Argument 1 passed to Friendica\Content\Text\BBCode::toPlaintext() must be of
the type string, null given, called in /.../src/Object/Api/Twitter/User.php
--------------------------
The "expensive" code there can be avoided being called by an empty string or
NULL to increase performance.
2022-06-26 23:28:48 +02:00
Philipp
e594656a48
Merge pull request #11684 from MrPetovan/bug/11651-ap-fetch-queue
...
Create ActivityPub\FetchQueue and ActivityPub\FetchQueueItem classes
2022-06-26 13:36:19 +02:00
91f5a7cc6b
Convert potential spaces in Memcache(d) key names
...
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1166475036
- Add test for space in cache keys
2022-06-26 07:30:30 -04:00
b67e488236
adaptions
2022-06-26 10:13:32 +02:00
0223c030a9
Improve 2 factor usage
2022-06-25 23:04:00 +02:00
f3de8d7764
improve 2fa token field
2022-06-25 22:48:35 +02:00
759d9d9f1a
Add more 2fa properties
2022-06-25 22:48:34 +02:00
b86ff1e970
Rename 2FA recovery message
2022-06-25 22:48:34 +02:00
da32fa8fa6
Create ActivityPub\FetchQueue and ActivityPub\FetchQueueItem classes
...
- These classes are used to flatten the recursive missing activity fetch that can hit PHP's maximum function nesting limit
- The original caller is responsible for processing the remaining queue once the original activity has been fetched
2022-06-25 12:40:54 -04:00
3c70d592f6
Merge pull request #11689 from Quix0r/rewrites/double-quotes-single
...
Changed more double-quotes to single
2022-06-25 12:02:01 -04:00
e10dd20036
Made @TODO more clear?
2022-06-25 17:58:27 +02:00
a7d49877a8
Centralize share tag attribute extraction code in Content\Text\BBCode
2022-06-25 11:46:52 -04:00
4164cdacf5
Changes:
...
- added type-hints
- added documentation
2022-06-25 16:48:37 +02:00
804b759df1
Changes:
...
- let's get rid of that `Database::exists()` is being misused for checking table existence
- reformatted array
2022-06-25 16:48:37 +02:00
f689faca99
Changed double-quotes to single
2022-06-25 16:48:36 +02:00
88870d18be
Changes:
...
- added some type-hints
- added documentation
2022-06-25 16:48:36 +02:00
39675fe683
Space for the rescue. ;-)
2022-06-25 16:48:35 +02:00
b0693c1ad7
Reformatted array
2022-06-25 16:48:35 +02:00
f12cc9648e
Changes:
...
- added some type-hints
- changed some double-quotes to single
2022-06-25 16:48:35 +02:00
aa133b5437
Add explicit gserver.site_name string truncate in Model\GServer
...
- Avoids "Data too long for column 'site_name'" database errors
2022-06-25 06:25:48 -04:00
a2afb101cd
Fix off-by-one error in Message ID header count check in Util\Emailer
2022-06-25 05:35:24 -04:00
c75dbfd3d7
Update default value for LocalRelationship->priority to avoid null values
...
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1166192993
2022-06-25 05:06:22 -04:00
636b84b41c
Update return value type-hint of GServer::getProtocol
...
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1164880874
2022-06-25 05:06:22 -04:00
c5b46fe748
Merge pull request #11681 from Quix0r/fixes/item-guidfromuri-allow-null
...
Allowing Item::getFromUri()'s 2nd parameter a null value
2022-06-24 10:15:26 -04:00
82bb36e13d
Changes:
...
- Made Item::guidFromUri()'s $host parameter optional (allowing null)
- added some type-hints
- added documentation
- this may fix reported issue in #11630
2022-06-24 03:17:57 +02:00
2dc38e5632
Move documentation :-)
2022-06-23 23:23:36 +02:00
5bf5b5e6c9
adaptions :-)
2022-06-23 23:01:09 +02:00
12ba37e8d2
add more doc
2022-06-23 22:46:46 +02:00
13783089e7
Add copyright
2022-06-23 22:44:17 +02:00
d441b90bda
Respect Forwarded-For headers
2022-06-23 22:42:35 +02:00
657a8a7cb5
Changes:
...
- documented null value
- two ' to much!
2022-06-23 17:30:17 +02:00
202857ba7d
No need to log $tid here
2022-06-23 17:30:17 +02:00
fd8f4269ff
Reformatted code
2022-06-23 17:30:17 +02:00
5699b03e8d
Changes:
...
- added some nodes to OpenSearch descriptor
- still no UTF-8 encoding!
- added some type-hints
2022-06-23 17:30:16 +02:00
a49fb9cbf9
Changes:
...
- added some type-hints
- added documentation
2022-06-23 17:30:16 +02:00
84d3eecc33
Changes:
...
- added some type-hints
- changed double-quotes to single
2022-06-23 17:30:15 +02:00
57e741f2cf
More type-hints added
2022-06-23 17:30:15 +02:00
182c3db9b8
Changes:
...
- added type-hints
- added missing documentation
2022-06-23 17:30:15 +02:00
b8353a6eb7
Changes:
...
- reformatted some array
- added missing documentation
- added type-hints
- changed double-quotes to single
2022-06-23 17:30:14 +02:00
c6c936a80f
Added more type-hints
2022-06-23 17:30:14 +02:00
3f74a59f73
Added some type-hints
2022-06-23 17:30:14 +02:00
69a68be800
Added some missing type-hints
2022-06-23 17:30:13 +02:00
d8ff966d21
Throw IAE again (should never become visible)
2022-06-23 17:30:13 +02:00
35c78ce14c
Ops, cannot return Thread?
2022-06-23 17:30:12 +02:00
c2e26b4f49
Changed:
...
- Introduced InvalidArgumentException (should never come)
- added type-hints
2022-06-23 17:30:12 +02:00
2f3705f471
Continued:
...
- renamed varibales to $camelCase
- added type-hints
- updated documentation
2022-06-23 17:30:11 +02:00
0ddb315b23
$id in Transmitter::sendContactAccept() is a string, see Introduction class
2022-06-23 16:48:00 +02:00
bf600905d3
Merge pull request #11676 from Quix0r/fixes/array-element-missing
...
Maybe this fixes missing array element
2022-06-23 09:06:59 -04:00
636fef26f1
Maybe this fixes missing array element
2022-06-23 07:40:49 +02:00
589d0360a4
So simple ... Ops!
2022-06-23 04:58:45 +02:00
69676c9f7b
Changes:
...
- enabled sub-directories for compiled/cached files which avoids large+slow
directory descriptors
- changed some double-quotes to single
2022-06-23 04:24:55 +02:00
7eefb9aed8
Changed:
...
- empty() is maybe superflous here, still I would prefer a code style that is
written explicitly and not rely on "magic casting"
2022-06-22 18:57:01 +02:00
15d8341d9a
Converted multiple single-comment (//) to multi-line comment block (/* */)
2022-06-22 18:06:35 +02:00
b996712ef7
Images::getInfoFromURL[Cached]() will both return empty arrays on error and
...
that needs to be reflected here, too.
2022-06-22 17:20:59 +02:00
eb231bc548
Fixed: ?? didn't work here as bool won't be seen as null
2022-06-22 17:09:53 +02:00
Philipp
78bf7f187c
Merge pull request #11669 from MrPetovan/bug/11666-email-subject-double-encode
2022-06-22 16:51:23 +02:00
d5441da49a
Fixed:
...
- TypeError: "Argument 1 passed to Friendica\Util\XML::escape() must be of the
type string, null given, called in src/Util/XML.php line 171
2022-06-22 16:20:26 +02:00
101cd2dd10
Changes:
...
- added some documentation
- fixed some documentation
- changed more double-quotes to singl
2022-06-22 16:14:14 +02:00
ba45e59313
Changes:
...
- added more type-hints
- added missing documentation
- Email::send() now returns what mail() returns (bool)
2022-06-22 14:36:48 +02:00
ee8d0ad619
Changes:
...
- added more type-hints
- added some documentation
2022-06-22 14:36:47 +02:00
feec96cbc4
Return empty array on error (I hope it works this way).
2022-06-22 14:36:47 +02:00
2dd7d465e8
Changes:
...
- added more type-hints
- updated documentation
- changed double-quotes to single
2022-06-22 14:36:47 +02:00
74ab7648c6
Changes:
...
- addHubLink()'s 2nd parameter is DOMElement
- added more type-hints
- converted double-quotes to single
2022-06-22 14:36:46 +02:00
12add2fb64
$data can turn into bool here
2022-06-22 14:36:46 +02:00
08f55f0358
Ops, forgot to rename these, too.
2022-06-22 14:36:46 +02:00
abd0d9f3fd
Changes
...
- added type-hints
- added some documentation
- added default: block for unknown 'rel' value
- changed return type void to empty array
2022-06-22 14:36:45 +02:00
dfa95ea58d
Changes:
...
- added type-hints
- added documentation
2022-06-22 14:36:45 +02:00
84bfc37bf1
Changes:
...
- added more type-hints
- added missing documentation
2022-06-22 14:36:45 +02:00
e9f7bb477d
Add expected type-hint to BoundariesPager::renderFull
...
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1162634199
2022-06-22 07:49:45 -04:00
7295138f8d
Remove type-hint inconsistent with expected return value in Database->getVariable
2022-06-22 07:47:15 -04:00
d68f307337
Remove email subject encoding from ItemCCEmail constructor
...
- It was wrongly re-encoded in Emailer::send
2022-06-21 21:12:09 -04:00
2f358607c7
Changes:
...
- renamed Logger::getLogger() to getInstance() (@MrPetovan )
2022-06-22 01:50:10 +02:00
cdcfb4064b
Changes:
...
- added type-hints
- added missing documentation
- renamed Logger::getWorker() to Logger::getLogger() as there is no worker class
returned but the actual (inner) logger
2022-06-21 21:22:16 +02:00
80c8ec17c2
Fixed documentation
2022-06-21 18:43:25 +02:00
0332a57bfd
Rewrote to suggestions from @MrPetovan (I tried to maintain the old way of
...
['scheme' => 'table'] with my version).
2022-06-21 18:13:01 +02:00
5fe428d3e4
Fixed:
...
- PHPUnit\Framework\Error\Notice: Undefined index: language in /.../src/Util/EMailer/MailBuilder.php on line 122
2022-06-21 13:47:40 +02:00
1080a840f5
Changes:
...
- Database->$driver can no longer be NULL, an empty string is fine anyway
2022-06-21 13:47:39 +02:00
945cd1a2c2
Fixed:
...
- since $table can be now schema.table, this needs being taken care off
- maybe this foreach(explode()) is a bit an overkill as only 1 or 2 entries
can be found in it
2022-06-21 13:47:39 +02:00
0d81a08e3c
WIP: Properly some fixes? Also why is DROP VIEW IF EXISTS is being killed?
2022-06-21 13:47:39 +02:00
44a9ec9b17
Rewrite:
...
- avoid having array|string for $table to have a "string" type-hint for $table
- you now have to do it for yourself by giving 'schema.table' as parameter
2022-06-21 13:47:38 +02:00
f62c28008a
Removed comment
2022-06-21 13:47:38 +02:00
cefffde691
Changes:
...
- added type-hints
- added some missing documentation
2022-06-21 13:47:37 +02:00
f1867463a0
Changes:
...
- added more type-hints
2022-06-21 13:47:37 +02:00
77c37ff2db
Fixed:
...
- Uncaught Exception TypeError: "Argument 3 passed to
Friendica\Protocol\DFRN::createActivity() must be of the type string, null
given, called ..."
2022-06-21 13:47:37 +02:00
4650ff53d9
Merge pull request #11662 from MrPetovan/bug/11661-splitattachment-null
...
Ensure parameter 4 of Post\Media::splitAttachment is a boolean value
2022-06-21 06:48:52 +02:00
d2ca812647
Merge pull request #11660 from Quix0r/fixes/more-type-hints-003
...
More type-hints - Batch 003
2022-06-20 21:53:17 -04:00
3e522ed512
Fixed:
...
- prevent NULL from being handled over to XML::escape()
- still I wonder that an object can be? It is a string-only accepting method
2022-06-21 01:42:37 +02:00
95f9eb34ac
Fixed indenting
2022-06-21 01:29:33 +02:00
b6fa022a73
Changes:
...
- added type-hints
- added some documentation
- marked some generic methods to be moved to Util\Strings class instead
2022-06-20 23:50:24 +02:00
fbae0b8bcf
Changes:
...
- renamed ItemArrayFromMail() to getItemArrayFromMail() to follow naming-convetion
- added missing type-hints
- added missing documentation
2022-06-20 21:22:46 +02:00
ea22e88896
Added documentation
2022-06-20 21:02:34 +02:00
752953e472
Changes:
...
- as @MrPetovan pointed out, $actor can be NULL earlier and used later as NULL
- added some missing type-hints
- added missing documentation
- the added @TODO points out to avoid true|false|null for a boolean
2022-06-20 21:00:19 +02:00
88eacbf66e
Ensure parameter 4 of Post\Media::splitAttachment is a boolean value
2022-06-20 14:34:02 -04:00
0c12e947dd
Changes:
...
- null was 2nd argument's value before, an empty string is basically the same here
2022-06-20 20:01:59 +02:00
feb87e8dc3
Changes:
...
- let's start throwing exceptions on e.g. invalid arguments instead of returning
FALSE
2022-06-20 19:09:08 +02:00
4fb03cf163
Changes:
...
- fixed a null value handled over to Friendica\Model\APContact::getByURL()
- added missing type-hints
2022-06-20 19:05:02 +02:00
e96a548286
Changes:
...
- dumped default value for $input
- added unknown 'platform' which prevents an "Undefined index: platform in
/var/www/.../src/Model/GServer.php on line 940" error
2022-06-20 18:56:22 +02:00
6743de63f5
Changed:
...
- DBA::exists() should only be used for checking if records exists.
- if you want to check if a table exists, please ALWAYS use
DBStructure::existsTable() instead
2022-06-20 08:20:07 +02:00
9c80dd35e5
Both declarations must be the same
2022-06-20 08:07:12 +02:00
13a5a30b28
Merge pull request #11659 from MrPetovan/bug/11511-relocate-quote-identifier
...
Add missing identifier quote in Database->replaceInTableFields
2022-06-20 06:26:33 +02:00
cd3b01fd82
Changed:
...
- cannot have type-hints :-(
2022-06-20 03:48:34 +02:00
94a594eeb2
Ops, wrong type-hint
2022-06-20 03:36:36 +02:00
ec96f2252e
Changes:
...
- added type-hints
- added some missing documentation
2022-06-20 03:10:23 +02:00
14bf72e4fe
Changes:
...
- added some documentation
- added type-hints
2022-06-20 02:48:05 +02:00
97904ea7dd
Changes:
...
- added type-hints
- added missing documentation
2022-06-20 02:48:02 +02:00
a0c8fc6d6e
Changes:
...
- added more type-hints
2022-06-20 02:48:02 +02:00
d48e40c1bf
Add missing identifier quote in Database->replaceInTableFields
...
- This caused hyphenated table names to fail the replace query
2022-06-19 20:06:12 -04:00
d276f2c62b
Changes:
...
- added type-hints
- changed some double-quotes to single
2022-06-20 01:00:29 +02:00
622b978a84
Merge pull request #11655 from Quix0r/fixes/more-type-hints-002
...
More type-hints and documentation added
2022-06-19 09:27:29 -04:00
ed3c53a5f8
Ops, not here wanted. :-(
2022-06-19 14:06:32 +02:00
bff57bb030
Changes:
...
- added type-hints
- added returned type-hints in interface (I checked all)
2022-06-19 14:00:31 +02:00
c0d7f8944d
Some calls saved
2022-06-19 11:26:10 +02:00
60f8c2d795
Changes:
...
- added missing type-hints
- added documentation for a method
2022-06-19 10:50:09 +02:00
5792a01a01
Contact::getAccountType()'s parameter is never a string, ops
2022-06-19 09:36:24 +02:00
f3599fa3e9
Changes:
...
- dbstructure(null) is no longer possible, an empty string does it
2022-06-19 09:13:10 +02:00
a063a89c57
Accesskey was used twice
...
The accesskey on the User Settings pages for the _account settings_ and the _two factor authentication_ were the same. This PR is assinging a new one to the 2FA.
2022-06-19 06:30:00 +02:00
b6bfe72083
Wrong returned type, has to be array
2022-06-19 02:40:07 +02:00
7bb0cb5323
Changes:
...
- added more type-hints
- DBStructure::existsTable() does no longer need array support for table name
because this is no longer used (good work!)
2022-06-19 02:11:12 +02:00
2c5685c89c
Changes:
...
- changed to proper "use Foo\Bar;"
- added doctag
- added return type as this is fixed
2022-06-19 01:11:30 +02:00
d7d2ad77ff
Ops, also this!
2022-06-18 23:31:52 +02:00
39f2d197ea
Changed to suggestings (back to original) + fixed typo in scalar type
2022-06-18 23:30:37 +02:00
6f1d52cf71
Changed back to suggestions by @MrPetovan
2022-06-18 23:24:08 +02:00
fa14a02a19
Changes:
...
- added type-hints
- added documentation
- changed double-quotes to single
2022-06-18 23:12:52 +02:00
f3b57008b5
Proper type is string
2022-06-18 18:41:16 +02:00
41f34c4261
Maybe fix for:
...
"Argument 1 passed to Friendica\Model\ItemURI::getIdByURI() must be of the type string, null given, called in Processor.php line 1219"
2022-06-18 18:30:50 +02:00
9691bb06fb
Changes:
...
- added more type-hints
- added missing documentation
2022-06-18 18:21:29 +02:00
94eb426151
Nodeinfo::getOrganization() doesn't need configuration object being inserted
...
when you have DI::config() around.
2022-06-18 17:56:33 +02:00
c29c49797a
Added missing type-hints
2022-06-18 17:52:46 +02:00
4e437190c5
Renamed variable, no need for "orig_" prefix
2022-06-18 17:50:11 +02:00
a1a81cdc6b
Continued:
...
- changed some double-quotes to single
- added missing type-hints
- added missing documentation
- fixed indenting a bit
2022-06-18 17:46:34 +02:00
8fc710f82a
Continued:
...
- added more type-hints
- added some missing documentation
- Return the result from DBA::delete() to let other methods know about it
2022-06-18 17:22:50 +02:00
8ba3f13fae
Changes:
...
- added more type-hints
- added missing documentation
2022-06-18 17:09:46 +02:00
7ec07178c8
Changes:
...
- added missing type-hints
- added missing documentation
2022-06-18 16:59:23 +02:00
8756d92316
Continued:
...
- prevents a "Return value of Friendica\Core\Worker::workerProcess() must be of the type array, bool returned"
2022-06-18 15:57:31 +02:00
bd3a7b9877
Ops, needs to be a variable:
...
Error: "Cannot pass parameter 2 by reference" at /var/www/.../src/Module/DFRN/Poll.php line 36
2022-06-18 09:59:19 +02:00
69cda4f760
Fixed TypeError: "Argument 1 passed to Friendica\Core\System::httpExit() must be
...
of the type string, null given, called in /var/www/.../src/Module/DFRN/Poll.php
on line 37"
2022-06-18 05:42:02 +02:00
7cbb818c93
Set type-hint for parameter $data to SimpleXMLElement as $fields in dispatch()
...
is the same and being handled over.
2022-06-18 05:19:24 +02:00
89302d0843
Some outside code relies on returned "false"
2022-06-18 05:06:18 +02:00
aaf5c323b6
Fixed indenting
2022-06-18 05:04:14 +02:00
adb4aea6ad
Changes:
...
- added some type-hints
- replaced most double-quotes (only Diaspora.php, later more) with single
- added some documentation
- normalized indenting in Diaspora.php (I hope I got all?)
2022-06-18 05:03:10 +02:00
88c40f3336
Ops, wrong type again
2022-06-17 17:18:31 +02:00
a770634b95
Ops, wrong type
2022-06-17 17:18:31 +02:00
36d56a4041
Continued:
...
- changed back to 'return false;' as other methods heavily rely on false instead
of an empty array as pointed out by @heluecht@pirati.ca
- $fetched_contact should be initialized as an empty array, let's not make this
code more crazier than it already is (see APContact::getByURL())
2022-06-17 17:18:31 +02:00
c467bff79f
Some more type-hints added
2022-06-17 17:18:31 +02:00
4f3321cc9f
Nore fixes
2022-06-17 17:18:31 +02:00
10bb7d5625
Possible fix for
...
Uncaught Exception TypeError: "Return value of
Friendica\Model\APContact::getByURL() must be of the type array, bool returned"
2022-06-17 17:18:31 +02:00
fdd237a090
Fix for "Uncaught Exception TypeError: "Argument 1 passed to
...
Friendica\Model\APContact::unarchiveInbox() must be of the type string, null
given" error message
2022-06-17 17:18:31 +02:00
605e7d55b3
Continued:
...
- added more type-hints
- some methods in Diaspora returned void but integer was documented so I
changed it to -1 to have a proper type-hint
2022-06-17 17:18:31 +02:00
0c9aff8a09
Also need to declare $profile or otherwise an invocation of
...
Receiver::getReceiverForActor() will fail.
2022-06-17 17:18:31 +02:00
af8cd5ca86
Worker::getWaitingJobForPID() can also return FALSE on failure ... :-(
2022-06-17 17:18:31 +02:00
227bab43a8
Ops, wrong type-hint here, must be string ($nickname can never be an integer).
2022-06-17 17:18:31 +02:00
f7c1eaa858
Continued:
...
- added type-hints
- removed out-dated documentation
- added some missing documentation
2022-06-17 17:18:31 +02:00
e484b6d6dc
Continued:
...
- added more type-hints
- added some documentation
- Contact::getAccountType() should only process string, not null
2022-06-17 17:18:31 +02:00
45b5f67bca
Fix for non-existing record system.mobile_theme in config table
2022-06-17 17:18:31 +02:00
5c9ce790bf
Fixed:
...
- $object_data['actor'] can be null, but Receiver::getReceivers()'s 2nd
parameter expect it to be string
2022-06-17 17:18:31 +02:00
33768ea1c6
Some fixes:
...
- $gsid's default value cannot sadly be 0, it now must be null to allow some
code work
- added some more type-hints
- documented a bit more
2022-06-17 17:18:31 +02:00
4e53666c70
Added more type-hints
2022-06-17 17:18:31 +02:00
7560dccc08
Added again more type-hints
2022-06-17 17:18:31 +02:00
2766c7d9cf
Continued:
...
- added more type-hints
- added some missing documentation
2022-06-17 17:18:31 +02:00
a587217f47
Fixed "Argument 4 passed to Friendica\Protocol\DFRN::processVerbs() must be of the type bool"
2022-06-17 17:18:31 +02:00
dd54e52575
MrPetovan brought the right one up:
...
> Since this is depending on remote systems, the log can quickly fill with unactionable messages.
2022-06-17 17:18:31 +02:00
c351099c5a
Ops, bad type-hint here
2022-06-17 17:18:31 +02:00
2c5595c358
Another incompatible method declaration fixed + type-hints added
2022-06-17 17:18:31 +02:00
40d7f29a11
Continued:
...
- more type-hints
- fixed incompatible method declarations
2022-06-17 17:18:31 +02:00
1edc6b3c3b
Added more type-hints for "App" classes
2022-06-17 17:18:31 +02:00
42b04f397b
Added more type-hints
2022-06-17 17:18:31 +02:00
aa5f0d5ec1
Added more type-hints and documented a few methods
2022-06-17 17:18:31 +02:00
97e27cb523
Added more type-hints
2022-06-17 17:18:31 +02:00
c2e889cfae
Added more type-hints
2022-06-17 17:18:31 +02:00
5106bb2881
Added parenthesis
2022-06-17 09:41:11 +02:00
a903dbd77e
Wrong braces causing 'undefined index causer-id'. See #11632
2022-06-16 23:00:16 +02:00
6035de6883
Continued:
...
- added more type-hints
- also cannot return FALSE when array is set
2022-06-16 19:06:41 +02:00
51a7b5c584
Made also this one sweeter (null-coalscing)
2022-06-16 17:36:47 +02:00
0e1f734b03
Also make this null-coalscing
2022-06-16 17:35:01 +02:00
e8fee5644b
Ops, syntax errors get unnoticed with a simple editor. :-(
2022-06-16 17:10:02 +02:00
624e4c192c
Changed to null-coalscing style (??) as sugguested by @MrPetovan
2022-06-16 16:59:54 +02:00
962b06bf41
Added check as suggested by @MrPetovan for empty $message.
2022-06-16 16:54:51 +02:00
f2b7326650
This will 2 things:
...
1) The first change prevents "expensive" code in HTML::toBBcode() to be executed
just for an empty string which makes no sense.
2) The above change was maybe flawed as $apcontact['about'] would have never
been created, not even empty which could have side effects
Thanks to @annando to make me rethink this part of code.
2022-06-16 16:54:50 +02:00
7814ba4fc4
Fixes for bad invocations of HTML::toBBCode() (1st parameter is now string)
2022-06-16 16:54:50 +02:00
b200874f17
Ops:
...
- wrong way around (!empty($foo)) is proper
- also needed to be checked on $acitivty['content']
2022-06-16 16:54:50 +02:00
b1e4c0931a
Fixes and type-hints:
...
- added more checked type-hints as they prevent bad method invocations
- fixed TypeError for HTML::toBBCode() invocations with NULL as first (wrong)
argument, thanks to @tobias@social.diekershoff.de pointing this out.
2022-06-16 16:54:49 +02:00
