458981f75c
Replace x() by isset(), !empty() or defaults()
...
- Remove extraneous parentheses around empty() calls
- Remove duplicate calls to intval(), count() or strlen() after empty()
- Replace ternary operators outputting binary value with empty() return value
- Rewrite defaults() without x()
2018-11-30 09:06:22 -05:00
167ff0eb71
Making the tests happy
2018-11-24 09:01:10 +00:00
586c7fb29a
Fixing redirection problems with parameters
2018-11-24 00:27:00 +00:00
0937c66484
A redirect is not an error
2018-11-12 04:12:36 +00:00
de0ddfa0d8
Fix wromg server detecting / improved Pleroma version numbers
2018-11-11 21:54:50 +00:00
1892462920
Fix formatting in Probe::uri
2018-11-10 08:24:53 -05:00
94a71d9ffc
Honor preference order in webfinger links
2018-11-10 08:23:11 -05:00
10a8be7943
Accept URLs with no trailing slash in Probe::uri
2018-11-10 08:22:47 -05:00
Adam Magness
218f0734be
Rename removeTags to escapeTags
...
rename function and update calls.
2018-11-09 13:29:42 -05:00
Adam Magness
ffc406d819
normalise_link calls
...
implement normaliseLink function
2018-11-08 11:28:29 -05:00
Adam Magness
6fc9c6de3b
base64url calls
...
implement base64UrlEncode and base64UrlDecode functions
2018-11-08 10:37:08 -05:00
Adam Magness
a0f65ca7a1
notags calls
...
implement removeTags function
2018-11-08 10:14:37 -05:00
Adam Magness
991f259ecb
random_string calls
...
implement getRandomHex function
2018-11-08 08:45:46 -05:00
Adam Magness
50da89d861
Logger Levels
...
update logger levels in calls
2018-10-30 09:58:45 -04:00
Adam Magness
14fde5dc9b
Log function
...
implement log() function.
2018-10-30 09:57:14 -04:00
cb75c40f4e
adapted profile pic resize to 300px for whole system
2018-10-23 16:36:57 +02:00
4392858662
Move Global Functions - Part 3
...
- Replaced every CACHE definition
- Moved check_url to App->checkURL()
- Removed unused definition "ZCURL_TIMEOUT"
2018-10-20 18:19:55 +02:00
0de1351a09
Fix notices in Network\Probe
2018-10-15 23:12:29 -04:00
b099cba4b4
CurlResult Tests & RegEx fix
2018-10-11 22:18:27 +02:00
00bf0c24b6
CurlResult Tests
2018-10-11 21:19:38 +02:00
a95e7f6504
Bugfixing CurlResult
2018-10-11 07:45:04 +02:00
9711581d49
Code standard
2018-10-10 22:51:26 +02:00
b2e7ce47b3
Renaming Curl to CurlResult
2018-10-10 22:08:13 +02:00
ffbc688797
Curl Response Refactoring
...
- refactored Network::getCurl()
- replaced every Network::getCur() execution with a Curl Response
2018-10-10 21:50:13 +02:00
2dec8895a9
Curl Response Refactoring
...
- extended Curl to parse Curl Response
- refactored Network::curl()
- replaced every Network::curl() execution with the new Curl container
2018-10-10 21:08:43 +02:00
5a02e39a65
Rename App Methods
...
- renamed a lot of App methods to CamelCase
- replaced direct public variables with get-/set-Methods
2018-10-10 00:16:06 +02:00
82987d018a
Some changes for better code quality
2018-09-30 07:21:57 +00:00
a56565fa99
AP is enabled for all users
2018-09-22 23:49:27 +00:00
f20bed67a9
Table "apcontact" is now in use / added functionality to handle JSON-LD
2018-09-20 05:00:49 +00:00
e45206ae5d
Merge remote-tracking branch 'upstream/2018.08-rc' into ap1
2018-09-15 20:49:46 +00:00
61e2c7d20d
Added AP to many network conditions / enabling inbox processing
2018-09-14 16:51:32 +00:00
7b45bdea17
Preparation for adding more networks there
2018-09-13 22:12:33 +00:00
c2f6b166c7
We now use the regular probing function
2018-09-13 21:57:41 +00:00
8b96a53fba
Burn notices, burn
2018-09-11 04:10:11 +00:00
df3b1be3b7
Merge pull request #5679 from annando/neverending-notices
...
The neverending story of removing notices continues ...
2018-08-27 09:12:38 +02:00
8d911b1465
The neverending story of removing notices continues ...
2018-08-27 05:37:10 +00:00
2079caea14
Issue 3501: Mail contacts can be added again
2018-08-26 19:49:39 +00:00
82d097879b
Oh no ... there are still some notices that want to be removed ...
2018-08-24 11:09:58 +00:00
Michael Vogel
54aee2aaa7
Removed notices that revealed themselfes over night ... ( #5645 )
...
* Removed notices that revealed themselfes over night ...
* And more notices removed that occured over night
* One more ..
* Some more notices of the day ...
2018-08-21 17:35:09 +02:00
Michael Vogel
7f3fb34c24
Some easy to replace "q" calls have been replaced by "DBA" calls ( #5632 )
...
* Some easy to replace "q" calls have been replaced by "DBA" calls
* Simplified the GUID creation
* And one in the API ...
* And OStatus has got some DBA calls more
* Just some more replaced database calls
* The event query is now simplified
* Events are now shown again
* subthread is now using the DBA calls as well
* Some more replaced database calls
* And some more replaced database calls and prevented notices
* Better use gravity
* Some more replaced database stuff
* Some more replaced database calls in DFRN.php
* The gcontact class now has got the new DBA functions as well
* The Contact class is now changed to new database functions as well
* Small correction
* We can now delete without cascade
* One more functionality is safe for future changes
2018-08-19 12:46:10 +00:00
0342f9e084
Removed notices, will it ever end?
2018-08-17 03:19:42 +00:00
Michael Vogel
1283b99c6f
Removed notices in the frio theme ( #5610 )
...
* Removed notices in the frio theme
* And fixed notices in the notifications
* And some more in frio
* Null is the default value
* And some small notice in the probing removed
* Added note
* Clarified note
* And a removed notice in OStatus
2018-08-14 19:37:44 +00:00
Roland Häder
e06fc2aa69
Stopped using deprecated constants NETWORK_* ( #5537 )
...
* Rewrite:
- stopped using deprecated NETWORK_* constants, now Protocol::* should be used
- still left them intact for slow/lazy developers ...
* Removed deprecated NETWORK_* constants as per code reviewer's request.
2018-08-11 22:40:44 +02:00
Michael Vogel
65d752d03c
Notices what else? ( #5545 )
...
* Poco isn't filled, so we cannot store it
* We should initialize our variables
2018-08-02 16:11:21 +02:00
Michael Vogel
c72c64a6d8
Notices again ( #5543 )
...
* And again notices
* Notices in the directory
* Much more places
* Fix some double $
* Notice in ping
* Missing field
* Fix: We now remove deleted users from the directory
* Some more stuff
* Notices when removing users
* Added logging
* More logging
* Two more
2018-08-02 07:21:01 +02:00
Michael Vogel
1afc0ab028
Added logging and one more reason for a notice found ( #5538 )
...
* Added logging and one more reason for a notice found
* And one more
2018-08-01 08:47:18 +02:00
Roland Häder
4a22710b3b
Moved global PAGE_* to Profile class ( #5500 )
...
* Rewrites:
- moved PAGE_* to Friendica\Model\Profile class
* Fixed more rewrites from plain (global namespace) PAGE_* to Friendica\Models\Profile class
* CR request:
- moved all PAGE_* constants to Friendica\Model\Contact class
- fixed all references of both classes
* CR request:
- moved ACCOUNT_TYPE_* constants from boot.php to Contact::ACCOUNT_TYPE_*
* Just copy-pasted this code from boot.php, needs to be changed to `const ACCOUNT_TYPE_FOO = x;`
* Ops, melting brain cells here ... :-/
2018-07-27 19:25:57 -04:00
Roland Häder
37253656e3
Moved CONTACT_* constants to Friendica\Model\Contact class, lesser in global namespace ( #5490 )
...
* Rewrite:
- moved all CONTACT_* constants from boot.php to Contact class
* CR request:
- renamed Contact::CONTACT_IS_* -> Contact::* ;-)
2018-07-24 22:53:46 -04:00
Hypolite Petovan
ecea7425f8
Rename DBA::is_result to DBA::isResult
2018-07-23 11:04:14 -04:00
Hypolite Petovan
0ec44f3e8a
Rename DBM method calls to DBA method calls
2018-07-23 11:02:24 -04:00
Hypolite Petovan
8ddb94ef06
Use DateTimeFormat::utc() instead of DBM::date()
2018-07-23 10:57:47 -04:00
Hypolite Petovan
4db98eb43d
Rename DBA::inArray to DBA::toArray
2018-07-22 19:27:35 -04:00
Michael Vogel
7382be2766
Some more notices ( #5424 )
2018-07-20 14:07:54 -04:00
Hypolite Petovan
af6dbc654f
Rename Friendica\Database\dba to Friendica\Database\DBA
2018-07-20 08:19:26 -04:00
5c63de1692
Just some more fixed notice
2018-07-20 05:31:26 +00:00
9a6a3bf1c1
Makes Diaspora working again
2018-07-20 05:10:16 +00:00
Hypolite Petovan
daa1177e3a
Update use statement lists with new Friendica\Database\dba class
...
- Remove unused use statement
- Remove superfluous use statements (classes in the same namespace)
- Add missing use statements
2018-07-19 22:15:21 -04:00
Michael Vogel
d3a2ed85fe
Next item structure works ( #5380 )
...
* Use "LEFT JOIN" to always fetch the item. Needed for update routines.
* New conversion routine that now covers every item
* Post update is now activated
* We now use a hash based upon RIPEMD-320 for content and activity
* The hash doesn't contain the plink anymore
* Legacy item fields are now "null"able
* New hash function for a server unique item hash
* Introduction of the legacy mode (usage of old item fields)
* Code simplification
* We don't need the "uri" fields anymore in item-activity and item-content
* Use the "created" and not the "received" date for the hash
* Avoiding several notices
* Some more warnings removed
* Improved uri-hash / Likes on Diaspora are now getting a creation date
* Corrected the post update version
* Ensure an unique uri-hash
* Don't delete orhaned item data at the moment
* Partly reworked, due to strange behaviour
* Some more parts reworked
* Using the uri currently seems to be more reliable
* Using the uri here as well
* Use the hash values again
* Grouped item fields in different categories
* Notices again
* use the gravity (we always should)
* Added hint for disabled post updates
* Notices ...
* Issue #5337 : Personal notes are displayed again
* Use the gravity again
2018-07-15 14:36:20 -04:00
Michael Vogel
0360f7197a
Several more warnings ... ( #5340 )
...
* Some more warnings removed
* Even more warnings ...
* Will it ever end? ;-)
* Avoid warning in dbstructure
* Origin and OStatus ...
* There are more warnings solved ... yeah!
* And again ...
* We are not done yet
* And more ...
* And some new places ...
* And more in the feeds
* Avoid some more
* And some backend stuff
* Notifications cleared
* Some more stuff
* and again ...
* It's getting fewer ...
* Some warnings had been hidden in the notifications
* Fix the fix
* And another missing one ...
* We need the owner here, not the user
* Forgotten user
* And more ...
* And some more warnings disappeared ...
* Some more frontend warnings
* Some backend warnings removed
* Fixed sidebar for "vier"
* And more ...
* Some more ...
* And something for "remote self"
* Am I stuck in an endless loop?
* Fix: Clear tag and file field on update
* Preset page content
2018-07-10 08:27:56 -04:00
Hypolite Petovan
6776c4e3f9
Fix some undefined variable/index notices in tests
2018-07-02 07:44:55 -04:00
8d8f2a1845
Change the community value as well
2018-05-11 08:04:01 +00:00
78271e88f5
Insert a gcontact on probing, but not insert a contact
2018-05-11 05:44:31 +00:00
08bfced11b
"pending" shouldn't be set as well by default ...
2018-05-03 18:19:40 +00:00
bce3b6f896
Urgent bugfix: Public contacts had been blocked automatically when created
2018-05-03 17:43:10 +00:00
1a8d0a573e
Bugfix: Contact wasn't added on probing
2018-04-30 16:45:00 +00:00
Hypolite Petovan
d419d07f73
[Scrutinizer] Fix undeclared variables in src/ (except Protocol/)
...
- Use dba::selectFirst to remove intermediate variables `$r`
- Remove unused variable `$url_recipients` in Worker\Dellivery
2018-02-14 00:05:00 -05:00
6a486aa92b
Remove address from name
2018-02-13 07:10:05 +00:00
7df60ae634
Improved profile probing for pump.io
2018-02-13 05:54:09 +00:00
15a857e411
Line endings are converted to unix style
2018-02-09 03:49:49 +00:00
rabuzarus
984bb2a808
Bugfix: Probe - get the contact address from xrd 'subject' key
2018-02-05 21:27:40 +01:00
Hypolite Petovan
5e7285b9ba
Move Temporal::convert() to DateTimeFormat::convert()
2018-02-03 08:56:55 -05:00
Hypolite Petovan
8aff8a76eb
Add Temporal::utcNow()
2018-02-03 08:56:52 -05:00
Hypolite Petovan
dc366bf1f7
Refactor datetime_convert into Temporal::convert
...
- Changed parameter order to save space
- Refactor select_timezone into Temporal::getTimezoneSelect
- Refactor field_timezone into Temporal::getTimezoneField
2018-02-03 08:56:51 -05:00
02ed22ba43
We now support querying nodeinfo 2.0
2018-02-02 13:53:40 +00:00
Hypolite Petovan
13849299f9
Remove require calls to library/OAuth1
2018-01-31 00:49:11 -05:00
Adam Magness
f04d40a37e
Review update
...
Rename function, move others
2018-01-27 11:13:41 -05:00
Adam Magness
0f1be37279
Remove old file
...
remove network.php and all require_once statements
2018-01-27 08:28:20 -05:00
Adam Magness
ca76e49c23
Move remaining functions
...
update remaining function calls
2018-01-27 08:25:54 -05:00
Adam Magness
1eb7c19c1e
Move multiple functions
...
move multiple smaller functions
2018-01-26 23:51:41 -05:00
Adam Magness
2f9642392d
Move z_fetch_url
...
move z_fetch_url method
2018-01-26 23:18:38 -05:00
Adam Magness
6c4c567319
Remove require
...
remove require_once for plugins.php
2018-01-20 07:48:22 -05:00
Adam Magness
11cf36105c
Update Addon functions and calls
...
Update function names and calls for Addon class.
2018-01-20 07:48:22 -05:00
Hypolite Petovan
e36f2bb1fb
Use short form array syntax everywhere
...
- Add short form array syntax to po2php.php generation
2018-01-15 14:07:17 -05:00
Hypolite Petovan
04481087a9
Delete unused library/oauth2-php library
2018-01-14 19:33:47 -05:00
Hypolite Petovan
5fc4927764
Improve dba::selectFirst calls
...
- Fix remaining $r[0] references
- Rename $r to meaningful names
2018-01-11 03:43:57 -05:00
Hypolite Petovan
ae66bcaff3
Rename selectOne to selectFirst
2018-01-10 12:57:21 -05:00
Hypolite Petovan
da60893590
Replace dba::select(limit => 1) by dba::selectOne
...
- Convert array declarations to new style
2018-01-10 12:57:21 -05:00
Hypolite Petovan
9f04017e27
Quick fix PHP notices in various files
...
- Remove unused variables
- Fix variable name typos
- Use x() and defaults() to fix undefined index
- Add back uninitialized variables
2018-01-02 08:11:14 -05:00
Adam Magness
9e6bf79380
Crypto to src
...
move Crypto to src and Friendica\Util namespace
2017-12-30 11:51:49 -05:00
Hypolite Petovan
910d3f7b5f
Formatting FKOauthDataStore
2017-12-17 15:34:29 -05:00
Hypolite Petovan
2978b1eef0
Fix undefined variable/wrong parameter count/unknown functions
2017-12-17 15:33:45 -05:00
Hypolite Petovan
10b72b0e9e
PHPStan: Fix missing requires/namespaces
2017-12-17 15:26:43 -05:00
44679a73b7
Bugfix for "Call to undefined function Friendica\Network\rsatopem()"
2017-12-13 10:34:51 +00:00
84b85e9198
Removed old include
2017-12-13 07:06:36 +00:00
fc55a4b9c0
The feed moved into the new location
2017-12-13 07:02:52 +00:00
Hypolite Petovan
6b60b89385
Move Object\Profile to Model\Profile
2017-12-07 23:55:05 -05:00
Michael Vogel
5747cfc79c
Revert "Move Objects to Model"
2017-12-08 05:21:51 +01:00
Hypolite Petovan
d4ca30a6db
Move Object\Profile to Model\Profile
2017-12-07 08:57:35 -05:00
Adam Magness
cadfef63c4
Update false evaluations
...
=== false and !== false to is_null where appropriate.
2017-12-06 14:57:06 -05:00
Adam Magness
22a3c7ad7d
remove index
...
remove unneeded index
2017-12-05 06:58:57 -05:00
Adam Magness
e32b4ed670
More use
...
more missing use
2017-12-04 21:18:48 -05:00
Adam Magness
f1a5560804
Use statement
...
missing use
2017-12-04 21:13:58 -05:00
Adam Magness
e997128c9f
Static
2017-12-04 21:03:39 -05:00
Adam Magness
448598495c
Static
...
remove static
2017-12-04 21:00:47 -05:00
Adam Magness
9f4be62d3d
Use statement
2017-12-04 20:30:10 -05:00
Adam Magness
547e24b443
Review
...
updates based on review.
2017-12-04 16:33:10 -05:00
Adam Magness
2bbfc0640f
Move to Network
...
Move to network namespace. Get rid of q() and try to get used to [ ] instead of array()
2017-12-04 15:59:21 -05:00
Adam Magness
9a4e741d1a
Review Changes
...
renamed some functions and adjusted corresponding calls.
2017-12-01 21:05:06 -05:00
Adam Magness
6008e3df11
Email to src
...
Create Email class and update/rename functions and function calls.
2017-12-01 14:41:27 -05:00
Hypolite Petovan
365850f26a
Fix httpdesc to work with new namespace
2017-11-23 23:47:52 -05:00
Hypolite Petovan
b41bf77ec8
Add HTTPException class files
2017-11-23 23:40:54 -05:00
Adam Magness
ddacbf2c13
XML class standards
...
updated the xml class for PSR-2
2017-11-20 12:56:31 -05:00
Adam Magness
1115d19f79
More Standards
...
More coding standards updates.
2017-11-20 11:01:32 -05:00
Hypolite Petovan
ec02af593d
Change called method names
...
- Add GlobalContact::getRandomUrl
- Rename Contact::getIdForURL
- Rename Diaspora::sendUnshare
- Remove unused parameter $self in Contact::terminateFriendship
2017-11-19 17:03:39 -05:00
Hypolite Petovan
b92fc24ff0
Add Contact Object
...
- Add Profile Object
- Add User Model
- Add use statements
2017-11-19 16:55:28 -05:00
Adam Magness
bc49fc974c
Capitalized XML
...
Acronym classes should be capitalized
2017-11-10 07:45:33 -05:00
Adam Magness
f245bc8359
Move xml to namespace
...
Relocate xml from include to src
Related to #3878
2017-11-10 07:18:24 -05:00
Adam Magness
06c3af9b60
Move Cache to src
...
relocate the cache class to Friendica\Core namespace
2017-11-09 11:05:18 -05:00
Adam Magness
4ca68c7af0
Class file relocations
...
Issue #3878
2017-11-08 08:37:03 -05:00
Adam Magness
6189f6c8e7
Relocate class files from /include to /src/
...
dbm, Diaspora, dfrn, and NotificationsManager moved to namespace. Includes and references in files updated.
2017-11-08 08:36:48 -05:00
Adam Magness
1a83b80dbd
Review Updates
...
Reverted changes made to .sql file and Errant use statement in Probe class.
2017-11-07 06:43:34 -05:00
Adam Magness
0dfa57948f
Issue-#3873
...
Replace deprecated functions with new syntax.
2017-11-07 06:24:39 -05:00
e2224a2ddc
Some Webfinger clean up
2017-10-28 11:48:29 +00:00
0b7e8b7fb4
Hubzilla doesn't return the handle in the hcard
2017-10-27 06:17:24 +00:00
d72e6b2c82
Bugfix for better mail import
2017-09-23 22:53:44 +00:00
78d4386332
We are now probing differently for webfinger data
2017-09-04 19:13:33 +00:00
1cc50a80f4
Only update if there is a change
2017-08-30 19:33:16 +00:00
0083c16e87
Better updating of contacts
2017-08-30 18:05:41 +00:00
4bc2076763
Avoid warnings from probe
2017-08-29 04:51:02 +00:00
5adfeb0bd5
App::get_baseurl is now replaced with System::baseUrl
2017-08-26 07:32:10 +00:00
3c24bed412
New class "System"
2017-08-26 06:04:21 +00:00
c09c806f78
Probing sometimes failed / problems with some web servers
2017-08-24 07:56:46 +00:00
51dca9b034
Compatibility with pleroma added
2017-08-21 20:21:04 +00:00
7052da745c
Issue 3615: Probing sometimes returned an empty "addr" field
2017-08-11 21:50:46 +00:00
rabuzarus
28eb5d57a7
fix some method names (camelcase) in Probe.php and Lock.php
2017-08-02 13:09:42 +02:00
955229e131
Fix incomplete webfinger data for OStatus
2017-07-25 21:46:14 +00:00
41ec057813
Avoid "Invalid argument" warning in probing.
2017-07-11 17:34:38 +00:00
363322ba78
Issue 3571 and Diaspora mail bugfix
2017-07-10 22:35:32 +00:00
Hypolite Petovan
9c0d2c31e8
Replace AND and OR in PHP conditions by && and ||
2017-06-07 22:00:59 -04:00
609649557b
Better handling of timeout issues while probing
2017-05-31 03:46:43 +00:00
a32de855cc
Don't quit if the own host cannot be reached via SSL
2017-05-29 19:14:44 +00:00
860887557a
Some more logging for the probing
2017-05-28 05:38:12 +00:00
07e318e991
some more logging
2017-05-23 20:19:39 +00:00
Hypolite Petovan
39f894bd4a
Use use instead of \
2017-05-11 11:53:04 -04:00
f6fe11ff49
Small bugfix for PR 3454
2017-05-08 20:01:18 +00:00
rabuzarus
3d5ff8bab3
remove use of PConfig Class from Probe class because we don't use it here
2017-05-08 19:04:01 +02:00
rabuzarus
8a2ffffe71
Bugfix: correct uninitialized variables
2017-05-08 19:02:34 +02:00
rabuzarus
035c79f355
add some spaces for better readability
2017-05-08 18:28:30 +02:00
rabuzarus
8830d20ed0
rename some variables for comprehensibility
2017-05-08 18:07:06 +02:00
rabuzarus
51372bc314
improve readability
2017-05-08 17:36:04 +02:00
rabuzarus
450a4920fd
apply coding standard
2017-05-08 17:06:57 +02:00
rabuzarus
cc8a3a4101
rename methods of the Probe class to camelCase
2017-05-08 16:19:10 +02:00
a8caeefb52
And even more global classes ...
2017-05-07 22:21:12 +00:00
Hypolite Petovan
f123f6df10
Yet more global classes to escape
2017-05-07 18:12:26 -04:00
Hypolite Petovan
36e515ee6d
Move Probe to src
2017-05-07 14:44:30 -04:00
