Hypolite Petovan MrPetovan
MrPetovan closed pull request friendica/friendica-addons#1628 2025-12-21 06:08:39 +01:00
Removing incorrectly copied files
MrPetovan commented on pull request friendica/friendica-addons#1628 2025-12-21 06:08:37 +01:00
Removing incorrectly copied files

This PR seems to be about an addon that hasn't been merged yet, please address my comment in #1629 first.

MrPetovan closed pull request friendica/friendica-addons#1629 2025-12-21 06:06:17 +01:00
loma-one-patch-1
MrPetovan commented on pull request friendica/friendica-addons#1629 2025-12-21 06:06:15 +01:00
loma-one-patch-1

Thank you for your work! Please create a separate pull request for each addon, and clean up the icons folder that is committed at the root of addons.

MrPetovan pushed to 2025.07-rc at friendica/friendica-addons 2025-12-16 16:02:58 +01:00
fb0816eb39 Merge pull request 'New converse.js based XMPP addon' (#1621) from heluecht/friendica-addons:xmpp-converse into 2025.07-rc
f31047f3c8 XMPP addon is created
Compare 2 commits »
MrPetovan merged pull request friendica/friendica-addons#1621 2025-12-16 16:02:57 +01:00
New converse.js based XMPP addon
MrPetovan pushed to 2025.07-rc at friendica/friendica-addons 2025-12-16 15:58:57 +01:00
51c0b11287 Merge pull request 'Fix PHPStan error' (#1625) from heluecht/friendica-addons:phpstan into 2025.07-rc
b060be281f Fix PHPStan error
Compare 2 commits »
MrPetovan merged pull request friendica/friendica-addons#1625 2025-12-16 15:58:56 +01:00
Fix PHPStan error
MrPetovan approved friendica/friendica-addons#1625 2025-12-16 15:58:41 +01:00
Fix PHPStan error
MrPetovan pushed to 2025.07-rc at friendica/friendica-addons 2025-11-12 14:36:37 +01:00
9b3278ffd9 Merge pull request 'add messages.po file for ratioed addon' (#1618) from mexon/friendica-addons:mat/ratioed-translation into 2025.07-rc
427f39ad57 add messages.po file for ratioed addon
Compare 2 commits »
MrPetovan merged pull request friendica/friendica-addons#1618 2025-11-12 14:36:34 +01:00
add messages.po file for ratioed addon
MrPetovan pushed to mat/ratioed-translation at mexon/friendica-addons 2025-11-10 07:27:38 +01:00
427f39ad57 add messages.po file for ratioed addon
0562623117 Merge pull request 'Update Link to Transifex Friendica page' (#1617) from haheute/friendica-addons:update-transifex-url into 2025.07-rc
8d42f99aff Update Link to Transifex Friendica page
Compare 3 commits »
MrPetovan pushed to mat/ratioed-translation at mexon/friendica-addons 2025-11-08 19:55:36 +01:00
6bfa3da4d5 add messages.po file for ratioed addon
6a342088a5 Merge pull request 'Avoid sending group posts through connectors' (#1615) from heluecht/friendica-addons:no-group-posts into 2025.07-rc
6dcf3cbf5c Avoid sending group posts through connectors
28fcccd9d5 Merge pull request 'Fix several warnings' (#1613) from heluecht/friendica-addons:warnings into 2025.07-rc
1cc54a83a9 Fix several warnings
Compare 11 commits »
MrPetovan commented on pull request friendica/friendica-addons#1618 2025-11-08 19:54:34 +01:00
add messages.po file for ratioed addon

@tobias Is Transifex going to pick this file up automatically?

MrPetovan suggested changes for friendica/friendica-addons#1603 2025-03-13 16:08:01 +01:00
PHPStan level 3
MrPetovan commented on pull request friendica/friendica-addons#1603 2025-03-13 16:08:01 +01:00
PHPStan level 3

Please change \Friendica\Protocol\ATProtocol\Processor::fetchUriId to always return an integer. This is what the method is expected to do.

MrPetovan commented on pull request friendica/friendica-addons#1603 2025-03-13 16:08:01 +01:00
PHPStan level 3

Instead of checking for this, $recipients should be assigned the result of DBA::toArray(DBA:p(...)) in order for the later foreach() to be valid. Normally, the DBA::p output requires the use of DBA::fetch() in a loop.

MrPetovan commented on pull request friendica/friendica-addons#1603 2025-03-13 16:08:01 +01:00
PHPStan level 3

parse_url() only returns an integer for the port key, this is superfluous.