tobias/friendica
1
0
Fork 0
Code Pull requests Activity
27722 commits 2 branches 61 tags 203 MiB
Commit graph

5833 commits

Author SHA1 Message Date
Hypolite Petovan 1a385153f8
Merge pull request #8895 from annando/performance 
Database performance updates
 2020-07-18 21:05:56 -04:00
Michael Vogel ea8965759e
Merge pull request #8893 from MrPetovan/task/8797-strip-label-shortened-url 
Add shortened URL link label stripping to PageInfo::stripTrailingUrlFromBody
 2020-07-18 18:06:01 +02:00
Michael Vogel 9f1d1db1ee Database performance updates 2020-07-18 17:49:10 +02:00
Hypolite Petovan 911a23f18b Use PageInfo::appendDataToBody in ActivityPub\Processor::constructAttachList 2020-07-17 19:39:12 -04:00
Hypolite Petovan 972b65ba33 Add intermediate method PageInfo::appendDataToBody 
- It handles the already existing attachment in the body case
 2020-07-17 19:38:28 -04:00
Hypolite Petovan 886cf40036 Ensure ParseUrl::getSiteinfo always returns the url and type keys 2020-07-17 19:18:27 -04:00
Hypolite Petovan 25b3fa83fc Rename PageInfo::appendToBody to searchAndAppendToBody 2020-07-17 19:15:43 -04:00
Hypolite Petovan 8de66c0274 Add shortened URL link label stripping to PageInfo::stripTrailingUrlFromBody 
- Add test cases for shortened URL link labels
 2020-07-17 17:16:22 -04:00
Hypolite Petovan da50456675 Add Twitter source debug to Debug\Babel 2020-07-17 17:14:13 -04:00
Michael c987785146 Use "contact-type" instead of "account-type" to avoid notices 2020-07-17 06:58:39 +00:00
Michael 0b93bcbbf9 Create a (meaningful) title 2020-07-17 05:27:45 +00:00
Michael c47931172d Indention fixed 2020-07-17 04:46:42 +00:00
Michael ecf6018b89 Atom feed generation is moved to the feed class 2020-07-17 04:40:20 +00:00
Michael 70699878ee Replaced more calls of "Probe::uri" with "Contact::getByURL" 2020-07-16 19:22:38 +00:00
Hypolite Petovan dd85f48e0d
Merge pull request #8886 from annando/getidforurl-update 
in "getidforurl" "no update" is now "update"
 2020-07-16 09:23:30 -04:00
Hypolite Petovan 8411c13d51
Merge pull request #8887 from annando/prevent-null 
Prevent "null" value when calling "getTagsFromUrl"
 2020-07-16 09:15:46 -04:00
Michael d6bf7f2cda Replace "Probe::uri" with "Contact::getByURL" 2020-07-16 10:22:14 +00:00
Michael 4a550ddcd8 Prevent "null" value when calling "getTagsFromUrl" 2020-07-16 06:13:47 +00:00
Michael c352af8eda Reverting accidentally commited test 2020-07-16 04:45:12 +00:00
Michael Vogel a24fca818d
Merge pull request #8879 from MrPetovan/task/8847-httpsig-quotes 
Add support for token strings in HTTPSignature::parseSigheader
 2020-07-16 06:36:17 +02:00
Michael b8682190de Fix fallback on unknown contact 2020-07-16 04:18:33 +00:00
Michael caf548e1a7 Fix fetching contacts 2020-07-16 03:52:18 +00:00
Michael b0086a49e2 in "getidforurl" "no update" is now "update" 2020-07-15 21:08:42 +00:00
Hypolite Petovan 631095eefd
Merge pull request #8883 from annando/replace-getdetails 
Replaced "getDetailsByURL" with "getByURL/getByURLForUser"
 2020-07-15 13:49:27 -04:00
Michael 6d3949d54a Changed default value 2020-07-15 17:29:52 +00:00
Michael e374aecc46 Changed parameter order for "getbyURLForUser" 2020-07-15 17:22:12 +00:00
Michael fc0312451d Changed parameter order for getByURL 2020-07-15 17:06:48 +00:00
Michael d9c6a46ffe Replaced "getDetailsByURL" with "getByURL/getByURLForUser" 2020-07-15 04:42:04 +00:00
Hypolite Petovan 5ba8b4a58a Add ffi_keyword_denylist key check to match previous call in Protocol\Feed 2020-07-14 14:50:52 -04:00
Hypolite Petovan a13e004df0 Delete include/items.php 
- Remove all references
 2020-07-14 10:21:31 -04:00
Hypolite Petovan 3e25fc3a72 Replace *_page_info function calls with Content\PageInfo equivalent 2020-07-14 10:15:04 -04:00
Hypolite Petovan a1d62734fa Remove consume_feed in favor of Protocol\Feed::consume 2020-07-14 10:14:05 -04:00
Hypolite Petovan bf599be1f8 Add support for token strings in HTTPSignature::parseSigheader 
- Only quoted strings were supported before
 2020-07-14 09:52:03 -04:00
Hypolite Petovan 291f11a8bb Fix critical bug in Crypto::unencapsulate 
- The direction of the sub-function has been corrected
 2020-07-14 09:35:06 -04:00
Michael Vogel acea18a255
Merge pull request #8872 from MrPetovan/task/5742-update-addl-features 
Update additional features
 2020-07-14 07:52:02 +02:00
Hypolite Petovan 059087f998 Suppress all emails when Update::run is ran with $sendEmail = false 
- Address Renderer crash in the App-less context of Console
 2020-07-13 17:22:21 -04:00
Michael bbb2f1fcf5 Use "0" as default 2020-07-13 16:24:44 +00:00
Michael baea99dee6 Unneeded variable removed 2020-07-13 14:16:44 +00:00
Michael 5a6887fb2e Use "jsonexit" 2020-07-13 13:26:09 +00:00
Michael 27deb4d188 Module classes splitted 2020-07-13 09:45:45 +00:00
Hypolite Petovan 0816e0330f Move export public calendar additional feature to core 2020-07-12 23:08:38 -04:00
Hypolite Petovan d11125d234 Move network sidebar widget additional features to core 
- Make Archives filter core
- Make Protocol filter core
 2020-07-12 22:52:51 -04:00
Hypolite Petovan 6ad8bf0cca Remove network tabs additional features 
- Remove New network tab
- Remove Bookmark network tab
 2020-07-12 22:41:12 -04:00
Michael 2a1e6e1a74 Support Nodeinfo2 2020-07-12 21:53:17 +00:00
Michael 81928727f2 Issue 8866: Fix fetching feed links with missing base 2020-07-12 12:45:34 +00:00
Michael 0100e0df84 Some more invalid feed elements 2020-07-11 19:11:35 +00:00
Michael e5a336ff77 Merge remote-tracking branch 'upstream/2020.06-rc' into valid-feed 2020-07-11 18:57:17 +00:00
Michael b107a4984e Make feeds validate 2020-07-11 18:54:08 +00:00
Hypolite Petovan 090fa78057
Merge pull request #8862 from annando/issue-8860 
Issue 8860: Activities weren't fetchable all the time
 2020-07-11 14:14:03 -04:00
Hypolite Petovan db7736c566
Merge pull request #8864 from annando/feed-date 
Don't check the date on regular feeds
 2020-07-11 14:13:37 -04:00
Michael fb18325b6b Don't check the date on regular feeds 2020-07-11 16:29:18 +00:00
Hypolite Petovan e91daf8f46 Add logging for unexpected Search::searchGlobalContact return in Module\Search\Acl 2020-07-11 09:19:22 -04:00
Hypolite Petovan 2af20ea17a Fix wrong condition in Diaspora\Fetch 2020-07-11 09:18:42 -04:00
Hypolite Petovan 32a8f5003f Add provision for result containing only connector profiles in Contact::getDetailsByURL 2020-07-11 09:18:18 -04:00
Hypolite Petovan b4eea625b6 Add another check for $a->user in Content\Nav 
- Fix punctuation typo in logging call
 2020-07-11 09:17:23 -04:00
Michael 63dc6950d4 Issue 8860: Activities weren't fetchable all the time 2020-07-11 07:15:54 +00:00
Michael 84d8753d5f Remove the locking to improve performance 2020-07-10 19:50:16 +00:00
Michael 87f054a642 Fix message "empty network" in gcontact::getid 2020-07-10 19:49:11 +00:00
Hypolite Petovan 42a3f278f8
Merge pull request #8858 from annando/issue-8857 
Issue 8857: Fix follow accept answers
 2020-07-10 08:02:20 -04:00
Michael fcb37449f3 Fix unneeded database functions in the callstack 2020-07-10 07:01:28 +00:00
Michael c656aea152 Issue 8857: Fix follow accept answers 2020-07-10 05:30:12 +00:00
Michael Vogel af6f6d4957 Fix speed issues with the network page 2020-07-10 00:22:26 +02:00
Michael Vogel ced0effa2a
Merge pull request #8854 from MrPetovan/bug/notices 
Address various notices again
 2020-07-09 21:45:27 +02:00
Michael 1f88bb8beb Fix the plink for reshared Diaspora posts 2020-07-09 19:19:18 +00:00
Hypolite Petovan cb03418937 Add checks for $a->user existence 
- Variable can be empty/null in many cases
 2020-07-09 15:09:07 -04:00
Hypolite Petovan ad66a92deb Add check for $a->profile structure in Module\HoverCard 2020-07-09 15:09:07 -04:00
Hypolite Petovan 2db04b0c34 Add check for parent item existence in Model\UserItem::setNotificationForUser 2020-07-09 15:09:07 -04:00
Hypolite Petovan e683bd60ae
Merge pull request #8853 from annando/issue-8836 
Issue 8836: Point the event to the local post
 2020-07-08 18:41:41 -04:00
Michael 77e272e8ed Issue 8836: Point the event to the local post 2020-07-08 20:42:28 +00:00
Hypolite Petovan 68ecbcea34 Add logging to unexpected case in Content\Nav 
- Address part of https://github.com/friendica/friendica/issues/8475#issuecomment-653912096
 2020-07-08 09:56:40 -04:00
Hypolite Petovan 1f0b7690eb Add error handling in Module\Profile\Status 
- Address part of https://github.com/friendica/friendica/issues/8475#issuecomment-653912096
 2020-07-08 09:49:39 -04:00
Hypolite Petovan f2adec6a7f Add error handling in Module\Xrd 
- Address part of https://github.com/friendica/friendica/issues/8475#issuecomment-653912096
 2020-07-08 09:14:34 -04:00
Hypolite Petovan 5c0e079ca6
Merge pull request #8851 from annando/issue-8844 
Issue 8844: Fix probing of unknown AP contacts
 2020-07-07 08:56:10 -04:00
Michael 99de216d15 Issue 8844: Fiy probing of unknown AP contacts 2020-07-07 04:47:15 +00:00
Hypolite Petovan 6cde7afa53 Exclude deleted user accounts from "active" user list in Model\User 2020-07-06 15:26:39 -04:00
Hypolite Petovan b4910066b6 Rename -q option to -y for user delete console command 
- Name was misleading, it isn't quiet mode but non-interactive mode
 2020-07-06 15:25:49 -04:00
Hypolite Petovan 78b424c7fd Add support for "hs2019" algorithm value in Util\HTTPSignature 2020-07-04 13:12:59 -04:00
Hypolite Petovan d5acd5f96a Add expected support for sort strings in select() parameters 
- Fix unexpected behaviors with calls already using the sort strings
 2020-07-01 22:54:14 -04:00
Hypolite Petovan 20a4799902 Update references to the friendica/friendica-directory stable branch 2020-06-30 15:25:17 -04:00
Hypolite Petovan 9c6fbc6a74 Update references to the friendica/friendica stable branch 2020-06-30 15:25:16 -04:00
Hypolite Petovan b9873a88a5
Merge pull request #8832 from annando/fix-db-error 
Fix database error ""Unknown column 'parent-item.author-id'"
 2020-06-30 14:55:52 -04:00
Michael 6aadb6b923 Changed structure 2020-06-30 17:51:03 +00:00
Michael 8f1635d8fd Fix database error ""Unknown column 'parent-item.author-id'" 2020-06-30 05:49:22 +00:00
Michael c947b7f211 "print_r" in logging replaced / obsolete stuff removed 2020-06-29 20:22:00 +00:00
Michael 9a47e51115 Next logger calls replaced 2020-06-28 18:22:29 +00:00
Michael f6ae7db0ca Further deprecated calls replaced 2020-06-28 17:50:11 +00:00
Michael 52bb1ff0f1 Some more replaced logger 2020-06-28 17:35:56 +00:00
Michael 2350c6ab57 Replace deprecated Logger calls 2020-06-28 15:43:58 +00:00
Tobias Diekershoff 91c843608b
Merge pull request #8825 from annando/render-speed 
Improve render speed by not probing for unknown contacts
 2020-06-28 16:18:36 +02:00
Michael Vogel f611c99ad7 Improve render speed by not probing for unknown contacts 2020-06-28 15:57:33 +02:00
Michael Vogel 77e0d8c7bc
Merge pull request #8821 from MrPetovan/bug/fix-item-source-route 
Improve Module\Admin\Item\Source
 2020-06-28 14:02:25 +02:00
Hypolite Petovan 7d726dbb0c Improve Module\Admin\Item\Source 
- Use router parameter
- Accept full URLs with GUID in form
- Fix 500 error when item with guid doesn't exist
 2020-06-28 07:51:17 -04:00
Tobias Diekershoff 64ba2f9b61
Merge pull request #8823 from annando/keyword-notices 
Fix notice "Undefined index: keywords"
 2020-06-28 11:10:37 +02:00
Michael a1a9d4f657 Fix processing of received coordinates 2020-06-28 08:46:27 +00:00
Michael Vogel 713eda1dfe Empty lines removed 2020-06-28 08:23:53 +02:00
Michael Vogel 2756c3249b Fix notice "Undefined index: keywords" 2020-06-28 08:18:35 +02:00
Michael Vogel c852e1479c
Merge pull request #8811 from MrPetovan/task/8517-probe-mobile-twitter 
Add support for mobile profile URL to core twitter probing
 2020-06-27 17:32:19 +02:00
Hypolite Petovan 3b701371ea
Merge pull request #8820 from annando/fix-author-network 
Fix notice "Undefined index: author-network"
 2020-06-27 11:28:14 -04:00
Michael 64dc3519a4 Fix notice "Undefined index: author-network" 2020-06-27 15:10:06 +00:00
Hypolite Petovan 0b38826a73 Simplify sender handle assignment in Model\Mail 2020-06-27 09:34:29 -04:00
Hypolite Petovan e78db3fac6
Merge pull request #8817 from annando/ap-diaspora-delivery 
Prevent delivering AP comments to Diaspora
 2020-06-27 09:30:11 -04:00
Michael de19f94aca Prevent delivering AP comments to Diaspora 2020-06-27 12:18:36 +00:00
Michael ef56837b9e Fix receiving non public posts from AP 2020-06-27 10:35:45 +00:00
Hypolite Petovan 2c2db55298 Add support for mobile profile URL to core twitter probing 2020-06-26 12:52:40 -04:00
Hypolite Petovan 50d05cec83 Ensure url property of Probe::uri result is used authoritatively 
- Some profile URLs aren't canonical and need to be updated during probe
 2020-06-26 12:52:39 -04:00
Michael a0ee12aade Fix notice "Undefined index: forum" 2020-06-26 05:29:00 +00:00
Michael 019a9d44c5 New function to fetch contact data by url 2020-06-26 05:28:25 +00:00
Michael d8f9bb1e0a Unify code structure 2020-06-25 20:41:34 +00:00
Michael 4d986526f9 Issue 8807: Improved feed detecting 2020-06-25 20:29:21 +00:00
Michael Vogel 95ed81de5f
Merge pull request #8805 from MrPetovan/bug/notices 
Add logging to rare condition in Model\Profile::sidebar
 2020-06-25 08:39:28 +02:00
Michael Vogel 1625dfa0a4
Merge pull request #8804 from MrPetovan/bug/warnings 
Add type hint to Database::insert
 2020-06-25 08:37:41 +02:00
Hypolite Petovan 06b992a5dd Add expected whitespace before Widget::unavailableNetworks() output in Module\Contact 2020-06-24 18:49:55 -04:00
Hypolite Petovan 192576f01a Add logging to rare condition in Model\Profile::sidebar 
- Adresses https://github.com/friendica/friendica/issues/8475#issuecomment-647104375
 2020-06-24 09:56:11 -04:00
Hypolite Petovan 5cf5869b04 Add type hint to Database::insert 
- Will escalate warning to fatal error in https://github.com/friendica/friendica/issues/8474#issuecomment-646802016
 2020-06-24 09:36:34 -04:00
Michael Vogel 7fd2c00171
Merge pull request #8792 from MrPetovan/task/share-block-guid 
[frio] Add local post link to share block when guid attribute is present
 2020-06-23 21:26:07 +02:00
Hypolite Petovan faeffff8a3 [pre] blocks now preserve spaces 
- Added test case
- Added English documentation
 2020-06-23 07:53:18 -04:00
Hypolite Petovan 251a3791dd Keep spaces after non-tags in Content\BBCode::convert 
- Added test case
 2020-06-23 07:52:38 -04:00
Hypolite Petovan d2aa68106b Make guid attribute available to convertShare callback 2020-06-21 09:45:00 -04:00
Hypolite Petovan 912ff069c0 Update getShareOpeningTag::getShareOpeningTag method signature 
- Optional parameter $guid is now at the end
- Always provided parameter $posted is now mandatory
 2020-06-21 09:42:37 -04:00
Tobias Diekershoff 797eff853a
Merge pull request #8790 from MrPetovan/bug/notices 
Fix latest notice messages
 2020-06-20 18:07:54 +02:00
Hypolite Petovan a83681e93a Use Contact::getDetailsByURL instead of custom query in Protocol\OStatus 
- Address part of https://github.com/friendica/friendica/issues/8475#issuecomment-646457104
 2020-06-19 07:10:39 -04:00
Hypolite Petovan aafef02789 Replace obsolete anonymity test with a slightly less obsolete one in Model\Item 
- Address part of https://github.com/friendica/friendica/issues/8475#issuecomment-646457104
 2020-06-19 07:10:27 -04:00
Hypolite Petovan 51bae35d2a Account for contact.ffi_keyword_denylist field being NULL by default in Protocol\Feed 2020-06-19 07:01:05 -04:00
Hypolite Petovan 1f20111c80 Replace share_header calls with BBCode::getShareOpeningTag 2020-06-18 08:53:57 -04:00
Hypolite Petovan cd74fb8609 Add new Content\BBCode::getShareOpeningTag 2020-06-18 08:53:30 -04:00
Hypolite Petovan f544c8383b Implement pull request feedback 
- Improve formatting of drop_item in mod/item
- Replace deprecated Logger::log() calls in Protocol\Feed::consume
 2020-06-17 21:44:28 -04:00
Hypolite Petovan 4e7c45f835 Add PageInfo result panels to Debug\Babel 2020-06-17 13:24:44 -04:00
Hypolite Petovan f3323aff5e Deprecate page_info functions to new PageInfo class 
- Add tests for parts not using remote requests
- Add scheme requirement for page info URLs
- Add policy to keep label from stripped Page Info links
 2020-06-17 13:24:44 -04:00
Hypolite Petovan eba964ec12 Deprecate consume_feed() in favor of Protocol\Feed::consume 2020-06-17 13:24:44 -04:00
Hypolite Petovan e3d20b4366 Move subscribe_to_hub function to Worker/OnePoll from include/items 
- It was its only usage
 2020-06-17 13:24:44 -04:00
Hypolite Petovan 51925f2994 Add new endsWith method to Util\Strings 2020-06-17 13:24:44 -04:00
Michael Vogel df03b19a9d
Merge pull request #8783 from MrPetovan/bug/8488-exclude-img-tags 
Exclude [img] tags from tag replacement
 2020-06-17 08:20:50 +02:00
Michael 1a86167ac5 Possibly fix "Undefined index: url" 2020-06-16 20:41:34 +00:00
Hypolite Petovan f9ecbbd743 Exclude [img] tags from tag replacement 
- It broke image captions by inserting an HTML link inside an HTML attribute
 2020-06-16 16:34:16 -04:00
Michael 8707ced2f7 Hopefully fixes notice "Undefined index: gravity" 2020-06-16 20:30:25 +00:00
Michael Vogel c5e5defc29
Update src/Module/Admin/Site.php 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
 2020-06-16 14:37:36 +02:00
Michael 016c99935c Different comment limits for single view 2020-06-16 06:49:53 +00:00
Michael e1dac1a87a Categories are not showing up at the bottom of the post 
Fixes friendica/friendica#8766
 2020-06-15 03:43:51 +00:00
Hypolite Petovan 4dc68b32b5
Merge pull request #8772 from annando/post-update 
Speed up post update for gsid
 2020-06-14 14:57:10 -04:00
Michael Vogel 6b93a7e395 Speed up post update for gsid 2020-06-14 18:09:59 +02:00
Michael 8ec2b21a14 Abuse mail received because of "unusual traffic" 
Fixes friendica/friendica#8663
 2020-06-14 15:47:47 +00:00
Hypolite Petovan 5f43f56f72
Merge pull request #8770 from annando/probing 
Reduced network request when probing
 2020-06-14 11:18:16 -04:00
Michael Vogel f10062dfdb
Merge pull request #8617 from MrPetovan/task/8220-twitter-followers-list 
(Re)Implement Twitter contact API endpoints
 2020-06-14 16:06:22 +02:00
Michael b948887221 Reduced network request when probing 2020-06-14 13:37:28 +00:00
Hypolite Petovan f60697110e Clear all previous template variables before replacing Macros in FriendicaSmartyEngine 
- Prevents variables leaking between replaceMacros() calls
 2020-06-12 22:06:09 -04:00
Michael Vogel aedbb0d627
Merge pull request #8753 from MrPetovan/bug/fatal-errors 
Remove dependency to App in Contact::createFromProbe
 2020-06-12 06:58:20 +02:00
Michael Vogel 9b85d0b16e
Merge pull request #8740 from MrPetovan/task/frio-improve-share-display 
[frio] Improve share blocks display
 2020-06-11 07:32:29 +02:00
Michael Vogel a5d1c0ff78
Merge pull request #8754 from MrPetovan/task/8676-ap-attachments 
Strip the link preview URL from the end of the body if any in ActivityPub\Processor
 2020-06-11 06:29:33 +02:00
Hypolite Petovan 7919860274
Merge pull request #8757 from annando/simplify-probe 
Simplify the probing process
 2020-06-10 15:33:03 -04:00
Michael e49de92cd4 Simplify the probing process 2020-06-10 19:19:10 +00:00