tobias/friendica
1
0
Fork 0
Code Pull requests Activity

Review update

Browse source 
Rename function, move others
This commit is contained in:
Adam Magness 2018-01-27 11:13:41 -05:00
commit f04d40a37e
55 changed files with 331 additions and 326 deletions
Download patch file Download diff file Expand all files Collapse all files

23
mod/dfrn_confirm.php
View file

@ -31,6 +31,7 @@ use Friendica\Network\Probe;
use Friendica\Protocol\Diaspora;
use Friendica\Util\Crypto;
use Friendica\Util\Network;
use Friendica\Util\XML;
require_once 'include/enotify.php';
require_once 'include/items.php';
@ -221,7 +222,7 @@ function dfrn_confirm_post(App $a, $handsfree = null)
*
*/
$res = Network::postURL($dfrn_confirm, $params, null, $redirects, 120);
$res = Network::post($dfrn_confirm, $params, null, $redirects, 120);
logger(' Confirm: received data: ' . $res, LOGGER_DATA);
@ -252,7 +253,7 @@ function dfrn_confirm_post(App $a, $handsfree = null)
return;
}
$xml = Network::parseXmlString($res);
$xml = XML::parseString($res);
$status = (int) $xml->status;
$message = unxmlify($xml->message); // human readable text of what may have gone wrong.
switch ($status) {
@ -493,7 +494,7 @@ function dfrn_confirm_post(App $a, $handsfree = null)
$user = dba::selectFirst('user', [], ['nickname' => $node]);
if (!DBM::is_result($user)) {
$message = L10n::t('No user record found for \'%s\' ', $node);
Network::xmlStatus(3, $message); // failure
Network::xmlExit(3, $message); // failure
// NOTREACHED
}
@ -503,7 +504,7 @@ function dfrn_confirm_post(App $a, $handsfree = null)
if (!strstr($my_prvkey, 'PRIVATE KEY')) {
$message = L10n::t('Our site encryption key is apparently messed up.');
Network::xmlStatus(3, $message);
Network::xmlExit(3, $message);
}
// verify everything
@ -514,7 +515,7 @@ function dfrn_confirm_post(App $a, $handsfree = null)
if (!strlen($decrypted_source_url)) {
$message = L10n::t('Empty site URL was provided or URL could not be decrypted by us.');
Network::xmlStatus(3, $message);
Network::xmlExit(3, $message);
// NOTREACHED
}
@ -530,7 +531,7 @@ function dfrn_confirm_post(App $a, $handsfree = null)
if (!DBM::is_result($contact)) {
// this is either a bogus confirmation (?) or we deleted the original introduction.
$message = L10n::t('Contact record was not found for you on our site.');
Network::xmlStatus(3, $message);
Network::xmlExit(3, $message);
return; // NOTREACHED
}
}
@ -544,7 +545,7 @@ function dfrn_confirm_post(App $a, $handsfree = null)
if (!$foreign_pubkey) {
$message = L10n::t('Site public key not available in contact record for URL %s.', $decrypted_source_url);
Network::xmlStatus(3, $message);
Network::xmlExit(3, $message);
}
$decrypted_dfrn_id = "";
@ -560,7 +561,7 @@ function dfrn_confirm_post(App $a, $handsfree = null)
if (dba::exists('contact', ['dfrn-id' => $decrypted_dfrn_id])) {
$message = L10n::t('The ID provided by your system is a duplicate on our system. It should work if you try again.');
Network::xmlStatus(1, $message); // Birthday paradox - duplicate dfrn-id
Network::xmlExit(1, $message); // Birthday paradox - duplicate dfrn-id
// NOTREACHED
}
@ -571,7 +572,7 @@ function dfrn_confirm_post(App $a, $handsfree = null)
);
if (!DBM::is_result($r)) {
$message = L10n::t('Unable to set your contact credentials on our system.');
Network::xmlStatus(3, $message);
Network::xmlExit(3, $message);
}
// It's possible that the other person also requested friendship.
@ -626,7 +627,7 @@ function dfrn_confirm_post(App $a, $handsfree = null)
);
if (!DBM::is_result($r)) { // indicates schema is messed up or total db failure
$message = L10n::t('Unable to update your contact profile details on our system');
Network::xmlStatus(3, $message);
Network::xmlExit(3, $message);
}
// Otherwise everything seems to have worked and we are almost done. Yay!
@ -707,7 +708,7 @@ function dfrn_confirm_post(App $a, $handsfree = null)
}
}
}
Network::xmlStatus(0); // Success
Network::xmlExit(0); // Success
return; // NOTREACHED
////////////////////// End of this scenario ///////////////////////////////////////////////
}