tobias/friendica
1
0
Fork 0
Code Pull requests Activity

Change called method names

Browse source 
- Add GlobalContact::getRandomUrl
- Rename Contact::getIdForURL
- Rename Diaspora::sendUnshare
- Remove unused parameter $self in Contact::terminateFriendship
This commit is contained in:
Hypolite Petovan 2017-11-19 17:03:39 -05:00
commit ec02af593d
48 changed files with 133 additions and 133 deletions
Download patch file Download diff file Expand all files Collapse all files

4
mod/admin.php
View file

@ -1446,7 +1446,7 @@ function admin_page_users_post(App $a) {
if (x($_POST,'page_users_delete')) {
require_once("include/Contact.php");
foreach ($users as $uid) {
user_remove($uid);
User::remove($uid);
}
notice(sprintf(tt("%s user deleted", "%s users deleted", count($users)), count($users)));
}
@ -1493,7 +1493,7 @@ function admin_page_users(App $a) {
check_form_security_token_redirectOnErr('/admin/users', 'admin_users', 't');
// delete user
require_once("include/Contact.php");
user_remove($uid);
User::remove($uid);
notice(sprintf(t("User '%s' deleted"), $user[0]['username']).EOL);
break;

8
mod/allfriends.php
View file

@ -40,7 +40,7 @@ function allfriends_content(App $a) {
}
$a->page['aside'] = "";
profile_load($a, "", 0, get_contact_details_by_url($c[0]["url"]));
profile_load($a, "", 0, Contact::getDetailsByURL($c[0]["url"]));
$total = GlobalContact::countAllFriends(local_user(), $cid);
@ -59,7 +59,7 @@ function allfriends_content(App $a) {
foreach ($r as $rr) {
//get further details of the contact
$contact_details = get_contact_details_by_url($rr['url'], $uid, $rr);
$contact_details = Contact::getDetailsByURL($rr['url'], $uid, $rr);
$photo_menu = '';
@ -67,7 +67,7 @@ function allfriends_content(App $a) {
// If the contact is not common to the user, Connect/Follow' will be added to the photo menu
if ($rr[cid]) {
$rr[id] = $rr[cid];
$photo_menu = contact_photo_menu ($rr);
$photo_menu = Contact::photoMenu ($rr);
}
else {
$connlnk = System::baseUrl() . '/follow/?url=' . $rr['url'];
@ -86,7 +86,7 @@ function allfriends_content(App $a) {
'details' => $contact_details['location'],
'tags' => $contact_details['keywords'],
'about' => $contact_details['about'],
'account_type' => account_type($contact_details),
'account_type' => Contact::getAccountType($contact_details),
'network' => network_to_name($contact_details['network'], $contact_details['url']),
'photo_menu' => $photo_menu,
'conntxt' => t('Connect'),

2
mod/cal.php
View file

@ -47,7 +47,7 @@ function cal_init(App $a) {
$profile = get_profiledata_by_nick($nick, $a->profile_uid);
$account_type = account_type($profile);
$account_type = Contact::getAccountType($profile);
$tpl = get_markup_template("vcard-widget.tpl");

8
mod/common.php
View file

@ -40,7 +40,7 @@ function common_content(App $a) {
);
/// @TODO Handle $c with DBM::is_result()
$a->page['aside'] = "";
profile_load($a, "", 0, get_contact_details_by_url($c[0]["url"]));
profile_load($a, "", 0, Contact::getDetailsByURL($c[0]["url"]));
} else {
$c = q("SELECT `name`, `url`, `photo` FROM `contact` WHERE `self` = 1 AND `uid` = %d LIMIT 1",
intval($uid)
@ -115,14 +115,14 @@ function common_content(App $a) {
foreach ($r as $rr) {
//get further details of the contact
$contact_details = get_contact_details_by_url($rr['url'], $uid);
$contact_details = Contact::getDetailsByURL($rr['url'], $uid);
// $rr['id'] is needed to use contact_photo_menu()
/// @TODO Adding '/" here avoids E_NOTICE on missing constants
$rr['id'] = $rr['cid'];
$photo_menu = '';
$photo_menu = contact_photo_menu($rr);
$photo_menu = Contact::photoMenu($rr);
$entry = array(
'url' => $rr['url'],
@ -133,7 +133,7 @@ function common_content(App $a) {
'details' => $contact_details['location'],
'tags' => $contact_details['keywords'],
'about' => $contact_details['about'],
'account_type' => account_type($contact_details),
'account_type' => Contact::getAccountType($contact_details),
'network' => network_to_name($contact_details['network'], $contact_details['url']),
'photo_menu' => $photo_menu,
'id' => ++$id,

25
mod/contacts.php
View file

@ -59,7 +59,7 @@ function contacts_init(App $a) {
'$addr' => (($a->data['contact']['addr'] != "") ? ($a->data['contact']['addr']) : ""),
'$network_name' => $networkname,
'$network' => t('Network:'),
'$account_type' => account_type($a->data['contact'])
'$account_type' => Contact::getAccountType($a->data['contact'])
));
$finpeople_widget = '';
@ -132,7 +132,7 @@ function contacts_batch_actions(App $a) {
if ($r) $count_actions++;
}
if (x($_POST, 'contacts_batch_drop')) {
_contact_drop($contact_id, $orig_record);
_contact_drop($orig_record);
$count_actions++;
}
}
@ -347,7 +347,9 @@ function _contact_archive($contact_id, $orig_record) {
}
return $r;
}
function _contact_drop($contact_id, $orig_record) {
function _contact_drop($orig_record)
{
$a = get_app();
$r = q("SELECT `contact`.*, `user`.* FROM `contact` INNER JOIN `user` ON `contact`.`uid` = `user`.`uid`
@ -358,9 +360,8 @@ function _contact_drop($contact_id, $orig_record) {
return;
}
$self = ""; // Unused parameter
terminate_friendship($r[0], $self, $orig_record);
contact_remove($orig_record['id']);
Contact::terminateFriendship($r[0], $orig_record);
Contact::remove($orig_record['id']);
}
@ -480,7 +481,7 @@ function contacts_content(App $a) {
}
}
_contact_drop($contact_id, $orig_record[0]);
_contact_drop($orig_record[0]);
info( t('Contact has been removed.') . EOL );
if (x($_SESSION,'return_url')) {
goaway('' . $_SESSION['return_url']);
@ -654,7 +655,7 @@ function contacts_content(App $a) {
'$url' => $url,
'$profileurllabel' => t('Profile URL'),
'$profileurl' => $contact['url'],
'$account_type' => account_type($contact),
'$account_type' => Contact::getAccountType($contact),
'$location' => bbcode($contact["location"]),
'$location_label' => t("Location:"),
'$xmpp' => bbcode($contact["xmpp"]),
@ -917,7 +918,7 @@ function contact_posts($a, $contact_id) {
if ($r) {
$contact = $r[0];
$a->page['aside'] = "";
profile_load($a, "", 0, get_contact_details_by_url($contact["url"]));
profile_load($a, "", 0, Contact::getDetailsByURL($contact["url"]));
} else
$profile = "";
@ -925,7 +926,7 @@ function contact_posts($a, $contact_id) {
$o .= $tab_str;
$o .= posts_from_contact_url($a, $contact["url"]);
$o .= Contact::getPostsFromUrl($contact["url"]);
return $o;
}
@ -960,14 +961,14 @@ function _contact_detail_for_template($rr){
return array(
'img_hover' => sprintf( t('Visit %s\'s profile [%s]'),$rr['name'],$rr['url']),
'edit_hover' => t('Edit contact'),
'photo_menu' => contact_photo_menu($rr),
'photo_menu' => Contact::photoMenu($rr),
'id' => $rr['id'],
'alt_text' => $alt_text,
'dir_icon' => $dir_icon,
'thumb' => proxy_url($rr['thumb'], false, PROXY_SIZE_THUMB),
'name' => htmlentities($rr['name']),
'username' => htmlentities($rr['name']),
'account_type' => account_type($rr),
'account_type' => Contact::getAccountType($rr),
'sparkle' => $sparkle,
'itemurl' => (($rr['addr'] != "") ? $rr['addr'] : $rr['url']),
'url' => $url,

2
mod/crepair.php
View file

@ -32,7 +32,7 @@ function crepair_init(App $a) {
if($contact_id) {
$a->data['contact'] = $r[0];
$contact = $r[0];
profile_load($a, "", 0, get_contact_details_by_url($contact["url"]));
profile_load($a, "", 0, Contact::getDetailsByURL($contact["url"]));
}
}

8
mod/dfrn_notify.php
View file

@ -128,13 +128,9 @@ function dfrn_notify_post(App $a) {
logger('dfrn_notify: data: ' . $data, LOGGER_DATA);
if ($dissolve == 1) {
/*
* Relationship is dissolved permanently
*/
require_once('include/Contact.php');
contact_remove($importer['id']);
// Relationship is dissolved permanently
Contact::remove($importer['id']);
logger('relationship dissolved : ' . $importer['name'] . ' dissolved ' . $importer['username']);
xml_status(0, 'relationship dissolved');
}

2
mod/directory.php
View file

@ -162,7 +162,7 @@ function directory_content(App $a) {
'img_hover' => $rr['name'],
'name' => $rr['name'],
'details' => $details,
'account_type' => account_type($rr),
'account_type' => Contact::getAccountType($rr),
'profile' => $profile,
'location' => $location_e,
'tags' => $rr['pub_keywords'],

10
mod/dirfind.php
View file

@ -76,7 +76,7 @@ function dirfind_content(App $a, $prefix = "") {
$objresult->tags = "";
$objresult->network = $user_data["network"];
$contact = get_contact_details_by_url($user_data["url"], local_user());
$contact = Contact::getDetailsByURL($user_data["url"], local_user());
$objresult->cid = $contact["cid"];
$j->results[] = $objresult;
@ -150,7 +150,7 @@ function dirfind_content(App $a, $prefix = "") {
continue;
}
$result = get_contact_details_by_url($result["url"], local_user(), $result);
$result = Contact::getDetailsByURL($result["url"], local_user(), $result);
if ($result["name"] == "") {
$urlparts = parse_url($result["url"]);
@ -194,7 +194,7 @@ function dirfind_content(App $a, $prefix = "") {
$alt_text = "";
$contact_details = get_contact_details_by_url($jj->url, local_user());
$contact_details = Contact::getDetailsByURL($jj->url, local_user());
$itemurl = (($contact_details["addr"] != "") ? $contact_details["addr"] : $jj->url);
@ -205,7 +205,7 @@ function dirfind_content(App $a, $prefix = "") {
$contact = q("SELECT * FROM `contact` WHERE `id` = %d",
intval($jj->cid));
if ($contact) {
$photo_menu = contact_photo_menu($contact[0]);
$photo_menu = Contact::photoMenu($contact[0]);
$details = _contact_detail_for_template($contact[0]);
$alt_text = $details['alt_text'];
} else {
@ -235,7 +235,7 @@ function dirfind_content(App $a, $prefix = "") {
'details' => $contact_details['location'],
'tags' => $contact_details['keywords'],
'about' => $contact_details['about'],
'account_type' => account_type($contact_details),
'account_type' => Contact::getAccountType($contact_details),
'network' => network_to_name($jj->network, $jj->url),
'id' => ++$id,
);

2
mod/display.php
View file

@ -182,7 +182,7 @@ function display_fetchauthor($a, $item) {
$profiledata["about"] = "";
}
$profiledata = get_contact_details_by_url($profiledata["url"], local_user(), $profiledata);
$profiledata = Contact::getDetailsByURL($profiledata["url"], local_user(), $profiledata);
$profiledata["photo"] = System::removedBaseUrl($profiledata["photo"]);

4
mod/follow.php
View file

@ -177,7 +177,7 @@ function follow_content(App $a) {
));
$a->page['aside'] = "";
profile_load($a, "", 0, get_contact_details_by_url($ret["url"]));
profile_load($a, "", 0, Contact::getDetailsByURL($ret["url"]));
if ($gcontact_id <> 0) {
$o .= replace_macros(get_markup_template('section_title.tpl'),
@ -185,7 +185,7 @@ function follow_content(App $a) {
));
// Show last public posts
$o .= posts_from_contact_url($a, $ret["url"]);
$o .= Contact::getPostsFromUrl($ret["url"]);
}
return $o;

6
mod/hovercard.php
View file

@ -52,14 +52,14 @@ function hovercard_content() {
$nurl = normalise_link(GlobalContact::cleanContactUrl($profileurl));
if($nurl) {
// Search for contact data
$contact = get_contact_details_by_url($nurl);
$contact = Contact::getDetailsByURL($nurl);
}
if(!is_array($contact))
return;
// Get the photo_menu - the menu if possible contact actions
if(local_user())
$actions = contact_photo_menu($contact);
$actions = Contact::photoMenu($contact);
// Move the contact data to the profile array so we can deliver it to
@ -81,7 +81,7 @@ function hovercard_content() {
// 'server_url' => $contact["server_url"],
'bd' => (($contact["birthday"] <= '0001-01-01') ? "" : $contact["birthday"]),
// 'generation' => $contact["generation"],
'account_type' => account_type($contact),
'account_type' => Contact::getAccountType($contact),
'actions' => $actions,
);
if($datatype == "html") {

6
mod/item.php
View file

@ -147,7 +147,7 @@ function item_post(App $a) {
$thrparent = q("SELECT `author-link`, `network` FROM `item` WHERE `uri` = '%s' LIMIT 1", dbesc($thr_parent));
if (DBM::is_result($thrparent) && ($thrparent[0]["network"] === NETWORK_OSTATUS)
&& (normalise_link($parent_contact["url"]) != normalise_link($thrparent[0]["author-link"]))) {
$parent_contact = get_contact_details_by_url($thrparent[0]["author-link"]);
$parent_contact = Contact::getDetailsByURL($thrparent[0]["author-link"]);
if (!isset($parent_contact["nick"])) {
$probed_contact = Probe::uri($thrparent[0]["author-link"]);
@ -704,11 +704,11 @@ function item_post(App $a) {
$datarray['owner-name'] = $contact_record['name'];
$datarray['owner-link'] = $contact_record['url'];
$datarray['owner-avatar'] = $contact_record['thumb'];
$datarray['owner-id'] = get_contact($datarray['owner-link'], 0);
$datarray['owner-id'] = Contact::getIdForURL($datarray['owner-link'], 0);
$datarray['author-name'] = $author['name'];
$datarray['author-link'] = $author['url'];
$datarray['author-avatar'] = $author['thumb'];
$datarray['author-id'] = get_contact($datarray['author-link'], 0);
$datarray['author-id'] = Contact::getIdForURL($datarray['author-link'], 0);
$datarray['created'] = datetime_convert();
$datarray['edited'] = datetime_convert();
$datarray['commented'] = datetime_convert();

4
mod/match.php
View file

@ -87,7 +87,7 @@ function match_content(App $a)
'follow' => array(t("Connect/Follow"), $connlnk)
);
$contact_details = get_contact_details_by_url($jj->url, local_user());
$contact_details = Contact::getDetailsByURL($jj->url, local_user());
$entry = array(
'url' => zrl($jj->url),
@ -96,7 +96,7 @@ function match_content(App $a)
'details' => $contact_details['location'],
'tags' => $contact_details['keywords'],
'about' => $contact_details['about'],
'account_type' => account_type($contact_details),
'account_type' => Contact::getAccountType($contact_details),
'thumb' => proxy_url($jj->photo, false, PROXY_SIZE_THUMB),
'inttxt' => ' ' . t('is interested in:'),
'conntxt' => t('Connect'),

4
mod/message.php
View file

@ -462,7 +462,7 @@ function message_content(App $a) {
$to_name_e = $message['name'];
}
$contact = get_contact_details_by_url($message['from-url']);
$contact = Contact::getDetailsByURL($message['from-url']);
if (isset($contact["thumb"]))
$from_photo = $contact["thumb"];
else
@ -576,7 +576,7 @@ function render_messages(array $msg, $t) {
$to_name_e = $rr['name'];
}
$contact = get_contact_details_by_url($rr['url']);
$contact = Contact::getDetailsByURL($rr['url']);
if (isset($contact["thumb"]))
$from_photo = $contact["thumb"];
else

2
mod/network.php
View file

@ -677,7 +677,7 @@ function networkThreadedView(App $a, $update = 0) {
'details' => $r['location'],
);
$entries[0]["account_type"] = account_type($r);
$entries[0]["account_type"] = Contact::getAccountType($r);
$o = replace_macros(get_markup_template("viewcontact_template.tpl"),array(
'contacts' => $entries,

8
mod/nogroup.php
View file

@ -33,19 +33,19 @@ function nogroup_content(App $a)
}
require_once 'include/Contact.php';
$r = contacts_not_grouped(local_user());
$r = Contact::getUngroupedList(local_user());
if (DBM::is_result($r)) {
$a->set_pager_total($r[0]['total']);
}
$r = contacts_not_grouped(local_user(), $a->pager['start'], $a->pager['itemspage']);
$r = Contact::getUngroupedList(local_user(), $a->pager['start'], $a->pager['itemspage']);
if (DBM::is_result($r)) {
foreach ($r as $rr) {
$contact_details = get_contact_details_by_url($rr['url'], local_user(), $rr);
$contact_details = Contact::getDetailsByURL($rr['url'], local_user(), $rr);
$contacts[] = array(
'img_hover' => sprintf(t('Visit %s\'s profile [%s]'), $contact_details['name'], $rr['url']),
'edit_hover' => t('Edit contact'),
'photo_menu' => contact_photo_menu($rr),
'photo_menu' => Contact::photoMenu($rr),
'id' => $rr['id'],
'alt_text' => $alt_text,
'dir_icon' => $dir_icon,

2
mod/photos.php
View file

@ -46,7 +46,7 @@ function photos_init(App $a) {
$profile = get_profiledata_by_nick($nick, $a->profile_uid);
$account_type = account_type($profile);
$account_type = Contact::getAccountType($profile);
$tpl = get_markup_template("vcard-widget.tpl");

2
mod/ping.php
View file

@ -350,7 +350,7 @@ function ping_init(App $a)
$notif['message'] = str_replace("{0}", $notif['name'], $notif['message']);
}
$contact = get_contact_details_by_url($notif['url']);
$contact = Contact::getDetailsByURL($notif['url']);
if (isset($contact['micro'])) {
$notif['photo'] = proxy_url($contact['micro'], false, PROXY_SIZE_MICRO);
} else {

2
mod/profiles.php
View file

@ -491,7 +491,7 @@ function profiles_post(App $a) {
}
if ($is_default) {
$location = formatted_location(array("locality" => $locality, "region" => $region, "country-name" => $country_name));
$location = Profile::formatLocation(array("locality" => $locality, "region" => $region, "country-name" => $country_name));
q("UPDATE `contact` SET `about` = '%s', `location` = '%s', `keywords` = '%s', `gender` = '%s' WHERE `self` AND `uid` = %d",
dbesc($about),

2
mod/randprof.php
View file

@ -7,7 +7,7 @@ use Friendica\Model\GlobalContact;
function randprof_init(App $a) {
require_once('include/Contact.php');
$x = random_profile();
$x = GlobalContact::getRandomUrl();
if ($x) {
goaway(zrl($x));

2
mod/removeme.php
View file

@ -30,7 +30,7 @@ function removeme_post(App $a) {
if ((strlen($a->user['password'])) && ($encrypted === $a->user['password'])) {
require_once('include/Contact.php');
user_remove($a->user['uid']);
User::remove($a->user['uid']);
// NOTREACHED
}

4
mod/suggest.php
View file

@ -88,7 +88,7 @@ function suggest_content(App $a) {
'hide' => array(t('Ignore/Hide'), $ignlnk)
);
$contact_details = get_contact_details_by_url($rr["url"], local_user(), $rr);
$contact_details = Contact::getDetailsByURL($rr["url"], local_user(), $rr);
$entry = array(
'url' => zrl($rr['url']),
@ -99,7 +99,7 @@ function suggest_content(App $a) {
'details' => $contact_details['location'],
'tags' => $contact_details['keywords'],
'about' => $contact_details['about'],
'account_type' => account_type($contact_details),
'account_type' => Contact::getAccountType($contact_details),
'ignlnk' => $ignlnk,
'ignid' => $rr['id'],
'conntxt' => t('Connect'),

7
mod/unfollow.php
View file

@ -39,8 +39,7 @@ function unfollow_post(App $a) {
intval($uid)
);
if (DBM::is_result($r)) {
$self = ""; // Unused parameter
terminate_friendship($r[0], $self, $contact);
Contact::terminateFriendship($r[0], $contact);
}
}
dba::update('contact', array('rel' => CONTACT_IS_FOLLOWER), array('id' => $contact['id']));
@ -128,14 +127,14 @@ function unfollow_content(App $a) {
));
$a->page['aside'] = "";
profile_load($a, "", 0, get_contact_details_by_url($contact["url"]));
profile_load($a, "", 0, Contact::getDetailsByURL($contact["url"]));
$o .= replace_macros(get_markup_template('section_title.tpl'),
array('$title' => t('Status Messages and Posts')
));
// Show last public posts
$o .= posts_from_contact_url($a, $contact["url"]);
$o .= Contact::getPostsFromUrl($contact["url"]);
return $o;
}

2
mod/videos.php
View file

@ -40,7 +40,7 @@ function videos_init(App $a) {
$profile = get_profiledata_by_nick($nick, $a->profile_uid);
$account_type = account_type($profile);
$account_type = Contact::getAccountType($profile);
$tpl = get_markup_template("vcard-widget.tpl");

6
mod/viewcontacts.php
View file

@ -101,19 +101,19 @@ function viewcontacts_content(App $a) {
else
$url = zrl($url);
$contact_details = get_contact_details_by_url($rr['url'], $a->profile['uid'], $rr);
$contact_details = Contact::getDetailsByURL($rr['url'], $a->profile['uid'], $rr);
$contacts[] = array(
'id' => $rr['id'],
'img_hover' => sprintf( t('Visit %s\'s profile [%s]'), $contact_details['name'], $rr['url']),
'photo_menu' => contact_photo_menu($rr),
'photo_menu' => Contact::photoMenu($rr),
'thumb' => proxy_url($contact_details['thumb'], false, PROXY_SIZE_THUMB),
'name' => htmlentities(substr($contact_details['name'],0,20)),
'username' => htmlentities($contact_details['name']),
'details' => $contact_details['location'],
'tags' => $contact_details['keywords'],
'about' => $contact_details['about'],
'account_type' => account_type($contact_details),
'account_type' => Contact::getAccountType($contact_details),
'url' => $url,
'sparkle' => '',
'itemurl' => (($contact_details['addr'] != "") ? $contact_details['addr'] : $rr['url']),