tobias/friendica
1
0
Fork 0
Code Pull requests Activity

More usage of dbm::is_result($r) instead of count($r):

Browse source 
- count() returns very different results and never a boolean (not even false on
  error condition).
- therefore you should NOT use it in boolean expressions. This still *can* be
  done in PHP because of its lazyness. But it is discouraged if it comes to
  more clean code.

Signed-off-by: Roland Häder <roland@mxchange.org>
This commit is contained in:
Roland Häder 2016-12-13 10:44:13 +01:00
commit 6a8a36f12d
115 changed files with 439 additions and 437 deletions
Download patch file Download diff file Expand all files Collapse all files

4
mod/wallmessage.php
View file

@ -22,7 +22,7 @@ function wallmessage_post(&$a) {
dbesc($recipient)
);
if(! count($r)) {
if(! dbm::is_result($r)) {
logger('wallmessage: no recipient');
return;
}
@ -91,7 +91,7 @@ function wallmessage_content(&$a) {
dbesc($recipient)
);
if(! count($r)) {
if(! dbm::is_result($r)) {
notice( t('No recipient.') . EOL);
logger('wallmessage: no recipient');
return;