tobias/friendica
1
0
Fork 0
Code Pull requests Activity

More usage of dbm::is_result($r) instead of count($r):

Browse source 
- count() returns very different results and never a boolean (not even false on
  error condition).
- therefore you should NOT use it in boolean expressions. This still *can* be
  done in PHP because of its lazyness. But it is discouraged if it comes to
  more clean code.

Signed-off-by: Roland Häder <roland@mxchange.org>
This commit is contained in:
Roland Häder 2016-12-13 10:44:13 +01:00
commit 6a8a36f12d
115 changed files with 439 additions and 437 deletions
Download patch file Download diff file Expand all files Collapse all files

8
mod/photos.php
View file

@ -165,7 +165,7 @@ function photos_post(&$a) {
intval($page_owner_uid)
);
if (! count($r)) {
if (! dbm::is_result($r)) {
notice( t('Contact information unavailable') . EOL);
logger('photos_post: unable to locate contact record for page owner. uid=' . $page_owner_uid);
killme();
@ -186,7 +186,7 @@ function photos_post(&$a) {
dbesc($album),
intval($page_owner_uid)
);
if (! count($r)) {
if (! dbm::is_result($r)) {
notice( t('Album not found.') . EOL);
goaway($_SESSION['photo_return']);
return; // NOTREACHED
@ -748,7 +748,7 @@ function photos_post(&$a) {
dbesc($album),
intval($page_owner_uid)
);
if ((! count($r)) || ($album == t('Profile Photos')))
if ((! dbm::is_result($r)) || ($album == t('Profile Photos')))
$visible = 1;
else
$visible = 0;
@ -1573,7 +1573,7 @@ function photos_content(&$a) {
}
$comments = '';
if (! count($r)) {
if (! dbm::is_result($r)) {
if ($can_post || can_write_wall($a,$owner_uid)) {
if ($link_item['last-child']) {
$comments .= replace_macros($cmnt_tpl,array(