More usage of dbm::is_result($r) instead of count($r):
- count() returns very different results and never a boolean (not even false on error condition). - therefore you should NOT use it in boolean expressions. This still *can* be done in PHP because of its lazyness. But it is discouraged if it comes to more clean code. Signed-off-by: Roland Häder <roland@mxchange.org>
This commit is contained in:
parent
293436e5fd
commit
6a8a36f12d
115 changed files with 439 additions and 437 deletions
|
@ -10,7 +10,7 @@ function fcontact_store($url,$name,$photo) {
|
|||
dbesc($nurl)
|
||||
);
|
||||
|
||||
if(count($r))
|
||||
if(dbm::is_result($r))
|
||||
return $r[0]['id'];
|
||||
|
||||
$r = q("INSERT INTO `fcontact` ( `url`, `name`, `photo` ) VALUES ( '%s', '%s', '%s' ) ",
|
||||
|
@ -19,11 +19,11 @@ function fcontact_store($url,$name,$photo) {
|
|||
dbesc($photo)
|
||||
);
|
||||
|
||||
if($r) {
|
||||
if(dbm::is_result($r)) {
|
||||
$r = q("SELECT `id` FROM `fcontact` WHERE `url` = '%s' LIMIT 1",
|
||||
dbesc($nurl)
|
||||
);
|
||||
if(count($r))
|
||||
if(dbm::is_result($r))
|
||||
return $r[0]['id'];
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue