tobias/friendica
1
0
Fork 0
Code Pull requests Activity

Reenable Twitter/Retweet tests

Browse source
This commit is contained in:
Philipp Holzer 2021-12-09 22:41:19 +01:00
parent d9949610c5
commit 631b9a84fc
Signed by: nupplaPhil
GPG key ID: 24A7501396EB5432
3 changed files with 71 additions and 42 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/Module/Api/Twitter/Statuses/Retweet.php
View file

@ -70,6 +70,6 @@ class Retweet extends BaseApi
$status_info = DI::twitterStatus()->createFromItemId($item_id, $uid)->toArray(); $status_info = DI::twitterStatus()->createFromItemId($item_id, $uid)->toArray();
DI::apiResponse()->exit('status', ['status' => $status_info], $this->parameters['extension'] ?? null); DI::apiResponse()->exit('statuses', ['status' => $status_info], $this->parameters['extension'] ?? null);
} }
} }

41
tests/legacy/ApiTest.php
View file

@ -835,47 +835,6 @@ class ApiTest extends FixtureTest
// api_statuses_mediap('json'); // api_statuses_mediap('json');
} }
/**
* Test the api_statuses_repeat() function.
*
* @return void
*/
public function testApiStatusesRepeat()
{
// $this->expectException(\Friendica\Network\HTTPException\ForbiddenException::class);
// api_statuses_repeat('json');
}
/**
* Test the api_statuses_repeat() function without an authenticated user.
*
* @return void
*/
public function testApiStatusesRepeatWithoutAuthenticatedUser()
{
// $this->expectException(\Friendica\Network\HTTPException\UnauthorizedException::class);
// BasicAuth::setCurrentUserID();
// $_SESSION['authenticated'] = false;
// api_statuses_repeat('json');
}
/**
* Test the api_statuses_repeat() function with an ID.
*
* @return void
*/
public function testApiStatusesRepeatWithId()
{
// DI::args()->setArgv(['', '', '', 1]);
// $result = api_statuses_repeat('json');
// self::assertStatus($result['status']);
// Also test with a shared status
// DI::args()->setArgv(['', '', '', 5]);
// $result = api_statuses_repeat('json');
// self::assertStatus($result['status']);
}
/** /**
* Test the api_format_messages() function. * Test the api_format_messages() function.
* *

70
tests/src/Module/Api/Twitter/Statuses/RetweetTest.php Normal file
View file

@ -0,0 +1,70 @@
<?php
namespace Friendica\Test\src\Module\Api\Twitter\Statuses;
use Friendica\App\Router;
use Friendica\DI;
use Friendica\Module\Api\Twitter\Statuses\Retweet;
use Friendica\Network\HTTPException\BadRequestException;
use Friendica\Test\src\Module\Api\ApiTest;
class RetweetTest extends ApiTest
{
/**
* Test the api_statuses_repeat() function.
*
* @return void
*/
public function testApiStatusesRepeat()
{
$this->expectException(BadRequestException::class);
$retweet = new Retweet(DI::app(), DI::l10n(), DI::baseUrl(), DI::args(), DI::logger(), DI::profiler(), DI::apiResponse(), ['REQUEST_METHOD' => Router::POST]);
$retweet->run();
}
/**
* Test the api_statuses_repeat() function without an authenticated user.
*
* @return void
*/
public function testApiStatusesRepeatWithoutAuthenticatedUser()
{
self::markTestIncomplete('Needs BasicAuth as dynamic method for overriding first');
// $this->expectException(\Friendica\Network\HTTPException\UnauthorizedException::class);
// BasicAuth::setCurrentUserID();
// $_SESSION['authenticated'] = false;
// api_statuses_repeat('json');
}
/**
* Test the api_statuses_repeat() function with an ID.
*
* @return void
*/
public function testApiStatusesRepeatWithId()
{
$retweet = new Retweet(DI::app(), DI::l10n(), DI::baseUrl(), DI::args(), DI::logger(), DI::profiler(), DI::apiResponse(), ['REQUEST_METHOD' => Router::POST]);
$response = $retweet->run(['id' => 1]);
$json = $this->toJson($response);
self::assertStatus($json);
}
/**
* Test the api_statuses_repeat() function with an shared ID.
*
* @return void
*/
public function testApiStatusesRepeatWithSharedId()
{
$retweet = new Retweet(DI::app(), DI::l10n(), DI::baseUrl(), DI::args(), DI::logger(), DI::profiler(), DI::apiResponse(), ['REQUEST_METHOD' => Router::POST]);
$response = $retweet->run(['id' => 5]);
$json = $this->toJson($response);
self::assertStatus($json);
}
}