tobias/friendica
1
0
Fork 0
Code Pull requests Activity

Merge pull request #11697 from Quix0r/fixes/contact-user-isblocked-retuning-null

Browse source 
Fixed: TypeError: "Return value of Friendica\Model\Contact\User::isBlocked() must be of the type bool, null returned"
This commit is contained in:
Hypolite Petovan 2022-06-27 07:57:55 -04:00 committed by GitHub
parent 43531d5aa0 8e19998191
commit 61d5f64933
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/Model/Contact.php
View file

@ -1180,7 +1180,7 @@ class Contact
$contact = self::getByURL($url, false, ['id', 'network', 'uri-id'], $uid);
if (!empty($contact)) {
$contact_id = $contact["id"];
$contact_id = $contact['id'];
if (empty($update) && (!empty($contact['uri-id']) || is_bool($update))) {
Logger::debug('Contact found', ['url' => $url, 'uid' => $uid, 'update' => $update, 'cid' => $contact_id]);
@ -1197,10 +1197,10 @@ class Contact
$data = [];
if (empty($default['network']) || $update) {
$data = Probe::uri($url, "", $uid);
$data = Probe::uri($url, '', $uid);
// Take the default values when probing failed
if (!empty($default) && !in_array($data["network"], array_merge(Protocol::NATIVE_SUPPORT, [Protocol::PUMPIO]))) {
if (!empty($default) && !in_array($data['network'], array_merge(Protocol::NATIVE_SUPPORT, [Protocol::PUMPIO]))) {
$data = array_merge($data, $default);
}
} elseif (!empty($default['network'])) {

10
src/Model/Contact/User.php
View file

@ -183,7 +183,7 @@ class User
if (!empty($cdata['public'])) {
$public_contact = DBA::selectFirst('user-contact', ['blocked'], ['cid' => $cdata['public'], 'uid' => $uid]);
if (DBA::isResult($public_contact)) {
$public_blocked = $public_contact['blocked'];
$public_blocked = (bool) $public_contact['blocked'];
}
}
@ -192,7 +192,7 @@ class User
if (!empty($cdata['user'])) {
$user_contact = DBA::selectFirst('contact', ['blocked'], ['id' => $cdata['user'], 'pending' => false]);
if (DBA::isResult($user_contact)) {
$user_blocked = $user_contact['blocked'];
$user_blocked = (bool) $user_contact['blocked'];
}
}
@ -246,7 +246,7 @@ class User
if (!empty($cdata['public'])) {
$public_contact = DBA::selectFirst('user-contact', ['ignored'], ['cid' => $cdata['public'], 'uid' => $uid]);
if (DBA::isResult($public_contact)) {
$public_ignored = $public_contact['ignored'];
$public_ignored = (bool) $public_contact['ignored'];
}
}
@ -255,7 +255,7 @@ class User
if (!empty($cdata['user'])) {
$user_contact = DBA::selectFirst('contact', ['readonly'], ['id' => $cdata['user'], 'pending' => false]);
if (DBA::isResult($user_contact)) {
$user_ignored = $user_contact['readonly'];
$user_ignored = (bool) $user_contact['readonly'];
}
}
@ -306,7 +306,7 @@ class User
if (!empty($cdata['public'])) {
$public_contact = DBA::selectFirst('user-contact', ['collapsed'], ['cid' => $cdata['public'], 'uid' => $uid]);
if (DBA::isResult($public_contact)) {
$collapsed = $public_contact['collapsed'];
$collapsed = (bool) $public_contact['collapsed'];
}
}