tobias/friendica
1
0
Fork 0
Code Pull requests Activity

Adding ConfigCacheTest

Browse source
This commit is contained in:
Philipp Holzer 2019-02-10 12:30:13 +01:00
parent b6e2c254fb
commit 2a42f8dded
No known key found for this signature in database
GPG key ID: 517BE60E2CE5C8A5
3 changed files with 185 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/Core/Config/AbstractDbaConfigAdapter.php
View file

@ -2,8 +2,6 @@
namespace Friendica\Core\Config;
use Friendica\Database\DBA;
abstract class AbstractDbaConfigAdapter
{
/** @var bool */

11
src/Core/Config/ConfigCache.php
View file

@ -18,7 +18,7 @@ class ConfigCache implements IConfigCache, IPConfigCache
*/
public function __construct(array $config = [])
{
$this->config = $config;
$this->loadConfigArray($config);
}
/**
@ -110,6 +110,9 @@ class ConfigCache implements IConfigCache, IPConfigCache
} else {
if (isset($this->config[$cat][$key])) {
unset($this->config[$cat][$key]);
if (count($this->config[$cat]) == 0) {
unset($this->config[$cat]);
}
}
}
}
@ -160,6 +163,12 @@ class ConfigCache implements IConfigCache, IPConfigCache
{
if (isset($this->config[$uid][$cat][$key])) {
unset($this->config[$uid][$cat][$key]);
if (count($this->config[$uid][$cat]) == 0) {
unset($this->config[$uid][$cat]);
if (count($this->config[$uid]) == 0) {
unset($this->config[$uid]);
}
}
}
}

175
tests/src/Core/Config/ConfigCacheTest.php Normal file
View file

@ -0,0 +1,175 @@
<?php
namespace Friendica\Test\Core\Config;
use Friendica\Core\Config\ConfigCache;
use Friendica\Test\MockedTest;
class ConfigCacheTest extends MockedTest
{
public function dataTests()
{
return [
'normal' => [
'data' => [
'system' => [
'test' => 'it',
'boolTrue' => true,
'boolFalse' => false,
'int' => 235,
'dec' => 2.456,
'array' => ['1', 2, '3', true, false],
],
'config' => [
'a' => 'value',
],
]
]
];
}
private function assertConfigValues($data, ConfigCache $configCache, $uid = null)
{
foreach ($data as $cat => $values) {
foreach ($values as $key => $value) {
if (isset($uid)) {
$this->assertEquals($data[$cat][$key], $configCache->getP($uid, $cat, $key));
} else {
$this->assertEquals($data[$cat][$key], $configCache->get($cat, $key));
}
}
}
}
/**
* Test the loadConfigArray() method without override
* @dataProvider dataTests
*/
public function testLoadConfigArray($data)
{
$configCache = new ConfigCache();
$configCache->loadConfigArray($data);
$this->assertConfigValues($data, $configCache);
}
/**
* Test the loadConfigArray() method with overrides
* @dataProvider dataTests
*/
public function testLoadConfigArrayOverride($data)
{
$override = [
'system' => [
'test' => 'not',
'boolTrue' => false,
]
];
$configCache = new ConfigCache();
$configCache->loadConfigArray($data);
$configCache->loadConfigArray($override);
$this->assertConfigValues($data, $configCache);
// override the value
$configCache->loadConfigArray($override, true);
$this->assertEquals($override['system']['test'], $configCache->get('system', 'test'));
$this->assertEquals($override['system']['boolTrue'], $configCache->get('system', 'boolTrue'));
}
/**
* Test the getAll() method
* @dataProvider dataTests
*/
public function testGetAll($data)
{
$configCache = new ConfigCache();
$configCache->loadConfigArray($data);
$all = $configCache->getAll();
$this->assertContains($data['system'], $all);
// config values are stored directly in the array base
$this->assertEquals($data['config']['a'], $all['a']);
}
/**
* Test the set() and get() method
* @dataProvider dataTests
*/
public function testSetGet($data)
{
$configCache = new ConfigCache();
foreach ($data as $cat => $values) {
foreach ($values as $key => $value) {
$configCache->set($cat, $key, $value);
}
}
$this->assertConfigValues($data, $configCache);
}
/**
* Test the delete() method
* @dataProvider dataTests
*/
public function testDelete($data)
{
$configCache = new ConfigCache($data);
foreach ($data as $cat => $values) {
foreach ($values as $key => $value) {
$configCache->delete($cat, $key);
}
}
$this->assertEmpty($configCache->getAll());
}
/**
* Test the setP() and getP() methods
* @dataProvider dataTests
*/
public function testSetGetP($data)
{
$configCache = new ConfigCache();
$uid = 345;
foreach ($data as $cat => $values) {
foreach ($values as $key => $value) {
$configCache->setP($uid, $cat, $key, $value);
}
}
$this->assertConfigValues($data, $configCache, $uid);
}
/**
* Test the deleteP() method
* @dataProvider dataTests
*/
public function testDeleteP($data)
{
$configCache = new ConfigCache();
$uid = 345;
foreach ($data as $cat => $values) {
foreach ($values as $key => $value) {
$configCache->setP($uid, $cat, $key, $value);
}
}
foreach ($data as $cat => $values) {
foreach ($values as $key => $value) {
$configCache->deleteP($uid, $cat, $key);
}
}
$this->assertEmpty($configCache->getAll());
}
}