friendica

strk/friendica

Fork 0

Commit graph

622b978a84

Merge pull request #11655 from Quix0r/fixes/more-type-hints-002 develop Hypolite Petovan 2022-06-19 09:27:29 -0400
5a553df7d8

Incremented database version Roland Häder 2022-06-19 14:41:04 +0200
ed3c53a5f8

Ops, not here wanted. :-( Roland Häder 2022-06-19 14:06:20 +0200
bff57bb030

Changes: - added type-hints - added returned type-hints in interface (I checked all) Roland Häder 2022-06-19 13:59:58 +0200
777872e6fa

Merge pull request #11658 from tobiasd/20220619-accesskey Hypolite Petovan 2022-06-19 07:09:20 -0400
c0d7f8944d

Some calls saved Roland Häder 2022-06-19 11:25:52 +0200
60f8c2d795

Changes: - added missing type-hints - added documentation for a method Roland Häder 2022-06-19 10:49:26 +0200
5f6943b008

Changes: - MySQL index on BLOB/TEXT can only be partial (e.g.: column(length)) Roland Häder 2022-06-19 10:48:47 +0200
5792a01a01

Contact::getAccountType()'s parameter is never a string, ops Roland Häder 2022-06-19 09:35:53 +0200
f3599fa3e9

Changes: - dbstructure(null) is no longer possible, an empty string does it Roland Häder 2022-06-19 09:11:08 +0200
065dad79ca

updated the Accesskey documentation accordingly Tobias Diekershoff 2022-06-19 06:33:21 +0200
a063a89c57

Accesskey was used twice Tobias Diekershoff 2022-06-19 06:30:00 +0200
b6bfe72083

Wrong returned type, has to be array Roland Häder 2022-06-19 02:39:51 +0200
7bb0cb5323

Changes: - added more type-hints - DBStructure::existsTable() does no longer need array support for table name because this is no longer used (good work!) Roland Häder 2022-06-19 02:10:04 +0200
2c5685c89c

Changes: - changed to proper "use Foo\Bar;" - added doctag - added return type as this is fixed Roland Häder 2022-06-19 01:10:50 +0200
d7d2ad77ff

Ops, also this! Roland Häder 2022-06-18 23:31:44 +0200
39f2d197ea

Changed to suggestings (back to original) + fixed typo in scalar type Roland Häder 2022-06-18 23:30:13 +0200
6f1d52cf71

Changed back to suggestions by @MrPetovan Roland Häder 2022-06-18 23:23:50 +0200
2f961b11bf

Naming-convention: - variables should start lower-case: $image Roland Häder 2022-06-18 23:16:07 +0200
fa14a02a19

Changes: - added type-hints - added documentation - changed double-quotes to single Roland Häder 2022-06-18 23:12:25 +0200
f3b57008b5

Proper type is string Roland Häder 2022-06-18 18:41:07 +0200
41f34c4261

Maybe fix for: Roland Häder 2022-06-18 18:30:03 +0200
9691bb06fb

Changes: - added more type-hints - added missing documentation Roland Häder 2022-06-18 18:21:05 +0200
94eb426151

Nodeinfo::getOrganization() doesn't need configuration object being inserted when you have DI::config() around. Roland Häder 2022-06-18 17:56:01 +0200
c29c49797a

Added missing type-hints Roland Häder 2022-06-18 17:52:34 +0200
4e437190c5

Renamed variable, no need for "orig_" prefix Roland Häder 2022-06-18 17:49:57 +0200
a1a81cdc6b

Continued: - changed some double-quotes to single - added missing type-hints - added missing documentation - fixed indenting a bit Roland Häder 2022-06-18 17:45:53 +0200
8fc710f82a

Continued: - added more type-hints - added some missing documentation - Return the result from DBA::delete() to let other methods know about it Roland Häder 2022-06-18 17:22:10 +0200
8ba3f13fae

Changes: - added more type-hints - added missing documentation Roland Häder 2022-06-18 17:09:18 +0200
7ec07178c8

Changes: - added missing type-hints - added missing documentation Roland Häder 2022-06-18 16:58:48 +0200
e90ad0c1cd

Merge pull request #11653 from Quix0r/fixes/more-type-hints Hypolite Petovan 2022-06-18 10:33:33 -0400
b2e5993314

Merge pull request #11654 from Quix0r/fixes/post-media-url-size Hypolite Petovan 2022-06-18 10:28:00 -0400
92a1d14e5e

Updated documentation and SQL dump, according to woodpecker tests Roland Häder 2022-06-18 16:02:10 +0200
8756d92316

Continued: - prevents a "Return value of Friendica\Core\Worker::workerProcess() must be of the type array, bool returned" Roland Häder 2022-06-18 15:56:58 +0200
8aaf99c61d

Sizes increased for: - video files that have sizes var being int allowes - URLs that might be longer (e.g. magnet: URLs) than varbinary(511) allows Roland Häder 2022-06-18 15:30:36 +0200
bd3a7b9877

Ops, needs to be a variable: Roland Häder 2022-06-18 09:58:44 +0200
69cda4f760

Fixed TypeError: "Argument 1 passed to Friendica\Core\System::httpExit() must be of the type string, null given, called in /var/www/.../src/Module/DFRN/Poll.php on line 37" Roland Häder 2022-06-18 05:41:19 +0200
7cbb818c93

Set type-hint for parameter $data to SimpleXMLElement as $fields in dispatch() is the same and being handled over. Roland Häder 2022-06-18 05:18:38 +0200
89302d0843

Some outside code relies on returned "false" Roland Häder 2022-06-18 05:06:00 +0200
aaf5c323b6

Fixed indenting Roland Häder 2022-06-18 05:04:04 +0200
adb4aea6ad

Changes: - added some type-hints - replaced most double-quotes (only Diaspora.php, later more) with single - added some documentation - normalized indenting in Diaspora.php (I hope I got all?) Roland Häder 2022-06-18 05:01:51 +0200
51f43278d6

Fixed incompatible types Roland Häder 2022-06-17 18:00:06 +0200
88c40f3336 Ops, wrong type again Roland Häder 2022-06-17 13:02:43 +0200
a770634b95 Ops, wrong type Roland Häder 2022-06-17 12:22:40 +0200
36d56a4041 Continued: - changed back to 'return false;' as other methods heavily rely on false instead of an empty array as pointed out by @heluecht@pirati.ca - $fetched_contact should be initialized as an empty array, let's not make this code more crazier than it already is (see APContact::getByURL()) Roland Häder 2022-06-17 11:48:52 +0200
c467bff79f Some more type-hints added Roland Häder 2022-06-17 11:17:53 +0200
4f3321cc9f Nore fixes Roland Häder 2022-06-17 11:04:47 +0200
10bb7d5625 Possible fix for Roland Häder 2022-06-17 10:57:17 +0200
fdd237a090 Fix for "Uncaught Exception TypeError: "Argument 1 passed to Friendica\Model\APContact::unarchiveInbox() must be of the type string, null given" error message Roland Häder 2022-06-17 10:53:45 +0200
605e7d55b3 Continued: - added more type-hints - some methods in Diaspora returned void but integer was documented so I changed it to -1 to have a proper type-hint Roland Häder 2022-06-17 10:44:13 +0200
0c9aff8a09 Also need to declare $profile or otherwise an invocation of Receiver::getReceiverForActor() will fail. Roland Häder 2022-06-17 09:51:11 +0200
af8cd5ca86 Worker::getWaitingJobForPID() can also return FALSE on failure ... :-( Roland Häder 2022-06-16 22:17:37 +0200
227bab43a8 Ops, wrong type-hint here, must be string ($nickname can never be an integer). Roland Häder 2022-06-16 22:15:06 +0200
f7c1eaa858 Continued: - added type-hints - removed out-dated documentation - added some missing documentation Roland Häder 2022-06-16 22:12:38 +0200
e484b6d6dc Continued: - added more type-hints - added some documentation - Contact::getAccountType() should only process string, not null Roland Häder 2022-06-16 21:57:02 +0200
45b5f67bca Fix for non-existing record system.mobile_theme in config table Roland Häder 2022-06-16 20:58:24 +0200
5c9ce790bf Fixed: - $object_data['actor'] can be null, but Receiver::getReceivers()'s 2nd parameter expect it to be string Roland Häder 2022-06-16 20:47:59 +0200
33768ea1c6 Some fixes: - $gsid's default value cannot sadly be 0, it now must be null to allow some code work - added some more type-hints - documented a bit more Roland Häder 2022-06-16 20:42:40 +0200
4e53666c70 Added more type-hints Roland Häder 2022-06-16 20:33:10 +0200
7560dccc08 Added again more type-hints Roland Häder 2022-06-16 20:17:04 +0200
2766c7d9cf Continued: - added more type-hints - added some missing documentation Roland Häder 2022-06-16 20:01:09 +0200
a587217f47 Fixed "Argument 4 passed to Friendica\Protocol\DFRN::processVerbs() must be of the type bool" Roland Häder 2022-06-16 19:39:49 +0200
dd54e52575 MrPetovan brought the right one up: > Since this is depending on remote systems, the log can quickly fill with unactionable messages. Roland Häder 2022-06-16 19:21:07 +0200
c351099c5a Ops, bad type-hint here Roland Häder 2022-06-16 19:17:25 +0200
2c5595c358 Another incompatible method declaration fixed + type-hints added Roland Häder 2022-06-16 18:36:56 +0200
40d7f29a11 Continued: - more type-hints - fixed incompatible method declarations Roland Häder 2022-06-16 18:28:38 +0200
1edc6b3c3b Added more type-hints for "App" classes Roland Häder 2022-06-16 16:49:43 +0200
42b04f397b Added more type-hints Roland Häder 2022-06-16 16:38:58 +0200
aa5f0d5ec1 Added more type-hints and documented a few methods Roland Häder 2022-06-16 16:35:39 +0200
97e27cb523 Added more type-hints Roland Häder 2022-06-16 16:25:30 +0200
c2e889cfae Added more type-hints Roland Häder 2022-06-16 14:59:29 +0200
a8a21c7fb6

Merge pull request #11652 from Quix0r/fixes/causer-id Hypolite Petovan 2022-06-17 10:12:22 -0400
5106bb2881

Added parenthesis Roland Häder 2022-06-17 09:40:29 +0200
a903dbd77e

Wrong braces causing 'undefined index causer-id'. See #11632 Roland Häder 2022-06-16 22:59:41 +0200
51b31a846f

Merge pull request #11649 from Quix0r/fixes/return-type-fetch-content Hypolite Petovan 2022-06-16 13:16:06 -0400
6035de6883

Continued: - added more type-hints - also cannot return FALSE when array is set Roland Häder 2022-06-16 19:03:53 +0200
341d8860d1

Merge pull request #11647 from Quix0r/fixes/type-error-exception Hypolite Petovan 2022-06-16 11:53:15 -0400
51a7b5c584

Made also this one sweeter (null-coalscing) Roland Häder 2022-06-16 17:36:32 +0200
0e1f734b03

Also make this null-coalscing Roland Häder 2022-06-16 17:34:43 +0200
e8fee5644b

Ops, syntax errors get unnoticed with a simple editor. :-( Roland Häder 2022-06-16 17:03:25 +0200
624e4c192c

Changed to null-coalscing style (??) as sugguested by @MrPetovan Roland Häder 2022-06-16 16:59:54 +0200
962b06bf41

Added check as suggested by @MrPetovan for empty $message. Roland Häder 2022-06-16 15:45:22 +0200
f2b7326650

This will 2 things: 1) The first change prevents "expensive" code in HTML::toBBcode() to be executed just for an empty string which makes no sense. 2) The above change was maybe flawed as $apcontact['about'] would have never been created, not even empty which could have side effects Roland Häder 2022-06-16 15:08:04 +0200
7814ba4fc4

Fixes for bad invocations of HTML::toBBCode() (1st parameter is now string) Roland Häder 2022-06-16 14:21:11 +0200
b200874f17

Ops: - wrong way around (!empty($foo)) is proper - also needed to be checked on $acitivty['content'] Roland Häder 2022-06-16 13:38:40 +0200
b1e4c0931a

Fixes and type-hints: - added more checked type-hints as they prevent bad method invocations - fixed TypeError for HTML::toBBCode() invocations with NULL as first (wrong) argument, thanks to @tobias@social.diekershoff.de pointing this out. Roland Häder 2022-06-16 13:14:00 +0200
bb57d45237

Merge pull request #11645 from Quix0r/fixes/e-notice_use Hypolite Petovan 2022-06-16 08:45:50 -0400
e9af4b5bb9

Shorter code, thanks to @annando pointing this out Roland Häder 2022-06-16 13:29:30 +0200
65da5246ca

Fixed possibble "Trying to access array offset on value of type bool" E_NOTICE Roland Häder 2020-10-29 22:34:43 +0100
13ef86d4a3

Merge pull request #11644 from Quix0r/fixes/file-permissions Tobias Diekershoff 2022-06-16 10:02:31 +0200
58c48977ec

These files should never have executable files Roland Häder 2022-04-28 23:10:17 +0200
fd0d4aedee

Font files should NEVER be executable Roland Häder 2022-01-29 08:17:57 +0100
207bf58801

Merge pull request #11624 from Quix0r/fixes/type-hints Hypolite Petovan 2022-06-15 16:32:25 -0400
5fa954208a

Changes: - ops, wasn't actually fixing return; to proper return ''; - added more type-hints - added TODO ($uid is unused) Roland Häder 2022-06-15 22:28:33 +0200
a3fa95e8e4

Changes: - added more type-hints - changed return; to return ''; when string was requested as returned type-hint (thanks to @MrPetovan) Roland Häder 2022-06-15 22:03:13 +0200
34aee64349

Added more type-hints Roland Häder 2022-06-14 09:08:09 +0200
143e4c4a18

Added more known type-hints Roland Häder 2022-06-08 17:26:47 +0200
98954dd14e

Merge pull request #11643 from annando/avatar-path Tobias Diekershoff 2022-06-15 06:25:31 +0200
726c4dff7d You can now store the avatar in a separate folder and host Michael 2022-06-15 03:59:26 +0000
f839cd3826

Merge pull request #11642 from annando/platform-default Hypolite Petovan 2022-06-13 16:31:34 -0400