friendica

nupplaPhil/friendica

Fork 0

Commit graph

fbae0b8bcf

Changes: - renamed ItemArrayFromMail() to getItemArrayFromMail() to follow naming-convetion - added missing type-hints - added missing documentation Roland Häder 2022-06-20 21:21:32 +02:00
ea22e88896

Added documentation Roland Häder 2022-06-20 21:02:18 +02:00
752953e472

Changes: - as @MrPetovan pointed out, $actor can be NULL earlier and used later as NULL - added some missing type-hints - added missing documentation - the added @TODO points out to avoid true|false|null for a boolean Roland Häder 2022-06-20 20:59:08 +02:00
88eacbf66e Ensure parameter 4 of Post\Media::splitAttachment is a boolean value Hypolite Petovan 2022-06-20 14:34:02 -04:00
0c12e947dd

Changes: - null was 2nd argument's value before, an empty string is basically the same here Roland Häder 2022-06-20 20:01:25 +02:00
feb87e8dc3

Changes: - let's start throwing exceptions on e.g. invalid arguments instead of returning FALSE Roland Häder 2022-06-20 19:08:23 +02:00
4fb03cf163

Changes: - fixed a null value handled over to Friendica\Model\APContact::getByURL() - added missing type-hints Roland Häder 2022-06-20 19:04:01 +02:00
e96a548286

Changes: - dumped default value for $input - added unknown 'platform' which prevents an "Undefined index: platform in /var/www/.../src/Model/GServer.php on line 940" error Roland Häder 2022-06-20 18:55:17 +02:00
e5cc7a5ab1

Fixes: - Strings::isHex() should not be misused for checking on NULL Roland Häder 2022-06-20 08:25:17 +02:00
6743de63f5

Changed: - DBA::exists() should only be used for checking if records exists. - if you want to check if a table exists, please ALWAYS use DBStructure::existsTable() instead Roland Häder 2022-06-20 08:18:53 +02:00
cc750d743b

Changes: - some methods now need to return bool to be compatible - added some missing type-hints Roland Häder 2022-06-20 08:12:09 +02:00
9c80dd35e5

Both declarations must be the same Roland Häder 2022-06-20 08:06:45 +02:00
13a5a30b28

Merge pull request #11659 from MrPetovan/bug/11511-relocate-quote-identifier Tobias Diekershoff 2022-06-20 06:26:33 +02:00
cd3b01fd82

Changed: - cannot have type-hints :-( Roland Häder 2022-06-20 03:48:12 +02:00
94a594eeb2

Ops, wrong type-hint Roland Häder 2022-06-20 03:36:13 +02:00
ec96f2252e

Changes: - added type-hints - added some missing documentation Roland Häder 2022-06-20 03:10:02 +02:00
14bf72e4fe

Changes: - added some documentation - added type-hints Roland Häder 2022-06-20 02:45:53 +02:00
97904ea7dd

Changes: - added type-hints - added missing documentation Roland Häder 2022-06-20 01:08:52 +02:00
a0c8fc6d6e

Changes: - added more type-hints Roland Häder 2022-06-20 00:51:59 +02:00
7528b79469

Merge pull request #11657 from Quix0r/fixes/post-media-size-bigint Hypolite Petovan 2022-06-19 20:23:29 -04:00
d48e40c1bf Add missing identifier quote in Database->replaceInTableFields Hypolite Petovan 2022-06-19 20:06:12 -04:00
d276f2c62b

Changes: - added type-hints - changed some double-quotes to single Roland Häder 2022-06-20 00:58:52 +02:00
8c38265b37

Changes: - url to varbinary(1024) - preview to varbinary(512) Roland Häder 2022-06-19 23:06:04 +02:00
2512449751

Incremented again Roland Häder 2022-06-19 15:32:14 +02:00
9f24a4b60e

Fixed documentation/SQL dump with ./bin/console dbstructure dump Roland Häder 2022-06-19 09:10:36 +02:00
96954e2b18

Size "mediumint" wasn't enough: https://digitalcourage.video/static/webseed/5a039eb2-9fbc-441d-a772-59ae3ee65c15-1080.mp4 has 6758472669 Bytes Roland Häder 2022-06-19 02:31:59 +02:00
622b978a84

Merge pull request #11655 from Quix0r/fixes/more-type-hints-002 Hypolite Petovan 2022-06-19 09:27:29 -04:00
5a553df7d8

Incremented database version Roland Häder 2022-06-19 14:41:04 +02:00
ed3c53a5f8

Ops, not here wanted. :-( Roland Häder 2022-06-19 14:06:20 +02:00
bff57bb030

Changes: - added type-hints - added returned type-hints in interface (I checked all) Roland Häder 2022-06-19 13:59:58 +02:00
777872e6fa

Merge pull request #11658 from tobiasd/20220619-accesskey Hypolite Petovan 2022-06-19 07:09:20 -04:00
c0d7f8944d

Some calls saved Roland Häder 2022-06-19 11:25:52 +02:00
60f8c2d795

Changes: - added missing type-hints - added documentation for a method Roland Häder 2022-06-19 10:49:26 +02:00
5f6943b008

Changes: - MySQL index on BLOB/TEXT can only be partial (e.g.: column(length)) Roland Häder 2022-06-19 10:48:47 +02:00
5792a01a01

Contact::getAccountType()'s parameter is never a string, ops Roland Häder 2022-06-19 09:35:53 +02:00
f3599fa3e9

Changes: - dbstructure(null) is no longer possible, an empty string does it Roland Häder 2022-06-19 09:11:08 +02:00
065dad79ca

updated the Accesskey documentation accordingly Tobias Diekershoff 2022-06-19 06:33:21 +02:00
a063a89c57

Accesskey was used twice Tobias Diekershoff 2022-06-19 06:30:00 +02:00
b6bfe72083

Wrong returned type, has to be array Roland Häder 2022-06-19 02:39:51 +02:00
7bb0cb5323

Changes: - added more type-hints - DBStructure::existsTable() does no longer need array support for table name because this is no longer used (good work!) Roland Häder 2022-06-19 02:10:04 +02:00
2c5685c89c

Changes: - changed to proper "use Foo\Bar;" - added doctag - added return type as this is fixed Roland Häder 2022-06-19 01:10:50 +02:00
d7d2ad77ff

Ops, also this! Roland Häder 2022-06-18 23:31:44 +02:00
39f2d197ea

Changed to suggestings (back to original) + fixed typo in scalar type Roland Häder 2022-06-18 23:30:13 +02:00
6f1d52cf71

Changed back to suggestions by @MrPetovan Roland Häder 2022-06-18 23:23:50 +02:00
2f961b11bf

Naming-convention: - variables should start lower-case: $image Roland Häder 2022-06-18 23:16:07 +02:00
fa14a02a19

Changes: - added type-hints - added documentation - changed double-quotes to single Roland Häder 2022-06-18 23:12:25 +02:00
f3b57008b5

Proper type is string Roland Häder 2022-06-18 18:41:07 +02:00
41f34c4261

Maybe fix for: Roland Häder 2022-06-18 18:30:03 +02:00
9691bb06fb

Changes: - added more type-hints - added missing documentation Roland Häder 2022-06-18 18:21:05 +02:00
94eb426151

Nodeinfo::getOrganization() doesn't need configuration object being inserted when you have DI::config() around. Roland Häder 2022-06-18 17:56:01 +02:00
c29c49797a

Added missing type-hints Roland Häder 2022-06-18 17:52:34 +02:00
4e437190c5

Renamed variable, no need for "orig_" prefix Roland Häder 2022-06-18 17:49:57 +02:00
a1a81cdc6b

Continued: - changed some double-quotes to single - added missing type-hints - added missing documentation - fixed indenting a bit Roland Häder 2022-06-18 17:45:53 +02:00
8fc710f82a

Continued: - added more type-hints - added some missing documentation - Return the result from DBA::delete() to let other methods know about it Roland Häder 2022-06-18 17:22:10 +02:00
8ba3f13fae

Changes: - added more type-hints - added missing documentation Roland Häder 2022-06-18 17:09:18 +02:00
7ec07178c8

Changes: - added missing type-hints - added missing documentation Roland Häder 2022-06-18 16:58:48 +02:00
e90ad0c1cd

Merge pull request #11653 from Quix0r/fixes/more-type-hints Hypolite Petovan 2022-06-18 10:33:33 -04:00
b2e5993314

Merge pull request #11654 from Quix0r/fixes/post-media-url-size Hypolite Petovan 2022-06-18 10:28:00 -04:00
92a1d14e5e

Updated documentation and SQL dump, according to woodpecker tests Roland Häder 2022-06-18 16:02:10 +02:00
8756d92316

Continued: - prevents a "Return value of Friendica\Core\Worker::workerProcess() must be of the type array, bool returned" Roland Häder 2022-06-18 15:56:58 +02:00
8aaf99c61d

Sizes increased for: - video files that have sizes var being int allowes - URLs that might be longer (e.g. magnet: URLs) than varbinary(511) allows Roland Häder 2022-06-18 15:30:36 +02:00
bd3a7b9877

Ops, needs to be a variable: Roland Häder 2022-06-18 09:58:44 +02:00
69cda4f760

Fixed TypeError: "Argument 1 passed to Friendica\Core\System::httpExit() must be of the type string, null given, called in /var/www/.../src/Module/DFRN/Poll.php on line 37" Roland Häder 2022-06-18 05:41:19 +02:00
7cbb818c93

Set type-hint for parameter $data to SimpleXMLElement as $fields in dispatch() is the same and being handled over. Roland Häder 2022-06-18 05:18:38 +02:00
89302d0843

Some outside code relies on returned "false" Roland Häder 2022-06-18 05:06:00 +02:00
aaf5c323b6

Fixed indenting Roland Häder 2022-06-18 05:04:04 +02:00
adb4aea6ad

Changes: - added some type-hints - replaced most double-quotes (only Diaspora.php, later more) with single - added some documentation - normalized indenting in Diaspora.php (I hope I got all?) Roland Häder 2022-06-18 05:01:51 +02:00
51f43278d6

Fixed incompatible types Roland Häder 2022-06-17 18:00:06 +02:00
88c40f3336 Ops, wrong type again Roland Häder 2022-06-17 13:02:43 +02:00
a770634b95 Ops, wrong type Roland Häder 2022-06-17 12:22:40 +02:00
36d56a4041 Continued: - changed back to 'return false;' as other methods heavily rely on false instead of an empty array as pointed out by @heluecht@pirati.ca - $fetched_contact should be initialized as an empty array, let's not make this code more crazier than it already is (see APContact::getByURL()) Roland Häder 2022-06-17 11:48:52 +02:00
c467bff79f Some more type-hints added Roland Häder 2022-06-17 11:17:53 +02:00
4f3321cc9f Nore fixes Roland Häder 2022-06-17 11:04:47 +02:00
10bb7d5625 Possible fix for Roland Häder 2022-06-17 10:57:17 +02:00
fdd237a090 Fix for "Uncaught Exception TypeError: "Argument 1 passed to Friendica\Model\APContact::unarchiveInbox() must be of the type string, null given" error message Roland Häder 2022-06-17 10:53:45 +02:00
605e7d55b3 Continued: - added more type-hints - some methods in Diaspora returned void but integer was documented so I changed it to -1 to have a proper type-hint Roland Häder 2022-06-17 10:44:13 +02:00
0c9aff8a09 Also need to declare $profile or otherwise an invocation of Receiver::getReceiverForActor() will fail. Roland Häder 2022-06-17 09:51:11 +02:00
af8cd5ca86 Worker::getWaitingJobForPID() can also return FALSE on failure ... :-( Roland Häder 2022-06-16 22:17:37 +02:00
227bab43a8 Ops, wrong type-hint here, must be string ($nickname can never be an integer). Roland Häder 2022-06-16 22:15:06 +02:00
f7c1eaa858 Continued: - added type-hints - removed out-dated documentation - added some missing documentation Roland Häder 2022-06-16 22:12:38 +02:00
e484b6d6dc Continued: - added more type-hints - added some documentation - Contact::getAccountType() should only process string, not null Roland Häder 2022-06-16 21:57:02 +02:00
45b5f67bca Fix for non-existing record system.mobile_theme in config table Roland Häder 2022-06-16 20:58:24 +02:00
5c9ce790bf Fixed: - $object_data['actor'] can be null, but Receiver::getReceivers()'s 2nd parameter expect it to be string Roland Häder 2022-06-16 20:47:59 +02:00
33768ea1c6 Some fixes: - $gsid's default value cannot sadly be 0, it now must be null to allow some code work - added some more type-hints - documented a bit more Roland Häder 2022-06-16 20:42:40 +02:00
4e53666c70 Added more type-hints Roland Häder 2022-06-16 20:33:10 +02:00
7560dccc08 Added again more type-hints Roland Häder 2022-06-16 20:17:04 +02:00
2766c7d9cf Continued: - added more type-hints - added some missing documentation Roland Häder 2022-06-16 20:01:09 +02:00
a587217f47 Fixed "Argument 4 passed to Friendica\Protocol\DFRN::processVerbs() must be of the type bool" Roland Häder 2022-06-16 19:39:49 +02:00
dd54e52575 MrPetovan brought the right one up: > Since this is depending on remote systems, the log can quickly fill with unactionable messages. Roland Häder 2022-06-16 19:21:07 +02:00
c351099c5a Ops, bad type-hint here Roland Häder 2022-06-16 19:17:25 +02:00
2c5595c358 Another incompatible method declaration fixed + type-hints added Roland Häder 2022-06-16 18:36:56 +02:00
40d7f29a11 Continued: - more type-hints - fixed incompatible method declarations Roland Häder 2022-06-16 18:28:38 +02:00
1edc6b3c3b Added more type-hints for "App" classes Roland Häder 2022-06-16 16:49:43 +02:00
42b04f397b Added more type-hints Roland Häder 2022-06-16 16:38:58 +02:00
aa5f0d5ec1 Added more type-hints and documented a few methods Roland Häder 2022-06-16 16:35:39 +02:00
97e27cb523 Added more type-hints Roland Häder 2022-06-16 16:25:30 +02:00
c2e889cfae Added more type-hints Roland Häder 2022-06-16 14:59:29 +02:00
a8a21c7fb6

Merge pull request #11652 from Quix0r/fixes/causer-id Hypolite Petovan 2022-06-17 10:12:22 -04:00
5106bb2881

Added parenthesis Roland Häder 2022-06-17 09:40:29 +02:00
a903dbd77e

Wrong braces causing 'undefined index causer-id'. See #11632 Roland Häder 2022-06-16 22:59:41 +02:00