Roland Häder
ea24ac9d95
Cleaned up: ( #5461 )
...
- no more x() (deprecated) usage but empty() instead
- fixed mixing of space/tab indending
- merged else/if block goether in elseif() (lesser nested code blocks)
2018-07-22 21:19:28 -04:00
Roland Häder
4eb6707dc9
Cleanup: ( #5463 )
...
- rewrote x() to empty() as it is deprecated
- fixed indending for some entries
2018-07-22 21:18:21 -04:00
Roland Häder
ffc70bee17
Fixes: ( #5462 )
...
- fixed E_NOTICE about missing array element "page-flags-raw" (should be
"page_flags_raw"?)
- same with account-type-raw -> account_type_raw
- added spaces to nicely indent code
2018-07-22 21:17:44 -04:00
Roland Häder
a27ef8d0c9
Prevents 4 E_NOTICEs when POST fields are not set. ( #5458 )
...
* Prevents 4 E_NOTICEs when POST fields are not set.
* Don't use x().
* Replaced usage of x() which is deprecated with !isset().
* Use empty() according to MrPetovan
2018-07-22 19:49:16 -04:00
Hypolite Petovan
cdd8e4fd9d
Rename DBA::get_db to DBA::getConnection
...
- Rename DBA::$db to DBA::$connection
2018-07-22 19:28:29 -04:00
Hypolite Petovan
415b982d39
Rename DBA::num_rows to DBA::numRows
2018-07-22 19:27:35 -04:00
Hypolite Petovan
1f2c0b98b5
Rename DBA::server_info to DBA::serverInfo
2018-07-22 19:27:35 -04:00
Hypolite Petovan
4db98eb43d
Rename DBA::inArray to DBA::toArray
2018-07-22 19:27:35 -04:00
Hypolite Petovan
f051ae1698
Rename DBA::fetch_first to DBA::fetchFirst
2018-07-22 19:27:34 -04:00
Hypolite Petovan
591939dfc0
Rename DBA::database_name to DBA::databaseName
2018-07-22 19:27:34 -04:00
Hypolite Petovan
abbaaf5aa5
Rename DBA::clean_query to DBA::cleanQuery
2018-07-22 19:27:34 -04:00
Hypolite Petovan
910e832dc2
Rename DBA::any_value_fallback to DBA::anyValueFallback
2018-07-22 19:27:34 -04:00
Hypolite Petovan
e42cf4d4fc
Rename DBA::affected_rows to DBA::affectedRows
2018-07-22 19:27:34 -04:00
Roland Häder
d3144e2837
Need to load "verb" from notify table, too. This whole thing is a maintenance ( #5459 )
...
nightmare. Let's use the new database frontend/backend system and load all
columns anywhere the "entity" is requested.
2018-07-22 19:25:07 -04:00
Hypolite Petovan
bb99ac8111
Fix Fatal error in Protocol\Diaspora ( #5460 )
2018-07-22 19:22:41 -04:00
Roland Häder
ad857b4314
Fixed E_NOTICE when no valid result has been returned. ( #5457 )
2018-07-22 18:05:10 -04:00
Roland Häder
7876d6547b
Fixed E_NOTICEs when uploading profile picture ( #5456 )
...
* Fixed E_NOTICEs when uploading profile picture.
* Fixed E_NOTICEs when $_POST doesn't contain these fields.
2018-07-22 16:01:14 -04:00
Roland Häder
c17adaf333
Uncommon logger levels in Friendica ( #5453 )
...
* "normal" is an uncommon logger level:
- changed LOGGER_NORMAL -> LOGGER_INFO
- added LOGGER_WARNING (a common logger level)
* Used constants instead of values (MrPetovan)
2018-07-22 14:07:44 -04:00
Hypolite Petovan
a202962f03
Fix yet another Fatal Error in Protocol\OStatus ( #5454 )
2018-07-22 13:32:34 -04:00
Hypolite Petovan
d6ccba79e0
Fix another Fatal error in Protocol\OStatus ( #5451 )
...
* Fix Fatal error in Protocol\OStatus
* Fix another Fatal error in Protocol\OStatus
2018-07-22 12:57:33 -04:00
Roland Häder
7d47152564
Fixed E_NOTICE in boot.php and DBA class ( #5430 )
...
* Fixes:
- fixed missing variable $port (MySQL: 3306)
- "imported" mysqli class
Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixed:
- better use `false` and `$port > 0`
* And better only provide `$port` when larger zero.
* Initialize `$port` with zero value (int) and not `false` (bool).
* Removed duplicate mysqli "import".
* `$post_update` is no longer used. Instead `$prefix` needs to be checked.
2018-07-22 12:53:46 -04:00
Hypolite Petovan
3500e50be9
Fix Fatal error in Protocol\OStatus ( #5450 )
2018-07-22 12:52:38 -04:00
Roland Häder
0a519f5001
Fixes/tye-hints ( #5449 )
...
- added type-hints for DOMDocument, DOMXPath and array
- added missing documentation about optional parameter
- `if ($foo['bar'])` is not a good choice, better use
`if (!empty($foo['bar']))` instead
2018-07-22 12:35:20 -04:00
Roland Häder
2e332134d4
There is no LOGGER_WARNING (triggering E_NOTICE about absent constant). Either ( #5448 )
...
declare it and push all other numbers higher or use LOGGER_NORMAL.
2018-07-22 12:33:28 -04:00
Roland Häder
2970a976d5
Fixes: ( #5447 )
...
- rewrote to first check if PID file is readable, then if found load it
- next addition is to cast it's content to int. Any non-integer content will
result in 0 (as I know).
- Give warnings a voice! (xdebug's scream option showed a warning)
- added some spaces for better readability
2018-07-22 12:28:39 -04:00
Jeroen De Meerleer
d1d2ee6b2f
Added a for-loop ( #5442 )
...
* Using json_decode instead of reinventing hot water
Guys, you could have told me ;)
* changed spaces to tabs
* Guess I'll need a beer ;)
2018-07-21 17:29:39 -04:00
Jeroen De Meerleer
ddaeb305bc
Worker-details: Using json_decode instead of reinventing hot water ( #5441 )
...
* Using json_decode instead of reinventing hot water
Guys, you could have told me ;)
* changed spaces to tabs
2018-07-21 13:24:03 -04:00
Philipp
c5cbf565d9
DBStructure enhancements ( #5437 )
...
* Adding DBStructure enhancements
- Added DBStructure::rename()
- Added DBStructure::existTable()
- Added DBStructure::existColumn()
(cherry picked from commit 4ae06ec)
* Adding `pre_update_1279` method
- Added DBStructure::rename()
- Added DBStructure::existTable()
- Added DBStructure::existColumn()
(cherry picked from commit 8496d84)
* code standards
(cherry picked from commit 551d09b)
* simplify to `empty` instead `is_null`
(cherry picked from commit ce68835)
2018-07-21 08:43:43 -04:00
Andreas Neustifter
303aef34f0
Make frio more consistent by replacing textual links with icons everywhere. ( #5415 )
...
* Make frio more consistent by replacing textual links with icons everywhere I could find them.
* [frio] Move profile add link to icon.
2018-07-21 07:31:05 -04:00
Tobias Diekershoff
eded252a40
Merge pull request #5435 from annando/htaccess
...
Automatically create a .htaccess when not existing
2018-07-21 07:48:15 +02:00
Michael
f02bcdba51
Automatically create a .htaccess when not existing
2018-07-21 05:41:19 +00:00
Tobias Diekershoff
e4a652cae8
Merge pull request #5433 from annando/mysqli
...
Forgotten "use"
2018-07-21 07:18:10 +02:00
Michael
4ba91d4ea1
Forgotten "use"
2018-07-21 05:09:09 +00:00
Michael Vogel
6a6a805225
One more notice ( #5429 )
...
* Some more notices
* And some more notice in the worker
2018-07-20 20:43:21 -04:00
Roland Häder
6da47936c6
renamed .htaccess to .htaccess-dist and ignored .htaccess afterwards ( #5428 )
...
* renamed .htaccess to .htaccess-dist and ignored .htaccess afterwards. This
allows local changes to it without having a dirty checkout directory.
Signed-off-by: Roland Häder <roland@mxchange.org>
* Some fixes:
- removed non-neutral words
- added examples for Linux/Windows
* Better documentation and added note about **not** renaming the file.
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-07-20 20:27:37 -04:00
Michael Vogel
4bbcb61a9e
We now have a pre update script ( #5425 )
...
* We now have a pre update script
* Some optimized stuff
2018-07-20 15:47:16 -04:00
Andreas Neustifter
b26da6096b
[frio] Restyle album edit header. ( #5426 )
2018-07-20 15:23:51 -04:00
Andreas Neustifter
24fc070c5c
[frio] Restyle photo upload ( #5427 )
...
* Better wording in photo upload.
* [frio] Restyle photo uploader to conform to frio style.
2018-07-20 15:23:12 -04:00
Michael Vogel
7382be2766
Some more notices ( #5424 )
2018-07-20 14:07:54 -04:00
Michael Vogel
4f2ae88684
Merge pull request #5422 from MrPetovan/task/5410-rename-dba-to-DBA
...
Rename Friendica\Database\dba to Friendica\Database\DBA
2018-07-20 19:44:54 +02:00
Hypolite Petovan
af6dbc654f
Rename Friendica\Database\dba to Friendica\Database\DBA
2018-07-20 08:19:26 -04:00
Tobias Diekershoff
b6a1df0598
Merge pull request #5420 from annando/notices
...
Just some more fixed notice
2018-07-20 12:46:42 +02:00
Tobias Diekershoff
e821e738a8
Merge pull request #5421 from annando/fatal
...
Wrong "use" for config
2018-07-20 12:45:00 +02:00
Michael
045358cb88
Wrong "use" for config
2018-07-20 06:04:23 +00:00
Michael
5c63de1692
Just some more fixed notice
2018-07-20 05:31:26 +00:00
Michael Vogel
519b82420a
Merge pull request #5419 from annando/fixes
...
Makes Diaspora working again
2018-07-20 07:13:24 +02:00
Michael
9a6a3bf1c1
Makes Diaspora working again
2018-07-20 05:10:16 +00:00
Michael Vogel
4e44b07dfe
Merge pull request #5418 from MrPetovan/task/5410-move-dba-to-src
...
Move \dba to \Friendica\Database\dba
2018-07-20 06:50:36 +02:00
Hypolite Petovan
9c70a94589
Add missing PDO* use statements in Database\dba
2018-07-19 22:24:03 -04:00
Hypolite Petovan
72f32f90d1
Remove class \dba from include/dba
2018-07-19 22:15:57 -04:00