Commit graph

4419 commits

Author SHA1 Message Date
Philipp Holzer
9e94e8b48c
Remove function prepare_text and use BBCode::convert() instead 2019-10-23 00:58:13 +02:00
Philipp Holzer
5843a80b6c
Move perms2str to ACLFormatter::aclToString()
- including new tests
2019-10-23 00:54:34 +02:00
Philipp Holzer
f65f7f11c3
Move expand_acl to ACLFormatter::expand()
- including tests
2019-10-23 00:40:14 +02:00
Philipp Holzer
a3e350313d
Move redir_private_images to Item::addRedirLinkToImageLinks() 2019-10-23 00:20:44 +02:00
Philipp Holzer
2870f42ca2
Move bb_translate_video
- To new Class BBCode\Video
- Adding tests
- Make BaseObject::getClass() public
2019-10-23 00:14:47 +02:00
Philipp Holzer
04a86dad75
remove superfluous line 2019-10-22 22:52:40 +02:00
Philipp Holzer
1fe9b789f3
Add some PHP doc 2019-10-22 22:51:52 +02:00
Philipp Holzer
4e32d46f97
switch case 2019-10-22 22:48:54 +02:00
Philipp Holzer
6b2c28e2d7
Add checks & realpath() usage
- New util class "FileSystem"
- Add check in admin summary too
2019-10-22 22:47:37 +02:00
Philipp Holzer
0e84a843a4
Add Fallback in case the logfile isn't accessible.
- Fixes https://github.com/friendica/friendica/issues/7756#issuecomment-544227862
2019-10-21 21:53:55 +02:00
Philipp Holzer
17aca9bee8
move mod/ignored to src/Module/Item/Ignored 2019-10-21 21:19:28 +02:00
2edccf9341
Merge pull request #7759 from nupplaphil/task/mod_receive
Move mod/receive to src/Module/Diaspora/receive
2019-10-21 11:59:13 -04:00
Philipp Holzer
a25d841b85
some improvements 2019-10-21 17:29:53 +02:00
Philipp Holzer
2a41f0b104
wrong field 2019-10-21 11:34:47 +02:00
17bb1eaf12 Fix fatal error 2019-10-21 05:52:45 +00:00
Philipp Holzer
7716374593
Move mod/receive to src/Module/Diaspora/receive
- Added routes
- Make Diaspora::decode(Raw) more explicit
- Add new User::getByGuid() method
2019-10-20 13:07:16 +02:00
df1db84846 Fix: Friendica contacts had falsely been detected as ActivityPub 2019-10-20 06:04:47 +00:00
1f98067189 Cleaned up code / removed legacy stuff 2019-10-19 16:41:07 +00:00
98c12006d5 Merge remote-tracking branch 'upstream/develop' into sanitize-gcontact 2019-10-18 18:48:32 +00:00
1a8bc6e73f
Merge pull request #7753 from annando/http-417
Handling for HTTP Error code 417
2019-10-18 12:53:33 -04:00
f8c0f24e34
Merge pull request #7752 from kPherox/develop
Change Model type to `OrderedCollectionPage`
2019-10-18 06:54:42 -04:00
kPherox
0da36b839c
Change Model type to OrderedCollectionPage
Use type `OrderedCollectionPage` instead of `OrderedCollection` in pages or distinct subsets
FYI: https://www.w3.org/TR/activitystreams-core/#h-paging
2019-10-18 12:58:47 +09:00
4664249fec Improved comment 2019-10-17 21:49:29 +00:00
36ba7fa79c Merge remote-tracking branch 'upstream/develop' into http-417 2019-10-17 21:37:24 +00:00
2ed61194d5 adopted some change requests 2019-10-17 07:45:48 +02:00
1997938ae7 Remove remaining Logger log level in explicit Logger::debug call 2019-10-16 22:39:31 -04:00
4c5b97834b Replaced quotes 2019-10-16 17:13:56 +00:00
5dcf6bfc58 Remove extra spaces before closing parentheses in src/ 2019-10-16 08:58:09 -04:00
146646c4d4 Replace deprecated calls to defaults() by ?? and ?: in src/ 2019-10-16 08:38:52 -04:00
Philipp
c0b78a9720
Merge pull request #7743 from MrPetovan/task/7190-remove-defaults-modules
Replace deprecated defaults() calls by ?? and ?: operators in src/Module/
2019-10-15 18:17:45 +02:00
f59ea2af55 Replace deprecated defaults() calls by ?? and ?: operators in src/Module/ 2019-10-15 09:20:32 -04:00
f1e7d97b8c Merge remote-tracking branch 'upstream/develop' into sanitize-gcontact 2019-10-15 10:10:12 +00:00
3e93c62a9c Changed quotation (" to ') 2019-10-15 07:55:20 +00:00
Philipp
fed486bfc5
Merge pull request #7727 from MrPetovan/task/4090-move-manage-to-src
Move mod/manage to src/Module/Delegation
2019-10-13 18:20:47 +02:00
Philipp
05c4fd9daa
Merge pull request #7737 from MrPetovan/task/4090-move-search-to-src
Saved Search fixes
2019-10-13 15:40:42 +02:00
230a97ccdd Correctly URL encode return URLS for saved search 2019-10-13 08:39:55 -04:00
74bf3a4dc8 Replace path parameter with query string parameter in Module\Search\Saved 2019-10-13 08:39:41 -04:00
c5f4f730e1 Use init() rather than rawContent() in Module\Search\Saved since there's no output 2019-10-13 08:37:25 -04:00
db0630b0f9 Catch missing Certainty bundle exception when checking for exposed password in Model\User 2019-10-12 21:10:03 -04:00
1cdbf32aa2 Remove duplicate array entry in Core\Logger 2019-10-12 21:10:03 -04:00
440da8a9f4 eol 2019-10-12 14:07:22 +00:00
c1ab93a5d8 Strings.php: Spaces are transformed to Tabs. 2019-10-12 10:28:18 +00:00
2c2beb5c0a
Revert Util\Strings::escapeHtml changes from #7725
- Breaks display of inserted mentions
2019-10-11 22:19:20 -04:00
02f02d44dc Move mod/manage to src/Module/Delegation
- Move templates/manage to templates/delegation
- Update navigation links
- Update CSS classes
2019-10-11 19:59:06 -04:00
4ee9e21a4f Make Router::getModuleClass throw exceptions
- Add new MethodNotAllowedModule
- Add new Module->determineClass catch blocks
- Update Module and Router tests
2019-10-11 19:59:05 -04:00
001c9ed259 Fix typo in Core\Authentication 2019-10-11 19:57:04 -04:00
27eaffd7fb
Merge pull request #7725 from dew-git/develop
Fix security vulnerabilities.
2019-10-11 14:48:07 -04:00
10a66f368c self should be lower case 2019-10-11 17:44:50 +02:00
9f3e68c2c5 correct the file name in the header 2019-10-11 11:55:57 +02:00
5ac5a67b6b enhance description 2019-10-11 11:49:28 +02:00
e3a947fb3d keep the ToDo hint from delegations 2019-10-11 11:48:05 +02:00
882449266c removed debugging leftover 2019-10-11 11:45:28 +02:00
06a964c32f only take action, when there is something to do 2019-10-11 11:42:07 +02:00
dew-git
e1e1d26b5b Revert random_int changes. 2019-10-11 00:00:15 -08:00
46172b641d moved UExport to src/Module/Settings/Uexport 2019-10-11 07:38:42 +02:00
dew-git
b5dac16def Comply with coding style. 2019-10-10 20:50:51 -08:00
dew-git
3940e804e3 Remove uneeded variable. 2019-10-10 20:48:13 -08:00
dew-git
dc01bdbc80 Use the utility instead. 2019-10-10 20:43:32 -08:00
dew-git
811cdcdfcb Fix security vulnerbilities.
Fix possible length extension attack, predicable generators, timing attacks on hash comparision and improved formatting.
2019-10-10 15:21:41 -08:00
4b71fd2442 Replace deprecated calls to App->getBaseURL in Module\Register 2019-10-10 13:13:23 -04:00
67d374a14f Complete L10n::detectLanguage call parameters in Module\Register 2019-10-10 13:12:55 -04:00
50fa119f79
Merge pull request #7722 from nupplaphil/bug/7718-lang
Fix browser language detection
2019-10-10 16:54:32 +02:00
Philipp Holzer
a522cf609b
Fix browser language detection (& tests) 2019-10-10 16:39:04 +02:00
Philipp
cf4bae26c7
Merge pull request #7720 from MrPetovan/task/4090-move-delegate-to-src
Move mod/delegate to src/Module/Settings/Delegation
2019-10-10 10:24:15 +02:00
43567bcf0e Add documentation comments to Module\Settings\Delegation 2019-10-10 04:17:37 -04:00
3cd916d7aa Use Model\User::getById when possible in Module\Settings\Delegation 2019-10-10 04:10:57 -04:00
cc0cf2b8ce Improve parent user password check in Module/Settings/Delegation 2019-10-10 04:10:29 -04:00
616edd0600 Move mod/delegate to src/Module/Settings/Delegation
- Move templates/delegate to templates/settings/delegation
2019-10-09 22:17:09 -04:00
Philipp
e72402389d
Merge pull request #7715 from annando/fix-getguid
The getGUID function hadn't fetched the GUID from pictures with scale "0"
2019-10-08 07:01:17 +02:00
11194d6679 Fix: The getGUID function hadn't fetched the GUID from pictures with scale "0" 2019-10-08 04:42:51 +00:00
e3e3ee72a0 Improve logging in Module\Search\Index 2019-10-07 16:18:19 -04:00
c8316bfe57 Use Dice instantiation to access App\Arguments
- Remove App->args accessors
2019-10-07 16:16:42 -04:00
1e737ae888 Move mod/search to src/Module/Search/Index
- Update BaseSeachModule not to depend on a single query string parameter
2019-10-07 14:27:46 -04:00
22598fc7e8 Improve search box
- Use new saved search module
- Use dynamic search option loop
- Use "q" instead of "search" for search query string parameter
2019-10-07 14:27:46 -04:00
cdefa7f32a Add new module and widget for managing saved searches 2019-10-07 14:27:46 -04:00
11ad0acd28 Add accessor for App->args in App and BaseModule 2019-10-07 14:27:46 -04:00
Philipp
5f80180b47
Merge pull request #7710 from MrPetovan/task/rework-theme-session-vars
Rework theme session variables
2019-10-07 18:17:29 +02:00
83f670e9e5 Test against the thread parent as well 2019-10-07 04:19:12 +00:00
9c6fd5fc35 Fix communication issues when a contact is able to speak AP, but uses Diaspora 2019-10-06 21:59:23 +00:00
1c8dd457cc Just some added logging to the proxy functionality to better analyze problems 2019-10-06 18:48:33 +00:00
4e7d94053e Fix for multiline host-meta, reducement of requests, fix for wordpress 2019-10-06 16:33:39 +00:00
f4d06ebd47 Remove useless theme session variable deletions in modules 2019-10-06 12:08:15 -04:00
ead0defb48 Rework theme override in Profile::load and App
- Separate desktop theme from mobile theme in App
2019-10-06 12:07:06 -04:00
e5fbaf6a00 Add Session::clear method
- Replace manual session clear by method in mod/manage
2019-10-06 11:21:54 -04:00
4a5dfefacc Move theme determination after full module run 2019-10-06 11:18:51 -04:00
cb4950a3be Replace duplicated authentication code in FKOAuth1 with Session::setAuthenticatedForUser 2019-10-06 11:17:30 -04:00
7959b9bbed
Merge pull request #7706 from tobiasd/20191006-checknote
add server side check about note to admin
2019-10-06 07:53:09 -04:00
cbaa4d13d1 add server side check about note to admin 2019-10-06 11:57:43 +02:00
e3431f2d26 Empty line added 2019-10-06 06:08:07 +00:00
8238081d87 Replace obsolete functionality in "PortableContact" 2019-10-05 23:30:47 +00:00
Philipp
c32fb1547f
Merge pull request #7699 from MrPetovan/task/4090-move-acl-to-src
Move mod/acl to src/Module/Search/Acl
2019-10-05 15:14:49 +02:00
b62e20c7bf Code beautification 2019-10-05 08:34:07 -04:00
af5527f896 Unified return value types 2019-10-05 04:50:29 +00:00
aa75e749be Enhanced documentation 2019-10-05 04:22:16 +00:00
908197cc70 Use switches instead of if/else in Module\Search\Acl 2019-10-04 22:27:13 -04:00
9e29321aaf Use constants for search type in Module\Search\Acl 2019-10-04 22:20:40 -04:00
445133cb21 Move Module\Search\Acl::contactAutocomplete to Core\Search::searchGlobalContact
- Replace broken reference to directory /lsearch module with /search module
2019-10-04 22:19:54 -04:00
4d1cc44151 Added documentation 2019-10-04 17:29:21 +00:00
cd3dada39c Detect network type via the contacts 2019-10-04 06:33:16 +00:00
a7e518acbd Readded the network parameter 2019-10-04 05:42:54 +00:00
8f20e2054b Move /acl module to src/
- Move Core\ACL::contactAutocomplete to Module\Search\Acl
- Rename module path to /search/acl
2019-10-03 22:40:42 -04:00
d9a74bd5dd Code transitioning from PortableContacts.php to GServer.php 2019-10-03 23:33:41 +00:00
2009080327 Remove more test data 2019-10-03 21:39:48 +00:00
832c765ad5 Hostmeta check, Pleroma version number cleaning 2019-10-03 20:52:04 +00:00
59b464ade3 PoCo endpoint added 2019-10-03 15:30:07 +00:00
3eb24d1b5c Nost test code is removed 2019-10-03 14:48:46 +00:00
ae55029028 Additional endpoints added 2019-10-03 13:02:48 +00:00
25f93cb03a Count known users, check for empty attribute values 2019-10-03 10:44:29 +00:00
9cbe5c5e0e New class for handling gserver entries 2019-10-03 09:20:36 +00:00
21e9e9f3c2 Remove obsolete function to guess the base url of a contact 2019-10-02 15:10:42 +00:00
Philipp
a855c6888b
Merge pull request #7687 from annando/get-header-field
Enable the possibility to fetch a specific header variable
2019-10-02 13:22:30 +02:00
7991b77343 Return value added 2019-10-02 09:37:05 +00:00
92ee309591 quotes 2019-10-02 08:28:12 +02:00
6a6a48c58d Renamed function 2019-10-02 06:24:29 +00:00
9a0201e674 require a note to the admin when register policy is set to needs approval 2019-10-02 07:39:42 +02:00
b051804dc3 Empty the header array 2019-10-02 04:10:36 +00:00
489510e7a9 Cache the header fields 2019-10-02 03:45:32 +00:00
5cdeb8615f Use $this 2019-10-02 03:31:58 +00:00
516fd02812 New function to check for key existance 2019-10-01 21:46:18 +00:00
c494b158c8 Fix notice "Undefined index: openRegistrations" 2019-10-01 19:27:33 +00:00
c37663f1c1 Changed return value 2019-10-01 19:02:26 +00:00
2c730a5c45 New function for fetching associated header array 2019-10-01 18:22:33 +00:00
18198b4aaa Enable the possibility to fetch a specific header variable 2019-10-01 16:33:11 +00:00
18807ae21d Don't send blank pictures on error, fail instead. 2019-10-01 12:41:49 +00:00
c0cb1a194e
Merge pull request #7670 from nupplaphil/task/add_router_config
Add router config
2019-09-30 11:13:36 -04:00
185f1fc687
Merge pull request #7636 from annando/manage
Restructured "manage" functionality, added count parameters
2019-09-30 11:12:46 -04:00
2333526b8a
Merge pull request #7678 from annando/remote-rework
Reworked the remote authentication
2019-09-30 09:18:43 -04:00
Philipp Holzer
dc73117a62
code optimization 2019-09-30 14:03:15 +02:00
Philipp Holzer
49e812f3d3
Bugfix GetAllKeys() of Memcache
- Abstract Memcache and Memcached implementation
2019-09-30 14:03:15 +02:00
Philipp Holzer
d5dd12b8f8
Add Drone CI
- Add drone test environment
- Add drone config
- apt phpunit
- Fix api.php
- Fix item.php
- Fix DBStructure
- Check if caching is possible during tests
2019-09-30 14:03:12 +02:00
d41399496e Merge remote-tracking branch 'upstream/develop' into manage 2019-09-30 06:30:13 +00:00
520c250a41 Some small code adjustments 2019-09-29 19:21:05 +00:00
5eeca432fe removed unused "f" parameter 2019-09-29 18:59:03 +00:00
51e55bca18 Added some logging 2019-09-29 10:58:07 +00:00
32ea610559 Avoid a contact lookup for empty URL 2019-09-29 10:23:36 +00:00
c2c1b317e0 Transferring the "addr" value on magic auth 2019-09-29 10:20:53 +00:00
Philipp Holzer
0e5cb88888
Add router config
- Introduce route.config.php structure
- Adding config loader for routes
- Adapt Module class (separation of duties)
- Add tests
2019-09-29 11:57:27 +02:00
0185c91246 Merge remote-tracking branch 'upstream/2019.09-rc' into remote-rework 2019-09-29 06:32:35 +00:00
58fb0beaa3 Delete the cache entry allowing direct login again 2019-09-29 06:26:02 +00:00
Michael Vogel
4e9a810206 Fix magic auth for redirects with non profile paths 2019-09-29 02:16:09 +02:00
7704758f9c Fix permissionset query 2019-09-28 20:42:33 +00:00
83b00ef308 New function "isAuthenticated" 2019-09-28 18:09:11 +00:00
1c26baec46 remote_user is replaced 2019-09-28 09:59:08 +00:00
6e9026e033 Renamed function, beginning to replace the "remote_user" function 2019-09-28 09:36:41 +00:00
1ddd2df4b8 Removed obsolete code 2019-09-28 05:37:24 +00:00
3dd94355b7 Fix permissions when viewing photos, applying same fix to items as well 2019-09-27 05:49:23 +00:00
abecf62f2d Merge remote-tracking branch 'upstream/2019.09-rc' into remote-rework 2019-09-26 20:50:29 +00:00
704cdf1b5a New function to store the "remote" session value / making the changes work 2019-09-26 04:47:42 +00:00
1f20a9330c Add new ignoreChildren behavior to HTML::tagToBBCode
- Allow discarding HTML tag children for single-value BBCode
- Add test for it
2019-09-25 20:44:09 -04:00
d8484e65bd Move autolinker execution earlier in BBCode::convert
- Prevents already replaced HTML links (like in [audio] tag) to be doubled
- Add test for it
2019-09-25 20:39:04 -04:00
ec66553032 Reworked "remote" cookie handling 2019-09-25 22:24:17 +00:00
d5c37001cd Empty the "remote" variable, avoid being remote to yourself 2019-09-25 07:02:07 +00:00
6a376c29d8 Fix session size problems 2019-09-25 05:57:32 +00:00
87462ec67f Don't use the "url" parameter on redir if it points to the same contact 2019-09-24 21:44:37 +00:00
8a5eb689f7
Merge pull request #7656 from annando/redir-loop
Fix "redir" loop
2019-09-23 18:56:50 -04:00
5254147ccc Fix "redir" loop 2019-09-23 22:13:20 +00:00
Philipp Holzer
ca36ea17f9
Fix Auto-Installer 2019-09-23 12:51:07 +02:00
aba23daeca Get rid of zombie introductions that reappear automatically 2019-09-22 10:51:34 +00:00
Philipp
482cf1bbfe
Merge pull request #7646 from MrPetovan/bug/warnings
Remove setting obsolete App->data['user'] in Module\Profile\Contacts
2019-09-21 18:20:57 +02:00
f51b275b17 Add parameter type hints in Temporal::getDateofBirthField 2019-09-21 10:52:55 -04:00
a2105c5dfe Changed documentation 2019-09-21 13:19:00 +00:00
b24ef7247d Don't update the basepath on local check 2019-09-21 13:17:33 +00:00
cf569425c6 Avoid a notice 2019-09-21 13:00:53 +00:00
c364a77d63 Always use direct DFRN transport on local contacts 2019-09-21 12:39:07 +00:00
118e737a49 Remove dependency to App object in Temporal::getDateofBirthField 2019-09-21 05:15:52 -04:00
f19136905f Remove setting obsolete App->data['user'] in Module\Profile\Contacts 2019-09-21 05:14:49 -04:00
64f30d3627 Fix: updateFromProbe failed when updating non-federated networks 2019-09-20 21:01:52 +00:00
3b6f16347a Fetch avatar and name on Twitter discovery 2019-09-19 05:28:46 +00:00
358cbe812a Correction: Must be inverted 2019-09-18 16:37:13 +00:00
1144863090 Changed "hidewall" behaviour 2019-09-18 05:20:33 +00:00
Philipp Holzer
b13dbb3dcb
Remove $_SERVER['PHP_SELF'] usage 2019-09-17 16:47:00 +02:00
8237d35a87 Restructured "manage" functionality, added count parameters 2019-09-17 04:05:26 +00:00
888f7ffd1c Use correct data key to compare authors before appending mention in Protocol\Diaspora 2019-09-15 07:05:47 -04:00
69752fd945 Prevent prepending implicit mention if replied to item is ours in Protocol\Diaspora 2019-09-14 17:42:02 -04:00
6576f15164 Check the root directory is writable before copying .htaccess in Worker\Cron
- Addresses https://github.com/friendica/friendica/issues/7298#issuecomment-531454632
2019-09-14 06:30:41 -04:00
a037427a54 Added comment 2019-09-14 07:17:06 +00:00
9d87bc94a6 Issue 6553: Restructured code for treating removed accounts 2019-09-14 07:12:25 +00:00
32707022bf Remove GET page parameter access from Core\ACL 2019-09-13 20:06:57 -04:00
1a81ed8616 Fix notice message when $return is undefined in Core\ACL 2019-09-13 20:06:22 -04:00
39133a1e0e Fix a notice because of invalid return data 2019-09-13 18:59:33 +00:00
f5eb8e88f1 Remove obsolete blockquote replacement in Item::prepareBody 2019-09-12 22:18:46 -04:00
c034fa7baa Use <details> tag for spoilers BCode 2019-09-12 22:17:55 -04:00
Philipp
50cce950f6
Merge pull request #7614 from annando/issue-5721
Issue 5721: Set permissions of photos in PM
2019-09-11 22:22:06 +02:00
4223011a7d Fix a notice about a missing "pending" 2019-09-11 20:03:29 +00:00
3c1380fdcc Fix enduring follow requests to Pleroma 2019-09-11 16:54:13 +00:00
a34995a3e5 Issue 5721: Set permissions of photos in PM 2019-09-11 04:08:41 +00:00
a733a00ea9 Detect the hide status when it hadn't been detected before 2019-09-10 20:20:34 +00:00
3c7fe5fc1b Issue 7610-2: Read the "hide" status for non DFRN profiles 2019-09-10 20:06:07 +00:00
57e4b9f806 Issue 7610: Set the appropriate meta header to not being crawled 2019-09-10 17:15:29 +00:00
Philipp
64e74b4e03
Merge pull request #7607 from annando/issue-7603
Issue 7603: Display forums too when they are AP
2019-09-10 13:01:41 +02:00
b2d6854829 Issue 7285: Perform duplicate check for item URI also with AP 2019-09-10 04:59:12 +00:00
5f2028b657
Merge pull request #7605 from annando/pending-2
Pending contacts: Fix contact deletion / added cron job for repairs
2019-09-10 06:32:18 +02:00
3d5d50a25b
Merge pull request #7606 from annando/fix-invalid-url
Replace not working "redir" link with a working one
2019-09-10 06:29:55 +02:00
e588c350ef Issue 7603: Display forums too when they are AP 2019-09-10 04:29:49 +00:00
0a0a961c52 The value is used twice, so use a variable 2019-09-10 04:04:07 +00:00
8fc8e26e23 Replace not working "redir" link with a working one 2019-09-09 21:37:26 +00:00
323285216b We have to check for "0" in "rel" as well 2019-09-09 20:39:19 +00:00
f185f6fd3d Pending contacts part 2: Fix contact deletion / added cron job for repairs 2019-09-09 20:03:11 +00:00
91b0f0465f
Merge pull request #7604 from annando/pending-contacts
Display pending contacts in the contact list
2019-09-09 13:49:51 -04:00
a70a0306d7 Only show incoming pending contact requests with intro 2019-09-09 08:58:56 +00:00