Commit graph

8549 commits

Author SHA1 Message Date
Tobias Diekershoff 3d08f54966
Merge pull request #11074 from MrPetovan/bug/warnings
Initialize $permissions variable in ActivityPub\Transmitter::fetchPermissionBlockFromConversation
2021-12-07 07:06:48 +01:00
Hypolite Petovan b04809ced4 Initialize $permissions variable in ActivityPub\Transmitter::fetchPermissionBlockFromConversation
- Address https://github.com/friendica/friendica/issues/10757#issuecomment-927361800
2021-12-06 20:16:46 -05:00
Hypolite Petovan ad1aea0a2b Suppress Undefined property message in Core\Protocol
- Address https://github.com/friendica/friendica/issues/10755#issuecomment-979427147
2021-12-06 19:27:36 -05:00
Philipp Holzer fb1e8e75f5
Add response for JSON only 2021-12-06 00:12:18 +01:00
Philipp Holzer dbfe918a8b
Fix tests 2021-12-05 20:34:01 +01:00
Philipp Holzer 9081b37762
Fix Twitter statuses list & reenable tests 2021-12-05 20:34:01 +01:00
Philipp Holzer 85b9f2b02c
Reenable Incoming test and fixes an array_reverse() bug 2021-12-05 20:34:00 +01:00
Philipp Holzer 6d8b8d95b1
Reenable Followers&Friends Lists and fixes a array_reverse() Bug 2021-12-05 20:34:00 +01:00
Philipp Holzer 7ca47e8d21
Re enable Blocks/Lists test 2021-12-05 20:34:00 +01:00
Philipp Holzer 6b03ee2922
Re enable UpdateProfile test 2021-12-05 20:34:00 +01:00
Philipp Holzer cc7b2fae4e
Re-enable AccountVerifyCredentials test 2021-12-05 20:33:59 +01:00
Michael d57cb05a24 Fix: array_reverse returns the reversed content as return value 2021-12-05 06:22:04 +00:00
Hypolite Petovan 423892b814 Replace references to NOW() in SQL queries with a DateTimeFormat generated parameter 2021-12-04 17:53:16 -05:00
Hypolite Petovan 80da47921e Replace references to UTC_TIMESTAMP in SQL queries with a DateTimeFormat generated parameter 2021-12-04 17:53:08 -05:00
Hypolite Petovan ecaed2a845 Update DateTimeFormat documentation
- Remove an explicit default value parameter
2021-12-04 17:52:01 -05:00
Michael 34260fc619 Improved page info detection 2021-12-04 19:54:33 +00:00
Hypolite Petovan ba98242b9f
Merge pull request #11066 from annando/issue-11063
Issue 11063: Fix check for current user
2021-12-03 23:47:19 -05:00
Michael 799baeda10 Issue 11063: Fix check for current user 2021-12-04 04:30:46 +00:00
Michael 3b92e086ce Merge remote-tracking branch 'upstream/2021.12-rc' into podcast 2021-12-04 04:12:44 +00:00
Michael 3d65809a82 Fix media handling upon creation and display 2021-12-04 04:03:18 +00:00
Hypolite Petovan e1d6de757f Add expected second parameter to BaseApi::getRequest in a few put() methods 2021-12-03 18:00:54 -05:00
Hypolite Petovan 67f4038051 Fix URI structure condition in Probe::detect
- This condition was wrongly discarding all URIs with a schemes
2021-12-03 17:39:35 -05:00
Hypolite Petovan d05d2a348b Deprecate Network::unparseURL in favor of UriInterfact objects
- Added specific test for Probe::cleanURI
2021-12-03 17:39:31 -05:00
Balázs Úr 48a0049adc
Fix typo 2021-12-03 01:14:29 +01:00
Hypolite Petovan e7d87d3524 Suppress notice messages related to the VCard::getHTML call in mod/display
- Address https://soc.schuerz.at/display/4edd2508-6661-a8d1-f168-b2a245440386
2021-12-02 09:45:32 -05:00
Hypolite Petovan f409bd7034 Remove all-numeric usernames condition
- False negatives aren't recoverable
2021-12-02 08:03:38 -05:00
Hypolite Petovan 1321a52f15 Reformat Probe::getWebfingerArray 2021-12-02 08:02:26 -05:00
Michael 5e912c2965 Unused use removed 2021-12-02 06:37:06 +00:00
Michael 4a90e6b1f0 Test code removed 2021-12-02 06:36:09 +00:00
Michael bd2ee581d3 Diaspora reshares via API are fixed now 2021-12-02 06:33:19 +00:00
Michael 03d2160690 Removed second ppst parameter 2021-11-30 21:41:10 +00:00
Michael 56f8adcb80 Merge remote-tracking branch 'upstream/2021.12-rc' into api-fixes 2021-11-30 19:07:24 +00:00
Philipp Holzer d8ac002001 Fix Introduction user selection 2021-11-30 01:08:00 -05:00
Philipp Holzer a88cc8d5c8 Replace DI::apiResponse()->exit() with $this->response->exit() 2021-11-30 01:08:00 -05:00
Philipp Holzer 2dc60cfd33 Make API call permission checks more reliable
- don't need to inherit every Module method anymore
2021-11-30 01:07:59 -05:00
Philipp Holzer 9cec38f916 Make HTTPInputData dynamic
- Removing DI:: dependency inside App class
- Making testability easier & adapting tests
2021-11-30 01:07:59 -05:00
Philipp Holzer 2e4d654c0a Make $_REQUEST processing independent of sub-calls
- Move HTTPInputData::process() into App::runFrontend()
- Pass $_REQUEST (including processed Input) to every Module method
- Delete $_POST parameters at Module post() calls because of $_REQUEST
2021-11-30 01:07:58 -05:00
Philipp Holzer f580d8e5c0 extract "BaseApi::checkDefaults()" method for later usage 2021-11-30 01:07:57 -05:00
Michael 7dd757b7f9 Merge remote-tracking branch 'upstream/2021.12-rc' into api-fixes 2021-11-30 05:48:03 +00:00
Michael 56824598ff Standards 2021-11-30 05:20:01 +00:00
Michael Vogel 3ff59cfdc3
Merge pull request #11045 from MrPetovan/bug/11029-contact-group
Use user-specific id to fetch the list of group appartenance in Module\Contact\Profile
2021-11-30 06:17:56 +01:00
Michael 2470482b4e Standards 2021-11-30 05:07:03 +00:00
Michael 33c8872c65 Merge remote-tracking branch 'upstream/2021.12-rc' into api-fixes 2021-11-30 05:00:46 +00:00
Michael e7e74819a3 Fix posting pictures 2021-11-29 18:03:34 +00:00
Hypolite Petovan 2ba3b7f771
Merge pull request #11037 from MrPetovan/bug/11023-api-photo-delete
Fix Api\Friendica\Photo|album\Delete endpoints
2021-11-29 08:44:33 -05:00
Michael 6bd9c9f496 Merge remote-tracking branch 'upstream/2021.12-rc' into api-fixes 2021-11-29 12:52:00 +00:00
Hypolite Petovan cd63533e2c Fix remaining references to BaseModule->parameters 2021-11-29 07:24:32 -05:00
Hypolite Petovan c2df5d66d7 Use user-specific id to fetch the list of group appartenance in Module\Contact\Profile 2021-11-29 07:06:41 -05:00
Hypolite Petovan c7a40906bf Fix Photoalbum delete endpoint
- Fix condition on a removed Item field
2021-11-29 06:29:38 -05:00
Hypolite Petovan e2016bc67d Fix Photo delete endpoint
- Set the request variable type
- Fix the condition on a nonexistant item field
2021-11-29 06:29:38 -05:00
Michael 477b8a91db Added endpoint 2021-11-29 06:09:28 +00:00
Michael 0440765849 Set item permissions on reshare 2021-11-29 04:38:58 +00:00
Michael 71f7679204 Fix function name 2021-11-28 21:40:38 +00:00
Michael cf999e681c Standards 2021-11-28 13:58:26 +00:00
Michael 367479e50e Standards 2021-11-28 13:52:39 +00:00
Michael 19019381e6 Fixes standards 2021-11-28 13:46:30 +00:00
Michael 61f1a4d14d Merge remote-tracking branch 'upstream/2021.12-rc' into api-fixes 2021-11-28 13:44:02 +00:00
Michael 222b35684d API: Added more functions, fixed function names 2021-11-28 13:34:00 +00:00
Philipp Holzer d576bb136b
Fix BaseApi and corresponding tests 2021-11-28 13:11:12 +01:00
Philipp Holzer 4cc36c9b2c
Fix BBCode::expandTags() & Remove AppMockTrait 2021-11-28 13:07:38 +01:00
Michael e381ca6ba0 Added group update 2021-11-27 22:25:40 -05:00
Michael b15d3a2523 API: Next bunch of functions transformed 2021-11-27 22:25:36 -05:00
Hypolite Petovan 9cc675233d Add a second parameter to BaseApi::getRequest to enable API tests 2021-11-27 18:38:09 -05:00
Philipp Holzer 056702c1e0
Fixing wrong inherited methodsyntax 2021-11-27 19:58:24 +01:00
Philipp Holzer e8ee312d80
Fix Tos Module 2021-11-27 14:11:48 +01:00
Philipp Holzer 77b092b4b9
Respect the Dollar(notation :-)) 2021-11-27 13:57:36 +01:00
Philipp Holzer 9207b9e408
Fixing https://github.com/friendica/friendica/issues/11033 2021-11-27 13:48:05 +01:00
Philipp Holzer 7cba74bb6c
Fix that (raw)content is always executed during Module::run() 2021-11-27 13:41:37 +01:00
Philipp Holzer f245fdaa5d
Fix Contact modules 2021-11-27 13:19:26 +01:00
Philipp Holzer e4000155f3
Fix Page Header usage 2021-11-27 12:40:58 +01:00
Philipp Holzer 6a9fff5100
Fixing Response 2021-11-27 12:40:57 +01:00
Philipp Holzer ae24bf8d54
Fixing Response 2021-11-27 12:40:57 +01:00
Philipp Holzer 7cd85873ee
Replace IRespondToRequests with PSR-7 ResponseInterface 2021-11-27 12:40:57 +01:00
Philipp Holzer 3b2946f98f
Replace header() with $response->setHeader() at BaseModule 2021-11-27 12:40:56 +01:00
Philipp Holzer 78c45bd142
Add NodeInfo Module test as an example 2021-11-27 12:40:56 +01:00
Philipp Holzer 537b74f307
Inherit ApiResponse from Response 2021-11-27 12:40:54 +01:00
Philipp Holzer 561aba18e3
Introduce Response for Modules to create a testable way for module responses 2021-11-27 12:40:38 +01:00
Philipp Holzer ad5b0762b0
Fix LegacyModule content return 2021-11-27 12:40:37 +01:00
Philipp Holzer 8bdd90066f
Make BaseModule a real entity
- Add all dependencies, necessary to run the content (baseUrl, Arguments)
- Encapsulate all POST/GET/DELETE/PATCH/PUT methods as protected methods inside the BaseModule
- Return Module content ONLY per `BaseModule::run()` (including the Hook logic there as well)
2021-11-27 12:40:36 +01:00
Philipp Holzer 238613fd01
Add feedback :) 2021-11-27 12:39:46 +01:00
Philipp Holzer b5d2d32b44
Split and delete ModuleController
- $moduleName is part of the argument string => App\Arguments
- $isBackend boolean already part of App\Mode::isBackend()
- $module is now the direct return of App\Router::getModule()
- ModuleController::run() moved to BaseModule::run()
2021-11-27 12:39:45 +01:00
Philipp a5ab184fb8
Merge pull request #11025 from MrPetovan/task/11022-improve-connector-hooks
Improve connector hooks
2021-11-27 12:37:47 +01:00
Philipp e852623c4f
Merge pull request #11030 from MrPetovan/bug/11029-add-remove-group
Add backward compatibility with user contacts in Module\Group
2021-11-27 12:37:18 +01:00
Michael a3e3d87a42 Standards 2021-11-26 21:57:18 +00:00
Michael d128b723c0 Code standards 2021-11-26 21:54:25 +00:00
Michael 0de9ae913b API: moved several lists 2021-11-26 21:48:13 +00:00
Hypolite Petovan 1c5aef0685 Escape dollar sign in replace string to prevent placeholder replacement in Model\Item::addShareDataFromOriginal 2021-11-26 12:38:34 -05:00
Hypolite Petovan 8bfe877629 Add backward compatibility with user contacts in Module\Group 2021-11-26 09:48:37 -05:00
Hypolite Petovan a26322b4c2 Replace args call with parameter from router in Module\Group 2021-11-26 09:48:05 -05:00
Michael 0e3c8e3f5e Mixed parameter order 2021-11-26 08:16:06 +00:00
Michael da9b5f32db Unneeded "use" removed 2021-11-26 07:56:54 +00:00
Michael fb47389c69 API: Fix profile_url handling / missing constant 2021-11-26 07:55:02 +00:00
Hypolite Petovan dbcaf51923
Merge pull request #11018 from annando/api-status
API: The status is now an object
2021-11-25 20:27:15 -05:00
Michael 68316c6e85 Coding standards 2021-11-25 11:31:01 +00:00
Michael 1ff6b1cf18 Coding standards 2021-11-25 11:28:56 +00:00
Michael 9c61bd3ffc Lists and tweet search moved 2021-11-25 11:16:47 +00:00
Michael d696c8d101 Use correct uri-id for attachments 2021-11-25 10:07:25 +00:00
Michael 44555cddb8 More functions moved 2021-11-25 06:00:58 +00:00
Michael 97719ca207 Standards 2021-11-24 23:36:41 +00:00
Michael 6d1d4789f1 Standards ... 2021-11-24 23:35:01 +00:00