Merge pull request #8898 from annando/spool-log

Add some logging to SpoolPost.php
This commit is contained in:
Tobias Diekershoff 2020-07-19 10:01:06 +02:00 committed by GitHub
commit 11c96d380c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -37,6 +37,7 @@ class SpoolPost {
// It is not named like a spool file, so we don't care. // It is not named like a spool file, so we don't care.
if (substr($file, 0, 5) != "item-") { if (substr($file, 0, 5) != "item-") {
Logger::notice('Spool file does does not start with "item-"', ['file' => $file]);
continue; continue;
} }
@ -44,11 +45,13 @@ class SpoolPost {
// We don't care about directories either // We don't care about directories either
if (filetype($fullfile) != "file") { if (filetype($fullfile) != "file") {
Logger::notice('Spool file is no file', ['file' => $file]);
continue; continue;
} }
// We can't read or write the file? So we don't care about it. // We can't read or write the file? So we don't care about it.
if (!is_writable($fullfile) || !is_readable($fullfile)) { if (!is_writable($fullfile) || !is_readable($fullfile)) {
Logger::notice('Spool file has insufficent permissions', ['file' => $file, 'writable' => is_writable($fullfile), 'readable' => is_readable($fullfile)]);
continue; continue;
} }
@ -56,17 +59,19 @@ class SpoolPost {
// If it isn't an array then it is no spool file // If it isn't an array then it is no spool file
if (!is_array($arr)) { if (!is_array($arr)) {
Logger::notice('Spool file is no array', ['file' => $file]);
continue; continue;
} }
// Skip if it doesn't seem to be an item array // Skip if it doesn't seem to be an item array
if (!isset($arr['uid']) && !isset($arr['uri']) && !isset($arr['network'])) { if (!isset($arr['uid']) && !isset($arr['uri']) && !isset($arr['network'])) {
Logger::notice('Spool file does not contain the needed fields', ['file' => $file]);
continue; continue;
} }
$result = Item::insert($arr); $result = Item::insert($arr);
Logger::log("Spool file ".$file." stored: ".$result, Logger::DEBUG); Logger::notice('Spool file is stored', ['file' => $file, 'result' => $result]);
unlink($fullfile); unlink($fullfile);
} }
closedir($dh); closedir($dh);