Merge pull request #681 from annando/notices-again

Notices again

fromgplus/fromgplus.php

@@ -341,10 +341,13 @@ function fromgplus_handleattachments($a, $uid, $item, $displaytext, $shared) {
 				if ($images["full"] != "")
 					$pagedata["images"][0]["src"] = $images["full"];
 
+				if (!empty($attachment->content)) {
 					$quote = trim(fromgplus_html2bbcode($attachment->content));
+				}
 
-				if ($quote != "")
+				if (!empty($quote)) {
 					$pagedata["text"] = $quote;
+				}
 
 				// Add Keywords to page link
 				$data = parseurl_getsiteinfo_cached($pagedata["url"], true);

pumpio/pumpio.php

@@ -778,6 +778,7 @@ function pumpio_fetchtimeline(App $a, $uid)
 		$success = $client->CallAPI($url, 'GET', [], ['FailOnAccessError'=>true], $user);
 	} else {
 		$success = false;
+		$user = [];
 	}
 
 	if (!$success) {
@@ -1386,6 +1387,10 @@ function pumpio_getallusers(App &$a, $uid)
 		$success = false;
 	}
 
+	if (empty($users)) {
+		return;
+	}
+
 	if ($users->totalItems > count($users->items)) {
 		$url = 'https://'.$hostname.'/api/user/'.$username.'/following?count='.$users->totalItems;
 

tumblr/tumblr.php

@@ -443,7 +443,7 @@ function tumblr_send(App $a, array &$b) {
 						"<p>".$params['caption']."</p>";
 		}
 
-		if (empty($params['caption'])) {
+		if (empty($params['caption']) && !empty($siteinfo["description"])) {
 			$params['caption'] = BBCode::convert("[quote]" . $siteinfo["description"] . "[/quote]", false, 4);
 		}
 

twitter/twitter.php

@@ -1514,6 +1514,11 @@ function twitter_fetchparentposts(App $a, $uid, $post, TwitterOAuth $connection,
 			break;
 		}
 
+		if (empty($post->id_str)) {
+			logger("twitter_fetchparentposts: This is not a post " . json_encode($post), LOGGER_DEBUG);
+			break;
+		}
+
 		if (DBA::exists('item', ['uri' => 'twitter::' . $post->id_str, 'uid' => $uid])) {
 			break;
 		}