Commit graph

34359 commits

Author SHA1 Message Date
Roland Häder ba33c95e97
Fixes:
"Argument 1 passed to Friendica\Content\Text\BBCode::toPlaintext() must be of the type string, null given, called in /var/www/.../htdocs/mod/display.php on line 305"
2022-07-03 14:45:12 +02:00
Tobias Diekershoff e6ed8f6315
Merge pull request #11703 from MrPetovan/bug/fatal-errors
Fix fatal errors
2022-07-03 06:32:37 +02:00
Hypolite Petovan 181c142bb4 Remove overly strict type-hint in ActivityPub\Transmission::createCachedActivityFromItem
- Fix "Return value of Friendica\Protocol\ActivityPub\Transmitter::createCachedActivityFromItem() must be of the type array, bool returned" error
2022-07-02 22:16:59 -04:00
Hypolite Petovan e6feed65bf Rename Smilies::pregHeart to better match its purpose
- Fix "Argument 1 passed to Friendica\Content\Smilies::pregHeart() must be of the type string, array given" error
2022-07-02 22:14:20 -04:00
Tobias Diekershoff da7bc082b9
Merge pull request #11701 from Quix0r/fixes/missing-type-hints-getstart
Added missing type-hints
2022-07-01 06:40:54 +02:00
Roland Häder 3326c4cb31
Added missing type-hints, #11700 2022-07-01 02:50:34 +02:00
Hypolite Petovan ef5d178e00
Merge pull request #11699 from Quix0r/rewrites/type-hints-001
Type-hints added, method renamed
2022-06-30 12:25:20 -04:00
Roland Häder 90b0b33687
Changed double-quotes to single 2022-06-30 17:43:32 +02:00
Roland Häder 1ee0e6f711
Changes:
- no NULL anymore for 2nd parameter OEmbed::toHTML()
- some double-quotes to single
2022-06-30 15:03:12 +02:00
Roland Häder 6186aac792
Fixed type-hints 2022-06-30 14:58:45 +02:00
Roland Häder 99902bb478
Changes
- ops, also this needs change since null is no longer wanted
2022-06-30 14:52:37 +02:00
Roland Häder 5c0e8c62de
Changes
- renamed Widget::accounttypes() to Widget::accountTypes()
- fixed type-hint the documentation was wrong
2022-06-30 14:50:28 +02:00
Roland Häder 83cbe586ac
Changes
- renamed Item::visibleActivity() to Item::isVisibleActivity() as this returns
  a boolean value
- added some type-hints
- added some documentation
2022-06-30 14:18:13 +02:00
Roland Häder e33f5612ab
Changes:
- added some type-hints
- added some documentation
- changed some double-quotes to single
2022-06-27 15:16:18 +02:00
Roland Häder a392a22eee
Changes:
- added some type-hints
- fixed some documentation (void is lately returned, not null)
- added some documentation
2022-06-27 15:16:17 +02:00
Roland Häder 703ba1439b
Some empty lines 2022-06-27 15:16:17 +02:00
Roland Häder 98bc5216ef
A bit more documentation 2022-06-27 15:16:17 +02:00
Roland Häder 9871e9718e
Changes:
- added some type-hints
2022-06-27 15:16:16 +02:00
Roland Häder 6c5acf9ee0
Fixed:
- "Argument 3 passed to Friendica\Model\Photo::createPhotoForExternalResource()
  must be of the type string, null given
2022-06-27 15:16:16 +02:00
Roland Häder ff9707713b
Fixed:
- Friendica\Content\BoundariesPager::renderFull(int $itemCount) must be
  compatible with Friendica\Content\Pager::renderFull(int $itemCount): string
2022-06-27 15:16:15 +02:00
Hypolite Petovan 61d5f64933
Merge pull request #11697 from Quix0r/fixes/contact-user-isblocked-retuning-null
Fixed: TypeError: "Return value of Friendica\Model\Contact\User::isBlocked() must be of the type bool, null returned"
2022-06-27 07:57:55 -04:00
Roland Häder 8e19998191
Fixes:
- more "bool expected but null returned" errors
2022-06-27 13:49:53 +02:00
Roland Häder 7c049abfda
Fixed:
- Contact/User::isBlocked() needs to return boolean, but sometimes (strangely)
  a NULL can come from database, so let's cast it

This tries to fix:
TypeError: "Return value of Friendica\Model\Contact\User::isBlocked() must be of the type bool, null returned"
2022-06-27 11:39:18 +02:00
Hypolite Petovan 43531d5aa0
Merge pull request #11696 from Quix0r/fixed-twitter-api-empty-about
Fixed "Argument 1 passed to Friendica\Content\Text\BBCode::toPlaintext() must be of the type string, null given"
2022-06-26 18:46:15 -04:00
Roland Häder 4bdce6948f
Changed:
- $publicContact['about'] can be NULL, causing following error:
--------------------------
Argument 1 passed to Friendica\Content\Text\BBCode::toPlaintext() must be of
the type string, null given, called in /.../src/Object/Api/Twitter/User.php
--------------------------
The "expensive" code there can be avoided being called by an empty string or
NULL to increase performance.
2022-06-26 23:28:48 +02:00
Tobias Diekershoff e04ad87c15
Merge pull request #11693 from nupplaphil/feat/woodpecker
Use labels for woodpecker continuous deployments
2022-06-26 15:56:58 +02:00
Philipp Holzer 215187595d
Use labels for woodpecker continuous deployments 2022-06-26 15:45:58 +02:00
Philipp e594656a48
Merge pull request #11684 from MrPetovan/bug/11651-ap-fetch-queue
Create ActivityPub\FetchQueue and ActivityPub\FetchQueueItem classes
2022-06-26 13:36:19 +02:00
Philipp f39231eb2a
Merge pull request #11692 from MrPetovan/bug/fatal-errors
Convert potential spaces in Memcache(d) key names
2022-06-26 13:34:23 +02:00
Hypolite Petovan 91f5a7cc6b Convert potential spaces in Memcache(d) key names
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1166475036
- Add test for space in cache keys
2022-06-26 07:30:30 -04:00
Hypolite Petovan c9d829a679
Merge pull request #11690 from nupplaphil/feat/2fa_improv
2 Factor Authentication improvements
2022-06-26 05:42:58 -04:00
Philipp Holzer b67e488236
adaptions 2022-06-26 10:13:32 +02:00
Philipp Holzer 2248850f78
add anything .. 2022-06-25 23:06:42 +02:00
Philipp Holzer 123c116591
Update messages.po 2022-06-25 23:04:01 +02:00
Philipp Holzer 0223c030a9
Improve 2 factor usage 2022-06-25 23:04:00 +02:00
Philipp Holzer f3de8d7764
improve 2fa token field 2022-06-25 22:48:35 +02:00
Philipp Holzer 759d9d9f1a
Add more 2fa properties 2022-06-25 22:48:34 +02:00
Philipp Holzer b86ff1e970
Rename 2FA recovery message 2022-06-25 22:48:34 +02:00
Hypolite Petovan da32fa8fa6 Create ActivityPub\FetchQueue and ActivityPub\FetchQueueItem classes
- These classes are used to flatten the recursive missing activity fetch that can hit PHP's maximum function nesting limit
- The original caller is responsible for processing the remaining queue once the original activity has been fetched
2022-06-25 12:40:54 -04:00
Hypolite Petovan 3c70d592f6
Merge pull request #11689 from Quix0r/rewrites/double-quotes-single
Changed more double-quotes to single
2022-06-25 12:02:01 -04:00
Roland Häder e10dd20036
Made @TODO more clear? 2022-06-25 17:58:27 +02:00
Philipp 9527cd5cb3
Merge pull request #11688 from MrPetovan/bug/11635-mod-photos-posted
Replace obsolete posted sort field by created in mod\photos
2022-06-25 17:54:49 +02:00
Hypolite Petovan ee96c26ede Replace obsolete posted sort field by created in mod\photos 2022-06-25 11:46:54 -04:00
Hypolite Petovan 7c1ae71527 Add tests for BBCode::fetchShareAttributes 2022-06-25 11:46:53 -04:00
Hypolite Petovan a7d49877a8 Centralize share tag attribute extraction code in Content\Text\BBCode 2022-06-25 11:46:52 -04:00
Roland Häder 4164cdacf5
Changes:
- added type-hints
- added documentation
2022-06-25 16:48:37 +02:00
Roland Häder 804b759df1
Changes:
- let's get rid of that `Database::exists()` is being misused for checking table existence
- reformatted array
2022-06-25 16:48:37 +02:00
Roland Häder f689faca99
Changed double-quotes to single 2022-06-25 16:48:36 +02:00
Roland Häder 88870d18be
Changes:
- added some type-hints
- added documentation
2022-06-25 16:48:36 +02:00
Roland Häder 39675fe683
Space for the rescue. ;-) 2022-06-25 16:48:35 +02:00