Commit graph

10154 commits

Author SHA1 Message Date
Philipp 801ee5c17f
Merge pull request #12276 from MrPetovan/bug/fatal-errors
Address a couple of fatal errors
2022-11-27 00:31:14 +01:00
Marek Bachmann 719c294fb5 Added info about upload_max_filesize to admin page 2022-11-26 23:45:58 +01:00
Hypolite Petovan a5f601718f Add a default value for $data['version'] in Model\GServer
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1327320541
2022-11-26 17:28:55 -05:00
Hypolite Petovan b6d62003a6 Have a default value for $item['contact-id'] in Model\Post\Delayed
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1327030873
2022-11-26 17:27:36 -05:00
MarekBenjamin 765b50bde8
Update src/Util/Strings.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2022-11-26 23:14:21 +01:00
MarekBenjamin ce56cabd9f
Update src/Util/Strings.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2022-11-26 23:12:46 +01:00
Philipp Holzer 3ef7ae2f74
License :) 2022-11-26 22:33:45 +01:00
Philipp Holzer d0b16b2fc1
Move mod/fbrowser to src\Modules\Attachment|Photos\Browser 2022-11-26 22:26:30 +01:00
Marek Bachmann 6c73077bbc whitespaces 2022-11-26 21:53:12 +01:00
Marek Bachmann 907deed523 introduced getBytesFromShorthand function to covert from shorthand notation to int 2022-11-26 21:43:31 +01:00
Hypolite Petovan ed7b175491 Catch worker argument type errors
- This marks the invalid worker queue item as completed instead of endlessly retrying it
- Address https://github.com/friendica/friendica/issues/11992#issuecomment-1327029331
2022-11-26 15:21:46 -05:00
Michael acfc11c436 Issue 12133: Account data can now be updated via API 2022-11-26 08:56:24 +00:00
Michael 8879d93aad Issue 12266: APISuggestions should now work 2022-11-26 02:08:34 +00:00
Hypolite Petovan 29ee2473d7
Merge pull request #12269 from annando/api-edit
Issue 12192: API: Enable edit
2022-11-25 19:22:27 -05:00
Philipp c2c563be26
Merge pull request #12249 from MrPetovan/bug/deprecated
Address several PHP 8.1 deprecation notices
2022-11-25 23:32:32 +01:00
Philipp 4291e0def5
Merge pull request #12246 from MrPetovan/bug/notices
Ensure the existence of various keys in decoded data in Diaspora::decodeRaw
2022-11-25 23:30:56 +01:00
Michael 92807d86a3 API: Enable edit 2022-11-25 19:35:40 +00:00
Hypolite Petovan 55640eec87 [Composer] Upgrade to phpseclib version 3
- Create custom Key file format for Salmon Magic key
- Remove obsolete pemToME and MEtoPem Crypto methods
- Remove unused newECKeypair Crypto method
- Switch to constant-time Base64 encode/decode in Base64Url Strings methods
2022-11-25 08:13:05 -05:00
Hypolite Petovan a3fb499735 Replace call to parse_url() with Uri instanciation in Util\Proxy
- Address part of https://github.com/friendica/friendica/issues/12011#issuecomment-1321796513
2022-11-25 08:13:05 -05:00
Hypolite Petovan 0ec7238da4 Fix null value passed to string functions deprecation notices
- Address part of https://github.com/friendica/friendica/issues/12011#issuecomment-1321796513
2022-11-25 08:13:05 -05:00
Hypolite Petovan 6b555f64da Add \ReturnTypeWillChange attribute to methods inherited from native interfaces
- Part of https://github.com/friendica/friendica/issues/12011#issuecomment-1321796513
2022-11-25 08:13:05 -05:00
Hypolite Petovan 01558d6dda
Merge pull request #12264 from annando/error
Fix "Argument #1 ($parts) must be of type array, bool given"
2022-11-25 08:05:10 -05:00
Michael fa5e7585a3 Fix "Argument #1 ($parts) must be of type array, bool given" 2022-11-25 06:08:56 +00:00
Hypolite Petovan 9de6350154 Reorder search to try redirecting to post first
- Pleroma's post page includes the author's feed which wrongly gets picked up as a contact
- Address https://libranet.de/display/0b6b25a8-1563-7ec0-7408-70b986546395
2022-11-24 22:21:51 -05:00
Marek Bachmann 18f0d3d31e removed double blank 2022-11-25 01:03:34 +01:00
Marek Bachmann f4e2c7a11d corrected typos in DocBlocks 2022-11-25 00:59:24 +01:00
Hypolite Petovan 313f3d8515
Merge pull request #12255 from annando/invalid-unfollow
Silently quit on unfollow of invalid contacts
2022-11-24 14:46:59 -05:00
Michael 53b46855ef return "null" 2022-11-24 19:45:45 +00:00
Michael c88125348f Issue 12189: Quote share a feed now shares the linked feed url 2022-11-24 06:36:08 +00:00
Michael 6a434588a9 Silently quit on unfollow of invalid contacts 2022-11-24 05:17:14 +00:00
Michael a6ff817f47 Update added 2022-11-23 21:47:47 +00:00
Michael 0bd0046b9f Merge remote-tracking branch 'upstream/develop' into remote-self 2022-11-23 21:11:09 +00:00
Michael 8bbf3f3699 "MIRROR_FORWARDED" is no more 2022-11-23 21:10:57 +00:00
Marek Bachmann 32aa8bd198 Added information that max image upload size on admin page does not affect server-side upload limits 2022-11-23 18:17:33 +01:00
Hypolite Petovan d2ea58428d Ensure the existence of various keys in decoded data in Diaspora::decodeRaw
- Address https://github.com/friendica/friendica/issues/11994#issuecomment-1302681295
2022-11-23 11:22:54 -05:00
Hypolite Petovan 14ebc4a821 Ensure $owner is set in ActivityPub\Transmitter::sendContactReject
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1289535020
2022-11-23 11:05:36 -05:00
Hypolite Petovan 7c6d54c989 Ensure $attachment has a width and a height when it's an image in Mastodon\Attachment
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1323274513
2022-11-23 11:00:15 -05:00
Hypolite Petovan a5af1408d6 Ward against the possible case that $actor is empty in ActivityPub\Processor::createItem
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1323273452
2022-11-23 10:47:51 -05:00
Hypolite Petovan a8eabae12f Ensure $owner is set in ActivityPub\Transmitter::sendActivity
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1322704863
2022-11-23 10:40:41 -05:00
Hypolite Petovan 8e67d28997 Return early if user contact doesn't exist in Mastodon\Notification::getType
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1321804594
2022-11-23 10:35:49 -05:00
Michael 7b563fd307 Tempory fix removed 2022-11-23 14:17:39 +00:00
Michael 352b7a0ac3 "MIRROR_FORWARDED" is removed 2022-11-23 14:00:34 +00:00
Michael 25992b063a Merge remote-tracking branch 'upstream/develop' into no-api-post 2022-11-23 06:28:24 +00:00
Michael f600f68907 No more automated posts via mod/item.php 2022-11-23 06:27:40 +00:00
Hank Grabowski 733509561a Update Notify->iid to itemId for notification endpoint 2022-11-21 23:40:15 -05:00
Hank Grabowski 548fd3201d The two endpoints for unfavoriting/liking (and related things) was failing because it wasn't using the correct uuid in item.php in processing the action. 2022-11-21 16:49:20 -05:00
Hypolite Petovan 77e87da441 Create /profile/{nickname}/photos route
- Create new Profile\Photos\Index module class
- Update most references of the legacy /photos/{nickname} route
2022-11-20 17:15:07 -05:00
Hypolite Petovan 6dcc964ed8 Fix string interpolation in Model\Photo::upload 2022-11-20 17:07:08 -05:00
Hypolite Petovan d4bb5223a4 Use guid from shared post in Protocol\Diaspora::getReshareDetails
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1321194769
2022-11-20 13:01:37 -05:00
Tobias Diekershoff eec48057dc
Merge pull request #12221 from MrPetovan/bug/warnings
Fix various PHP 8 deprecations
2022-11-20 08:21:06 +01:00
Tobias Diekershoff 70ea419fcc
Merge pull request #12218 from MrPetovan/bug/frion-search-items
[frio] Improve search list display for web and mobile
2022-11-20 08:14:42 +01:00
Tobias Diekershoff d1a85f1fa4
Merge pull request #12222 from MrPetovan/bug/12219-hovercard-stay-local
Fix support for `/contact/123456/conversations` URLs in Module\Contact\Hovercard
2022-11-20 08:10:42 +01:00
Hypolite Petovan 5f074bc4e7 Add support for Mastodon /authorize_interaction route
- It is used by Fedifind to follow people who set their Webfinger address in their Twitter bio
2022-11-19 19:55:01 -05:00
Hypolite Petovan 83c04ac433 Fix support for /contact/123456/conversations URLs in Module\Contact\Hovercard 2022-11-19 19:41:45 -05:00
Hypolite Petovan 99df11e99b Fix PHP 8 inheritance deprecation warnings in App\PAge and ParsedLogIterator 2022-11-19 19:30:48 -05:00
Hypolite Petovan 6f93ee7e49 Fix various PHP 8 deprecations 2022-11-19 19:15:47 -05:00
Hypolite Petovan a147038c2e Ensure IEMail::getMessage returns a string 2022-11-19 19:15:47 -05:00
Hypolite Petovan 2a4985cd46 Fix database connection with sockets
- Reformat Database\Database.php file
- Reformat and fix spelling in static/defaults.config.php file
2022-11-19 19:15:43 -05:00
Hypolite Petovan 24804eb042 Hide non-functional mass deletion feature in search view 2022-11-19 17:16:01 -05:00
Philipp 5a2a8db21f
Merge pull request #12208 from MrPetovan/bug/12059-display-not-found
Improve error message when conversation isn't available in Module\Item\Display
2022-11-19 19:59:40 +01:00
Philipp 643d18b108
Merge pull request #12215 from MrPetovan/bug/hovercard-url
Fix support for `/contact/redir` URLs in Module\Contact\Hovercard
2022-11-19 19:53:38 +01:00
Hypolite Petovan a91944af24 Fix constructor compatibility with BaseSettings parent class
- Address https://paste.metaversum.wtf/?fc75de3f8eba6e7d#813SFjJwWWaJERQyrEpGAVnL33xZpTRV4MZeKmzsAvK8
2022-11-19 13:33:05 -05:00
Hypolite Petovan 525eab395c Improve error message when conversation isn't available in Module\Item\Display
- Retrieve the parent post no matter what. Previously it was depending on the user's settings, which gave unpredictable behavior if the parent post wasn't retrieved for whatever reason.
- List possible reasons the conversation isn't showing up based on the condition in Model\Post::selectViewForUser
- Allow HTML in exception messages
2022-11-19 12:29:08 -05:00
Hypolite Petovan de5097b772 Fix support for /contact/redir URLs in Module\Contact\Hovercard
- The feature was broken after the Redir route was moved
2022-11-19 12:28:54 -05:00
Thorsten 90567772bd Prevent division by zero. 2022-11-19 18:16:41 +01:00
Hypolite Petovan 3d5b81e4ef
Merge pull request #12213 from Schnoop/bugfix/NodeInfo
Fix that users property should be an object instead of array.
2022-11-19 11:59:33 -05:00
Thorsten 877369d964 Fix that user property should be an object instead of array. 2022-11-19 16:48:07 +01:00
Hypolite Petovan 6460218c0e Ensure register records aren't created with uid = 0
- uid = 0 matches system account and public contact records, giving unexpected display in pending user list. More importantly, the originally created user can't be approved since its user id is lost.
2022-11-18 16:04:02 -05:00
Thorsten 2edbd1a3e2 Reverted some changes that won't work with PHP7.3 2022-11-18 19:41:56 +01:00
Thorsten 7a39be8270 DDEV and some PHP8.1 fixes. 2022-11-18 12:03:55 +01:00
Thorsten 8a71bdc1a0 Add meta tag to attachment to show images in mastodon app. 2022-11-18 09:38:02 +01:00
Hypolite Petovan e354f48765
Merge pull request #12200 from annando/ignore-view
"View" activities are now ignored
2022-11-17 15:28:34 -05:00
Michael cdbfa34066 "View" activities are now ignored 2022-11-17 20:01:32 +00:00
Hypolite Petovan 293f147867
Merge pull request #12186 from nupplaphil/mod/editpost
Move mod/editpost.php to src\Module\Post\Edit
2022-11-16 16:14:07 -05:00
Philipp Holzer 81b21c4131
Revert "Remove geotag"
This reverts commit 5dc9319b
2022-11-16 21:20:24 +01:00
Philipp Holzer 9621279572
Make PHP-CS happy ... 2022-11-16 10:49:12 +01:00
Philipp Holzer 12fb897f54
Adhere PHP-CS 2022-11-16 08:56:37 +01:00
Philipp Holzer e7fd4a4cd1
Remove legacy comments 2022-11-16 08:56:19 +01:00
Philipp Holzer 5dc9319bb2
Remove geotag 2022-11-16 08:50:57 +01:00
Philipp Holzer db7af4c45b
Remove jotnets 2022-11-16 08:49:48 +01:00
Michael ec92f7a81c Fix memory issue on displaying conversations 2022-11-16 04:57:46 +00:00
Philipp Holzer 09e01b9356
Replace $_SESSION 2022-11-15 22:52:23 +01:00
Philipp Holzer 00883c9dcb
Move mod/editpost.php to src\Module\Post\Edit 2022-11-15 22:32:46 +01:00
Philipp 53f3454874
Merge pull request #12184 from annando/duplicated-media
This fixes duplicated media in quoted posts
2022-11-15 21:17:19 +01:00
Hypolite Petovan 403b025b5d
Merge pull request #12179 from nupplaphil/mod/display
Move mod/(update_)display.php to src\Module
2022-11-15 15:14:17 -05:00
Michael 348156dbcf Simplify the check 2022-11-15 19:55:03 +00:00
Michael eca52627c1 This fixes duplicated media in quoted posts 2022-11-15 19:48:43 +00:00
Philipp Holzer 59c97234f8
PHP-CS and license .. 2022-11-15 20:15:25 +01:00
Philipp Holzer 584e7a7e6d
Remove trailing slash in update_ calls 2022-11-15 20:11:38 +01:00
Philipp Holzer eff7740a67
Address feedback 2022-11-15 19:53:53 +01:00
Hypolite Petovan 3a7586e3f7 Fix wrong user table field name in Repository\Notify
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1314954594
2022-11-15 09:03:43 -05:00
Philipp Holzer ba0b83b0b0
Make PHP-CS happy 2022-11-15 01:10:49 +01:00
Philipp Holzer 3259bd17dc
Move mod/(update_)display.php to src\Module 2022-11-15 00:57:47 +01:00
Philipp Holzer 5c05a3b0f6
Move mod/display.php "feed-item" to a src\Module\Item\Feed.php 2022-11-15 00:52:58 +01:00
Hypolite Petovan fe547b7851 Centralize config.admin_email management in Model\User 2022-11-14 17:02:42 -05:00
Hypolite Petovan cbe8d463b1 Don't create notify for deleted user accounts 2022-11-14 17:02:42 -05:00
Hypolite Petovan 48b1dceb19 Don't send item notifications to deleted user accounts 2022-11-14 17:02:42 -05:00
Hypolite Petovan 6df187478d Fixed wrong reference to user.expire in Model\User::getActorName
- Update field documentation to prevent further confusion
2022-11-14 17:02:41 -05:00
Hypolite Petovan 10e48a34f2 Ensure Post::toArray returns an array
- We don't handle query errors anyway
- Remove unused parameter do_close
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1314245581
2022-11-14 14:53:54 -05:00
Hypolite Petovan cb0fde5d7d Create new OStatus\Subscribe module class
- Move route from /ostatus_subscribe to /ostatus/subscribe
2022-11-14 13:48:47 -05:00