34277 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Roland Häder	bff57bb030	Changes: ... - added type-hints - added returned type-hints in interface (I checked all)	2022-06-19 14:00:31 +02:00
Hypolite Petovan	777872e6fa	Merge pull request #11658 from tobiasd/20220619-accesskey ... Accesskey was used twice	2022-06-19 07:09:20 -04:00
Roland Häder	c0d7f8944d	Some calls saved	2022-06-19 11:26:10 +02:00
Roland Häder	60f8c2d795	Changes: ... - added missing type-hints - added documentation for a method	2022-06-19 10:50:09 +02:00
Roland Häder	5f6943b008	Changes: ... - MySQL index on BLOB/TEXT can only be partial (e.g.: `column`(length))	2022-06-19 10:50:06 +02:00
Roland Häder	5792a01a01	Contact::getAccountType()'s parameter is never a string, ops	2022-06-19 09:36:24 +02:00
Roland Häder	f3599fa3e9	Changes: ... - dbstructure(null) is no longer possible, an empty string does it	2022-06-19 09:13:10 +02:00
Tobias Diekershoff	065dad79ca	updated the Accesskey documentation accordingly	2022-06-19 06:33:21 +02:00
Tobias Diekershoff	a063a89c57	Accesskey was used twice ... The accesskey on the User Settings pages for the _account settings_ and the _two factor authentication_ were the same. This PR is assinging a new one to the 2FA.	2022-06-19 06:30:00 +02:00
Roland Häder	b6bfe72083	Wrong returned type, has to be array	2022-06-19 02:40:07 +02:00
Roland Häder	7bb0cb5323	Changes: ... - added more type-hints - DBStructure::existsTable() does no longer need array support for table name because this is no longer used (good work!)	2022-06-19 02:11:12 +02:00
Roland Häder	2c5685c89c	Changes: ... - changed to proper "use Foo\Bar;" - added doctag - added return type as this is fixed	2022-06-19 01:11:30 +02:00
Roland Häder	d7d2ad77ff	Ops, also this!	2022-06-18 23:31:52 +02:00
Roland Häder	39f2d197ea	Changed to suggestings (back to original) + fixed typo in scalar type	2022-06-18 23:30:37 +02:00
Roland Häder	6f1d52cf71	Changed back to suggestions by @MrPetovan	2022-06-18 23:24:08 +02:00
Roland Häder	2f961b11bf	Naming-convention: ... - variables should start lower-case: $image	2022-06-18 23:16:34 +02:00
Roland Häder	fa14a02a19	Changes: ... - added type-hints - added documentation - changed double-quotes to single	2022-06-18 23:12:52 +02:00
Roland Häder	f3b57008b5	Proper type is string	2022-06-18 18:41:16 +02:00
Roland Häder	41f34c4261	Maybe fix for: ... "Argument 1 passed to Friendica\Model\ItemURI::getIdByURI() must be of the type string, null given, called in Processor.php line 1219"	2022-06-18 18:30:50 +02:00
Roland Häder	9691bb06fb	Changes: ... - added more type-hints - added missing documentation	2022-06-18 18:21:29 +02:00
Roland Häder	94eb426151	Nodeinfo::getOrganization() doesn't need configuration object being inserted ... when you have DI::config() around.	2022-06-18 17:56:33 +02:00
Roland Häder	c29c49797a	Added missing type-hints	2022-06-18 17:52:46 +02:00
Roland Häder	4e437190c5	Renamed variable, no need for "orig_" prefix	2022-06-18 17:50:11 +02:00
Roland Häder	a1a81cdc6b	Continued: ... - changed some double-quotes to single - added missing type-hints - added missing documentation - fixed indenting a bit	2022-06-18 17:46:34 +02:00
Roland Häder	8fc710f82a	Continued: ... - added more type-hints - added some missing documentation - Return the result from DBA::delete() to let other methods know about it	2022-06-18 17:22:50 +02:00
Roland Häder	8ba3f13fae	Changes: ... - added more type-hints - added missing documentation	2022-06-18 17:09:46 +02:00
Roland Häder	7ec07178c8	Changes: ... - added missing type-hints - added missing documentation	2022-06-18 16:59:23 +02:00
Hypolite Petovan	e90ad0c1cd	Merge pull request #11653 from Quix0r/fixes/more-type-hints ... More type-hints added	2022-06-18 10:33:33 -04:00
Hypolite Petovan	b2e5993314	Merge pull request #11654 from Quix0r/fixes/post-media-url-size ... post-media has too small sizes for video files	2022-06-18 10:28:00 -04:00
Roland Häder	92a1d14e5e	Updated documentation and SQL dump, according to woodpecker tests	2022-06-18 16:02:33 +02:00
Roland Häder	8756d92316	Continued: ... - prevents a "Return value of Friendica\Core\Worker::workerProcess() must be of the type array, bool returned"	2022-06-18 15:57:31 +02:00
Roland Häder	8aaf99c61d	Sizes increased for: ... - video files that have sizes var being int allowes - URLs that might be longer (e.g. magnet: URLs) than varbinary(511) allows	2022-06-18 15:31:47 +02:00
Roland Häder	bd3a7b9877	Ops, needs to be a variable: ... Error: "Cannot pass parameter 2 by reference" at /var/www/.../src/Module/DFRN/Poll.php line 36	2022-06-18 09:59:19 +02:00
Roland Häder	69cda4f760	Fixed TypeError: "Argument 1 passed to Friendica\Core\System::httpExit() must be ... of the type string, null given, called in /var/www/.../src/Module/DFRN/Poll.php on line 37"	2022-06-18 05:42:02 +02:00
Roland Häder	7cbb818c93	Set type-hint for parameter $data to SimpleXMLElement as $fields in dispatch() ... is the same and being handled over.	2022-06-18 05:19:24 +02:00
Roland Häder	89302d0843	Some outside code relies on returned "false"	2022-06-18 05:06:18 +02:00
Roland Häder	aaf5c323b6	Fixed indenting	2022-06-18 05:04:14 +02:00
Roland Häder	adb4aea6ad	Changes: ... - added some type-hints - replaced most double-quotes (only Diaspora.php, later more) with single - added some documentation - normalized indenting in Diaspora.php (I hope I got all?)	2022-06-18 05:03:10 +02:00
Roland Häder	51f43278d6	Fixed incompatible types	2022-06-17 18:00:36 +02:00
Roland Häder	88c40f3336	Ops, wrong type again	2022-06-17 17:18:31 +02:00
Roland Häder	a770634b95	Ops, wrong type	2022-06-17 17:18:31 +02:00
Roland Häder	36d56a4041	Continued: ... - changed back to 'return false;' as other methods heavily rely on false instead of an empty array as pointed out by @heluecht@pirati.ca - $fetched_contact should be initialized as an empty array, let's not make this code more crazier than it already is (see APContact::getByURL())	2022-06-17 17:18:31 +02:00
Roland Häder	c467bff79f	Some more type-hints added	2022-06-17 17:18:31 +02:00
Roland Häder	4f3321cc9f	Nore fixes	2022-06-17 17:18:31 +02:00
Roland Häder	10bb7d5625	Possible fix for ... Uncaught Exception TypeError: "Return value of Friendica\Model\APContact::getByURL() must be of the type array, bool returned"	2022-06-17 17:18:31 +02:00
Roland Häder	fdd237a090	Fix for "Uncaught Exception TypeError: "Argument 1 passed to ... Friendica\Model\APContact::unarchiveInbox() must be of the type string, null given" error message	2022-06-17 17:18:31 +02:00
Roland Häder	605e7d55b3	Continued: ... - added more type-hints - some methods in Diaspora returned void but integer was documented so I changed it to -1 to have a proper type-hint	2022-06-17 17:18:31 +02:00
Roland Häder	0c9aff8a09	Also need to declare $profile or otherwise an invocation of ... Receiver::getReceiverForActor() will fail.	2022-06-17 17:18:31 +02:00
Roland Häder	af8cd5ca86	Worker::getWaitingJobForPID() can also return FALSE on failure ... :-(	2022-06-17 17:18:31 +02:00
Roland Häder	227bab43a8	Ops, wrong type-hint here, must be string ($nickname can never be an integer).	2022-06-17 17:18:31 +02:00