Commit Graph

6062 Commits

Author SHA1 Message Date
Hypolite Petovan 819592c3bd Fix Scrutinizer issues in mod [_well_know -> contactgroup]
- Remove unused variables and parameter
- Updated function documentation
- Fix formatting
- Add back uninitialized variables
- Simplify nested conditions
2018-01-04 19:42:48 -05:00
Hypolite Petovan 3b4f5f98f8
Merge pull request #4169 from annando/comment-dfrn
Precaution for incomplete threads
2018-01-04 16:31:16 -05:00
Michael 05c8cbc1e1 Precaution for incomplete threads 2018-01-04 20:59:19 +00:00
Hypolite Petovan 58d5d91831
Merge pull request #4168 from annando/comment-dfrn
Commenting to (nearly) every Friendica contact is now possible
2018-01-04 15:12:07 -05:00
Michael Vogel 066b776dcc
Merge pull request #4166 from MrPetovan/task/fix-scrutinizer-issues
[Scrutinizer] Fix unused code issues in boot and include
2018-01-04 20:59:07 +01:00
Michael Vogel c938623a3d
Merge pull request #4167 from MrPetovan/bug/4155-remove-proxy-oembed
Add settings for OEmbed
2018-01-04 20:57:27 +01:00
Michael 0c9a9b6f0c Commenting to (nearly) every Friendica contact is now possible 2018-01-04 19:48:56 +00:00
Hypolite Petovan d1b3b7fbe4 Review changes
- Remove doc for unused config value
- Restore api_get_user($a) calls
2018-01-04 13:26:09 -05:00
Hypolite Petovan 35a18f6825 Fix unused code in include (second pass) 2018-01-04 12:21:13 -05:00
Hypolite Petovan 3b23f89ca2 Fix unused code in include
- Fix local formatting
- Remove unused variable
- Fix unreached breaks
- Remove commented out code
- Add some documentation
2018-01-04 12:21:13 -05:00
Hypolite Petovan 722782d553 Remove unused parameter in can_write_wall() 2018-01-04 12:21:13 -05:00
Hypolite Petovan 659d637b5a Remove unused param in datetimesel() 2018-01-04 12:19:06 -05:00
Hypolite Petovan 3b4625ebdd Fix unused code in include/api 2018-01-04 12:19:06 -05:00
Hypolite Petovan d9c6417f5d Remove construct_acl_data() 2018-01-04 12:19:06 -05:00
Tobias Diekershoff 04589ecd38
Merge pull request #4092 from MrPetovan/task/3954-move-auth-to-src
Move auth to src
2018-01-04 18:06:42 +01:00
Hypolite Petovan 1f805da94f Move ParseUrl to Util namespace 2018-01-04 12:03:15 -05:00
Hypolite Petovan 3494663c15 Add allowed_domain generic function 2018-01-04 11:57:41 -05:00
Hypolite Petovan 6e71a84075
Merge pull request #4160 from annando/community
We now are having a global items page
2018-01-04 11:50:45 -05:00
Michael ade987db47 Updates for community pages do work now 2018-01-04 15:46:56 +00:00
Michael b677bdd4ff Ensuring that only local users can comment on community items 2018-01-04 14:39:47 +00:00
Michael 505474e118 Community is always available 2018-01-04 14:09:44 +00:00
Michael f66f631079 We now have a single menu item again 2018-01-04 14:02:04 +00:00
Michael e96dbbe7f7 It's now in a single file 2018-01-04 13:04:12 +00:00
Michael 174a1bb54b Commenting on community timelines is now possible 2018-01-04 10:02:56 +00:00
Adam Magness e37640c44c Move Photos to xrc
Move photos from include to Model\Photo class
2018-01-03 21:01:41 -05:00
Michael 243848eec1 Remove some currently unused stuff 2018-01-03 13:34:51 +00:00
Michael 3ffea2cd2c We now have a global page for all global entries from the network. 2018-01-03 13:27:43 +00:00
Michael 6925299e5a Merge remote-tracking branch 'upstream/develop' into community 2018-01-03 01:15:27 +00:00
Hypolite Petovan 9a3e773a9a Merge branch 'develop' into task/3954-move-auth-to-src 2018-01-02 19:30:41 -05:00
Hypolite Petovan 9ea4fad46c Review: Ensure $arr['network'] is populated in item_store 2018-01-02 08:32:53 -05:00
Hypolite Petovan 3dab04e6cc Review: Removed unused code in include/bbcode 2018-01-02 08:30:15 -05:00
Hypolite Petovan 69df67740c Last minute fix to include/items
- Use defaults() to fix undefined indexes
2018-01-02 08:18:19 -05:00
Hypolite Petovan d0d4e3813b Fix formatting and PHP notices in include/tags
- Change remaining double quotes into single
2018-01-02 08:11:14 -05:00
Hypolite Petovan 9f04017e27 Quick fix PHP notices in various files
- Remove unused variables
- Fix variable name typos
- Use x() and defaults() to fix undefined index
- Add back uninitialized variables
2018-01-02 08:11:14 -05:00
Hypolite Petovan 861c4c7474 Fix formatting and PHP notices in identity
- Change flow of profile_load() function to return early if $profiledata
and !$user
- Replace remaining double quotes by single
- Add back uninitialized variables in profile_sidebar
2018-01-02 08:09:50 -05:00
Hypolite Petovan a964129085 Fix formatting and PHP notices in events
- Initialized variables in include/event
- Check for argc before retrieving argv in mod/events
2018-01-02 08:09:50 -05:00
Hypolite Petovan 3069f3b59d Fix formatting and PHP notices in include/conversation
- Remove unused $nickname variable
- Remove unused $comment variable
- Use defaults() in get_responses() to check for array key existence
2018-01-02 08:09:50 -05:00
Hypolite Petovan 66dbef93e3 Fix formatting and PHP notices in bb_ShareAttributes
- Use x() to check for existence of key in $matches
- Remove unused $reldate from template shared_content
2018-01-02 08:09:49 -05:00
Hypolite Petovan eb1b6605b7 Remove include/oembed and mod/oembed 2017-12-31 20:58:32 -05:00
Hypolite Petovan e7c53af6fa Add Module\Oembed and Content\OEmbed 2017-12-31 20:58:09 -05:00
Adam Magness 9e6bf79380 Crypto to src
move Crypto to src and Friendica\Util namespace
2017-12-30 11:51:49 -05:00
Hypolite Petovan c238154a6e Move include/auth to Login::sessionAuth
- Remove include/auth
2017-12-29 21:55:13 -05:00
Hypolite Petovan 2dc598ed5b Move login() to Login module
- Move nuke_session to include/security
- Remove mod/login
2017-12-29 21:55:13 -05:00
Hypolite Petovan 1724dd3841 Make validate_url more intuitive
- Remove the parameter passed by reference
- Add modified url in return value
2017-12-29 21:55:13 -05:00
Hypolite Petovan e16852c2f5 Replace init_groups_visitor with Group::getIdsByContactId 2017-12-29 21:55:12 -05:00
Hypolite Petovan 09467be02a Fix formatting include/security 2017-12-29 21:55:12 -05:00
Michael 69d16d9cfa Don't show the connect link in the profile on the "follow" page 2017-12-29 22:53:08 +00:00
Michael 0bcbe6034e Like on uid=0 does work now 2017-12-27 22:21:40 +00:00
Michael 9acc2ffc24 Make it easier 2017-12-27 21:51:16 +00:00
Michael 1c72a71933 Use another uid for likes 2017-12-27 21:44:22 +00:00