Commit graph

265 commits

Author SHA1 Message Date
nupplaPhil ed9756225d
improvements 2020-02-02 22:43:42 +01:00
nupplaPhil 0e13428210
Move "App::getSenderEmailAddress()" to "Emailer::getSiteEmailAddress()" 2020-02-02 22:43:40 +01:00
nupplaPhil 3291728059
Extract System emails from enotify
- Removed every SYSTEM_EMAIL occurrence in enotify
- Introduced a "SystemMailBuilder" for build system emails
- Replaced every SYSTEM_EMAIL usage in the classes with calling this builder
- Added tests for this new Builder
- Split the email templates between "base" template for email and concrete usages for different use cases
2020-02-02 22:43:35 +01:00
nupplaPhil 74490d6594
Cleanup enotify email
- Removing unused fields
- Move notify template to email subdirectory
2020-02-02 22:43:34 +01:00
Philipp Holzer c2b8c65104
Merge "notification" routes 2020-01-28 23:21:24 +01:00
Philipp Holzer 91707a530c
Add default values for inserts 2020-01-28 22:26:23 +01:00
Philipp Holzer ff9eb20663
Fix enotify item link 2020-01-28 18:41:46 +01:00
Philipp Holzer 443e106105
Fix missing notifications:
- Add namecache in enotify
- Add "unset()" in notify repository for additional field "abort"
- Add possibility for additional, non-saved fields in model
2020-01-28 18:41:45 +01:00
Philipp Holzer 765a0d8892
Some Renames:
- EMail => EMail
- toEmail => toAddress
- fromEmail => fromAddress
2020-01-26 23:47:16 +01:00
Philipp Holzer 2b8f067715
Introduce interface for emailing and create email classes 2020-01-26 21:35:04 +01:00
Philipp Holzer 915abe8a33
Add explicit parameters to Sender::send() method signature 2020-01-26 21:35:03 +01:00
Philipp Holzer ea9d3b7438
Make EMailer util dynamic 2020-01-26 21:35:03 +01:00
Philipp Holzer 0840938dff
Rename classes
- Repository/Model Notification => Notify
- Factory/Object Notification => Notification
2020-01-26 20:30:24 +01:00
Philipp Holzer b85511b00d
Improvements:
- Fix API-select
- Introduce OTYPE-constants
- Rename `IntroductionFactory` methods
2020-01-26 14:33:10 +01:00
Philipp Holzer 0850fb88dd
ReWork Notification Model/Module/Object/Repository/Factory
- Introduce Repository for interaction with "notify" table
- Introduce Factory for read-only notification objects (they're just loosely based on notification the table!)
- Introduce Objects for type-safe usage at the presentation layer
- Reworked Model, which is now fully based on the notify table, including generated fields (cache, ..)
2020-01-25 19:58:22 +01:00
Philipp Holzer 0f932ae723
Notify => Notification
Notifs => Notifications
2020-01-24 18:32:38 +01:00
Philipp Holzer ed9392469e
Remove unneeded Config namespace usages 2020-01-19 22:50:44 +01:00
Philipp Holzer 6c36fd9e01
Move Config::get() to DI::config()->get() 2020-01-19 21:21:13 +01:00
Philipp Holzer d6efc90194
cleanup namespace usages for L10n 2020-01-19 16:31:33 +01:00
Philipp Holzer d3255afa66
Move L10n::withLang() calls to DI::l10n()->withLang() calls 2020-01-19 16:31:18 +01:00
Michael 0a4119adaf @brief is removed completely 2020-01-19 06:05:23 +00:00
Michael 469eefdc5b Notifications: Now declare direct thread answers as replies 2020-01-09 17:53:17 +00:00
Michael 3bf7664ee3 changed priority of messages 2020-01-08 22:36:31 +00:00
Michael d9ea0fea87 Use "replied" 2020-01-08 21:59:12 +00:00
Michael cabaea38ac Improved notification messages 2020-01-08 21:48:59 +00:00
Michael 4d5e15709c The item notifications now are based upon the "user-item" field 2020-01-06 00:59:18 +00:00
Philipp Holzer f0eea6f875
Remove get_app() in favor of DI::app() 2020-01-04 23:42:01 +01:00
Philipp Holzer a4a7f19df1
Move redundant System::removedBaseUrl() to DI::baseUrl()->remove() calls 2019-12-30 23:03:56 +01:00
Philipp Holzer 3f34229752
Move redundant System::baseUrl() to DI::baseUrl() calls 2019-12-30 23:00:08 +01:00
Philipp Holzer 50be94aa5e
Remove deprecated App::getHostName() - process methods to DI::baseUrl()->getHostName() 2019-12-29 20:17:47 +01:00
Philipp Holzer 7a2f4dc54e
Make L10n immutable
- Remove Push/Pop
- Add "withLang($lang)" method
2019-12-28 23:12:01 +01:00
Michael 3a6a78ca46 Issue 7664: Don't notify every time a contact posted something 2019-12-18 06:36:43 +00:00
Philipp Holzer dbbe3ec031
Remove deprecated method to find duplicates (issue from 2013) 2019-11-09 22:00:04 +01:00
Philipp Holzer f9e3ff4b55
Remove unnecessary hash function.
- Was introduced for getting the last inserted ID before "lastInstertID()" was possible
- See b821399f00 (diff-a8e86a3c07531e66a3b0b4c8b4b07879R148)
2019-11-09 21:50:52 +01:00
Philipp Holzer 07cea24430
Move Activity/Namespaces defines to constants 2019-10-24 21:40:12 +02:00
Hypolite Petovan 8b836189d4 Replace deprecated defaults() calls with ?? and ?: in include/ and view/ 2019-10-16 08:51:03 -04:00
Michael 461c3169b1 Issue 6521: Don't send notifications for deleted items 2019-09-10 05:44:09 +00:00
Michael 3b7be251d5 Issue 6521: Don't show notifications on posts that the user deleted 2019-03-15 05:23:45 +00:00
Philipp Holzer 6872b118a4
Fixing preamble in enotify 2019-03-13 20:44:07 +01:00
Hypolite Petovan 8c1db51a76 Improve Logger calls
- Replace various deprecated Logger::log calls
- Reassign log level for verbose log calls
2019-02-23 17:32:11 -05:00
Hypolite Petovan 1467a02576 Fix namespace usage in include/enotify 2019-01-21 11:38:01 -05:00
Hypolite Petovan ce177f22c8 Fix doc blocks and return value type 2019-01-21 11:36:01 -05:00
Hypolite Petovan 7f2dc40601 Fix potential bugs without expected behavior change
- Fix uninitialized variables
- Fix potentially not set variables
- Fix wrong parameter default value
- Fix method scope
- Fix missing return value
2019-01-21 11:04:19 -05:00
Hypolite Petovan ad9c67663d Move Contact::Page_* constants to User::PAGE_FLAGS_* 2019-01-21 10:55:37 -05:00
Hypolite Petovan 070aa016e0 Update more PHPDoc, including in include/ 2019-01-21 10:39:28 -05:00
Hypolite Petovan cbda92f253 Add "on their post" label to notifications
- Align tag notifications on comment notifications
2019-01-21 10:12:52 -05:00
Hypolite Petovan 55e54bb950 Replace deprecated Addon::callHooks with Hook::callAll
- Update documentation
2019-01-21 09:50:56 -05:00
Hypolite Petovan 5e1ceb57de Escape global namespaced get_app() calls
- Add deprecated status
2019-01-03 21:27:36 -05:00
Adam Magness ffc406d819 normalise_link calls
implement normaliseLink function
2018-11-08 11:28:29 -05:00
Adam Magness 991f259ecb random_string calls
implement getRandomHex function
2018-11-08 08:45:46 -05:00
Adam Magness e537f7d017 Function calls
update function calls to new class
2018-11-06 21:16:27 -05:00
Adam Magness 35abc4bb64 get markup template
implement getMarkupTemplate function
2018-10-31 10:44:06 -04:00
Adam Magness 91facd2d0a replace macros
implement new replaceMacros function
2018-10-31 10:35:50 -04:00
Adam Magness 50da89d861 Logger Levels
update logger levels in calls
2018-10-30 09:58:45 -04:00
Adam Magness 14fde5dc9b Log function
implement log() function.
2018-10-30 09:57:14 -04:00
Hypolite Petovan a8d3a4d218 Add missing L10n::popLang calls 2018-10-20 09:02:10 -04:00
Michael Vogel 389685e099
Merge pull request #5920 from MrPetovan/bug/remove-password-from-register
Avoid storing plaintext password in register table
2018-10-17 21:04:11 +02:00
Hypolite Petovan 481b0ac138 Fix notices in include/enotify 2018-10-15 23:13:00 -04:00
Hypolite Petovan f2bde919e5 Fix ignored show_in_notification_page parameter in notification() 2018-10-14 11:30:39 -04:00
Philipp Holzer 5a02e39a65
Rename App Methods
- renamed a lot of App methods to CamelCase
- replaced direct public variables with get-/set-Methods
2018-10-10 00:16:06 +02:00
Michael Vogel d29cb1acaf Fix: Mail notifications arrive again (#5654)
* Fix: Mail notifications arrive again

* Ensure that user data is always there
2018-08-23 10:00:25 +02:00
Michael Vogel 7f3fb34c24 Some easy to replace "q" calls have been replaced by "DBA" calls (#5632)
* Some easy to replace "q" calls have been replaced by "DBA" calls

* Simplified the GUID creation

* And one in the API ...

* And OStatus has got some DBA calls more

* Just some more replaced database calls

* The event query is now simplified

* Events are now shown again

* subthread is now using the DBA calls as well

* Some more replaced database calls

* And some more replaced database calls and prevented notices

* Better use gravity

* Some more replaced database stuff

* Some more replaced database calls in DFRN.php

* The gcontact class now has got the new DBA functions as well

* The Contact class is now changed to new database functions as well

* Small correction

* We can now delete without cascade

* One more functionality is safe for future changes
2018-08-19 12:46:10 +00:00
Michael 56443b53cb Fix: We now are notified again when a new post had been created 2018-08-12 04:34:56 +00:00
Michael Vogel 276abfaba6 Issue 5158: Ignore all threads, even public ones (#5588)
* Issue 5158: Ignore all threads, even public ones

* Remove some notice

* Now it really should work

* Using "defaults"
2018-08-08 22:32:11 +02:00
Michael Vogel c72c64a6d8 Notices again (#5543)
* And again notices

* Notices in the directory

* Much more places

* Fix some double $

* Notice in ping

* Missing field

* Fix: We now remove deleted users from the directory

* Some more stuff

* Notices when removing users

* Added logging

* More logging

* Two more
2018-08-02 07:21:01 +02:00
Michael Vogel 71b1638d9a Once again, notices ... (#5535) 2018-07-31 18:39:23 +02:00
Roland Häder 4a22710b3b Moved global PAGE_* to Profile class (#5500)
* Rewrites:
- moved PAGE_* to Friendica\Model\Profile class

* Fixed more rewrites from plain (global namespace) PAGE_* to Friendica\Models\Profile class

* CR request:
- moved all PAGE_* constants to Friendica\Model\Contact class
- fixed all references of both classes

* CR request:
- moved ACCOUNT_TYPE_* constants from boot.php to Contact::ACCOUNT_TYPE_*

* Just copy-pasted this code from boot.php, needs to be changed to `const ACCOUNT_TYPE_FOO = x;`

* Ops, melting brain cells here ... :-/
2018-07-27 19:25:57 -04:00
Hypolite Petovan a6fb3568f9 Rename dbesc to DBA::escape 2018-07-23 15:30:54 -04:00
Hypolite Petovan ecea7425f8 Rename DBA::is_result to DBA::isResult 2018-07-23 11:04:14 -04:00
Hypolite Petovan 0ec44f3e8a Rename DBM method calls to DBA method calls 2018-07-23 11:02:24 -04:00
Hypolite Petovan af6dbc654f Rename Friendica\Database\dba to Friendica\Database\DBA 2018-07-20 08:19:26 -04:00
Hypolite Petovan daa1177e3a Update use statement lists with new Friendica\Database\dba class
- Remove unused use statement
- Remove superfluous use statements (classes in the same namespace)
- Add missing use statements
2018-07-19 22:15:21 -04:00
Hypolite Petovan 762a786611 Replace direct accesses to App->config by Config::get/set calls 2018-07-16 19:38:16 -04:00
Michael Vogel 0360f7197a Several more warnings ... (#5340)
* Some more warnings removed

* Even more warnings ...

* Will it ever end? ;-)

* Avoid warning in dbstructure

* Origin and OStatus ...

* There are more warnings solved ... yeah!

* And again ...

* We are not done yet

* And more ...

* And some new places ...

* And more in the feeds

* Avoid some more

* And some backend stuff

* Notifications cleared

* Some more stuff

* and again ...

* It's getting fewer ...

* Some warnings had been hidden in the notifications

* Fix the fix

* And another missing one ...

* We need the owner here, not the user

* Forgotten user

* And more ...

* And some more warnings disappeared ...

* Some more frontend warnings

* Some backend warnings removed

* Fixed sidebar for "vier"

* And more ...

* Some more ...

* And something for "remote self"

* Am I stuck in an endless loop?

* Fix: Clear tag and file field on update

* Preset page content
2018-07-10 08:27:56 -04:00
Michael 0ab9f2e265 Preparations to not store the tags in the item table anymore 2018-06-30 13:54:01 +00:00
Michael 76dab3b2d7 Use gravity instead of verb 2018-06-27 18:09:33 +00:00
Michael 6e10de9284 New function to fetch item data especially for users 2018-06-17 17:05:17 +00:00
Michael abef0cd46c Don't use the author-link anymore - just author-id 2018-06-16 15:35:30 +00:00
Michael bb79b8f4ac More item calls have been replaced with the new functions 2018-06-15 22:30:49 +00:00
Hypolite Petovan 7469de29f1 Fix corrupt registration emails
- Use double quotes for line break-containing translation string
- Simplify HTML/plaintext email body conversion
2018-06-14 23:42:08 -04:00
Michael 5d9083c369 Bugfix in notifications / network and display are using the new functions now 2018-06-10 07:26:37 +00:00
Michael baf316e898 The central item fetch does work now and the API now uses these functions 2018-06-09 16:56:37 +00:00
Michael 3f07d01dd1 Get rid of unneeded or redundant fields 2018-06-03 07:42:56 +00:00
Tobias Diekershoff d149541dba notify admin when user deletes account 2018-04-15 11:39:05 +02:00
Hypolite Petovan 32ca95a1b0 Use App->getSenderEmailAddress in include/enotify 2018-04-06 21:47:42 -04:00
Hypolite Petovan 27d94023ee Merge branch 'master' into develop 2018-03-23 06:15:55 -04:00
fabrixxm 8a2a4510ec
Small fixes to translatable string
and some small cosmetic fixup to docstring for `notification()`
2018-03-19 10:15:09 +01:00
Hypolite Petovan 789561c7a2 Remove/Update references to include/html2*.php 2018-03-07 16:34:17 -05:00
Hypolite Petovan 9e3bae5caa Remove references to include/bbcode.php 2018-02-14 22:01:14 -05:00
Hypolite Petovan 0c52866693 Refactor bbcode() into BBCode::convert() 2018-02-14 21:33:55 -05:00
Hypolite Petovan 5e7285b9ba Move Temporal::convert() to DateTimeFormat::convert() 2018-02-03 08:56:55 -05:00
Hypolite Petovan 8aff8a76eb Add Temporal::utcNow() 2018-02-03 08:56:52 -05:00
Hypolite Petovan dc366bf1f7 Refactor datetime_convert into Temporal::convert
- Changed parameter order to save space
- Refactor select_timezone into Temporal::getTimezoneSelect
- Refactor field_timezone into Temporal::getTimezoneField
2018-02-03 08:56:51 -05:00
Hypolite Petovan 9cd3b17743 Fix translation strings for use with util/extract.php
- Change parentheses to “\x28” and “\x29”
- Remove leading commas
- Remove quotes before commas
2018-01-24 16:51:32 -05:00
Adam Magness 208a149a7b Review sprintf
remove more sprintf calls
2018-01-23 21:59:16 -05:00
Adam Magness f0725ae384 Hopefully all t()
hopefully the last of the t()
2018-01-22 18:03:26 -05:00
Adam Magness 83f1149d04 More missing t()
update t() calls
2018-01-22 18:03:26 -05:00
Adam Magness d49f986d1e Many t() calls
modify many t() calls.
2018-01-22 18:03:26 -05:00
Adam Magness c8ecc31405 Update functions and calls
Update function names and calls.
2018-01-22 18:03:26 -05:00
Adam Magness 11cf36105c Update Addon functions and calls
Update function names and calls for Addon class.
2018-01-20 07:48:22 -05:00