Commit graph

14618 commits

Author SHA1 Message Date
Roland Häder 0e19fdfc71
removed parentheses + added TODO about a small rewrite
Signed-off-by: Roland Haeder <roland@mxchange.org>
2017-03-24 21:05:55 +01:00
Roland Häder b5b3451b31
Continued:
- marked commented-out code as possible old-lost
- added more curly braces
- used more dbm::is_result() where SELECT is stated
- ! added quotes in array element, else (here) >thumb< (without quotes) is
  considered as a constant and causes an E_NOTICE

Signed-off-by: Roland Haeder <roland@mxchange.org>
2017-03-24 20:57:52 +01:00
Roland Häder ccd1e2cc6a
fixed parser error
Signed-off-by: Roland Haeder <roland@mxchange.org>
2017-03-24 20:52:26 +01:00
Roland Häder d45e79dfe9
Continued:
- converted multiple single-line comments into one multi-line comment (please
  stop abusing programming languages!)
- added more TODO tags for type-hints (upcoming rewrite)
- opps, one space was only fixed in develop branch, not in this PR branch

Signed-off-by: Roland Haeder <roland@mxchange.org>
2017-03-24 20:39:00 +01:00
Roland Häder db1c2e4041
fixed comment and explained one
Signed-off-by: Roland Haeder <roland@mxchange.org>
2017-03-23 23:37:58 +01:00
Roland Häder a410f86e9c
Continued with #3254:
- added curly braces + spaces
- converted multiple single-line comments to one multi-line comment

Signed-off-by: Roland Haeder <roland@mxchange.org>
2017-03-23 23:08:40 +01:00
Roland Häder c4b82133e9
added more curly braces + spaces for #3254
Signed-off-by: Roland Haeder <roland@mxchange.org>
2017-03-23 23:06:28 +01:00
Roland Häder 2470930902
Continued #3254:
- thrown out old lost-code
- add curly braces (not curely ;-) ) and spaces
- exit is not a keyword, it is a function, so use () here

Signed-off-by: Roland Haeder <roland@mxchange.org>
2017-03-23 23:02:25 +01:00
Roland Häder e4ad359f5a
added curely braces + TODO for maybe avoiding multi-lined if() blocks as it confuses #3254
Signed-off-by: Roland Haeder <roland@mxchange.org>
2017-03-23 22:53:03 +01:00
Roland Häder f94a10bf00
old behaviour restored
Signed-off-by: Roland Haeder <roland@mxchange.org>
2017-03-23 22:49:34 +01:00
Roland Häder 66366b2804
added more spaces and curely braces
killed ?> as it is discouraged

Signed-off-by: Roland Haeder <roland@mxchange.org>
2017-03-23 22:46:25 +01:00
Roland Häder d8eee2be55
added curely branches + reverted back to old behaviour (may come back one day)
Signed-off-by: Roland Haeder <roland@mxchange.org>
2017-03-23 22:33:57 +01:00
Roland Häder 09ab141404
better comment added by @Hypolite
Signed-off-by: Roland Haeder <roland@mxchange.org>
2017-03-23 22:29:26 +01:00
Roland Häder 16c405b387
more spaces added (CR by @Hypolite)
Signed-off-by: Roland Haeder <roland@mxchange.org>
2017-03-23 22:22:41 +01:00
Roland Häder dad6a61be4
it is space-season ... ;-) #3254
Signed-off-by: Roland Haeder <roland@mxchange.org>
2017-03-23 22:19:25 +01:00
Roland Häder 843b7a003c
closed internal TODO, merged 2 if() to one + added spaces
Signed-off-by: Roland Haeder <roland@mxchange.org>
2017-03-23 22:17:39 +01:00
Roland Häder 11d3fd163a
yet another one removed, thanks to @Hypolite for CR
Signed-off-by: Roland Haeder <roland@mxchange.org>
2017-03-23 22:13:28 +01:00
Roland Häder 480871d371
removed no longer old stuff, let's don't stuff code with commented-out code
Signed-off-by: Roland Haeder <roland@mxchange.org>
2017-03-23 22:11:58 +01:00
Roland Häder 9521f39ebe
added more spaces #3254
Signed-off-by: Roland Haeder <roland@mxchange.org>
2017-03-23 22:09:15 +01:00
Roland Häder f85e6d2aac
No parantheses here + no @ (which surpresses warnings and such) #3254
Signed-off-by: Roland Haeder <roland@mxchange.org>
2017-03-23 21:47:51 +01:00
Roland Häder 47602577f3
Opps, missed one ...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2017-03-23 21:45:00 +01:00
Roland Häder 221cfa8c22
added curly braces #3254
Signed-off-by: Roland Haeder <roland@mxchange.org>
2017-03-23 21:44:01 +01:00
Roland Häder f5227c016d
replaced some tabs -> spaces + added curly braces #3254
Signed-off-by: Roland Haeder <roland@mxchange.org>
2017-03-23 21:28:32 +01:00
Roland Häder f173322539
added missing spaces/curly braces
Signed-off-by: Roland Häder <roland@mxchange.org>
2017-03-21 21:52:00 +01:00
Roland Häder ddb5a8ea78
Continued:
- added missing space/curly braces
- added TODOs for later adding a lot type-hints, without these (and they are
  long time around in PHP) anything can be handled over to the method/function.

Signed-off-by: Roland Häder <roland@mxchange.org>
2017-03-21 21:51:22 +01:00
Roland Häder 830af774d3
added more curly braces + a bit more usage of dbm::is_result()
Signed-off-by: Roland Häder <roland@mxchange.org>
2017-03-21 21:50:45 +01:00
Hypolite Petovan 61a01141d7 Merge pull request #3253 from friendica/revert-3112-rewrites/coding-convention
Revert "Coding convention applied - part 1"
2017-03-21 12:04:19 -04:00
Hypolite Petovan 7b352f3f74 Revert "Coding convention applied - part 1" 2017-03-21 12:02:59 -04:00
Hypolite Petovan 9c2c483996 Merge pull request #3112 from Quix0r/rewrites/coding-convention
Coding convention applied - part 1
2017-03-21 10:19:53 -04:00
Tobias Diekershoff 0fd874a683 Merge pull request #3246 from annando/1701-poco
Split poco discovery in smaller function calls
2017-03-21 07:27:10 +01:00
Roland Häder 09851331a9
Merge remote-tracking branch 'upstream/develop' into rewrites/coding-convention
Signed-off-by: Roland Haeder <roland@mxchange.org>
2017-03-20 20:51:32 +01:00
Hypolite Petovan 7a95fcf02a Merge pull request #3241 from rabuzarus/20170316_-_fix_event_edit
add dop event & fix event edit
2017-03-20 13:18:18 -04:00
rabuzarus 0557a42e2f add missed NULL_DATE 2017-03-20 17:19:24 +01:00
rabuzarus d1d33dc79a Merge origin/20170316_-_fix_event_edit into 20170316_-_fix_event_edit
Conflicts:
	mod/events.php
2017-03-20 17:16:39 +01:00
rabuzarus 0879b46125 add NULL_DATE & coding standard work 2017-03-20 16:59:21 +01:00
rabuzarus 0060e2449e Merge develop into 20170316_-_fix_event_edit
Conflicts:
	mod/events.php
2017-03-20 16:46:36 +01:00
Hypolite Petovan 8f7d191bfc Merge branch 'develop' into 20170316_-_fix_event_edit 2017-03-20 11:08:07 -04:00
Michael Vogel eaf308ad01 Merge pull request #3250 from tobiasd/20170320-msg
regenerated master messages.po file
2017-03-20 08:40:37 +01:00
Tobias Diekershoff 8bd8e858d0 regenerated master messages.po file 2017-03-20 08:27:10 +01:00
Tobias Diekershoff 3021254f85 Merge pull request #3247 from annando/issue-3242-b
If the maintenance reason is a url, then redirect to this address
2017-03-20 07:20:23 +01:00
Michael 62915007c6 Test code removed 2017-03-20 04:37:59 +00:00
Michael aa4f9c985f Enhanced explanation 2017-03-20 04:37:13 +00:00
Hypolite Petovan 8c8b8c32d9 Merge pull request #3249 from annando/bugfix-dbstructure
Bugfix for issue 3242 - forgotten "use"
2017-03-19 21:00:55 -04:00
Michael b42a977894 Bugfix for issue 3242 - forgotten "use" 2017-03-19 22:58:35 +00:00
Michael 41ee4ec60a Standards and just some more poco slitting 2017-03-19 21:32:11 +00:00
Michael 24ee60492b If the maintenance reason is a url, then redirect to this address 2017-03-19 19:03:09 +00:00
Michael e684fff477 Added documention 2017-03-19 18:24:49 +00:00
Michael 2615d40d6b Split the POCO discovery process in several small processes 2017-03-19 17:43:59 +00:00
Michael 7f61b2ee15 Merge remote-tracking branch 'upstream/develop' into 1701-poco
Conflicts:
	include/socgraph.php
2017-03-19 15:36:41 +00:00
Hypolite Petovan 65f809f5cb Merge pull request #3245 from annando/issue-3242
Issue 3242: Define a maintenance reason
2017-03-19 11:06:25 -04:00