Commit graph

10574 commits

Author SHA1 Message Date
Hank Grabowski a2559d6241 Add 'include_all' parameter on Mastodon API endpoint
Maintains old functionality of only returning non-dismissed notifications while adding ability to get list of dismissed and non-dismissed notifications
2022-11-30 14:24:46 -05:00
Hank Grabowski a27ffda59f Add dismissed field to Mastodon API Notification types 2022-11-30 14:23:20 -05:00
Hank Grabowski 5b5c38f9ab Fix broken dismiss endpoint on Mastodon notifications API 2022-11-30 14:11:39 -05:00
MarekBenjamin 8f5d6fdf72
Merge branch 'friendica:develop' into show_image_upload_limit 2022-11-30 18:19:18 +01:00
MarekBenjamin e4fd9d425f
Update src/Module/Media/Photo/Upload.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2022-11-30 18:16:55 +01:00
MarekBenjamin f9c0d5a14b
Update src/Module/Media/Photo/Upload.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2022-11-30 18:16:42 +01:00
Michael fbcc56d42d Changes after code review 2022-11-30 14:33:55 +00:00
Michael 1ced4673fe Indention 2022-11-30 13:35:57 +00:00
Hypolite Petovan 7402bc9f50
Merge pull request #12299 from annando/auto-reshare-fix
Check that an auto reshare is only done on the expected contact
2022-11-30 08:34:10 -05:00
Matthias Moritz 2035a7a178 Merge branch 'bug-noLocalPosts' of https://github.com/matthiasmoritz/friendica into bug-noLocalPosts 2022-11-30 13:20:50 +01:00
Matthias Moritz 71f4dd0d20 Update Status.php
Instead of removing AP, added Protocol::DFRN to the list of networks.
2022-11-30 13:19:31 +01:00
Matthias Moritz 7676aa7908
Merge branch 'friendica:develop' into bug-noLocalPosts 2022-11-30 12:18:48 +01:00
Matthias Moritz da93373e8d Fix #12262 - shared friendica posts are filtered on status page
Native shares from the same Instance (or maybe all Friendica instances) were filtered out from the users home. With this commit they now appear on the users Profile/Status
2022-11-30 12:15:58 +01:00
Michael a01cdccb05 Check that an auto reshare is only done on the expected contact 2022-11-30 09:28:27 +00:00
Michael f31e617f5d Contact suggestions are now cached 2022-11-30 05:59:27 +00:00
Marek Bachmann 79235b6db1 Removed redundant maximagesize = INF statements 2022-11-30 05:17:48 +01:00
Marek Bachmann a3d8a59b00 Correctly output binary prefix values since base 2 is used for conversion 2022-11-30 04:37:08 +01:00
Marek Bachmann 75b01f669a Check for inf values before try to converts bytes to binary prefix strings 2022-11-30 04:35:18 +01:00
Marek Bachmann bb9afc520b Added getBytesFromShorthand at the remaining places. 2022-11-30 04:13:10 +01:00
Hypolite Petovan 150c0e0750 Address some PHP 8.1 deprecation notices
- Replace a strstr call by strpos in Model\APContact
- Simplify conditions in Protocol\DFRN
- Address part of https://github.com/friendica/friendica/issues/12011#issuecomment-1331012289
2022-11-29 21:37:41 -05:00
Marek Bachmann 97a3587e58 Added handling as infinity if maxfilesize is set to 0 2022-11-30 02:44:48 +01:00
Marek Bachmann ca7af7a64b Merge branch 'develop' into show_image_upload_limit 2022-11-30 02:28:15 +01:00
Marek Bachmann bbd1c34292 Wrapped all occurrences of DI::config()->get('system', 'maximagesize') with Strings::getBytesFromShorthand() 2022-11-30 02:26:56 +01:00
Marek Bachmann 99e1c64b1a Added info that shorthands can be used for maxfilesize Admin Site 2022-11-30 02:16:48 +01:00
MarekBenjamin 72b3bbb23c
Update src/Module/Admin/Site.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2022-11-30 01:49:53 +01:00
Marek Bachmann 7d86cb1a1e Removed Trends.php which for what ever reason found its way in my branch under src/Module/Api/Mastodon but is not present in friendica:develop 2022-11-30 01:40:21 +01:00
Marek Bachmann c03784eaa9 wanted to use a constant for the shorthand regex to be used in the form input templates and to check maximagesize post value. But Input field seems to require the regex without enclosing "/.../", so remove const for now 2022-11-30 01:26:08 +01:00
Marek Bachmann d44968cd10 split-off! Trends.php allow shorthands in the system.maximagesize 2022-11-30 01:26:08 +01:00
Marek Bachmann 9c383e2004 allow shorthands in the system.maximagesize 2022-11-30 01:26:08 +01:00
Michael 8eda9dfe7c Fix warning 'Undefined array key "name"' 2022-11-29 23:21:27 +00:00
MarekBenjamin 3cf0b9b9fd
Merge branch 'friendica:develop' into show_image_upload_limit 2022-11-29 21:58:46 +01:00
Michael 8b41d62a88 API: Speed improvements 2022-11-29 18:45:30 +00:00
Marek Bachmann 77c68d10e8 Merge branch 'develop' into show_image_upload_limit 2022-11-29 00:28:05 +01:00
Michael 3288efb323 Fix fatal errors because of unknown function/variable names 2022-11-28 21:22:21 +00:00
Hypolite Petovan 0ba111d99c
Merge pull request #12288 from annando/api-tags
API: Added trending links
2022-11-28 16:13:37 -05:00
Michael Vogel 7898f9cccb
Update src/Module/Api/Mastodon/Trends/Links.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2022-11-28 21:42:34 +01:00
Michael de76e860ad API: Added trending links 2022-11-28 20:19:57 +00:00
Hypolite Petovan d6a7303991
Merge pull request #12283 from annando/api-tags
Issue 12191: API tag handling
2022-11-28 14:52:29 -05:00
Philipp Holzer de25d3a7ee
Fix Legacy Router class routing 2022-11-28 20:14:37 +01:00
Michael bded1c3989 Only use items that had originally been posted in the last week 2022-11-28 14:51:37 +00:00
Michael 0e160040d4 Code standards 2022-11-28 10:54:26 +00:00
Michael c00004f6ea API: Tredning statuses added 2022-11-28 09:30:41 +00:00
Michael 73ba7d8005 Coding styles 2022-11-28 06:52:55 +00:00
Michael f7167acc74 Standards 2022-11-28 04:07:25 +00:00
Michael 56c4727fe1 Merge branch 'api-tags' of github.com:annando/friendica into api-tags 2022-11-28 04:04:35 +00:00
Michael 934766c364 Trim the tag 2022-11-28 04:04:27 +00:00
Michael Vogel 4e6b6fd76b
Update src/Module/Api/Mastodon/FollowedTags.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2022-11-28 05:00:08 +01:00
Michael 85f57e69fa Issue 12191: We can now follow and unfollow tags via API 2022-11-28 03:29:43 +00:00
Michael a6d060b0e4 Merge remote-tracking branch 'upstream/develop' into api-tags 2022-11-28 02:13:20 +00:00
Marek Bachmann d43e393921 and now the missing ')' at the correct position 2022-11-28 01:16:54 +01:00
Marek Bachmann 5b2ac7b944 Added missing ')' 2022-11-28 01:11:02 +01:00
MarekBenjamin 6877f8a473
Update src/Module/Admin/Site.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2022-11-28 01:06:40 +01:00
Marek Bachmann a01872a117 Merge branch 'develop' into show_image_upload_limit
# Conflicts:
#	src/Util/Strings.php
#	view/lang/C/messages.po
2022-11-27 23:52:58 +01:00
Michael 6d74d74a26 Issue 12149: Show that a post was reshared 2022-11-27 20:47:08 +00:00
Michael 0e2c2cd0e0 API: Support new tag endpoints 2022-11-27 19:22:41 +00:00
Hypolite Petovan db987999b5 Return only one result in case of exact match in Api\Mastodon\Search 2022-11-27 08:28:52 -05:00
Hypolite Petovan 9fbdcb5459
Merge pull request #12277 from nupplaphil/mod/fbrowser
Move mod/fbrowser to src\Modules\Attachment|Photos\Browser
2022-11-27 07:55:55 -05:00
Philipp b56e6f4b5b
Merge pull request #12280 from MrPetovan/bug/11804-delete-notifications-item
Remove related notifications when marking an item for deletion
2022-11-27 09:01:28 +01:00
Hypolite Petovan 25e1412174 Remove related notifications when marking an item for deletion 2022-11-26 21:48:26 -05:00
Philipp Holzer 3ac3b3d2af
Perfection! 2022-11-27 01:52:49 +01:00
Philipp 272911527c
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2022-11-27 01:52:14 +01:00
Philipp Holzer 4e53ba0c20
Cache the Module class 2022-11-27 01:48:52 +01:00
Philipp Holzer 29190fae73
Update messages.po 2022-11-27 01:36:31 +01:00
Philipp Holzer 012f486eb6
Adhere feedback 2022-11-27 01:34:59 +01:00
Philipp Holzer e6933a28da
Be more kindly :-) 2022-11-27 01:34:59 +01:00
Philipp Holzer 50316bbb80
Move Browser & Upload to own namespace 2022-11-27 01:34:59 +01:00
Philipp Holzer 051253a745
Move FileBrowser to own namespace & Bugfix album usage 2022-11-27 01:34:58 +01:00
Philipp 3607aa32ca
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2022-11-27 01:34:58 +01:00
Philipp e60dfef0d0
Update src/App/Arguments.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2022-11-27 01:34:58 +01:00
Philipp Holzer 7c058153b5
Make PHP-CS happy 2022-11-27 01:34:58 +01:00
Philipp 801ee5c17f
Merge pull request #12276 from MrPetovan/bug/fatal-errors
Address a couple of fatal errors
2022-11-27 00:31:14 +01:00
Marek Bachmann 719c294fb5 Added info about upload_max_filesize to admin page 2022-11-26 23:45:58 +01:00
Hypolite Petovan a5f601718f Add a default value for $data['version'] in Model\GServer
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1327320541
2022-11-26 17:28:55 -05:00
Hypolite Petovan b6d62003a6 Have a default value for $item['contact-id'] in Model\Post\Delayed
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1327030873
2022-11-26 17:27:36 -05:00
MarekBenjamin 765b50bde8
Update src/Util/Strings.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2022-11-26 23:14:21 +01:00
MarekBenjamin ce56cabd9f
Update src/Util/Strings.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2022-11-26 23:12:46 +01:00
Philipp Holzer 3ef7ae2f74
License :) 2022-11-26 22:33:45 +01:00
Philipp Holzer d0b16b2fc1
Move mod/fbrowser to src\Modules\Attachment|Photos\Browser 2022-11-26 22:26:30 +01:00
Marek Bachmann 6c73077bbc whitespaces 2022-11-26 21:53:12 +01:00
Marek Bachmann 907deed523 introduced getBytesFromShorthand function to covert from shorthand notation to int 2022-11-26 21:43:31 +01:00
Hypolite Petovan ed7b175491 Catch worker argument type errors
- This marks the invalid worker queue item as completed instead of endlessly retrying it
- Address https://github.com/friendica/friendica/issues/11992#issuecomment-1327029331
2022-11-26 15:21:46 -05:00
Michael acfc11c436 Issue 12133: Account data can now be updated via API 2022-11-26 08:56:24 +00:00
Michael 8879d93aad Issue 12266: APISuggestions should now work 2022-11-26 02:08:34 +00:00
Hypolite Petovan 29ee2473d7
Merge pull request #12269 from annando/api-edit
Issue 12192: API: Enable edit
2022-11-25 19:22:27 -05:00
Philipp c2c563be26
Merge pull request #12249 from MrPetovan/bug/deprecated
Address several PHP 8.1 deprecation notices
2022-11-25 23:32:32 +01:00
Philipp 4291e0def5
Merge pull request #12246 from MrPetovan/bug/notices
Ensure the existence of various keys in decoded data in Diaspora::decodeRaw
2022-11-25 23:30:56 +01:00
Michael 92807d86a3 API: Enable edit 2022-11-25 19:35:40 +00:00
Hypolite Petovan 55640eec87 [Composer] Upgrade to phpseclib version 3
- Create custom Key file format for Salmon Magic key
- Remove obsolete pemToME and MEtoPem Crypto methods
- Remove unused newECKeypair Crypto method
- Switch to constant-time Base64 encode/decode in Base64Url Strings methods
2022-11-25 08:13:05 -05:00
Hypolite Petovan a3fb499735 Replace call to parse_url() with Uri instanciation in Util\Proxy
- Address part of https://github.com/friendica/friendica/issues/12011#issuecomment-1321796513
2022-11-25 08:13:05 -05:00
Hypolite Petovan 0ec7238da4 Fix null value passed to string functions deprecation notices
- Address part of https://github.com/friendica/friendica/issues/12011#issuecomment-1321796513
2022-11-25 08:13:05 -05:00
Hypolite Petovan 6b555f64da Add \ReturnTypeWillChange attribute to methods inherited from native interfaces
- Part of https://github.com/friendica/friendica/issues/12011#issuecomment-1321796513
2022-11-25 08:13:05 -05:00
Hypolite Petovan 01558d6dda
Merge pull request #12264 from annando/error
Fix "Argument #1 ($parts) must be of type array, bool given"
2022-11-25 08:05:10 -05:00
Michael fa5e7585a3 Fix "Argument #1 ($parts) must be of type array, bool given" 2022-11-25 06:08:56 +00:00
Hypolite Petovan 9de6350154 Reorder search to try redirecting to post first
- Pleroma's post page includes the author's feed which wrongly gets picked up as a contact
- Address https://libranet.de/display/0b6b25a8-1563-7ec0-7408-70b986546395
2022-11-24 22:21:51 -05:00
Marek Bachmann 18f0d3d31e removed double blank 2022-11-25 01:03:34 +01:00
Marek Bachmann f4e2c7a11d corrected typos in DocBlocks 2022-11-25 00:59:24 +01:00
Hypolite Petovan 313f3d8515
Merge pull request #12255 from annando/invalid-unfollow
Silently quit on unfollow of invalid contacts
2022-11-24 14:46:59 -05:00
Michael 53b46855ef return "null" 2022-11-24 19:45:45 +00:00
Michael c88125348f Issue 12189: Quote share a feed now shares the linked feed url 2022-11-24 06:36:08 +00:00
Michael 6a434588a9 Silently quit on unfollow of invalid contacts 2022-11-24 05:17:14 +00:00
Michael a6ff817f47 Update added 2022-11-23 21:47:47 +00:00
Michael 0bd0046b9f Merge remote-tracking branch 'upstream/develop' into remote-self 2022-11-23 21:11:09 +00:00
Michael 8bbf3f3699 "MIRROR_FORWARDED" is no more 2022-11-23 21:10:57 +00:00
Marek Bachmann 32aa8bd198 Added information that max image upload size on admin page does not affect server-side upload limits 2022-11-23 18:17:33 +01:00
Hypolite Petovan d2ea58428d Ensure the existence of various keys in decoded data in Diaspora::decodeRaw
- Address https://github.com/friendica/friendica/issues/11994#issuecomment-1302681295
2022-11-23 11:22:54 -05:00
Hypolite Petovan 14ebc4a821 Ensure $owner is set in ActivityPub\Transmitter::sendContactReject
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1289535020
2022-11-23 11:05:36 -05:00
Hypolite Petovan 7c6d54c989 Ensure $attachment has a width and a height when it's an image in Mastodon\Attachment
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1323274513
2022-11-23 11:00:15 -05:00
Hypolite Petovan a5af1408d6 Ward against the possible case that $actor is empty in ActivityPub\Processor::createItem
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1323273452
2022-11-23 10:47:51 -05:00
Hypolite Petovan a8eabae12f Ensure $owner is set in ActivityPub\Transmitter::sendActivity
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1322704863
2022-11-23 10:40:41 -05:00
Hypolite Petovan 8e67d28997 Return early if user contact doesn't exist in Mastodon\Notification::getType
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1321804594
2022-11-23 10:35:49 -05:00
Michael 7b563fd307 Tempory fix removed 2022-11-23 14:17:39 +00:00
Michael 352b7a0ac3 "MIRROR_FORWARDED" is removed 2022-11-23 14:00:34 +00:00
Michael 25992b063a Merge remote-tracking branch 'upstream/develop' into no-api-post 2022-11-23 06:28:24 +00:00
Michael f600f68907 No more automated posts via mod/item.php 2022-11-23 06:27:40 +00:00
Hank Grabowski 733509561a Update Notify->iid to itemId for notification endpoint 2022-11-21 23:40:15 -05:00
Hank Grabowski 548fd3201d The two endpoints for unfavoriting/liking (and related things) was failing because it wasn't using the correct uuid in item.php in processing the action. 2022-11-21 16:49:20 -05:00
Hypolite Petovan 77e87da441 Create /profile/{nickname}/photos route
- Create new Profile\Photos\Index module class
- Update most references of the legacy /photos/{nickname} route
2022-11-20 17:15:07 -05:00
Hypolite Petovan 6dcc964ed8 Fix string interpolation in Model\Photo::upload 2022-11-20 17:07:08 -05:00
Hypolite Petovan d4bb5223a4 Use guid from shared post in Protocol\Diaspora::getReshareDetails
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1321194769
2022-11-20 13:01:37 -05:00
Tobias Diekershoff eec48057dc
Merge pull request #12221 from MrPetovan/bug/warnings
Fix various PHP 8 deprecations
2022-11-20 08:21:06 +01:00
Tobias Diekershoff 70ea419fcc
Merge pull request #12218 from MrPetovan/bug/frion-search-items
[frio] Improve search list display for web and mobile
2022-11-20 08:14:42 +01:00
Tobias Diekershoff d1a85f1fa4
Merge pull request #12222 from MrPetovan/bug/12219-hovercard-stay-local
Fix support for `/contact/123456/conversations` URLs in Module\Contact\Hovercard
2022-11-20 08:10:42 +01:00
Hypolite Petovan 5f074bc4e7 Add support for Mastodon /authorize_interaction route
- It is used by Fedifind to follow people who set their Webfinger address in their Twitter bio
2022-11-19 19:55:01 -05:00
Hypolite Petovan 83c04ac433 Fix support for /contact/123456/conversations URLs in Module\Contact\Hovercard 2022-11-19 19:41:45 -05:00
Hypolite Petovan 99df11e99b Fix PHP 8 inheritance deprecation warnings in App\PAge and ParsedLogIterator 2022-11-19 19:30:48 -05:00
Hypolite Petovan 6f93ee7e49 Fix various PHP 8 deprecations 2022-11-19 19:15:47 -05:00
Hypolite Petovan a147038c2e Ensure IEMail::getMessage returns a string 2022-11-19 19:15:47 -05:00
Hypolite Petovan 2a4985cd46 Fix database connection with sockets
- Reformat Database\Database.php file
- Reformat and fix spelling in static/defaults.config.php file
2022-11-19 19:15:43 -05:00
Hypolite Petovan 24804eb042 Hide non-functional mass deletion feature in search view 2022-11-19 17:16:01 -05:00
Philipp 5a2a8db21f
Merge pull request #12208 from MrPetovan/bug/12059-display-not-found
Improve error message when conversation isn't available in Module\Item\Display
2022-11-19 19:59:40 +01:00
Philipp 643d18b108
Merge pull request #12215 from MrPetovan/bug/hovercard-url
Fix support for `/contact/redir` URLs in Module\Contact\Hovercard
2022-11-19 19:53:38 +01:00
Hypolite Petovan a91944af24 Fix constructor compatibility with BaseSettings parent class
- Address https://paste.metaversum.wtf/?fc75de3f8eba6e7d#813SFjJwWWaJERQyrEpGAVnL33xZpTRV4MZeKmzsAvK8
2022-11-19 13:33:05 -05:00
Hypolite Petovan 525eab395c Improve error message when conversation isn't available in Module\Item\Display
- Retrieve the parent post no matter what. Previously it was depending on the user's settings, which gave unpredictable behavior if the parent post wasn't retrieved for whatever reason.
- List possible reasons the conversation isn't showing up based on the condition in Model\Post::selectViewForUser
- Allow HTML in exception messages
2022-11-19 12:29:08 -05:00
Hypolite Petovan de5097b772 Fix support for /contact/redir URLs in Module\Contact\Hovercard
- The feature was broken after the Redir route was moved
2022-11-19 12:28:54 -05:00
Thorsten 90567772bd Prevent division by zero. 2022-11-19 18:16:41 +01:00
Hypolite Petovan 3d5b81e4ef
Merge pull request #12213 from Schnoop/bugfix/NodeInfo
Fix that users property should be an object instead of array.
2022-11-19 11:59:33 -05:00
Thorsten 877369d964 Fix that user property should be an object instead of array. 2022-11-19 16:48:07 +01:00
Hypolite Petovan 6460218c0e Ensure register records aren't created with uid = 0
- uid = 0 matches system account and public contact records, giving unexpected display in pending user list. More importantly, the originally created user can't be approved since its user id is lost.
2022-11-18 16:04:02 -05:00
Thorsten 2edbd1a3e2 Reverted some changes that won't work with PHP7.3 2022-11-18 19:41:56 +01:00
Thorsten 7a39be8270 DDEV and some PHP8.1 fixes. 2022-11-18 12:03:55 +01:00
Thorsten 8a71bdc1a0 Add meta tag to attachment to show images in mastodon app. 2022-11-18 09:38:02 +01:00
Hypolite Petovan e354f48765
Merge pull request #12200 from annando/ignore-view
"View" activities are now ignored
2022-11-17 15:28:34 -05:00
Michael cdbfa34066 "View" activities are now ignored 2022-11-17 20:01:32 +00:00
Hypolite Petovan 293f147867
Merge pull request #12186 from nupplaphil/mod/editpost
Move mod/editpost.php to src\Module\Post\Edit
2022-11-16 16:14:07 -05:00
Philipp Holzer 81b21c4131
Revert "Remove geotag"
This reverts commit 5dc9319b
2022-11-16 21:20:24 +01:00
Philipp Holzer 9621279572
Make PHP-CS happy ... 2022-11-16 10:49:12 +01:00
Philipp Holzer 12fb897f54
Adhere PHP-CS 2022-11-16 08:56:37 +01:00
Philipp Holzer e7fd4a4cd1
Remove legacy comments 2022-11-16 08:56:19 +01:00
Philipp Holzer 5dc9319bb2
Remove geotag 2022-11-16 08:50:57 +01:00
Philipp Holzer db7af4c45b
Remove jotnets 2022-11-16 08:49:48 +01:00
Michael ec92f7a81c Fix memory issue on displaying conversations 2022-11-16 04:57:46 +00:00
Philipp Holzer 09e01b9356
Replace $_SESSION 2022-11-15 22:52:23 +01:00
Philipp Holzer 00883c9dcb
Move mod/editpost.php to src\Module\Post\Edit 2022-11-15 22:32:46 +01:00
Philipp 53f3454874
Merge pull request #12184 from annando/duplicated-media
This fixes duplicated media in quoted posts
2022-11-15 21:17:19 +01:00
Hypolite Petovan 403b025b5d
Merge pull request #12179 from nupplaphil/mod/display
Move mod/(update_)display.php to src\Module
2022-11-15 15:14:17 -05:00
Michael 348156dbcf Simplify the check 2022-11-15 19:55:03 +00:00
Michael eca52627c1 This fixes duplicated media in quoted posts 2022-11-15 19:48:43 +00:00
Philipp Holzer 59c97234f8
PHP-CS and license .. 2022-11-15 20:15:25 +01:00
Philipp Holzer 584e7a7e6d
Remove trailing slash in update_ calls 2022-11-15 20:11:38 +01:00
Philipp Holzer eff7740a67
Address feedback 2022-11-15 19:53:53 +01:00
Hypolite Petovan 3a7586e3f7 Fix wrong user table field name in Repository\Notify
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1314954594
2022-11-15 09:03:43 -05:00
Philipp Holzer ba0b83b0b0
Make PHP-CS happy 2022-11-15 01:10:49 +01:00
Philipp Holzer 3259bd17dc
Move mod/(update_)display.php to src\Module 2022-11-15 00:57:47 +01:00
Philipp Holzer 5c05a3b0f6
Move mod/display.php "feed-item" to a src\Module\Item\Feed.php 2022-11-15 00:52:58 +01:00
Hypolite Petovan fe547b7851 Centralize config.admin_email management in Model\User 2022-11-14 17:02:42 -05:00
Hypolite Petovan cbe8d463b1 Don't create notify for deleted user accounts 2022-11-14 17:02:42 -05:00
Hypolite Petovan 48b1dceb19 Don't send item notifications to deleted user accounts 2022-11-14 17:02:42 -05:00
Hypolite Petovan 6df187478d Fixed wrong reference to user.expire in Model\User::getActorName
- Update field documentation to prevent further confusion
2022-11-14 17:02:41 -05:00
Hypolite Petovan 10e48a34f2 Ensure Post::toArray returns an array
- We don't handle query errors anyway
- Remove unused parameter do_close
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1314245581
2022-11-14 14:53:54 -05:00
Hypolite Petovan cb0fde5d7d Create new OStatus\Subscribe module class
- Move route from /ostatus_subscribe to /ostatus/subscribe
2022-11-14 13:48:47 -05:00
Hypolite Petovan eb6b03b555 Add new OStatus\PortableContacts module class
- Retain existing route /poco for backward compatibility
- Remove unsupported links to /poco/{nickname} route
2022-11-14 13:48:46 -05:00
Hypolite Petovan a1a0b6512c Create new OStatus\PubSub module class
- Retain previous route /pubsub for backward compatibility
2022-11-14 13:48:46 -05:00
Hypolite Petovan a8759a9b86 Create new OStatus\PubSubHubBub module class
- Retaining the same /pubsubhubbub route to keep backward compatibility
2022-11-14 13:48:45 -05:00
Hypolite Petovan 63fc315ea0 Add support for Mastodon /reports API call 2022-11-14 12:22:54 -05:00
Hypolite Petovan 17a3a48210 Add new Moderation\Report domain classes 2022-11-14 12:22:52 -05:00
Michael 9506bf6989 Avoid duplicate media elements 2022-11-13 23:38:48 +00:00
Hypolite Petovan 4dc96daeb3 mail() requires additional headers to be separated by CRLF
- Rewrite Email->getAdditionalMailHeaderString to have only one string concatenation statement
2022-11-13 02:28:06 -05:00
Hypolite Petovan eedde86a37 Remove superfluous property declaration in Settings\UserExport
- Address https://github.com/friendica/friendica/issues/11992#issuecomment-1312417007
2022-11-12 08:37:42 -05:00
Michael 5b70df63de Avoid link parsing problems in front of "share" elements 2022-11-12 11:20:26 +00:00
Hypolite Petovan 863977da66 Fix constructor parameters in Module\Settings\RemoveMe
- Address https://github.com/friendica/friendica/issues/11992#issuecomment-1311162326
2022-11-10 22:36:54 -05:00
Hypolite Petovan 256c8ab170 Remove RTL Override character from display names to show in notifications
- It was causing the notification message to be unreadable
2022-11-10 10:42:21 -05:00
Hypolite Petovan 71ab9e13f2 Flatten arbitrary contact structure in constructor of FormattedNavNotification 2022-11-10 10:41:02 -05:00
Philipp Holzer 477bec1977
Fix some PHP8.1 issues if possible 2022-11-09 23:58:23 +01:00
Philipp Holzer 6d7cfc8450
whops .. wrong legacy endpoint 2022-11-09 22:39:36 +01:00
Philipp Holzer 815d8975e6
Rename Match to MatchInterests because PHP8-lint rejects "match" 2022-11-09 22:36:02 +01:00
Philipp Holzer 7c66073e4b
Add license 2022-11-09 22:29:43 +01:00
Philipp Holzer 82c631eae3
Fix Guzzle InvalidArgumentException for POST with array parameters 2022-11-09 22:25:37 +01:00
Philipp Holzer 75360f3b8c
Move mod/mod/msearch & mod/match to src/Module 2022-11-09 22:17:50 +01:00
Hypolite Petovan e6ada08e1b Delete mod/settings.php and its reference 2022-11-09 06:26:08 -05:00
Hypolite Petovan 5916544bc8 Move settings/features to src/Module 2022-11-09 06:26:08 -05:00
Hypolite Petovan 45c4439119 Move settings/connectors to src/Module 2022-11-09 06:26:05 -05:00
Hypolite Petovan 33d1df3c6d Move settings/addons to src/Module 2022-11-09 06:25:41 -05:00
Hypolite Petovan 3226b00995 Move settings/oauth to src/Module
- Add settings_content() permission checks to Module\BaseSettings
- Transform application token deletion GET links to POST forms to keep a single OAuth module class
2022-11-09 06:25:22 -05:00
Michael d3bbed176f Merge remote-tracking branch 'upstream/develop' into warning 2022-11-09 07:35:31 +00:00
Michael e9393fb509 Fix warning when loading invalid html 2022-11-09 06:38:31 +00:00
Michael a7e576fda0 Fix warning: Undefined array key "public" 2022-11-09 06:31:05 +00:00
Hypolite Petovan 4a626ef101 Create new Contact\Redir module class
- Move /redir route to /contact/redir
2022-11-08 20:12:23 -05:00
Hypolite Petovan 386c08aa05 Remove superfluous calls to DI::baseUrl in Contact:photoMenu 2022-11-08 19:31:09 -05:00
Hypolite Petovan a68c790c64 Create new Settings\RemoveMe module class
- Moved route from /removeme to /settings/removeme
- Combined templates into one
2022-11-08 18:33:54 -05:00
Michael df8644c59c Performance improvements in public timeline 2022-11-08 21:48:42 +00:00
Hypolite Petovan 99d54dc711 Restore Item\Source module functionality 2022-11-08 11:53:09 -05:00
Michael 246021fdfa Store the source of incoming posts 2022-11-08 11:53:09 -05:00
Tobias Diekershoff 48090d1b70
Merge pull request #12142 from MrPetovan/task/homepage-verified
Add title to homepage verified check mark
2022-11-08 11:12:17 +01:00
Hypolite Petovan 0a20566199 Replace remaining occurrences of admin/users route by moderation/users 2022-11-08 04:26:11 -05:00
Hypolite Petovan 561f22cdc4 Add title to homepage verified check mark
- Decrease log level for not found Memcached keys
2022-11-08 04:20:19 -05:00
Hypolite Petovan 18f54f4425 New area "moderation"
- Moved several admin pages to the moderation area
- ACL still is checking for administrator credentials
2022-11-08 02:28:42 -05:00
Hypolite Petovan c7dbe0b610 Create new OStatus\Repair module class
- Create corresponding template file
2022-11-07 21:44:18 -05:00
Michael 664071a0b1 Quoted reshares containing quoted reshares should now look fine 2022-11-07 20:44:20 -05:00
Philipp Holzer bb97776dfb
The last PHPCS error .. 2022-11-07 20:35:07 +01:00
Philipp Holzer d524f55e3e
Reduce error-throws :-) 2022-11-07 20:34:05 +01:00
Philipp Holzer a81708091f
Make PHPCS happy 2022-11-07 20:32:55 +01:00
Philipp Holzer 2da2ac6826
make PHP CS happy? 2022-11-07 20:28:08 +01:00
Philipp Holzer 78a8ed6fe7
adhere feedback 2022-11-07 20:21:11 +01:00
Philipp Holzer f13c91b320
Move mod/cal.php and mod/events.php to Module 2022-11-07 19:52:24 +01:00
Philipp Holzer 89fde911f9
Fix possible security issue 2022-11-07 19:52:13 +01:00
Roland Häder 3bdc20df15
Changed:
- added type-hints as follow-up commit to #12130
2022-11-07 19:18:34 +01:00
Michael Vogel e6a5c172ce
Merge pull request #12131 from MrPetovan/task/4090-move-mod-salmon
Move mod/salmon.php to src/Module
2022-11-07 14:55:02 +01:00
Hypolite Petovan 7c7fc624f3
Fix code standards in Module\OStatus\Salmon 2022-11-07 07:54:12 -05:00
Tobias Diekershoff 44af6e4bc2 don't be pythonic 2022-11-07 11:19:33 +01:00
Tobias Diekershoff 379eeb49eb make the standards check happy 2022-11-07 11:19:33 +01:00
Tobias Diekershoff cdfd51310e we don't need the 20... 2022-11-07 11:19:33 +01:00
Tobias Diekershoff 594c17546b the config default parameter was deprecated 2022-11-07 11:19:33 +01:00
Tobias Diekershoff a9265220af add labels for the logger parameters 2022-11-07 11:19:33 +01:00
Tobias Diekershoff 33c9d17bdb change the cURL success check and adopt the logger messages 2022-11-07 11:19:33 +01:00
Tobias Diekershoff fb04eb107b set the validation to false, and only set it to true if we were able to verify the link 2022-11-07 11:19:33 +01:00
Tobias Diekershoff 64f290a055 avoide useless cURL request to the profile page 2022-11-07 11:19:33 +01:00
Tobias Diekershoff dd0811aec9 remove debugging tracers 2022-11-07 11:19:33 +01:00
Tobias Diekershoff 5530b6fc75 reviews 2022-11-07 11:19:33 +01:00
Tobias Diekershoff 1c65098013 clean up the used modules 2022-11-07 11:19:33 +01:00
Tobias Diekershoff a1d57abfe4 add the new CheckRelMeProfileLink class to the worker 2022-11-07 11:15:55 +01:00
Tobias Diekershoff 028d823d96 add a help text to the profile settings indicating how to verify the homepage, or that the homepage is verified 2022-11-07 11:15:55 +01:00
Tobias Diekershoff c8636db9f6 When the profile is updated, let the Worker verify the homepage link 2022-11-07 11:15:55 +01:00
Tobias Diekershoff 30b9a57a37 Let the Worker check the homepage of a profile daily 2022-11-07 11:15:54 +01:00
Hypolite Petovan ec02664773 Add new OStatus\Salmon module class
- Add module instanciation in Module\DFRN\Notify
2022-11-06 20:42:05 -05:00
Hypolite Petovan bd9292fe19 Convert static methods to dynamic in Module\DFRN\Notify 2022-11-06 20:38:33 -05:00
Hypolite Petovan d5b29b1c61 Add follow/unfollow link to the contact actions menu 2022-11-06 19:03:21 -05:00
Michael 210200d330 Use different parser modes for Mastodon and Twitter-API 2022-11-06 20:02:43 +00:00
Michael 1d7d8788bd Support "fedifinder" to import contacts 2022-11-06 10:05:54 +00:00
Tobias Diekershoff e582cd4543
Merge pull request #12125 from annando/pending
Don't show following/followed_by on pending
2022-11-06 10:26:11 +01:00
Michael e10d714ef5 Don't show following/followed_by on pending 2022-11-06 08:18:28 +00:00
Tobias Diekershoff 4b5c6994b2
Merge pull request #12122 from annando/issue-2657
Issue 2657: Mentions will now be recognized by clients
2022-11-06 09:13:45 +01:00
Tobias Diekershoff 174151d4d0
Merge pull request #12124 from annando/issue-11832
Issue 11832: Avoid error when fetching group members
2022-11-06 09:12:22 +01:00
Tobias Diekershoff d0318b3df6
Merge pull request #12123 from annando/issue-11831
Issue 11831: Activate "notify on new post" via API
2022-11-06 09:10:34 +01:00
Michael b202354bbb Merge remote-tracking branch 'upstream/develop' into issue-2657 2022-11-06 07:08:55 +00:00
Michael fe3713b8f3 Merge remote-tracking branch 'upstream/develop' into issue-11832 2022-11-06 07:07:32 +00:00
Michael f1f40fbbf7 Merge remote-tracking branch 'upstream/develop' into issue-11831 2022-11-06 07:04:35 +00:00
Michael 92813dd2e4 Issue 11832: Avoid error when fetching group members 2022-11-06 06:42:33 +00:00
Michael bc7d21183d Issue 11831: Activate "notify on new post" via API 2022-11-06 06:11:22 +00:00
Michael 40fb820aef Unused use removed 2022-11-06 06:00:19 +00:00
Michael 56ac879c92 Issue 2657: Mentions will now be recognized by clients 2022-11-06 05:43:34 +00:00
Hypolite Petovan 3e33ec0c0f Suppress InvalidArgument exceptions handling URLs in Model\Item::containsLink 2022-11-05 20:18:14 -04:00
Michael Vogel ea49ab6e04
Merge pull request #12114 from MrPetovan/bug/12112-unFollow
Fix capitalization of unfollow links in Model\Contact
2022-11-06 00:21:27 +01:00
Hypolite Petovan b9f0985467
Merge pull request #12116 from annando/issue-11846
Issue 11846: Fix client behaviour when following hash tags
2022-11-05 19:13:31 -04:00
Michael Vogel 52f74b6312
Update src/Object/Api/Mastodon/Status.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2022-11-05 23:51:16 +01:00
Michael 9fa3df3cbf "arrat" to "array" 2022-11-05 22:39:15 +00:00
Michael aa2b4e15a3 Issue 11846: Fix client behaviour when following hash tags 2022-11-05 22:35:35 +00:00
Michael db12814f3b Improved url detection 2022-11-05 22:32:56 +00:00
Michael 70d0f087b7 Issue 12096: Improve account search 2022-11-05 22:08:28 +00:00
Hypolite Petovan e763f57d29 Fix capitalization of unfollow links in Model\Contact 2022-11-05 17:54:50 -04:00
Michael 4dd2d7ebab Transmit the quoted part in the source 2022-11-05 16:25:04 +00:00
Hypolite Petovan 198d38545d
Remove trailing spaces from Module\Post\Share 2022-11-04 14:14:00 -04:00
Hypolite Petovan 8124dedbf6 Create new Post/Share module class 2022-11-04 13:02:01 -04:00
Philipp 119f9d9d27
Merge pull request #12094 from MrPetovan/task/hide-reply-counts-ping
Remove non-top-level posts from notification labels when network sort order is "received"
2022-11-04 18:00:15 +01:00
Hypolite Petovan 8ec5d10bf4 Add new Contact/Suggestions module class 2022-11-04 07:57:00 -04:00
Hypolite Petovan 811e144e9e Move viewcontact_template and contact_template to contact/ folder 2022-11-04 07:03:55 -04:00
Hypolite Petovan 6c745c8522 Remove non-top-level posts from notification labels when network sort order is "received"
- These posts don't alter the network view in this sort order and so are distracting with no actionable benefits
2022-11-04 06:42:38 -04:00
Hypolite Petovan 8092bfe277 Remove dependency on DI in Notifications\Ping module 2022-11-04 06:42:38 -04:00
Hypolite Petovan 23dda5d510 Deprecate default value parameters in Session and Config interfaces
- It is more efficient to use the null coalescing operator ?? that prevents the computation of the default value if the key has been found
2022-11-04 06:42:38 -04:00
Hypolite Petovan da3041a4d4 Add new Conversation\Network::getTimelineOrderBySession method 2022-11-04 06:42:37 -04:00
Hypolite Petovan fa123bd765 Rename Repository\Notify->NotifyOnDesktop to shouldShowOnDesktop
- New name better reflect the behavior
2022-11-04 06:42:37 -04:00
Hypolite Petovan 1ba9a65fd8 Add new Post/Tag/Add module class
- Convert GET to POST
2022-11-03 22:26:48 -04:00
Michael a89f235044 Merge remote-tracking branch 'upstream/develop' into issue-12097 2022-11-03 20:15:53 +00:00
Michael Vogel a20c6e3216
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2022-11-03 21:13:03 +01:00
Michael 0f9e2b6da4 Issue 12097: Notify for each new user registration 2022-11-03 19:59:33 +00:00
Hypolite Petovan 78d063f35a
Merge pull request #12095 from annando/bulk
Improved bulk delivery / don't redistribute activities
2022-11-03 07:59:44 -04:00
Michael 12a352f441 Simplified else case 2022-11-03 04:27:30 +00:00
Hypolite Petovan e0dc7a471e Create Post/Tag/Remove module class and route
- Fix tag name parameter in single tag removal link in mod/photos
- Remove "/post" from backend routes as it was preventing sessions from working in this module. No existing module had a route starting with "/post".
2022-11-03 00:27:08 -04:00
Michael 1847347c3a Improved logging 2022-11-03 04:23:04 +00:00
Michael 842e51194e Improved bulk delivery / don't redistribute activities 2022-11-03 04:03:39 +00:00
Hypolite Petovan 4ab260042c Create new User\Import module class
- Merge Core\UserImport class in Module class
2022-11-02 11:27:31 -04:00
Philipp Holzer 7c4a7bff2e
Move new events routes to calendar routes 2022-11-02 15:16:24 +01:00
Philipp Holzer 2c90ab69d6
Move event export to src/Module/Events/Export 2022-11-02 15:16:23 +01:00
Hypolite Petovan 2c7a60eb0e Replace remaining "follow" route instances to "contact/follow" 2022-11-01 09:41:39 -04:00
Hypolite Petovan 2cf1e1074b Fix documentation typo in src/Protocol/Diaspora.php 2022-11-01 08:45:25 -04:00
Michael 1f1c2d8ca6 (Hopefully) query performance improvements 2022-11-01 08:45:25 -04:00
Hypolite Petovan 5ef76e8f14 Also look for Atom feeds when probing link URLs 2022-11-01 00:45:46 -04:00
Philipp Holzer baa97febef
hopefully last feedback :) 2022-11-01 00:09:30 +01:00
Philipp Holzer 41565326e3
Make CS happy 2022-10-31 21:03:58 +01:00
Philipp Holzer 8f62278703
Rename $action because of PR before 2022-10-31 21:00:23 +01:00
Philipp Holzer 82cd6ff91d
Fixing the non-auto follow process ... 2022-10-31 20:58:37 +01:00
Philipp Holzer eb9da2967e
Fixups ... hopefully the last one :-/ 2022-10-31 20:58:37 +01:00
Philipp Holzer 87291e30a4
Found some more follow-links 2022-10-31 20:58:34 +01:00
Philipp Holzer b5d01337d9
Move Follow to /contact namespace 2022-10-31 20:58:27 +01:00
Philipp Holzer 3554894577
Fixup post 2022-10-31 20:56:44 +01:00
Philipp Holzer 437472d0a6
Move Follow to Contact namespace 2022-10-31 20:56:43 +01:00
Philipp Holzer 0e47d5b0aa
make CS happy 2022-10-31 20:56:43 +01:00
Philipp Holzer 8e6f676719
Move mod/follow to src/Modules 2022-10-31 20:56:41 +01:00
Hypolite Petovan 58d6e7e2bb Create Contact\Unfollow module class 2022-10-31 15:31:44 -04:00
Hypolite Petovan a1e6e13a9f Move remote follow module to profile folder 2022-10-31 15:31:43 -04:00
Hypolite Petovan 5de8fe3a48 Fix unfollowing not showing on contact page
- Deleted contact rows kept the relationship status which would keep showing
- Deleting contact rows would also not update the corresponding user-contact record
2022-10-31 15:30:23 -04:00
Hypolite Petovan 3020dfbeeb Rename auto_request.tpl form action template variable 2022-10-31 15:30:23 -04:00
Hypolite Petovan 969b4f991e Create Profile\Attachment\Upload module class
- Add missing response type in AjaxUpload initializition
2022-10-31 14:57:25 -04:00
Hypolite Petovan 39765e6018 Create Profile\Photos\Upload class 2022-10-30 14:20:01 -04:00
Hypolite Petovan 9561910e83 Create Profile\UnkMail module class 2022-10-30 10:49:47 -04:00
Hypolite Petovan 3865733e18 Move Model\Profile::getMyUrl to UserSessions 2022-10-30 10:49:47 -04:00
Michael eae1383f48 Merge remote-tracking branch 'upstream/develop' into quote 2022-10-30 11:38:17 +00:00
Michael b402a760a8 Symplified code 2022-10-30 10:02:12 +00:00
Michael a183723254 Improved handling of contact links 2022-10-30 10:02:01 +00:00
Michael 96a36568e2 Add quote to API 2022-10-30 01:20:05 +00:00
Michael f569ccbbc2 Code is simplyfied 2022-10-29 22:55:39 +00:00
Michael 3c169b534e Improved handling of native quotes 2022-10-29 22:11:39 +00:00
Hypolite Petovan e24078a4d2
Merge pull request #12074 from annando/fix-notification
Accepting contact request does finally work per Mastodon API
2022-10-29 15:55:40 -04:00
Michael 8bba8663fb Only fetch the needed field 2022-10-29 19:11:26 +00:00
Michael f44c9e7975 Accepting contact request does finally work per Mastodon API 2022-10-29 19:04:29 +00:00
Hypolite Petovan a2adb1cd93
Remove unused argument from L10n->tt() call in Model/Item.php 2022-10-28 13:45:09 -04:00
René Wagner b99e7a9e92
fix exception when adding an poll option without votes 2022-10-28 18:51:35 +02:00
Hypolite Petovan f418687a71
Merge pull request #12070 from annando/share
Some more improvements for posts with shares
2022-10-27 08:19:23 -04:00
Michael deccea0228 More functions moved to content class 2022-10-27 05:44:44 +00:00
Michael c65fff6f93 Some more improvements for posts with shares 2022-10-26 17:00:55 +00:00
Hypolite Petovan 0c4ebce391
Merge pull request #12067 from Quix0r/cleanup/type-hints-002
Cleanup: missing type-hints, double-quotes, reformatted array
2022-10-26 12:03:04 -04:00
Roland Häder 498d7f690a
Changes:
- php-cs is now happy with it
2022-10-26 17:59:10 +02:00
Roland Häder 03e09627e4
Used $this->isThreaded() instead as suggested by @MrPetovan 2022-10-26 17:59:07 +02:00
Roland Häder 3c50d5b70f
Changes:
- made code more readable
2022-10-26 01:31:34 +02:00
Roland Häder 2f1336339f
Changes:
- added missing type-hints
- added missing documentation
- changed double-quotes to single
- Setters do ALWAYS return void
2022-10-26 01:29:01 +02:00
Hypolite Petovan 22bfd3b4d6 Revert "Add email notification to all users on server domain pattern block list update"
This reverts commit 5045f9e188 because the main stakeholder isn't using the feature and it's putting a strain on email server accountability vis-a-vis spam lists.

# Conflicts:
#	src/Moderation/DomainPatternBlocklist.php
2022-10-25 19:02:55 -04:00
Roland Häder 5306bb3e31
Changes:
- added more missing type-hints (checked them in body of the method)
- reformatted code a little (code-style)
- moved '/.well-known/host-meta' to constant Probe::HOST_META
2022-10-25 20:25:13 +02:00
Hypolite Petovan a7e9457ef2
Merge pull request #12061 from annando/share-rework
The "share" handling is improved
2022-10-25 09:04:16 -04:00
Michael 842a4bb904 Changed function name 2022-10-25 12:40:22 +00:00
Hypolite Petovan 2555596158
Merge pull request #12055 from nupplaphil/feat/usersess_decorator
Extend `IHandleUserSessions` from `IHandleSessions` and adapt classes
2022-10-25 07:52:23 -04:00
Michael ebd175872d Improved description 2022-10-25 08:45:41 +00:00
Michael 1a0b63659b Merge remote-tracking branch 'upstream/develop' into share-rework 2022-10-25 08:31:01 +00:00
Michael f54a886a5e The "share" handling is improved 2022-10-25 06:37:23 +00:00
Philipp Holzer f03c5c7f89
implement feeback 2022-10-25 08:07:42 +02:00
Hypolite Petovan dc2d96a502 Fix condition for follows export
- Select follows instead of followers
- Filter out archived contacts
2022-10-24 18:21:10 -04:00
Hypolite Petovan 142b399c84 Reformat Module\Settings\UserExport
- Import IHandleUserSessions and DbaDefinition object in constructor
- Convert remaining double quotes to single quotes
- Convert static methods to dynamic to use class properties
- Remove unused POST permission from route
2022-10-24 18:14:59 -04:00
Roland Häder bf9f09182e
Changes:
- added some missing type-hints
- no need for local array `$t` (changed to "anonymous" varriant)
- formatted some arrays
2022-10-24 20:32:24 +02:00
Philipp Holzer b5bc1b0844
Extend IHandleUserSessions from IHandleSessions and adapt classes 2022-10-23 20:41:17 +02:00
Tobias Diekershoff b72d727a06
Merge pull request #12051 from Quix0r/hotfix/one-dollar-to-much
Hotfix: One `$` to much ...
2022-10-23 16:25:46 +02:00
Roland Häder e8fe0c52e7
Hotfix: One $ to much ... 2022-10-23 13:15:34 +02:00
Philipp Holzer b4b9f426db
Fix missing/wrong IHandleUserSessions usages 2022-10-23 11:32:43 +02:00
Philipp Holzer a9963dc54b
Remove Core\Session 2022-10-21 19:36:42 +02:00
Philipp 7b3caca276
Update src/Content/Widget.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2022-10-21 19:35:34 +02:00
Philipp Holzer 44a9683008
Move "submanage" Session value into own methods 2022-10-21 19:35:34 +02:00
Philipp Holzer cafb23f8f0
Reduce parentheses 2022-10-21 19:35:34 +02:00
Philipp Holzer f15878195c
make App\Router easier 2022-10-21 19:35:34 +02:00
Philipp Holzer 7b35c570f9
Move DI dependency for App class 2022-10-21 19:35:33 +02:00
Philipp Holzer 134f98e22e
Move DI dependency for Navigation\Notifications\Factory\Introduction class 2022-10-21 19:35:33 +02:00
Philipp Holzer a1997d73c2
Move DI dependency for Navigation\Notifications\Factory\FormattedNotify class 2022-10-21 19:35:33 +02:00
Philipp Holzer f1cbb41a60
Move DI dependency for Navigation\Notifications\Factory\FormattedNavNotification class 2022-10-21 19:35:33 +02:00
Philipp Holzer d76a2b6ad6
Move DI dependency for Content\Item class 2022-10-21 19:35:32 +02:00
Philipp Holzer 37ff477b55
Move DI dependency for App\Conversation class 2022-10-21 19:35:32 +02:00
Philipp Holzer fa8a32e83c
Move DI dependency for App\Router class 2022-10-21 19:35:32 +02:00
Philipp Holzer f83784cc63
Move DI dependency for App\Page class 2022-10-21 19:35:32 +02:00
Philipp Holzer b3f9cef94a
UserSession class [3] - Refactor src/ files excluding Module/Model 2022-10-21 19:35:32 +02:00
Hypolite Petovan a11c125f81
Merge pull request #12042 from nupplaphil/feat/usersession_Module_DepInj
UserSession class [6] - Refactor src/Module/ files without DI
2022-10-21 13:21:48 -04:00
Philipp Holzer 8ad83e5d5c
Add missing DI 2022-10-21 19:16:25 +02:00
Philipp Holzer 22198ea495
UserSession class [6] - Refactor src/Module/ files without DI 2022-10-21 10:25:07 +02:00
Philipp Holzer bf39b5a948
Fix messages.po issue 2022-10-21 10:19:13 +02:00
Hypolite Petovan f609386ca1
Merge pull request #12041 from nupplaphil/feat/usersession_Module
UserSession class [5] - Refactor src/Module/ files with DI
2022-10-20 20:32:54 -04:00
Philipp Holzer eecc456e0c
UserSession class [5] - Refactor src/Module/ files with DI 2022-10-20 22:59:39 +02:00
Philipp Holzer b4ffb0bde0
UserSession class [4] - Refactor src/Model/ files 2022-10-20 22:14:50 +02:00
Philipp Holzer 0b66b6e0d5
Move Session "exists" and "expire" to new class 2022-10-20 20:27:35 +02:00
Philipp Holzer 940619325d
Add SessionUsers class including tests 2022-10-20 20:27:34 +02:00
Hypolite Petovan eaf1485c6f Fix using wrong variable in DomainPatterBlocklist::extractFromCSVFile
- This was clobbering the internal block list structure from an associative array to a simple list
2022-10-20 09:45:40 -04:00
Michael 4930737cc4 Legacy "include" fragments have been removed 2022-10-20 04:21:00 +00:00
Michael d3e167c77c All references to boot.php are now removed 2022-10-19 20:38:25 +00:00
Michael cfbba97e0a Fix Error: Uncaught Exception Error: "Class "Friendica\Content\Session" not found" 2022-10-19 19:16:01 +00:00
Michael d47d78f2d4 old boot.php functions replaced in src/module (4) 2022-10-19 09:23:12 -04:00
Hypolite Petovan 956f196f7c Align pConfig calls in Module\Settings\Display 2022-10-19 09:20:48 -04:00
Hypolite Petovan 979e226d27 Suppress repetitive "missing cache key ping:events:XX" when there are no upcoming events 2022-10-19 09:17:28 -04:00
Michael ae6d67ed1f old boot.php functions replaced in src/module (3) 2022-10-19 09:14:24 -04:00
Michael c9f17e1ef5 old boot.php functions replaced in src/module (2) 2022-10-19 09:06:09 -04:00
Hypolite Petovan 47d9f91009 Add missing use statements in modules classes 2022-10-19 09:02:53 -04:00
Michael d2da2492b7 old boot.php functions replaced in src/module 2022-10-19 08:53:45 -04:00
Hypolite Petovan 058abc0336
Simplify boolean statements in Content\Conversation 2022-10-19 08:05:31 -04:00
Michael ee1acba9eb old boot.php functions replaced in /src 2022-10-19 07:56:25 -04:00
Michael 11944dda32 old boot.php functions replaced in various places 2022-10-19 07:44:08 -04:00
Philipp Holzer 692566d93b
Fix ERROR IHandleSessions 2022-10-19 08:07:12 +02:00
Tobias Diekershoff d8fe8b1e8b
Merge pull request #12029 from annando/warning
Suppress warning on load check
2022-10-19 07:51:24 +02:00
Michael 196dda9487 Suppress warning on load check 2022-10-19 04:49:57 +00:00
Philipp Holzer 4a2f67aa9a
Move Core\Session::clear() to DI::session()->clear() 2022-10-18 21:13:58 +02:00
Philipp Holzer a2eb0c7378
Move Core\Session::remove() to DI::session()->remove() 2022-10-18 21:13:28 +02:00
Philipp Holzer 315ed3ed22
Remove unused Core\Session::setMultiple() 2022-10-18 21:12:48 +02:00
Philipp Holzer 3a8bcb3fbf
Move Core\Session::set() to DI::session()->set() 2022-10-18 21:12:23 +02:00
Philipp Holzer dfb5792773
Remove unused Core\Session::pop() method 2022-10-18 21:11:19 +02:00
Philipp Holzer fb2b2f5c58
Remove unused Core\Session::create() method 2022-10-18 21:11:00 +02:00
Philipp Holzer 7ac86e49d1
Move Core\Session::get() to DI::session()->get() 2022-10-18 21:10:37 +02:00
Michael ae82737445 Fix errors introduced by PR #11997 2022-10-18 18:32:20 +00:00
Roland Häder c36da392f8
Changed:
- re-added `null` again https://github.com/friendica/friendica/pull/11900#discussion_r979248182
- removed null coalescing operator
2022-10-18 18:21:45 +02:00
Roland Häder 2773ac9909
Changed according feedback:
- $posted_date should not allow NULL, instead use `?? ''` instead
- this happened in e.g. 2FA app-specific password listing
2022-10-18 17:47:15 +02:00
Roland Häder 66b9cace9f
Changed:
- first parameter can be null
2022-10-18 17:47:15 +02:00
Roland Häder 26e0469de7
Merge branch 'develop' into rewrite/gravity-constants 2022-10-18 16:34:40 +02:00
Michael 6f68679375 The EOL constant is removed 2022-10-18 12:29:50 +00:00
Hypolite Petovan abf52c0c11
Merge pull request #12012 from nupplaphil/feat/move_monolog
Move Monolog to Addons
2022-10-18 07:31:59 -04:00
Hypolite Petovan ab9b60b9d2
Merge pull request #12014 from annando/usertosession
The user related functions moved to the session class
2022-10-18 07:30:21 -04:00
Michael d43122c6d8 Check the readability before acessing /proc/loadavg 2022-10-18 08:02:55 +00:00
Michael 27e9f2b223 SIGTERM moved 2022-10-18 04:35:06 +00:00
Michael 33ac39c335 The user related functions moved to the session class 2022-10-17 21:11:00 +00:00
Philipp Holzer 497fc4e432
Move Monolog to Addons 2022-10-17 22:22:00 +02:00
Michael fdfa1f8630 The notice and info have been moved 2022-10-17 18:55:22 +00:00
Michael 20291ddc2b Merge remote-tracking branch 'upstream/develop' into notice 2022-10-17 13:32:10 +00:00
Michael e96fd5166a Fix wrong constant 2022-10-17 11:28:54 +00:00
Michael 4ff7c37f85 Replace "notice" calls 2022-10-17 11:27:32 +00:00
Michael 62a0d55fc8 The friendica constants have been moved to the app class 2022-10-17 10:37:48 +00:00
Michael 9bac8153ae Some more constants are moved to their specific classes 2022-10-17 09:24:32 +00:00
Michael 018858934b The priority is now a class constant 2022-10-17 05:49:55 +00:00
Michael 9ffa053c90 Merge remote-tracking branch 'upstream/develop' into linked-posts 2022-10-16 21:51:26 +00:00
Michael f8f0dfa91a Detect linked posts and add them as quote 2022-10-16 21:37:05 +00:00
Hypolite Petovan e556dc3c31 Add new frio.always_open_compose setting
- This setting allows the New Post button to always open the Compose page instead of the modal by default
2022-10-16 11:49:27 -04:00
Hypolite Petovan d826fe0a3b Refactor files related to the Compose page and frio theme settings
- Use dependencies instead of most DI calls in Module\Item\Compose
- Group translation strings in a subkey of the template variables array
- Rewrite array initializations in theme/frio/config
2022-10-16 11:48:28 -04:00
Michael 8e1af9277a Improve quite generation 2022-10-15 13:00:52 +00:00
Roland Häder ebf3b7e62d
Changes:
- Content\Item versus Model\Item solved (?)
2022-10-15 00:44:07 +02:00
Roland Häder 85ed0742cf
Fixed:
- Content\Item versus Model\Item is really confusing!
2022-10-15 00:44:07 +02:00
Roland Häder 8f92d1cc8e
Changes:
- unified class import, we had these both:

````
use Friendica\Model\Item as ModelItem;
use Friendica\Object\Post as PostObject;
````

In first version the namespace was prefixing class name, in second suffixing it.
2022-10-15 00:44:07 +02:00
Roland Häder da66730e4f
Rewrite:
- moved constants GRAVITY_* from boot.php to Friendica\Model\Item
- also rewrote some array initialization:

From:
````
<?php
$arr = [];
$arr['foo'] = "FOO";
````

To:
````
<?php
$arr['foo'] = "FOO";
````
- added a few type-hints
2022-10-15 00:44:06 +02:00
Michael 3e868416c7 Check for post existence 2022-10-14 22:02:25 +00:00
Michael 88aceeb27f Merge remote-tracking branch 'upstream/2022.09-rc' into quote-uri-id 2022-10-14 19:11:15 +00:00
Michael c2e57c5c0e Return the pageinfo when feed is shared 2022-10-14 04:43:46 +00:00
Michael da2afbeae3 Merge remote-tracking branch 'upstream/2022.09-rc' into quote-again 2022-10-12 05:36:00 +00:00
Michael e69b04d2df Only add the media for non federated posts 2022-10-12 05:34:55 +00:00
Hypolite Petovan 0480d9aebd Add missing post keys to retrieve pLink in Model\Event::prepareListForTemplate()
- Address https://github.com/friendica/friendica/issues/11632#issuecomment-1275117722
2022-10-11 22:18:52 -04:00
Michael 0e82f64d71 Only attach images 2022-10-11 21:39:28 +00:00
Michael f1f13db24f Simplified code 2022-10-11 20:48:47 +00:00
Michael 68d6e11d83 Fix attached media in quoted posts 2022-10-11 20:10:39 +00:00
Hypolite Petovan 9e74a1bd06 Contact array can be empty in Model\Contact::getAvatarPath
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1274195844
2022-10-11 08:26:00 -04:00
Michael a67a364b91 Merge remote-tracking branch 'upstream/2022.09-rc' into quote-uri-id 2022-10-11 05:19:21 +00:00
Michael 747139d186 Quoted posts from Twitter now contain media again 2022-10-10 23:18:58 +00:00
Michael aeb4645ba6 New field "quote-uri-id" for quoted posts 2022-10-10 22:39:30 +00:00
Michael 028de0e228 Quote of quotes are visually improved 2022-10-10 12:30:07 +00:00
Michael a21c04d55d Use "maxloadavg" when "worker_load_cooldown" is not defined 2022-10-10 06:01:07 +00:00
Hypolite Petovan a10f55bb85
Merge pull request #11979 from annando/issue-11853
Notices
2022-10-09 17:45:33 -04:00
Hypolite Petovan 424dad886f
Merge pull request #11978 from annando/quote-simplified
The quote functionality is simplified
2022-10-09 17:26:22 -04:00
Michael 0d3aa681b4 The quote functionality is simplified 2022-10-09 21:16:36 +00:00
Hypolite Petovan a4b0ebf160 Add a couple of cases to DateTimeFormat::fix()
- Reworked method to perform more string replacements and fewer regular expression matches
2022-10-09 09:34:38 -04:00
Hypolite Petovan bee6506d33 Only call DateTimeFormat::fix() when there's an Exception
- This prevents valid date/time strings to be mangled by fix()
2022-10-09 09:34:30 -04:00
Michael Vogel b5ad8c3e15
Merge pull request #11973 from MrPetovan/task/test-fixDateFormat
Add tests for DateTimeFormat::fix()
2022-10-08 17:11:10 +02:00
Michael 4552d36373 Issue 11975: Don't call the postupdate if the table is missing 2022-10-08 14:42:11 +00:00
Hypolite Petovan 47dd19ab95
Merge pull request #11974 from annando/issue-11969
Issue 11969: Simplified share
2022-10-08 10:04:07 -04:00
Michael 4a37c978c2 Issue 11969: Simplified share 2022-10-08 09:36:35 +00:00
Hypolite Petovan 345d307ae0 Add tests for DateTimeFormat::fix() 2022-10-07 23:10:50 -04:00
Hypolite Petovan c0447ced48 Simplify method name for DateTimeFormat::fix 2022-10-07 23:10:50 -04:00
Hypolite Petovan 2cbc11403e Fix parameter names before being passed to Model\Event::store
- Partial revert of 946db2ab45
2022-10-07 17:20:22 -04:00
Michael 1ddeaaad4a And another weird date format 2022-10-07 19:56:02 +00:00
Michael 33d48f7d55 Use trim 2022-10-07 08:14:04 +00:00
Michael f340fc6efa Harmonized regular expression 2022-10-07 08:00:09 +00:00
Michael 21bd2a8396 More whitespace 2022-10-07 07:57:20 +00:00
Michael f8d4ab1830 Whitespace removed 2022-10-07 07:55:44 +00:00
Michael ef934db614 Moved the share interpretation 2022-10-07 07:41:03 +00:00
Michael d7a9745ffd Simplified share element 2022-10-07 05:51:36 +00:00
Michael 48182a95fb Improve quote share ("message_id" added) 2022-10-06 21:50:20 +00:00