Merge pull request #5947 from annando/uri-id

Use "uri-id" for item relations
This commit is contained in:
Hypolite Petovan 2018-10-17 14:45:40 -04:00 committed by GitHub
commit e254ace9d5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 16 additions and 5 deletions

View File

@ -41,7 +41,7 @@ define('FRIENDICA_PLATFORM', 'Friendica');
define('FRIENDICA_CODENAME', 'The Tazmans Flax-lily'); define('FRIENDICA_CODENAME', 'The Tazmans Flax-lily');
define('FRIENDICA_VERSION', '2018.12-dev'); define('FRIENDICA_VERSION', '2018.12-dev');
define('DFRN_PROTOCOL_VERSION', '2.23'); define('DFRN_PROTOCOL_VERSION', '2.23');
define('DB_UPDATE_VERSION', 1287); define('DB_UPDATE_VERSION', 1288);
define('NEW_UPDATE_ROUTINE_VERSION', 1170); define('NEW_UPDATE_ROUTINE_VERSION', 1170);
/** /**

View File

@ -620,7 +620,8 @@
"indexes": { "indexes": {
"PRIMARY": ["id"], "PRIMARY": ["id"],
"uri-hash": ["UNIQUE", "uri-hash"], "uri-hash": ["UNIQUE", "uri-hash"],
"uri": ["uri(191)"] "uri": ["uri(191)"],
"uri-id": ["uri-id"]
} }
}, },
"item-content": { "item-content": {
@ -649,7 +650,8 @@
"indexes": { "indexes": {
"PRIMARY": ["id"], "PRIMARY": ["id"],
"uri-plink-hash": ["UNIQUE", "uri-plink-hash"], "uri-plink-hash": ["UNIQUE", "uri-plink-hash"],
"uri": ["uri(191)"] "uri": ["uri(191)"],
"uri-id": ["uri-id"]
} }
}, },
"item-delivery-data": { "item-delivery-data": {

View File

@ -665,11 +665,11 @@ class Item extends BaseObject
} }
if (strpos($sql_commands, "`item-activity`.") !== false) { if (strpos($sql_commands, "`item-activity`.") !== false) {
$joins .= " LEFT JOIN `item-activity` ON `item-activity`.`id` = `item`.`iaid`"; $joins .= " LEFT JOIN `item-activity` ON `item-activity`.`uri-id` = `item`.`uri-id`";
} }
if (strpos($sql_commands, "`item-content`.") !== false) { if (strpos($sql_commands, "`item-content`.") !== false) {
$joins .= " LEFT JOIN `item-content` ON `item-content`.`id` = `item`.`icid`"; $joins .= " LEFT JOIN `item-content` ON `item-content`.`uri-id` = `item`.`uri-id`";
} }
if (strpos($sql_commands, "`item-delivery-data`.") !== false) { if (strpos($sql_commands, "`item-delivery-data`.") !== false) {

View File

@ -246,3 +246,12 @@ function update_1278() {
return UPDATE_SUCCESS; return UPDATE_SUCCESS;
} }
function update_1288() {
// Updates missing `uri-id` values
DBA::e("UPDATE `item-activity` INNER JOIN `item` ON `item`.`iaid` = `item-activity`.`id` SET `item-activity`.`uri-id` = `item`.`uri-id` WHERE `item-activity`.`uri-id` IS NULL OR `item-activity`.`uri-id` = 0");
DBA::e("UPDATE `item-content` INNER JOIN `item` ON `item`.`icid` = `item-content`.`id` SET `item-content`.`uri-id` = `item`.`uri-id` WHERE `item-content`.`uri-id` IS NULL OR `item-content`.`uri-id` = 0");
return UPDATE_SUCCESS;
}