Adapt because of feedback

This commit is contained in:
Philipp Holzer 2019-10-23 21:29:17 +02:00
parent db25f5b6ca
commit dba2d574b1
No known key found for this signature in database
GPG Key ID: D8365C3D36B77D90
1 changed files with 3 additions and 4 deletions

View File

@ -49,13 +49,12 @@ class Ignored extends BaseModule
case local_user(): case local_user():
$dba->update('thread', ['ignored' => $ignored], ['iid' => $message_id]); $dba->update('thread', ['ignored' => $ignored], ['iid' => $message_id]);
break; break;
// Empty or 0 (null will get transformed to 0) => it's a public post // 0 (null will get transformed to 0) => it's a public post
case 0: case 0:
case '':
$dba->update('user-item', ['ignored' => $ignored], ['iid' => $message_id, 'uid' => local_user()], true); $dba->update('user-item', ['ignored' => $ignored], ['iid' => $message_id, 'uid' => local_user()], true);
break; break;
// In case we retrieved a thread which isn't our or a public, it's a forbidden action // Throws a BadRequestException and not a ForbiddenException on purpose
// but due to security reason (brute force), we print a Bad request exception // Avoids harvesting existing, but forbidden IIDs (security issue)
default: default:
throw new HTTPException\BadRequestException(); throw new HTTPException\BadRequestException();
} }