Moved is_filled_array() to both dba classes and named it is_result().

Please see ticket #2390 for full discussion.

Signed-off-by: Roland Haeder <roland@mxchange.org>
This commit is contained in:
Roland Häder 2016-03-12 18:54:55 +01:00
parent c60605ce0c
commit 9cfc249b12
No known key found for this signature in database
GPG key ID: B72F8185C6C7BD78
8 changed files with 39 additions and 24 deletions

View file

@ -927,7 +927,7 @@ class App {
} else { } else {
$r = q("SELECT `contact`.`avatar-date` AS picdate FROM `contact` WHERE `contact`.`thumb` like '%%/%s'", $r = q("SELECT `contact`.`avatar-date` AS picdate FROM `contact` WHERE `contact`.`thumb` like '%%/%s'",
$common_filename); $common_filename);
if(! is_filled_array($r)){ if(! dba::is_result($r)){
$this->cached_profile_image[$avatar_image] = $avatar_image; $this->cached_profile_image[$avatar_image] = $avatar_image;
} else { } else {
$this->cached_profile_picdate[$common_filename] = "?rev=".urlencode($r[0]['picdate']); $this->cached_profile_picdate[$common_filename] = "?rev=".urlencode($r[0]['picdate']);
@ -1412,7 +1412,7 @@ function run_update_function($x) {
function check_plugins(&$a) { function check_plugins(&$a) {
$r = q("SELECT * FROM `addon` WHERE `installed` = 1"); $r = q("SELECT * FROM `addon` WHERE `installed` = 1");
if(is_filled_array($r)) if(dba::is_result($r))
$installed = $r; $installed = $r;
else else
$installed = array(); $installed = array();
@ -1743,7 +1743,7 @@ function current_theme(){
$r = q("select theme from user where uid = %d limit 1", $r = q("select theme from user where uid = %d limit 1",
intval($a->profile_uid) intval($a->profile_uid)
); );
if(is_filled_array($r)) if(dba::is_result($r))
$page_theme = $r[0]['theme']; $page_theme = $r[0]['theme'];
} }
@ -1856,7 +1856,7 @@ function feed_birthday($uid,$tz) {
intval($uid) intval($uid)
); );
if(is_filled_array($p)) { if(dba::is_result($p)) {
$tmp_dob = substr($p[0]['dob'],5); $tmp_dob = substr($p[0]['dob'],5);
if(intval($tmp_dob)) { if(intval($tmp_dob)) {
$y = datetime_convert($tz,$tz,'now','Y'); $y = datetime_convert($tz,$tz,'now','Y');
@ -1902,7 +1902,7 @@ function load_contact_links($uid) {
intval($uid) intval($uid)
); );
if(is_filled_array($r)) { if(dba::is_result($r)) {
foreach($r as $rr){ foreach($r as $rr){
$url = normalise_link($rr['url']); $url = normalise_link($rr['url']);
$ret[$url] = $rr; $ret[$url] = $rr;
@ -2202,7 +2202,3 @@ function argv($x) {
return ''; return '';
} }
function is_filled_array ($array) {
return (is_array($array) && count($array) > 0);
}

View file

@ -86,7 +86,7 @@ class ForumManager {
$total = count($contacts); $total = count($contacts);
$visible_forums = 10; $visible_forums = 10;
if(is_filled_array($contacts)) { if(dba::is_result($contacts)) {
$id = 0; $id = 0;

View file

@ -230,6 +230,16 @@ class dba {
} }
} }
/**
* Checks if $array is a filled array with at least one entry.
*
* @param $array mixed A filled array with at least one entry
* @return Whether $array is a filled array
*/
public function is_result ($array) {
return (is_array($array) && count($array) > 0);
}
function __destruct() { function __destruct() {
if ($this->db) if ($this->db)
if($this->mysqli) if($this->mysqli)
@ -340,4 +350,3 @@ function dbesc_array(&$arr) {
function dba_timer() { function dba_timer() {
return microtime(true); return microtime(true);
} }

View file

@ -232,6 +232,16 @@ class dba {
} }
} }
/**
* Checks if $array is a filled array with at least one entry.
*
* @param $array mixed A filled array with at least one entry
* @return Whether $array is a filled array
*/
public function is_result ($array) {
return (is_array($array) && count($array) > 0);
}
function __destruct() { function __destruct() {
if ($this->db) if ($this->db)
\DDDBL\disconnect(); \DDDBL\disconnect();

View file

@ -197,7 +197,7 @@ function poller_max_connections_reached() {
function poller_kill_stale_workers() { function poller_kill_stale_workers() {
$r = q("SELECT `pid`, `executed` FROM `workerqueue` WHERE `executed` != '0000-00-00 00:00:00'"); $r = q("SELECT `pid`, `executed` FROM `workerqueue` WHERE `executed` != '0000-00-00 00:00:00'");
if (!is_filled_array($r)) { if (!dba::is_result($r)) {
// No processing here needed // No processing here needed
return; return;
} }

View file

@ -108,7 +108,7 @@ if (x($_SESSION,'authenticated') && !x($_SESSION,'language')) {
// we didn't loaded user data yet, but we need user language // we didn't loaded user data yet, but we need user language
$r = q("SELECT language FROM user WHERE uid=%d", intval($_SESSION['uid'])); $r = q("SELECT language FROM user WHERE uid=%d", intval($_SESSION['uid']));
$_SESSION['language'] = $lang; $_SESSION['language'] = $lang;
if (is_filled_array($r)) $_SESSION['language'] = $r[0]['language']; if (dba::is_result($r)) $_SESSION['language'] = $r[0]['language'];
} }
if((x($_SESSION,'language')) && ($_SESSION['language'] !== $lang)) { if((x($_SESSION,'language')) && ($_SESSION['language'] !== $lang)) {

View file

@ -360,13 +360,13 @@ function message_content(&$a) {
dbesc($myprofile) dbesc($myprofile)
); );
if (is_filled_array($r)) { if (dba::is_result($r)) {
$a->set_pager_total($r[0]['total']); $a->set_pager_total($r[0]['total']);
} }
$r = get_messages(local_user(), $a->pager['start'], $a->pager['itemspage']); $r = get_messages(local_user(), $a->pager['start'], $a->pager['itemspage']);
if(! is_filled_array($r)) { if(! dba::is_result($r)) {
info( t('No messages.') . EOL); info( t('No messages.') . EOL);
return $o; return $o;
} }

View file

@ -51,7 +51,7 @@ function ping_init(&$a) {
intval(local_user()), intval(local_user()) intval(local_user()), intval(local_user())
); );
if(is_filled_array($r)) { if(dba::is_result($r)) {
$arr = array('items' => $r); $arr = array('items' => $r);
call_hooks('network_ping', $arr); call_hooks('network_ping', $arr);
@ -150,7 +150,7 @@ function ping_init(&$a) {
dbesc(datetime_convert('UTC','UTC','now')) dbesc(datetime_convert('UTC','UTC','now'))
); );
if(is_filled_array($ev)) { if(dba::is_result($ev)) {
$all_events = intval($ev[0]['total']); $all_events = intval($ev[0]['total']);
if($all_events) { if($all_events) {
@ -219,7 +219,7 @@ function ping_init(&$a) {
<home>$home</home>\r\n"; <home>$home</home>\r\n";
if ($register!=0) echo "<register>$register</register>"; if ($register!=0) echo "<register>$register</register>";
if ( is_filled_array($groups_unseen) ) { if ( dba::is_result($groups_unseen) ) {
echo '<groups>'; echo '<groups>';
foreach ($groups_unseen as $it) foreach ($groups_unseen as $it)
if ($it['count'] > 0) if ($it['count'] > 0)
@ -228,7 +228,7 @@ function ping_init(&$a) {
echo "</groups>"; echo "</groups>";
} }
if ( is_filled_array($forums_unseen) ) { if ( dba::is_result($forums_unseen) ) {
echo '<forums>'; echo '<forums>';
foreach ($forums_unseen as $it) foreach ($forums_unseen as $it)
if ($it['count'] > 0) if ($it['count'] > 0)
@ -245,7 +245,7 @@ function ping_init(&$a) {
<birthdays-today>$birthdays_today</birthdays-today>\r\n"; <birthdays-today>$birthdays_today</birthdays-today>\r\n";
if (is_filled_array($notifs) && (! $sysnotify)) { if (dba::is_result($notifs) && (! $sysnotify)) {
foreach ($notifs as $zz) { foreach ($notifs as $zz) {
if($zz['seen'] == 0) if($zz['seen'] == 0)
$sysnotify ++; $sysnotify ++;
@ -255,7 +255,7 @@ function ping_init(&$a) {
echo ' <notif count="'. ($sysnotify + $intro + $mail + $register) .'">'; echo ' <notif count="'. ($sysnotify + $intro + $mail + $register) .'">';
// merge all notification types in one array // merge all notification types in one array
if ( is_filled_array($intros) ) { if ( dba::is_result($intros) ) {
foreach ($intros as $i) { foreach ($intros as $i) {
$n = array( $n = array(
'href' => $a->get_baseurl().'/notifications/intros/'.$i['id'], 'href' => $a->get_baseurl().'/notifications/intros/'.$i['id'],
@ -270,7 +270,7 @@ function ping_init(&$a) {
} }
} }
if ( is_filled_array($mails) ) { if ( dba::is_result($mails) ) {
foreach ($mails as $i) { foreach ($mails as $i) {
$n = array( $n = array(
'href' => $a->get_baseurl().'/message/'.$i['id'], 'href' => $a->get_baseurl().'/message/'.$i['id'],
@ -285,7 +285,7 @@ function ping_init(&$a) {
} }
} }
if ( is_filled_array($regs) ) { if ( dba::is_result($regs) ) {
foreach ($regs as $i) { foreach ($regs as $i) {
$n = array( $n = array(
'href' => $a->get_baseurl().'/admin/users/', 'href' => $a->get_baseurl().'/admin/users/',
@ -311,7 +311,7 @@ function ping_init(&$a) {
}; };
usort($notifs, $sort_function); usort($notifs, $sort_function);
if( is_filled_array($notifs) ) { if( dba::is_result($notifs) ) {
foreach($notifs as $n) { foreach($notifs as $n) {
echo xmlize($n); echo xmlize($n);
} }