Merge pull request #7654 from nupplaphil/bug/auto-installer

Fix Auto-Installer
This commit is contained in:
Michael Vogel 2019-09-23 15:13:09 +02:00 committed by GitHub
commit 0dfd6a523d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 30 additions and 20 deletions

View File

@ -129,16 +129,13 @@ HELP;
$config_file = $this->getOption(['f', 'file']); $config_file = $this->getOption(['f', 'file']);
if (!empty($config_file)) { if (!empty($config_file)) {
if ($config_file != 'config' . DIRECTORY_SEPARATOR . 'local.config.php') {
// Copy config file if (!file_exists($config_file)) {
$this->out("Copying config file...\n"); throw new RuntimeException("ERROR: Config file does not exist.\n");
if (!copy($basePathConf . DIRECTORY_SEPARATOR . $config_file, $basePathConf . DIRECTORY_SEPARATOR . 'config' . DIRECTORY_SEPARATOR . 'local.config.php')) {
throw new RuntimeException("ERROR: Saving config file failed. Please copy '$config_file' to '" . $basePathConf . "'" . DIRECTORY_SEPARATOR . "config" . DIRECTORY_SEPARATOR . "local.config.php' manually.\n");
}
} }
//reload the config cache //reload the config cache
$loader = new ConfigFileLoader($basePathConf); $loader = new ConfigFileLoader($config_file);
$loader->setupCache($configCache); $loader->setupCache($configCache);
} else { } else {
@ -219,6 +216,14 @@ HELP;
throw new RuntimeException($errorMessage); throw new RuntimeException($errorMessage);
} }
if (!empty($config_file) && $config_file != 'config' . DIRECTORY_SEPARATOR . 'local.config.php') {
// Copy config file
$this->out("Copying config file...\n");
if (!copy($basePathConf . DIRECTORY_SEPARATOR . $config_file, $basePathConf . DIRECTORY_SEPARATOR . 'config' . DIRECTORY_SEPARATOR . 'local.config.php')) {
throw new RuntimeException("ERROR: Saving config file failed. Please copy '$config_file' to '" . $basePathConf . "'" . DIRECTORY_SEPARATOR . "config" . DIRECTORY_SEPARATOR . "local.config.php' manually.\n");
}
}
$this->out(" Complete!\n\n"); $this->out(" Complete!\n\n");
// Install theme // Install theme

View File

@ -90,9 +90,12 @@ class Database
public function connect() public function connect()
{ {
if (!is_null($this->connection) && $this->connected()) { if (!is_null($this->connection) && $this->connected()) {
return true; return $this->connected;
} }
// Reset connected state
$this->connected = false;
$port = 0; $port = 0;
$serveraddr = trim($this->configCache->get('database', 'hostname')); $serveraddr = trim($this->configCache->get('database', 'hostname'));
$serverdata = explode(':', $serveraddr); $serverdata = explode(':', $serveraddr);
@ -187,10 +190,7 @@ class Database
*/ */
public function disconnect() public function disconnect()
{ {
if (is_null($this->connection)) { if (!is_null($this->connection)) {
return;
}
switch ($this->driver) { switch ($this->driver) {
case 'pdo': case 'pdo':
$this->connection = null; $this->connection = null;
@ -202,6 +202,10 @@ class Database
} }
} }
$this->driver = null;
$this->connected = false;
}
/** /**
* Perform a reconnect of an existing database connection * Perform a reconnect of an existing database connection
*/ */
@ -369,6 +373,7 @@ class Database
$connected = $this->connection->ping(); $connected = $this->connection->ping();
break; break;
} }
return $connected; return $connected;
} }