friendica/friendica-docker-ci
6
0
Fork 3
Code Issues Pull requests Packages Projects Releases Wiki Activity

Fix "check-addons.sh" file #5

Merged
nupplaphil merged 2 commits from bug/transifex into stable 2021-05-24 11:58:00 +02:00
Conversation 2 Commits 2 Files changed 2 +3 -3
nupplaphil commented 2021-05-22 20:10:06 +02:00 (Migrated from github.com)
Copy link

Fixed a bug that we didn't skip all unwanted rows after the diff, so two messages.po would result in a wrong row count

And made the output of two scripts bold for better visibiltiy

Fixed a bug that we didn't skip all unwanted rows after the diff, so two `messages.po` would result in a wrong row count And made the output of two scripts bold for better visibiltiy
nupplaphil commented 2021-05-24 00:40:09 +02:00 (Migrated from github.com)
Copy link

Ping @MrPetovan - at least for having a second Pair of eyes :-)

Ping @MrPetovan - at least for having a second Pair of eyes :-)
MrPetovan (Migrated from github.com) approved these changes 2021-05-24 00:53:03 +02:00
MrPetovan (Migrated from github.com) left a comment
Copy link

What was the issue that you fixed exactly? I wasn't able to guess either from the code or the commit message.

What was the issue that you fixed exactly? I wasn't able to guess either from the code or the commit message.
nupplaphil commented 2021-05-24 11:13:11 +02:00 (Migrated from github.com)
Copy link

Uh.. it was a bug that the regex didn't catch all unwanted gut rows, thx

Uh.. it was a bug that the regex didn't catch all unwanted gut rows, thx
Sign in to join this conversation.
Reviewers
No reviewers
MrPetovan
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: friendica/friendica-docker-ci#5
No description provided.
Delete branch "bug/transifex"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?