Use updated PHP-CS-Fixer in standard location #16
No reviewers
MrPetovan
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: friendica/friendica-docker-ci#16
Loading…
Reference in a new issue
No description provided.
Delete branch "toddy/friendica-docker-ci:php-cs-fixer"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Hi,
this is step #2 in updating PHP-CS-Fixer to a recent version and installing it in a standard location (
vendor/bin/php-cs-fixerinstead ofbin/dev/php-cs-fixer/vendor/bin/php-cs-fixer).See https://github.com/friendica/friendica/pull/13824 for details and https://github.com/friendica/friendica/pull/13824#issuecomment-1892042037 for the plan.
Regards,
Tobias
@ -9,3 +9,3 @@fi./bin/dev/php-cs-fixer/vendor/bin/php-cs-fixer fix --config=.php_cs.dist -v --diff --diff-format=udiff --dry-run --using-cache=no ${EXTRA_ARGS}./vendor/bin/php-cs-fixer check -v --diff --using-cache=no ${EXTRA_ARGS}The previous call used the
--dry-runflag, I’m not sure we should remove it.I've changed the command from
fix --dry-runtocheck, so I think it's safe to omit the --dry-run flag. If you prefer, I can add it again.I've now adopted the suggestion from the php-cs-fixer documentation for running it on CI.
Great, thanks. I think now the image at https://hub.docker.com/r/friendicaci/php-cs needs to be pushed again, so it can pick up the latest changes.
Unfortunately I have no idea how to do that. hopefully @nupplaPhil -senpai notices us.