Add PHP 8.3 #15

toddy · 2024-01-02T16:05:30+01:00

toddy commented

2024-01-02 16:05:30 +01:00

Hi,

you might want to add PHP 8.3 for testing.

Regards,
Tobias

Hi, you might want to add PHP 8.3 for testing. Regards, Tobias

toddy added 1 commit 2024-01-02 16:05:31 +01:00

8691cb9be3 Add PHP 8.3

MrPetovan reviewed 2024-01-02 16:08:53 +01:00

php8.3/Dockerfile

					
				@ -0,0 +11,4 @@

				        DEBIAN_FRONTEND=noninteractive apt-get install -q -y php8.3-gd git curl openssl \

				        php8.3-cli php8.3-curl php8.3-mysql wget make \

				        php8.3-redis php8.3-intl php8.3-memcached php8.3-memcache \

				        php8.3-apcu php8.3-xdebug php8.3-xml php8.3-zip php8.3-dev php8.3-mbstring; \

MrPetovan commented

2024-01-02 16:08:50 +01:00

Why do we install the XDebug extension only to disable it later?

toddy commented

2024-01-02 16:14:44 +01:00

Great question. 🙂

I've just copied the files from PHP 8.2 and adapted them for PHP 8.3, so this slipped through. However, from a quick look at the other Dockerfiles, this is done in every one of them from PHP 7.3 up to PHP 8.2.

If there's no reason to enable the XDebug module, we could remove it from all Dockerfiles. I'm leaving that decision to someone who knows better about the Docker setup for Friendica.

Great question. 🙂 I've just copied the files from PHP 8.2 and adapted them for PHP 8.3, so this slipped through. However, from a quick look at the other Dockerfiles, this is done in every one of them from PHP 7.3 up to PHP 8.2. If there's no reason to enable the XDebug module, we could remove it from all Dockerfiles. I'm leaving that decision to someone who knows better about the Docker setup for Friendica.

MrPetovan commented

2024-01-08 13:48:05 +01:00

Paging @nupplaPhil for the general setup.

toddy commented

2024-01-08 16:21:35 +01:00

I think I have an idea. In the file .woodpecker/.phpunit.yml, the xdebug module is enabled again if the PHP version equals 7.4.

I guess that is to upload the code coverage only once and not after every other test with different PHP versions pass.

But it would in theory suffice to enable xdebug only in the PHP 7.4 image. However, you'd need to recreate the image if you choose to use another PHP version for uploading the code coverage.

I think I have an idea. In the file .woodpecker/.phpunit.yml, the xdebug module is enabled again if the PHP version equals 7.4. I guess that is to upload the code coverage only once and not after every other test with different PHP versions pass. But it would in theory suffice to enable xdebug only in the PHP 7.4 image. However, you'd need to recreate the image if you choose to use another PHP version for uploading the code coverage.

MrPetovan commented

2024-01-12 06:10:02 +01:00

Thank you for the suggestion, however I'm not able to personally act on it. I hope it's useful for @nupplaPhil though.

nupplaPhil commented

2024-03-15 22:44:59 +01:00

@toddy is right with his suggestion :) I added xdebug for the code coverage and for "convienence", I added it at every container. Still we don't "really" need it, but it doesnt't hurt since they are "just" CI images and not for production.

I'm merging this PR now to add the new image to our pipeline

@toddy is right with his suggestion :) I added xdebug for the code coverage and for "convienence", I added it at every container. Still we don't "really" need it, but it doesnt't hurt since they are "just" CI images and not for production. I'm merging this PR now to add the new image to our pipeline

👍 1

nupplaPhil merged commit 88a02fa2cf into stable

2024-03-15 22:45:02 +01:00

nupplaPhil referenced this issue from a commit

2024-03-15 22:45:04 +01:00

Merge pull request 'Add PHP 8.3' (#15) from toddy/friendica-docker-ci:stable into stable

nupplaPhil referenced this pull request from friendica/friendica-addons

2024-03-15 23:14:01 +01:00

[CI] Add PHP 8.3 and upgrade CI images #1485

Sign in to join this conversation.

No reviewers