friendica/friendica-docker-ci
6
0
Fork 3
Code Issues Pull requests Packages Projects Releases Wiki Activity

Add PHP 8.3 #15

Merged
nupplaPhil merged 1 commit from toddy/friendica-docker-ci:stable into stable 2024-03-15 22:45:02 +01:00
Conversation 3 Commits 1 Files changed 2 +47
toddy commented 2024-01-02 16:05:30 +01:00
Contributor
Copy link

Hi,

you might want to add PHP 8.3 for testing.

Regards,
Tobias

Hi, you might want to add PHP 8.3 for testing. Regards, Tobias
toddy added 1 commit 2024-01-02 16:05:31 +01:00
MrPetovan reviewed 2024-01-02 16:08:53 +01:00
php8.3/Dockerfile
@ -0,0 +11,4 @@
DEBIAN_FRONTEND=noninteractive apt-get install -q -y php8.3-gd git curl openssl \
php8.3-cli php8.3-curl php8.3-mysql wget make \
php8.3-redis php8.3-intl php8.3-memcached php8.3-memcache \
php8.3-apcu php8.3-xdebug php8.3-xml php8.3-zip php8.3-dev php8.3-mbstring; \
MrPetovan commented 2024-01-02 16:08:50 +01:00
Owner
Copy link

Why do we install the XDebug extension only to disable it later?

Why do we install the XDebug extension only to disable it later?
toddy commented 2024-01-02 16:14:44 +01:00
Author
Contributor
Copy link

Great question. 🙂

I've just copied the files from PHP 8.2 and adapted them for PHP 8.3, so this slipped through. However, from a quick look at the other Dockerfiles, this is done in every one of them from PHP 7.3 up to PHP 8.2.

If there's no reason to enable the XDebug module, we could remove it from all Dockerfiles. I'm leaving that decision to someone who knows better about the Docker setup for Friendica.

Great question. 🙂 I've just copied the files from PHP 8.2 and adapted them for PHP 8.3, so this slipped through. However, from a quick look at the other Dockerfiles, this is done in every one of them from PHP 7.3 up to PHP 8.2. If there's no reason to enable the XDebug module, we could remove it from all Dockerfiles. I'm leaving that decision to someone who knows better about the Docker setup for Friendica.
MrPetovan commented 2024-01-08 13:48:05 +01:00
Owner
Copy link

Paging @nupplaPhil for the general setup.

Paging @nupplaPhil for the general setup.
toddy commented 2024-01-08 16:21:35 +01:00
Author
Contributor
Copy link

I think I have an idea. In the file .woodpecker/.phpunit.yml, the xdebug module is enabled again if the PHP version equals 7.4.

I guess that is to upload the code coverage only once and not after every other test with different PHP versions pass.

But it would in theory suffice to enable xdebug only in the PHP 7.4 image. However, you'd need to recreate the image if you choose to use another PHP version for uploading the code coverage.

I think I have an idea. In the file .woodpecker/.phpunit.yml, the xdebug module is enabled again if the PHP version equals 7.4. I guess that is to upload the code coverage only once and not after every other test with different PHP versions pass. But it would in theory suffice to enable xdebug only in the PHP 7.4 image. However, you'd need to recreate the image if you choose to use another PHP version for uploading the code coverage.
MrPetovan commented 2024-01-12 06:10:02 +01:00
Owner
Copy link

Thank you for the suggestion, however I'm not able to personally act on it. I hope it's useful for @nupplaPhil though.

Thank you for the suggestion, however I'm not able to personally act on it. I hope it's useful for @nupplaPhil though.
nupplaPhil commented 2024-03-15 22:44:59 +01:00
Owner
Copy link

@toddy is right with his suggestion :) I added xdebug for the code coverage and for "convienence", I added it at every container. Still we don't "really" need it, but it doesnt't hurt since they are "just" CI images and not for production.

I'm merging this PR now to add the new image to our pipeline

@toddy is right with his suggestion :) I added xdebug for the code coverage and for "convienence", I added it at every container. Still we don't "really" need it, but it doesnt't hurt since they are "just" CI images and not for production. I'm merging this PR now to add the new image to our pipeline
👍 1
nupplaPhil merged commit 88a02fa2cf into stable 2024-03-15 22:45:02 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: friendica/friendica-docker-ci#15
No description provided.
Delete branch "toddy/friendica-docker-ci:stable"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?