Fixes: #71

Merged
Quix0r merged 1 commits from fixes/timeout-class-reference into stable 3 years ago
Quix0r commented 3 years ago (Migrated from github.com)
  • timeout of 1 second was to short for the default directory at https://dir.friendica.social
  • Used \Some\Foo::class instead of '\Some\Foo' which type-safe and easier to find by your editor/IDE

Signed-off-by: Roland Häder roland@mxchange.org

- timeout of 1 second was to short for the default directory at https://dir.friendica.social - Used \Some\Foo::class instead of '\Some\Foo' which type-safe and easier to find by your editor/IDE Signed-off-by: Roland Häder <roland@mxchange.org>
MrPetovan (Migrated from github.com) requested changes 3 years ago
MrPetovan (Migrated from github.com) commented 3 years ago

1 second is the absolute minimum but you can increase the timeout itself in your local config file. Please remove this change from your PR.

1 second is the absolute minimum but you can increase the timeout itself in your local config file. Please remove this change from your PR.
AndyHee (Migrated from github.com) reviewed 3 years ago
AndyHee (Migrated from github.com) commented 3 years ago

Thanks for the hint @MrPetovan !

Could you tell us how this configuration looks like in practice?

Thanks for the hint @MrPetovan ! Could you tell us how this configuration looks like in practice?
MrPetovan (Migrated from github.com) reviewed 3 years ago
MrPetovan (Migrated from github.com) commented 3 years ago

Sure, here's a sample config/local.json file with the setting updated:

{
    "database": {
        "driver": "mysql",
        "hostname": "localhost",
        "database": "friendica-directory",
        "username": "friendica-directory",
        "password": "🤡"
    },
    "poller": {
        "server_poll_delay": 28800,
        "profile_poll_delay": 36000,
        "probe_timeout": 10
    },
    "logger": {
        "level": 250
    }
}
Sure, here's a sample `config/local.json` file with the setting updated: ```json { "database": { "driver": "mysql", "hostname": "localhost", "database": "friendica-directory", "username": "friendica-directory", "password": "🤡" }, "poller": { "server_poll_delay": 28800, "profile_poll_delay": 36000, "probe_timeout": 10 }, "logger": { "level": 250 } } ```
AndyHee (Migrated from github.com) reviewed 3 years ago
AndyHee (Migrated from github.com) commented 3 years ago

Great! Thanks very much, @MrPetovan

Great! Thanks very much, @MrPetovan
Quix0r commented 3 years ago (Migrated from github.com)

I forced-pushed the revert of the timeouts. Now only the ::class usage is left.

I forced-pushed the revert of the timeouts. Now only the `::class` usage is left.
MrPetovan (Migrated from github.com) approved these changes 3 years ago
MrPetovan (Migrated from github.com) left a comment

Thank you for your work!

Thank you for your work!

Reviewers

The pull request has been merged as 7112c65166.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b fixes/timeout-class-reference stable
git pull origin fixes/timeout-class-reference

Step 2:

Merge the changes and update on Forgejo.
git checkout stable
git merge --no-ff fixes/timeout-class-reference
git push origin stable
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: friendica/friendica-directory#71
Loading…
There is no content yet.