friendica
/
friendica-addons
7
2
Fork 13
Code Issues 3 Pull Requests 2 Releases 16 Wiki Activity

[various] Fix admin addons #854

Merged
MrPetovan merged 4 commits from task/fix-admin-addons into develop 2019-05-09 18:05:02 +02:00
Conversation 0 Commits 4 Files Changed 10 +143 -239
MrPetovan commented 2019-05-08 06:53:51 +02:00 (Migrated from github.com)
Copy Link

Depends on https://github.com/friendica/friendica/pull/7116
From https://forum.friendi.ca/display/a006f0fd-755c-cfbb-458f-f28665634766

Some addons were wrongly using the addon_settings hook to show the node-wide addon settings to admins only in their user settings. This PR rectifies this sad state by using the proper <addon>_addon_admin functions that are effectively used to show node-wide addon settings in the admin addon detail page.

Thanks Adam Gaskins for the keen eye!

Depends on https://github.com/friendica/friendica/pull/7116 From https://forum.friendi.ca/display/a006f0fd-755c-cfbb-458f-f28665634766 Some addons were wrongly using the `addon_settings` hook to show the node-wide addon settings to admins only in their user settings. This PR rectifies this sad state by using the proper `<addon>_addon_admin` functions that are effectively used to show node-wide addon settings in the admin addon detail page. Thanks Adam Gaskins for the keen eye!
tobiasd (Migrated from github.com) reviewed 2019-05-08 06:53:51 +02:00
tobiasd (Migrated from github.com) reviewed 2019-05-08 08:01:14 +02:00
tobiasd (Migrated from github.com) reviewed 2019-05-08 08:03:19 +02:00
tobiasd (Migrated from github.com) reviewed 2019-05-08 08:07:12 +02:00
MrPetovan (Migrated from github.com) reviewed 2019-05-08 14:24:04 +02:00
MrPetovan (Migrated from github.com) reviewed 2019-05-08 14:25:32 +02:00
MrPetovan (Migrated from github.com) reviewed 2019-05-08 14:27:02 +02:00
MrPetovan (Migrated from github.com) reviewed 2019-05-08 15:17:34 +02:00
tobiasd (Migrated from github.com) reviewed 2019-05-08 15:26:31 +02:00
tobiasd (Migrated from github.com) reviewed 2019-05-08 15:27:35 +02:00
MrPetovan (Migrated from github.com) reviewed 2019-05-08 16:18:15 +02:00
MrPetovan (Migrated from github.com) reviewed 2019-05-08 16:42:59 +02:00
MrPetovan (Migrated from github.com) reviewed 2019-05-09 16:31:47 +02:00
MrPetovan (Migrated from github.com) reviewed 2019-05-09 16:32:05 +02:00
tobiasd (Migrated from github.com) reviewed 2019-05-09 18:01:01 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
tobiasd
Labels
Clear labels   
2018.09

   
2019.01

   
2019.03

   
2019.06

   
2019.09

   
2019.12

   
2020.03

   
2020.06

   
2020.09

   
2020.12

   
2021.03

   
2021.07

   
2021.09

   
2022.02

   
2022.06

   
2022.09

   
2022.12

   
2023.04

   
2023.05

   
2023.09

   
2024.03

   
2024.06

   
dependencies

Pull requests that update a dependency file

  
Hackathon 2021
No Label
2018.09
2019.01
2019.03
2019.06
2019.09
2019.12
2020.03
2020.06
2020.09
2020.12
2021.03
2021.07
2021.09
2022.02
2022.06
2022.09
2022.12
2023.04
2023.05
2023.09
2024.03
2024.06
dependencies
Hackathon 2021
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: friendica/friendica-addons#854
No description provided.
Delete Branch "task/fix-admin-addons"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?