friendica
/
friendica-addons
7
2
Fork 13
Code Issues 3 Pull Requests 4 Releases 16 Wiki Activity

[twitter] Add expected wall = 1 for own posts #789

Closed
MrPetovan wants to merge 1 commits from task/notification-add-their-post into develop
pull from: task/notification-add-their-post
merge into: friendica:develop
Conversation 6 Commits 1 Files Changed 1 +2
MrPetovan commented 2019-01-06 10:13:47 +01:00 (Migrated from github.com)
Copy Link

Pendant to https://github.com/friendica/friendica/pull/6389

Fixes a issue where own Twitter posts aren't recognized as being our own in the notification process.

Pendant to https://github.com/friendica/friendica/pull/6389 Fixes a issue where own Twitter posts aren't recognized as being our own in the notification process.
annando commented 2019-01-06 20:34:27 +01:00 (Migrated from github.com)
Copy Link

This "wall" value is used - for example - to display the item on the profile page. I would vote for other mechanism to detect this.

We are calling this hook here: https://github.com/friendica/friendica/blob/develop/include/enotify.php#L680

With this we do know the author names that we are using. So we do know which posts are ours.

This "wall" value is used - for example - to display the item on the profile page. I would vote for other mechanism to detect this. We are calling this hook here: https://github.com/friendica/friendica/blob/develop/include/enotify.php#L680 With this we do know the author names that we are using. So we do know which posts are ours.
MrPetovan commented 2019-01-06 21:28:50 +01:00 (Migrated from github.com)
Copy Link

The actual definition of what constitutes "our" posts is defined here:

https://github.com/friendica/friendica/blob/develop/include/enotify.php#L182

If it isn't accurate, please update the condition accordingly.

The actual definition of what constitutes "our" posts is defined here: https://github.com/friendica/friendica/blob/develop/include/enotify.php#L182 If it isn't accurate, please update the condition accordingly.
annando commented 2019-01-06 22:09:17 +01:00 (Migrated from github.com)
Copy Link

I currently want to have a look at others issues at first.

I currently want to have a look at others issues at first.
MrPetovan commented 2019-01-06 22:35:18 +01:00 (Migrated from github.com)
Copy Link

What happens now to this PR then?

What happens now to this PR then?
annando commented 2019-01-06 22:46:25 +01:00 (Migrated from github.com)
Copy Link

I have the feeling that it would create massive side effects, so I wouldn't like to accept it.

I have the feeling that it would create massive side effects, so I wouldn't like to accept it.
MrPetovan commented 2019-01-06 23:11:40 +01:00 (Migrated from github.com)
Copy Link

It's okay, Twitter post will have the previous behavior which was to repeat the name of the top-level author almost no matter what.

It's okay, Twitter post will have the previous behavior which was to repeat the name of the top-level author almost no matter what.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
2018.09

   
2019.01

   
2019.03

   
2019.06

   
2019.09

   
2019.12

   
2020.03

   
2020.06

   
2020.09

   
2020.12

   
2021.03

   
2021.07

   
2021.09

   
2022.02

   
2022.06

   
2022.09

   
2022.12

   
2023.04

   
2023.05

   
2023.09

   
2024.03

   
2024.06

   
dependencies

Pull requests that update a dependency file

  
Hackathon 2021
No Label
2018.09
2019.01
2019.03
2019.06
2019.09
2019.12
2020.03
2020.06
2020.09
2020.12
2021.03
2021.07
2021.09
2022.02
2022.06
2022.09
2022.12
2023.04
2023.05
2023.09
2024.03
2024.06
dependencies
Hackathon 2021
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: friendica/friendica-addons#789
No description provided.
Delete Branch "task/notification-add-their-post"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?