[pumpio] Fixes/imports: #661

Merged

Quix0r merged 3 commits from pumpio/import-curly-braces into develop

2018-07-22 18:01:05 +02:00

Quix0r commented

2018-07-22 15:15:49 +02:00

(Migrated from github.com)

Fixes/imports:

added curly braces and spaces for better readability
merged 2 if() blocks into one for lesser nested code blocks
added type-hint App and array where applyable
better "import" (use under PHP) classes and not reference them directly,
reducing and improving readability

Fixes/imports: - added curly braces and spaces for better readability - merged 2 `if()` blocks into one for lesser nested code blocks - added type-hint `App` and `array` where applyable - better "import" (`use` under PHP) classes and not reference them directly, reducing and improving readability

MrPetovan (Migrated from github.com) requested changes 2018-07-22 16:04:59 +02:00

MrPetovan (Migrated from github.com) left a comment

Please add App type-hinting to all the other functions while you're at it.

Please add `App` type-hinting to all the other functions while you're at it.

Quix0r (Migrated from github.com) reviewed 2018-07-22 16:16:09 +02:00

MrPetovan (Migrated from github.com) reviewed 2018-07-22 16:23:17 +02:00

MrPetovan (Migrated from github.com) requested changes 2018-07-22 16:34:09 +02:00

MrPetovan (Migrated from github.com) left a comment

Good, still missing many App type hints.

Good, still missing many `App` type hints.

Quix0r commented

2018-07-22 17:25:35 +02:00

(Migrated from github.com)

Okay, thank you for noticing me about it. Edit: Done. I also found a missing array type-hint ($b is an array there).

Okay, thank you for noticing me about it. **Edit**: Done. I also found a missing `array` type-hint (`$b` is an array there).

MrPetovan (Migrated from github.com) approved these changes 2018-07-22 17:59:41 +02:00

MrPetovan commented

2018-07-22 18:00:46 +02:00

(Migrated from github.com)

I appreciate the touch, but please don't mention my GitHub handle in your commit messages. It creates additional unactionable notifications when you commit and when we merge.

👍 1 😆 1

Quix0r commented

2018-07-22 18:23:46 +02:00

(Migrated from github.com)

Okay, sorry about this. Next time I leave the @ out.

Okay, sorry about this. Next time I leave the `@` out.