Add Cat Avatar Generator Addon #571

Merged
fabrixxm merged 1 commit from catavatar into develop 2018-04-05 14:09:47 +02:00
fabrixxm commented 2018-04-05 10:58:35 +02:00 (Migrated from github.com)
No description provided.
MrPetovan (Migrated from github.com) approved these changes 2018-04-05 14:09:37 +02:00
fabrixxm commented 2018-04-05 16:12:42 +02:00 (Migrated from github.com)

whoa! at first try? no comments on code style? :-)

whoa! at first try? no comments on code style? :-)
MrPetovan commented 2018-04-05 16:22:28 +02:00 (Migrated from github.com)

I reviewed it quickly this morning which explains the minimal scrutiny, are you sure you want me to make another pass at it demanding changes?

I already spotted PSR-2 violations and obsolete syntax 🕵️‍♂️

I reviewed it quickly this morning which explains the minimal scrutiny, are you sure you want me to make another pass at it demanding changes? I already spotted PSR-2 violations and obsolete syntax 🕵️‍♂️
annando commented 2018-04-05 16:36:05 +02:00 (Migrated from github.com)

There was a reason, why I hadn't accepted it - I spotted these violations and thought you would let your virtual dogs chase me, when I would do it - and then I saw you accepting it without any complaint ;-)

There was a reason, why I hadn't accepted it - I spotted these violations and thought you would let your virtual dogs chase me, when I would do it - and then I saw you accepting it without any complaint ;-)
MrPetovan (Migrated from github.com) reviewed 2018-04-05 16:59:31 +02:00
MrPetovan (Migrated from github.com) left a comment

Happy now?

Happy now?
fabrixxm (Migrated from github.com) reviewed 2018-04-05 17:13:18 +02:00
MrPetovan (Migrated from github.com) reviewed 2018-04-05 17:15:23 +02:00
fabrixxm (Migrated from github.com) reviewed 2018-04-05 18:06:17 +02:00
MrPetovan (Migrated from github.com) reviewed 2018-04-05 18:26:25 +02:00
Sign in to join this conversation.
No description provided.