Several changes to Facebook-Connector #46

Merged

CatoTH merged 5 commits from master into master

2012-04-17 12:44:42 +02:00

CatoTH commented

2012-04-17 11:42:54 +02:00

(Migrated from github.com)

Hi,

this is a rather big patch of changes to the connector, so I'd be grateful if someone besides myself reviewed / tested these changes.
The main changes are:

The routine to synchronize contacts with FB is rewritten. Instead of fetching the data of every contact in one request, it uses batch-requests (http://developers.facebook.com/docs/reference/api/batch/). While synching all friends still takes some time, at least it's not that slow as before anymore. (For me with 130 fb-contacts, its 15-20s now, instead of 1-2m before)
The installation instructions by Martin Farrent is linked to. The ones provided in the README were obsolete anyway.
PHP Documentor comments are added (it makes editing in an IDE more convenient)
Some Code-Problems are solved (call-time reference is not supported in 5.4 any more; the $importer and $uid were not set at some points in the code)
Some notices when using error_reporting(E_ALL) are avoided
Variables that were not used anywhere in the code are removed. This is for code clarity.

Hi, this is a rather big patch of changes to the connector, so I'd be grateful if someone besides myself reviewed / tested these changes. The main changes are: - The routine to synchronize contacts with FB is rewritten. Instead of fetching the data of every contact in one request, it uses batch-requests (http://developers.facebook.com/docs/reference/api/batch/). While synching all friends still takes some time, at least it's not that slow as before anymore. (For me with 130 fb-contacts, its 15-20s now, instead of 1-2m before) - The installation instructions by Martin Farrent is linked to. The ones provided in the README were obsolete anyway. - PHP Documentor comments are added (it makes editing in an IDE more convenient) - Some Code-Problems are solved (call-time reference is not supported in 5.4 any more; the $importer and $uid were not set at some points in the code) - Some notices when using error_reporting(E_ALL) are avoided - Variables that were not used anywhere in the code are removed. This is for code clarity.