Connectors: Fix handling of the 'private' field / reformatted code #1564

Merged

MrPetovan merged 1 commit from heluecht/friendica-addons:private into 2024.09-rc

2024-11-16 19:15:37 +01:00

heluecht commented

2024-11-16 06:46:06 +01:00

Owner

This PR unifies the conditions between the posting connectors concerning "private" and "gravity". We now use the appropriate constants to check if we should publish the post. Also the code is reformatted.

heluecht added 1 commit 2024-11-16 06:46:07 +01:00

Fix handling of the 'private' field / reformatted code c22e0ae831

MrPetovan changed title from ~~Fix handling of the 'private' field / reformatted code~~ to Bluesky: Fix handling of the 'private' field / reformatted code

2024-11-16 19:14:24 +01:00

MrPetovan commented

2024-11-16 19:14:48 +01:00

Owner

Please rename your commit so it identifies which addon it is about.

MrPetovan changed title from ~~Bluesky: Fix handling of the 'private' field / reformatted code~~ to Connectors: Fix handling of the 'private' field / reformatted code

2024-11-16 19:15:22 +01:00

MrPetovan approved these changes 2024-11-16 19:15:32 +01:00

MrPetovan merged commit aeefb92926 into 2024.09-rc

2024-11-16 19:15:37 +01:00

MrPetovan referenced this pull request from a commit

2024-11-16 19:15:39 +01:00

Merge pull request 'Connectors: Fix handling of the 'private' field / reformatted code' (#1564) from heluecht/friendica-addons:private into 2024.09-rc

SteffenK9 commented

2024-11-16 21:24:25 +01:00

First-time contributor

There is an error in the pumpio addon now.

app [CRITICAL]: Uncaught Exception ParseError: "Unclosed '{' on line 408 does not match ')'" at /var/www/html/libranet/addon/pumpio/pumpio.php line 415 {"exception":"ParseError: Unclosed '{' on line 408 does not match ')' in /var/www/html/libranet/addon/pumpio/pumpio.php:415\nStack trace:\n#0 /var/www/html/libranet/src/Core/Hook.php(184): Friendica\\Core\\Hook::callSingle()\n#1 /var/www/html/libranet/src/App.php(324): Friendica\\Core\\Hook::callAll()\n#2 /var/www/html/libranet/src/App.php(289): Friendica\\App->load()\n#3 [internal function]: Friendica\\App->__construct()\n#4 /var/www/html/libranet/vendor/level-2/dice/Dice.php(132): ReflectionMethod->invokeArgs()\n#5 /var/www/html/libranet/vendor/level-2/dice/Dice.php(96): Dice\\Dice->Dice\\{closure}()\n#6 /var/www/html/libranet/src/DI.php(78): Dice\\Dice->create()\n#7 /var/www/html/libranet/index.php(28): Friendica\\DI::app()\n#8 {main}"} - {"file":null,"line":null,"function":null,"request-id":"6738fe3fa4b52","stack":"ErrorHandler::handleException (114), ErrorHandler::Friendica\\Core\\Logger\\Handler\\{closure}","uid":"cf0e3b","process_id":1671619}

There is an error in the pumpio addon now. ``` app [CRITICAL]: Uncaught Exception ParseError: "Unclosed '{' on line 408 does not match ')'" at /var/www/html/libranet/addon/pumpio/pumpio.php line 415 {"exception":"ParseError: Unclosed '{' on line 408 does not match ')' in /var/www/html/libranet/addon/pumpio/pumpio.php:415\nStack trace:\n#0 /var/www/html/libranet/src/Core/Hook.php(184): Friendica\\Core\\Hook::callSingle()\n#1 /var/www/html/libranet/src/App.php(324): Friendica\\Core\\Hook::callAll()\n#2 /var/www/html/libranet/src/App.php(289): Friendica\\App->load()\n#3 [internal function]: Friendica\\App->__construct()\n#4 /var/www/html/libranet/vendor/level-2/dice/Dice.php(132): ReflectionMethod->invokeArgs()\n#5 /var/www/html/libranet/vendor/level-2/dice/Dice.php(96): Dice\\Dice->Dice\\{closure}()\n#6 /var/www/html/libranet/src/DI.php(78): Dice\\Dice->create()\n#7 /var/www/html/libranet/index.php(28): Friendica\\DI::app()\n#8 {main}"} - {"file":null,"line":null,"function":null,"request-id":"6738fe3fa4b52","stack":"ErrorHandler::handleException (114), ErrorHandler::Friendica\\Core\\Logger\\Handler\\{closure}","uid":"cf0e3b","process_id":1671619} ```

SteffenK9 commented

2024-11-16 21:42:48 +01:00

First-time contributor

And..

worker [CRITICAL]: Uncaught Exception ParseError: "Unclosed '{' on line 1319 does not match ')'" at /var/www/html/libranet/addon/pumpio/pumpio.php line 1322 {"exception":"ParseError: Unclosed '{' on line 1319 does not match ')' in /var/www/html/libranet/addon/pumpio/pumpio.php:1322\nStack trace:\n#0 /var/www/html/libranet/src/Core/Hook.php(184): Friendica\\Core\\Hook::callSingle()\n#1 /var/www/html/libranet/src/App.php(324): Friendica\\Core\\Hook::callAll()\n#2 /var/www/html/libranet/src/App.php(289): Friendica\\App->load()\n#3 [internal function]: Friendica\\App->__construct()\n#4 /var/www/html/libranet/vendor/level-2/dice/Dice.php(132): ReflectionMethod->invokeArgs()\n#5 /var/www/html/libranet/vendor/level-2/dice/Dice.php(96): Dice\\Dice->Dice\\{closure}()\n#6 /var/www/html/libranet/src/DI.php(78): Dice\\Dice->create()\n#7 /var/www/html/libranet/src/Core/Worker.php(536): Friendica\\DI::app()\n#8 /var/www/html/libranet/src/Core/Worker.php(374): Friendica\\Core\\Worker::execFunction()\n#9 /var/www/html/libranet/src/Core/Worker.php(109): Friendica\\Core\\Worker::execute()\n#10 /var/www/html/libranet/bin/worker.php(75): Friendica\\Core\\Worker::processQueue()\n#11 {main}"} - {"file":null,"line":null,"function":null,"request-id":"67390385513ca","stack":"ErrorHandler::handleException (114), ErrorHandler::Friendica\\Core\\Logger\\Handler\\{closure}","uid":"229736","process_id":1729633}

And.. ``` worker [CRITICAL]: Uncaught Exception ParseError: "Unclosed '{' on line 1319 does not match ')'" at /var/www/html/libranet/addon/pumpio/pumpio.php line 1322 {"exception":"ParseError: Unclosed '{' on line 1319 does not match ')' in /var/www/html/libranet/addon/pumpio/pumpio.php:1322\nStack trace:\n#0 /var/www/html/libranet/src/Core/Hook.php(184): Friendica\\Core\\Hook::callSingle()\n#1 /var/www/html/libranet/src/App.php(324): Friendica\\Core\\Hook::callAll()\n#2 /var/www/html/libranet/src/App.php(289): Friendica\\App->load()\n#3 [internal function]: Friendica\\App->__construct()\n#4 /var/www/html/libranet/vendor/level-2/dice/Dice.php(132): ReflectionMethod->invokeArgs()\n#5 /var/www/html/libranet/vendor/level-2/dice/Dice.php(96): Dice\\Dice->Dice\\{closure}()\n#6 /var/www/html/libranet/src/DI.php(78): Dice\\Dice->create()\n#7 /var/www/html/libranet/src/Core/Worker.php(536): Friendica\\DI::app()\n#8 /var/www/html/libranet/src/Core/Worker.php(374): Friendica\\Core\\Worker::execFunction()\n#9 /var/www/html/libranet/src/Core/Worker.php(109): Friendica\\Core\\Worker::execute()\n#10 /var/www/html/libranet/bin/worker.php(75): Friendica\\Core\\Worker::processQueue()\n#11 {main}"} - {"file":null,"line":null,"function":null,"request-id":"67390385513ca","stack":"ErrorHandler::handleException (114), ErrorHandler::Friendica\\Core\\Logger\\Handler\\{closure}","uid":"229736","process_id":1729633} ```

SteffenK9 commented

2024-11-16 21:43:27 +01:00

First-time contributor

There are two superfluous ) in those lines.

There are two superfluous `)` in those lines.

MrPetovan commented

2024-11-17 03:18:13 +01:00

Owner

I'm on it.

❤️ 1

MrPetovan referenced this pull request

2024-11-17 03:24:27 +01:00