friendica/friendica-addons
7
2
Fork 13
Code Issues 3 Pull requests 2 Releases 16 Wiki Activity

[webrtc] loma-one-patch-2 #1445

Closed
loma-one wants to merge 8 commits from loma-one-patch-2 into 2023.09-rc
pull from: loma-one-patch-2
merge into: friendica:2023.09-rc
Conversation 0 Commits 8 Files changed 2 +12 -4
loma-one commented 2023-12-10 20:16:34 +01:00
Contributor
Copy link

With the iFrame solution there could be problems activating the microphone settings. Therefore, a separate browser window is now opened.

With the iFrame solution there could be problems activating the microphone settings. Therefore, a separate browser window is now opened.
loma-one added 7 commits 2023-12-10 20:16:34 +01:00
b547cf8908 Coloured box added 
Among other things, I use the page header to inform about current maintenance work or other upcoming work. The information should therefore be provided within an appropriate framework. With a little CSS, the page header gets a frame in green. The font was adjusted to an appropriate size.
8cdb5a5ae3 [pageheader] Improve visibility 
Removed commented out code from your pull request
e86b7ada2f webrtc is no longer launched as an iFrame, but as a browser window. 
With the iFrame solution there could be problems activating the microphone settings. Therefore, a separate browser window is now opened.
MrPetovan requested changes 2023-12-10 20:36:02 +01:00
pageheader/pageheader.css
@ -20,4 +20,9 @@
width: 100%;
margin-top: 25px;
font-size: 20px;
/* The pageheader box */
MrPetovan commented 2023-12-10 20:35:04 +01:00
Owner
Copy link

Please remove unrelated changes from this PR.

Please remove unrelated changes from this PR.
webrtc/webrtc.php Outdated
@ -56,2 +57,3 @@
/* embedd the landing page in an iframe */
/* open the landing page in a new browser window without controls */
$o .= '<script>
MrPetovan commented 2023-12-10 20:35:36 +01:00
Owner
Copy link

This shouldn’t be ran when the setting value is empty.

This shouldn’t be ran when the setting value is empty.
MrPetovan changed title from loma-one-patch-2 to [webrtc] loma-one-patch-2 2023-12-10 20:36:16 +01:00
loma-one added 1 commit 2023-12-10 21:11:49 +01:00
loma-one closed this pull request 2024-01-22 19:21:01 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
MrPetovan
Labels
Clear labels   
2018.09

   
2019.01

   
2019.03

   
2019.06

   
2019.09

   
2019.12

   
2020.03

   
2020.06

   
2020.09

   
2020.12

   
2021.03

   
2021.07

   
2021.09

   
2022.02

   
2022.06

   
2022.09

   
2022.12

   
2023.04

   
2023.05

   
2023.09

   
2024.03

   
2024.06

   
dependencies

Pull requests that update a dependency file

  
Hackathon 2021
No labels
2018.09
2019.01
2019.03
2019.06
2019.09
2019.12
2020.03
2020.06
2020.09
2020.12
2021.03
2021.07
2021.09
2022.02
2022.06
2022.09
2022.12
2023.04
2023.05
2023.09
2024.03
2024.06
dependencies
Hackathon 2021
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: friendica/friendica-addons#1445
No description provided.
Delete branch "loma-one-patch-2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?