friendica/friendica-addons
7
2
Fork 13
Code Issues 3 Pull requests 3 Releases 16 Wiki Activity

[Addon pageheader] Coloured box added #1419

Closed
loma-one wants to merge 2 commits from (deleted):loma-one-patch-1 into develop
pull from: (deleted):loma-one-patch-1
merge into: friendica:develop
Conversation 2 Commits 2 Files changed 1 +7
loma-one commented 2023-09-20 15:39:43 +02:00
Contributor
Copy link

Among other things, I use the page header to inform about current maintenance work or other upcoming work. The information should therefore be provided within an appropriate framework. With a little CSS, the page header gets a frame in green. The font was adjusted to an appropriate size.

Among other things, I use the page header to inform about current maintenance work or other upcoming work. The information should therefore be provided within an appropriate framework. With a little CSS, the page header gets a frame in green. The font was adjusted to an appropriate size.
collor_box.png
42 KiB
collor_box.png
loma-one added 2 commits 2023-09-20 15:39:44 +02:00 
Among other things, I use the page header to inform about current maintenance work or other upcoming work. The information should therefore be provided within an appropriate framework. With a little CSS, the page header gets a frame in green. The font was adjusted to an appropriate size.
MrPetovan commented 2023-09-23 16:35:04 +02:00
Owner
Copy link

Using an absolute color is problematic in an environment where the theme colors can drastically change. I don't have a good solution for this, this display should be handled at the theme-level which an addon cannot change at the moment. Still, I don't think we can accept this change, sorry about that.

Using an absolute color is problematic in an environment where the theme colors can drastically change. I don't have a good solution for this, this display should be handled at the theme-level which an addon cannot change at the moment. Still, I don't think we can accept this change, sorry about that.
loma-one commented 2023-09-23 17:16:24 +02:00
Author
Contributor
Copy link

I had orientated myself on the Altert buttons from https://www.w3schools.com/howto/howto_css_alert_buttons.asp. But I can understand the objection. I will comment out the coloured passages.

I had orientated myself on the Altert buttons from https://www.w3schools.com/howto/howto_css_alert_buttons.asp. But I can understand the objection. I will comment out the coloured passages.
loma-one closed this pull request 2023-09-23 17:18:59 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
2018.09

   
2019.01

   
2019.03

   
2019.06

   
2019.09

   
2019.12

   
2020.03

   
2020.06

   
2020.09

   
2020.12

   
2021.03

   
2021.07

   
2021.09

   
2022.02

   
2022.06

   
2022.09

   
2022.12

   
2023.04

   
2023.05

   
2023.09

   
2024.03

   
2024.06

   
dependencies

Pull requests that update a dependency file

  
Hackathon 2021
No labels
2018.09
2019.01
2019.03
2019.06
2019.09
2019.12
2020.03
2020.06
2020.09
2020.12
2021.03
2021.07
2021.09
2022.02
2022.06
2022.09
2022.12
2023.04
2023.05
2023.09
2024.03
2024.06
dependencies
Hackathon 2021
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: friendica/friendica-addons#1419
No description provided.
Delete branch "(deleted):loma-one-patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?